summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2023-09-29 01:56:51 +1000
committer Vas Crabb <vas@vastheman.com>2023-09-29 01:56:51 +1000
commitd71c72ba746503934102788e5dcbb487c6134396 (patch)
treeed63fa00eb24d7f608a68e77c4c517888e4c873b /src/devices
parent117c384d4ac65c06481f7a0631051c8ba273c0b5 (diff)
Miscellaneous change roll-up:
render/drawbgfx.cpp: Return an error if Wayland EGL surface can't be created for additional windows. emu/emucore.h: Added explicitly defaulted copy and move constructors for emu_fatalerror. Fixed apparent misunderstanding of const. Returning const value types and casting to const value types is pointless outside very narrow use cases. Putting const value type parameters in interfaces just makes trouble. cpu/adsp2100: Use count_leading_ones_32 where it's simple rather than inverting and counting leading zeroes. util/multibyte.h: Don't pollute global namespace, constexpr implies inline, make narrowing casts explicit. imagedev/simh_tape_image.h: inline is implied for member functions with bodies supplied at declaration. Tidied up some ugly casts in various places.
Diffstat (limited to 'src/devices')
-rw-r--r--src/devices/cpu/adsp2100/2100ops.hxx4
-rw-r--r--src/devices/imagedev/simh_tape_image.h4
-rw-r--r--src/devices/machine/smc91c9x.cpp3
3 files changed, 6 insertions, 5 deletions
diff --git a/src/devices/cpu/adsp2100/2100ops.hxx b/src/devices/cpu/adsp2100/2100ops.hxx
index bd2df9acce6..be8f4524a7a 100644
--- a/src/devices/cpu/adsp2100/2100ops.hxx
+++ b/src/devices/cpu/adsp2100/2100ops.hxx
@@ -2097,7 +2097,7 @@ void adsp21xx_device::shift_op(uint32_t op)
if (xop < 0)
{
SET_SS;
- res = count_leading_zeros_32(~xop) - 16 - 1;
+ res = count_leading_ones_32(xop) - 16 - 1;
}
else
{
@@ -2120,7 +2120,7 @@ void adsp21xx_device::shift_op(uint32_t op)
if (xop < 0)
{
SET_SS;
- res = count_leading_zeros_32(~xop) - 16 - 1;
+ res = count_leading_ones_32(xop) - 16 - 1;
}
else
{
diff --git a/src/devices/imagedev/simh_tape_image.h b/src/devices/imagedev/simh_tape_image.h
index 95f1c70b2e3..cb98056b837 100644
--- a/src/devices/imagedev/simh_tape_image.h
+++ b/src/devices/imagedev/simh_tape_image.h
@@ -30,8 +30,8 @@ public:
virtual void call_unload() override;
// miscellaneous
- inline void set_interface(const char *interface) { m_interface = interface; }
- inline simh_tape_file *get_file() const { return m_file.get(); }
+ void set_interface(const char *interface) { m_interface = interface; }
+ simh_tape_file *get_file() const { return m_file.get(); }
protected:
// construction
diff --git a/src/devices/machine/smc91c9x.cpp b/src/devices/machine/smc91c9x.cpp
index a27c1f7d281..e237d186b95 100644
--- a/src/devices/machine/smc91c9x.cpp
+++ b/src/devices/machine/smc91c9x.cpp
@@ -12,8 +12,9 @@
#include "smc91c9x.h"
#include "multibyte.h"
-#include <sstream>
+
#include <iomanip>
+#include <sstream>
/***************************************************************************
DEBUGGING