diff options
author | 2015-12-26 13:54:32 +0100 | |
---|---|---|
committer | 2015-12-26 13:54:32 +0100 | |
commit | 9f998d0afb69f4286f05e46efe27806b6aba32af (patch) | |
tree | 7a126081d7eb971c4cc9f8fa8952ad04a30ab231 | |
parent | a546ea128238feaa616451ed7b7f4fe389dd1460 (diff) |
cleanup (nw)
69 files changed, 199 insertions, 242 deletions
diff --git a/src/devices/cpu/alto2/a2disk.cpp b/src/devices/cpu/alto2/a2disk.cpp index 8075ae3ed39..f6de163d745 100644 --- a/src/devices/cpu/alto2/a2disk.cpp +++ b/src/devices/cpu/alto2/a2disk.cpp @@ -1600,7 +1600,7 @@ void alto2_cpu_device::disk_bitclk(void* ptr, INT32 arg) (void)ptr; diablo_hd_device* dhd = m_drive[m_dsk.drive]; int clk = arg & 1; - int bit = 0; + int bit; /** * The source for BITCLK and DATAIN depends on disk controller part #65 diff --git a/src/devices/cpu/alto2/a2mem.cpp b/src/devices/cpu/alto2/a2mem.cpp index 94697c38324..e4fa65184f1 100644 --- a/src/devices/cpu/alto2/a2mem.cpp +++ b/src/devices/cpu/alto2/a2mem.cpp @@ -770,7 +770,7 @@ UINT16 alto2_cpu_device::debug_read_mem(UINT32 addr) { space(AS_2).set_debugger_access(true); int base_addr = addr & 0177777; - int data = 0177777; + int data; if (base_addr >= ALTO2_IO_PAGE_BASE && addr < ALTO2_RAM_SIZE) { data = m_iomem->read_word(m_iomem->address_to_byte(base_addr)); } else { diff --git a/src/devices/cpu/alto2/alto2cpu.h b/src/devices/cpu/alto2/alto2cpu.h index 11208dbae83..9a9fdf0d031 100644 --- a/src/devices/cpu/alto2/alto2cpu.h +++ b/src/devices/cpu/alto2/alto2cpu.h @@ -252,12 +252,6 @@ private: //!< write i/o space RAM DECLARE_WRITE16_MEMBER( ioram_w ); - //!< read memory mapped i/o - DECLARE_READ16_MEMBER ( mmio_r ); - - //!< write memory mapped i/o - DECLARE_WRITE16_MEMBER( mmio_w ); - int m_icount; typedef void (alto2_cpu_device::*a2func)(); diff --git a/src/devices/cpu/arcompact/arcompact_execute.cpp b/src/devices/cpu/arcompact/arcompact_execute.cpp index ba3c3ea3af4..8da820fa25d 100644 --- a/src/devices/cpu/arcompact/arcompact_execute.cpp +++ b/src/devices/cpu/arcompact/arcompact_execute.cpp @@ -1293,7 +1293,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle01_00_01dasm(OPS_32) ARCOMPACT_RETTYPE arcompact_device::arcompact_01_01_00_helper(OPS_32, const char* optext) { - int size = 4; + int size; // Branch on Compare / Bit Test - Register-Register @@ -1564,7 +1564,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle01_01_01_0f(OPS_32) { retur ARCOMPACT_RETTYPE arcompact_device::arcompact_handle02(OPS_32) { int size = 4; - UINT32 limm = 0; + UINT32 limm; int S = (op & 0x00008000) >> 15;// op &= ~0x00008000; int s = (op & 0x00ff0000) >> 16;// op &= ~0x00ff0000; @@ -1761,7 +1761,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle03(OPS_32) ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_helper(OPS_32, const char* optext, int ignore_dst, int b_reserved) { - int size = 4; + int size; //UINT32 limm = 0; int got_limm = 0; @@ -1925,7 +1925,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_1d(OPS_32) ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_20_p00(OPS_32) { - int size = 4; + int size; UINT32 limm = 0; int got_limm = 0; @@ -2011,7 +2011,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_20_p11_m0(OPS_32) // Jcc COMMON32_GET_CONDITION; COMMON32_GET_F - UINT32 c = 0; + UINT32 c; if (creg == LIMM_REG) { @@ -2127,7 +2127,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_21_p10(OPS_32) ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_21_p11_m0(OPS_32) // Jcc.D (no link, delay) { int size = 4; - UINT32 limm = 0; + UINT32 limm; int got_limm = 0; COMMON32_GET_creg @@ -2270,7 +2270,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_29(OPS_32) ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_2f_helper(OPS_32, const char* optext) { - int size = 4; + int size; COMMON32_GET_p; //COMMON32_GET_breg; @@ -2330,7 +2330,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_2f_3f_05(OPS_32) { arcom ARCOMPACT_RETTYPE arcompact_device::arcompact_handle04_3x_helper(OPS_32, int dsize, int extend) { - int size = 4; + int size; //UINT32 limm=0; int got_limm = 0; @@ -2406,7 +2406,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle05_29(OPS_32) { return arco ARCOMPACT_RETTYPE arcompact_device::arcompact_handle05_2f_0x_helper(OPS_32, const char* optext) { - int size = 4; + int size; COMMON32_GET_p; //COMMON32_GET_breg; @@ -2548,7 +2548,7 @@ ARCOMPACT_RETTYPE arcompact_device::arcompact_handle0d_03(OPS_16) ARCOMPACT_RETTYPE arcompact_device::arcompact_handle0e_0x_helper(OPS_16, const char* optext, int revop) { int h;// , breg; - int size = 2; + int size; GROUP_0e_GET_h; diff --git a/src/devices/cpu/arm7/arm7ops.cpp b/src/devices/cpu/arm7/arm7ops.cpp index ef0ae06cf63..9c1f0197764 100644 --- a/src/devices/cpu/arm7/arm7ops.cpp +++ b/src/devices/cpu/arm7/arm7ops.cpp @@ -822,7 +822,7 @@ void arm7_cpu_device::HandleSwap(UINT32 insn) void arm7_cpu_device::HandlePSRTransfer(UINT32 insn) { int reg = (insn & 0x400000) ? SPSR : eCPSR; // Either CPSR or SPSR - UINT32 newval, val = 0; + UINT32 newval, val; int oldmode = GET_CPSR & MODE_FLAG; // get old value of CPSR/SPSR @@ -1195,7 +1195,7 @@ void arm7_cpu_device::HandleSMulLong(UINT32 insn) { INT32 rm, rs; UINT32 rhi, rlo; - INT64 res = 0; + INT64 res; // MULL takes 1S + (m+1)I and MLAL 1S + (m+2)I cycles to execute, where m is the // number of 8 bit multiplier array cycles required to complete the multiply, which is @@ -1247,7 +1247,7 @@ void arm7_cpu_device::HandleUMulLong(UINT32 insn) { UINT32 rm, rs; UINT32 rhi, rlo; - UINT64 res = 0; + UINT64 res; // MULL takes 1S + (m+1)I and MLAL 1S + (m+2)I cycles to execute, where m is the // number of 8 bit multiplier array cycles required to complete the multiply, which is diff --git a/src/devices/cpu/avr8/avr8.cpp b/src/devices/cpu/avr8/avr8.cpp index d043e466876..085700da53f 100644 --- a/src/devices/cpu/avr8/avr8.cpp +++ b/src/devices/cpu/avr8/avr8.cpp @@ -2973,15 +2973,15 @@ void avr8_device::execute_set_input(int inputnum, int state) void avr8_device::execute_run() { - UINT32 op = 0; - INT32 offs = 0; - UINT8 rd = 0; - UINT8 rr = 0; - UINT8 res = 0; - UINT16 pd = 0; - UINT32 pd32 = 0; - INT16 sd = 0; - INT32 opcycles = 1; + UINT32 op; + INT32 offs; + UINT8 rd; + UINT8 rr; + UINT8 res; + UINT16 pd; + UINT32 pd32; + INT16 sd; + INT32 opcycles; while (m_icount > 0) { diff --git a/src/devices/cpu/cosmac/cosmac.h b/src/devices/cpu/cosmac/cosmac.h index 02cd87f0668..26a60021335 100644 --- a/src/devices/cpu/cosmac/cosmac.h +++ b/src/devices/cpu/cosmac/cosmac.h @@ -251,7 +251,6 @@ protected: inline void reset(); inline void initialize(); inline void fetch_instruction(); - inline void fetch_instruction_debug(); inline void execute_instruction(); inline void dma_input(); inline void dma_output(); diff --git a/src/devices/cpu/drcbeut.cpp b/src/devices/cpu/drcbeut.cpp index 3bd0edac4a1..356045fad3b 100644 --- a/src/devices/cpu/drcbeut.cpp +++ b/src/devices/cpu/drcbeut.cpp @@ -359,7 +359,7 @@ UINT32 drc_map_variables::get_value(drccodeptr codebase, UINT32 mapvar) const UINT64 *endscan = (UINT64 *)m_cache.top(); // look for the signature - while (curscan < endscan && *curscan++ != m_uniquevalue) ; + while (curscan < endscan && *curscan++ != m_uniquevalue) {}; if (curscan >= endscan) return 0; diff --git a/src/devices/cpu/drcbex86.h b/src/devices/cpu/drcbex86.h index 33eaa65bacc..df81ee0c7c7 100644 --- a/src/devices/cpu/drcbex86.h +++ b/src/devices/cpu/drcbex86.h @@ -127,7 +127,6 @@ private: void fixup_exception(drccodeptr *codeptr, void *param1, void *param2); static void debug_log_hashjmp(int mode, offs_t pc); - static void debug_log_hashjmp_fail(); // code generators void op_handle(x86code *&dst, const uml::instruction &inst); @@ -262,7 +261,6 @@ private: void emit_sbb_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); void emit_sbb_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_cmp_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_cmp_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_and_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); void emit_and_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_test_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); @@ -272,19 +270,12 @@ private: void emit_xor_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); void emit_xor_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_shl_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_shl_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_shr_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_shr_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_sar_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_sar_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_rol_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_rol_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_ror_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_ror_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_rcl_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_rcl_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); void emit_rcr_r64_p64(x86code *&dst, UINT8 reglo, UINT8 reghi, const be_parameter ¶m, const uml::instruction &inst); - void emit_rcr_m64_p64(x86code *&dst, x86_memref memref, const be_parameter ¶m, const uml::instruction &inst); // floating-point code emission helpers void emit_fld_p(x86code *&dst, int size, const be_parameter ¶m); diff --git a/src/devices/cpu/dsp56k/dsp56k.h b/src/devices/cpu/dsp56k/dsp56k.h index 39ed11cc945..8b2eeb4561c 100644 --- a/src/devices/cpu/dsp56k/dsp56k.h +++ b/src/devices/cpu/dsp56k/dsp56k.h @@ -204,8 +204,6 @@ class dsp56k_device : public cpu_device public: dsp56k_device(const machine_config &mconfig, const char *_tag, device_t *_owner, UINT32 _clock); - DECLARE_READ16_MEMBER( program_r ); - DECLARE_WRITE16_MEMBER( program_w ); DECLARE_READ16_MEMBER( peripheral_register_r ); DECLARE_WRITE16_MEMBER( peripheral_register_w ); diff --git a/src/devices/cpu/e132xs/e132xs.h b/src/devices/cpu/e132xs/e132xs.h index 3448522a2cc..719c139ae84 100644 --- a/src/devices/cpu/e132xs/e132xs.h +++ b/src/devices/cpu/e132xs/e132xs.h @@ -492,8 +492,6 @@ private: void ope8(); void ope9(); void opea(); void opeb(); void opec(); void oped(); void opee(); void opef(); void opf0(); void opf1(); void opf2(); void opf3(); void opf4(); void opf5(); void opf6(); void opf7(); void opf8(); void opf9(); void opfa(); void opfb(); void opfc(); void opfd(); void opfe(); void opff(); - - void set_irq_line(int irqline, int state); }; // device type definition diff --git a/src/devices/cpu/hd61700/hd61700.cpp b/src/devices/cpu/hd61700/hd61700.cpp index cabb0539acf..3d08c23473e 100644 --- a/src/devices/cpu/hd61700/hd61700.cpp +++ b/src/devices/cpu/hd61700/hd61700.cpp @@ -2255,7 +2255,7 @@ void hd61700_cpu_device::execute_run() { UINT8 arg = read_op(); UINT8 arg1 = read_op(); - UINT8 r1 = 0, r2 = 0, f = 0; + UINT8 r1 = 0, r2, f = 0; r2 = (arg&0x40) ? 0 : 1; @@ -2745,7 +2745,7 @@ inline void hd61700_cpu_device::set_pc(INT32 new_pc) inline UINT8 hd61700_cpu_device::read_op() { - UINT16 data = 0; + UINT16 data; UINT32 addr18 = make_18bit_addr((m_irq_status) ? 0 : prev_ua, m_pc); if (m_pc <= INT_ROM) diff --git a/src/devices/cpu/i386/i386.cpp b/src/devices/cpu/i386/i386.cpp index 0c56db0686c..5ce7fdb4f4e 100644 --- a/src/devices/cpu/i386/i386.cpp +++ b/src/devices/cpu/i386/i386.cpp @@ -697,7 +697,7 @@ void i386_device::i386_trap(int irq, int irq_gate, int trap_level) UINT32 offset, oldflags = get_flags(); UINT16 segment; int entry = irq * (PROTECTED_MODE ? 8 : 4); - int SetRPL = 0; + int SetRPL; m_lock = false; if( !(PROTECTED_MODE) ) @@ -721,7 +721,7 @@ void i386_device::i386_trap(int irq, int irq_gate, int trap_level) int type; UINT16 flags; I386_SREG desc; - UINT8 CPL = m_CPL, DPL = 0; //, RPL = 0; + UINT8 CPL = m_CPL, DPL; //, RPL = 0; /* 32-bit */ v1 = READ32PL0(m_idtr.base + entry ); @@ -1347,7 +1347,7 @@ void i386_device::i386_protected_mode_jump(UINT16 seg, UINT32 off, int indirect, I386_SREG desc; I386_CALL_GATE call_gate; UINT8 CPL,DPL,RPL; - UINT8 SetRPL = 0; + UINT8 SetRPL; UINT16 segment = seg; UINT32 offset = off; @@ -1618,7 +1618,7 @@ void i386_device::i386_protected_mode_call(UINT16 seg, UINT32 off, int indirect, { I386_SREG desc; I386_CALL_GATE gate; - UINT8 SetRPL = 0; + UINT8 SetRPL; UINT8 CPL, DPL, RPL; UINT16 selector = seg; UINT32 offset = off; @@ -3091,7 +3091,7 @@ UINT64 i386_device::debug_seglimit(symbol_table &table, int params, const UINT64 UINT64 i386_device::debug_segofftovirt(symbol_table &table, int params, const UINT64 *param) { - UINT32 result = 0; + UINT32 result; I386_SREG seg; if(param[0] > 65535) diff --git a/src/devices/cpu/i86/i286.cpp b/src/devices/cpu/i86/i286.cpp index 637f9cc1e47..819ce92f69d 100644 --- a/src/devices/cpu/i86/i286.cpp +++ b/src/devices/cpu/i86/i286.cpp @@ -1970,7 +1970,7 @@ UINT16 i80286_cpu_device::far_return(int iret, int bytes) void i80286_cpu_device::check_permission(UINT8 check_seg, UINT32 offset, UINT16 size, int operation) { - int trap = 0; + int trap; UINT8 rights; if(PM) { diff --git a/src/devices/cpu/lc8670/lc8670.cpp b/src/devices/cpu/lc8670/lc8670.cpp index be38f0b3128..a397f8505bb 100644 --- a/src/devices/cpu/lc8670/lc8670.cpp +++ b/src/devices/cpu/lc8670/lc8670.cpp @@ -1135,7 +1135,7 @@ inline UINT8 lc8670_cpu_device::pop() inline UINT16 lc8670_cpu_device::get_addr() { int mode = m_op & 0x0f; - UINT16 addr = 0; + UINT16 addr; if (mode > 0x01 && mode <= 0x03) addr = GET_D9; @@ -1150,7 +1150,7 @@ inline UINT16 lc8670_cpu_device::get_addr() inline UINT8 lc8670_cpu_device::get_data() { int mode = m_op & 0x0f; - UINT8 data = 0; + UINT8 data; if (mode == 0x01) data = GET_I8; @@ -1217,7 +1217,7 @@ inline void lc8670_cpu_device::set_irq_flag(int source) int lc8670_cpu_device::decode_op(UINT8 op) { - int idx = 0; + int idx; switch (op & 0x0f) { case 0: case 1: diff --git a/src/devices/cpu/m68000/m68kops.cpp b/src/devices/cpu/m68000/m68kops.cpp index 40c4a78cecf..e3884c55195 100644 --- a/src/devices/cpu/m68000/m68kops.cpp +++ b/src/devices/cpu/m68000/m68kops.cpp @@ -5311,8 +5311,8 @@ void m68000_base_device_ops::m68k_op_bfchg_32_ai(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_AI_8(mc68kcpu); @@ -5365,8 +5365,8 @@ void m68000_base_device_ops::m68k_op_bfchg_32_di(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_DI_8(mc68kcpu); @@ -5419,8 +5419,8 @@ void m68000_base_device_ops::m68k_op_bfchg_32_ix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_IX_8(mc68kcpu); @@ -5473,8 +5473,8 @@ void m68000_base_device_ops::m68k_op_bfchg_32_aw(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AW_8(mc68kcpu); @@ -5527,8 +5527,8 @@ void m68000_base_device_ops::m68k_op_bfchg_32_al(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AL_8(mc68kcpu); @@ -5618,8 +5618,8 @@ void m68000_base_device_ops::m68k_op_bfclr_32_ai(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_AI_8(mc68kcpu); @@ -5672,8 +5672,8 @@ void m68000_base_device_ops::m68k_op_bfclr_32_di(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_DI_8(mc68kcpu); @@ -5726,8 +5726,8 @@ void m68000_base_device_ops::m68k_op_bfclr_32_ix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_IX_8(mc68kcpu); @@ -5780,8 +5780,8 @@ void m68000_base_device_ops::m68k_op_bfclr_32_aw(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AW_8(mc68kcpu); @@ -5834,8 +5834,8 @@ void m68000_base_device_ops::m68k_op_bfclr_32_al(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AL_8(mc68kcpu); @@ -7124,8 +7124,8 @@ void m68000_base_device_ops::m68k_op_bfins_32_ai(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_AI_8(mc68kcpu); @@ -7200,8 +7200,8 @@ void m68000_base_device_ops::m68k_op_bfins_32_di(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_DI_8(mc68kcpu); @@ -7276,8 +7276,8 @@ void m68000_base_device_ops::m68k_op_bfins_32_ix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_IX_8(mc68kcpu); @@ -7352,8 +7352,8 @@ void m68000_base_device_ops::m68k_op_bfins_32_aw(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AW_8(mc68kcpu); @@ -7428,8 +7428,8 @@ void m68000_base_device_ops::m68k_op_bfins_32_al(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AL_8(mc68kcpu); @@ -7538,8 +7538,8 @@ void m68000_base_device_ops::m68k_op_bfset_32_ai(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_AI_8(mc68kcpu); if(BIT_B(word2)) @@ -7591,8 +7591,8 @@ void m68000_base_device_ops::m68k_op_bfset_32_di(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_DI_8(mc68kcpu); if(BIT_B(word2)) @@ -7644,8 +7644,8 @@ void m68000_base_device_ops::m68k_op_bfset_32_ix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_IX_8(mc68kcpu); if(BIT_B(word2)) @@ -7697,8 +7697,8 @@ void m68000_base_device_ops::m68k_op_bfset_32_aw(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AW_8(mc68kcpu); if(BIT_B(word2)) @@ -7750,8 +7750,8 @@ void m68000_base_device_ops::m68k_op_bfset_32_al(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AL_8(mc68kcpu); if(BIT_B(word2)) @@ -7838,8 +7838,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_ai(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_AI_8(mc68kcpu); if(BIT_B(word2)) @@ -7889,8 +7889,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_di(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_DI_8(mc68kcpu); if(BIT_B(word2)) @@ -7940,8 +7940,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_ix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AY_IX_8(mc68kcpu); if(BIT_B(word2)) @@ -7991,8 +7991,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_aw(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AW_8(mc68kcpu); if(BIT_B(word2)) @@ -8042,8 +8042,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_al(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_AL_8(mc68kcpu); if(BIT_B(word2)) @@ -8093,8 +8093,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_pcdi(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_PCDI_8(mc68kcpu); if(BIT_B(word2)) @@ -8144,8 +8144,8 @@ void m68000_base_device_ops::m68k_op_bftst_32_pcix(m68000_base_device* mc68kcpu) UINT32 mask_base; UINT32 data_long; UINT32 mask_long; - UINT32 data_byte = 0; - UINT32 mask_byte = 0; + UINT32 data_byte; + UINT32 mask_byte; UINT32 ea = EA_PCIX_8(mc68kcpu); if(BIT_B(word2)) @@ -13608,9 +13608,9 @@ void m68000_base_device_ops::m68k_op_divl_32_d(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = DY(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -13678,9 +13678,9 @@ void m68000_base_device_ops::m68k_op_divl_32_ai(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AY_AI_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -13748,9 +13748,9 @@ void m68000_base_device_ops::m68k_op_divl_32_pi(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AY_PI_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -13818,9 +13818,9 @@ void m68000_base_device_ops::m68k_op_divl_32_pd(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AY_PD_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -13888,9 +13888,9 @@ void m68000_base_device_ops::m68k_op_divl_32_di(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AY_DI_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -13958,9 +13958,9 @@ void m68000_base_device_ops::m68k_op_divl_32_ix(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AY_IX_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -14028,9 +14028,9 @@ void m68000_base_device_ops::m68k_op_divl_32_aw(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AW_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -14098,9 +14098,9 @@ void m68000_base_device_ops::m68k_op_divl_32_al(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_AL_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -14168,9 +14168,9 @@ void m68000_base_device_ops::m68k_op_divl_32_pcdi(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_PCDI_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -14238,9 +14238,9 @@ void m68000_base_device_ops::m68k_op_divl_32_pcix(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_PCIX_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { @@ -14308,9 +14308,9 @@ void m68000_base_device_ops::m68k_op_divl_32_i(m68000_base_device* mc68kcpu) { UINT32 word2 = OPER_I_16(mc68kcpu); UINT64 divisor = OPER_I_32(mc68kcpu); - UINT64 dividend = 0; - UINT64 quotient = 0; - UINT64 remainder = 0; + UINT64 dividend; + UINT64 quotient; + UINT64 remainder; if(divisor != 0) { diff --git a/src/devices/cpu/mcs51/mcs51.cpp b/src/devices/cpu/mcs51/mcs51.cpp index 0fc5d9449be..d77a84a20d0 100644 --- a/src/devices/cpu/mcs51/mcs51.cpp +++ b/src/devices/cpu/mcs51/mcs51.cpp @@ -1004,7 +1004,7 @@ void mcs51_cpu_device::transmit_receive(int source) void mcs51_cpu_device::update_timer_t0(int cycles) { int mode = (GET_M0_1<<1) | GET_M0_0; - UINT32 count = 0; + UINT32 count; if (GET_TR0) { @@ -1091,7 +1091,7 @@ void mcs51_cpu_device::update_timer_t1(int cycles) { UINT8 mode = (GET_M1_1<<1) | GET_M1_0; UINT8 mode_0 = (GET_M0_1<<1) | GET_M0_0; - UINT32 count = 0; + UINT32 count; if (mode_0 != 3) { @@ -1713,7 +1713,7 @@ void mcs51_cpu_device::check_irqs() UINT8 ints = (GET_IE0 | (GET_TF0<<1) | (GET_IE1<<2) | (GET_TF1<<3) | ((GET_RI|GET_TI)<<4)); UINT8 int_vec = 0; - UINT8 int_mask = 0; + UINT8 int_mask; int priority_request = -1; int i; diff --git a/src/devices/cpu/powerpc/ppc.h b/src/devices/cpu/powerpc/ppc.h index a73accb6409..c9b37cbb196 100644 --- a/src/devices/cpu/powerpc/ppc.h +++ b/src/devices/cpu/powerpc/ppc.h @@ -620,9 +620,6 @@ protected: uml::code_label labelnum; /* index for local labels */ }; - int IS_PPC602(void); - int IS_PPC603(void); - int IS_PPC403(void); UINT32 get_cr(); void set_cr(UINT32 value); UINT32 get_xer(); diff --git a/src/devices/cpu/powerpc/ppccom.cpp b/src/devices/cpu/powerpc/ppccom.cpp index 25c39516c73..5fc2ea00b9b 100644 --- a/src/devices/cpu/powerpc/ppccom.cpp +++ b/src/devices/cpu/powerpc/ppccom.cpp @@ -1516,7 +1516,7 @@ void ppc_device::ppccom_execute_tlbl() { UINT32 address = m_core->param0; int isitlb = m_core->param1; - vtlb_entry flags = 0; + vtlb_entry flags; int entrynum; /* determine entry number; we use rand() for associativity */ diff --git a/src/devices/cpu/psx/psx.h b/src/devices/cpu/psx/psx.h index c0b4eb0a1cd..e15bb9663ae 100644 --- a/src/devices/cpu/psx/psx.h +++ b/src/devices/cpu/psx/psx.h @@ -153,7 +153,6 @@ class psxcpu_device : public cpu_device, { public: // construction/destruction - psxcpu_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); virtual ~psxcpu_device() {}; // static configuration helpers diff --git a/src/devices/cpu/rsp/rspcp2.cpp b/src/devices/cpu/rsp/rspcp2.cpp index fe6d3b243e8..ce16a351b5a 100644 --- a/src/devices/cpu/rsp/rspcp2.cpp +++ b/src/devices/cpu/rsp/rspcp2.cpp @@ -1167,7 +1167,7 @@ void rsp_cop2::handle_lwc2(UINT32 op) if (ve > 32) ve = 32; - INT32 element = 7 - (index >> 1); + INT32 element; if (index & 1) fatalerror("RSP: LTV: index = %d\n", index); @@ -2966,7 +2966,7 @@ void rsp_cop2::handle_vector_ops(UINT32 op) CLEAR_CLIP1_FLAGS(); CLEAR_ZERO_FLAGS(); CLEAR_CLIP2_FLAGS(); - UINT32 vce = 0; + UINT32 vce; for (i=0; i < 8; i++) { diff --git a/src/devices/cpu/rsp/rspcp2.h b/src/devices/cpu/rsp/rspcp2.h index 8911eeb1838..bfa5b91a7fb 100644 --- a/src/devices/cpu/rsp/rspcp2.h +++ b/src/devices/cpu/rsp/rspcp2.h @@ -175,7 +175,6 @@ protected: virtual int generate_vector_opcode(drcuml_block *block, rsp_device::compiler_state *compiler, const opcode_desc *desc) { return TRUE; } UINT16 SATURATE_ACCUM(int accum, int slice, UINT16 negative, UINT16 positive); - UINT16 SATURATE_ACCUM1(int accum, UINT16 negative, UINT16 positive); // Data that needs to be stored close to the generated DRC code struct internal_rspcop2_state diff --git a/src/devices/cpu/rsp/rspcp2d.cpp b/src/devices/cpu/rsp/rspcp2d.cpp index 61d567b6509..c16eb109449 100644 --- a/src/devices/cpu/rsp/rspcp2d.cpp +++ b/src/devices/cpu/rsp/rspcp2d.cpp @@ -375,7 +375,7 @@ static void cfunc_llv(void *param) void rsp_cop2_drc::ldv() { UINT32 op = m_rspcop2_state->op; - UINT32 ea = 0; + UINT32 ea; int dest = (op >> 16) & 0x1f; int base = (op >> 21) & 0x1f; int index = (op >> 7) & 0x8; @@ -687,7 +687,7 @@ void rsp_cop2_drc::ltv() ve = 32; } - int element = 7 - (index >> 1); + int element; UINT32 ea = (base) ? m_rsp.m_rsp_state->r[base] + (offset * 16) : (offset * 16); @@ -2438,7 +2438,7 @@ void rsp_cop2_drc::vch() CLEAR_ZERO_FLAGS(); CLEAR_CLIP2_FLAGS(); - UINT32 vce = 0; + UINT32 vce; for (int i = 0; i < 8; i++) { INT16 s1, s2; diff --git a/src/devices/cpu/superfx/superfx.cpp b/src/devices/cpu/superfx/superfx.cpp index ad0915be9b8..7601fa9bdc3 100644 --- a/src/devices/cpu/superfx/superfx.cpp +++ b/src/devices/cpu/superfx/superfx.cpp @@ -988,7 +988,7 @@ void superfx_device::execute_run() case 0x46: case 0x47: case 0x48: case 0x49: case 0x4a: case 0x4b: // LDW_IR / LDB_IR if((m_sfr & SUPERFX_SFR_ALT1) == 0) { // LDW_IR - UINT16 data = 0; + UINT16 data; m_ramaddr = m_r[op & 0xf]; data = superfx_rambuffer_read(m_ramaddr ^ 0) << 0; data |= superfx_rambuffer_read(m_ramaddr ^ 1) << 8; @@ -1271,7 +1271,7 @@ void superfx_device::execute_run() case SUPERFX_SFR_ALT1: // LMS case SUPERFX_SFR_ALT3: // LMS { - UINT16 data = 0; + UINT16 data; m_ramaddr = superfx_pipe() << 1; data = superfx_rambuffer_read(m_ramaddr ^ 0) << 0; data |= superfx_rambuffer_read(m_ramaddr ^ 1) << 8; diff --git a/src/devices/cpu/tms32025/tms32025.cpp b/src/devices/cpu/tms32025/tms32025.cpp index e9226c86165..562b86b2a6a 100644 --- a/src/devices/cpu/tms32025/tms32025.cpp +++ b/src/devices/cpu/tms32025/tms32025.cpp @@ -2187,7 +2187,7 @@ bool tms32025_device::memory_readop(offs_t offset, int size, UINT64 &value) ****************************************************************************/ bool tms32025_device::memory_read(address_spacenum spacenum, offs_t offset, int size, UINT64 &value) { - void *ptr = nullptr; + void *ptr; UINT64 temp = 0; switch (spacenum) @@ -2239,7 +2239,7 @@ bool tms32025_device::memory_read(address_spacenum spacenum, offs_t offset, int ****************************************************************************/ bool tms32025_device::memory_write(address_spacenum spacenum, offs_t offset, int size, UINT64 value) { - void *ptr = nullptr; + void *ptr; switch (spacenum) { diff --git a/src/devices/cpu/tms32025/tms32025.h b/src/devices/cpu/tms32025/tms32025.h index 773ddb576f8..464843cbe95 100644 --- a/src/devices/cpu/tms32025/tms32025.h +++ b/src/devices/cpu/tms32025/tms32025.h @@ -276,7 +276,6 @@ private: void mpys(); void mpyu(); void neg(); - void nop(); void norm(); void or_(); void ork(); diff --git a/src/devices/cpu/tms32082/mp_ops.cpp b/src/devices/cpu/tms32082/mp_ops.cpp index bdfbcf1ff28..1cce61f6a8d 100644 --- a/src/devices/cpu/tms32082/mp_ops.cpp +++ b/src/devices/cpu/tms32082/mp_ops.cpp @@ -897,7 +897,7 @@ void tms32082_mp_device::execute_reg_long_imm() UINT32 shiftmask = SHIFT_MASK[shift ? shift : 32]; UINT32 compmask = endmask & shiftmask; - UINT32 res = 0; + UINT32 res; if (r) // right { res = ROTATE_R(source, rot) & compmask; @@ -928,7 +928,7 @@ void tms32082_mp_device::execute_reg_long_imm() UINT32 shiftmask = SHIFT_MASK[shift ? shift : 32]; UINT32 compmask = endmask & shiftmask; - UINT32 res = 0; + UINT32 res; if (r) // right { res = ROTATE_R(source, rot) & compmask; @@ -960,7 +960,7 @@ void tms32082_mp_device::execute_reg_long_imm() UINT32 shiftmask = SHIFT_MASK[shift ? shift : 32]; UINT32 compmask = endmask & ~shiftmask; - UINT32 res = 0; + UINT32 res; if (r) // right { res = ROTATE_R(source, rot) & compmask; diff --git a/src/devices/cpu/tms57002/tms57002.h b/src/devices/cpu/tms57002/tms57002.h index 5e871591158..6cfcf4b4b51 100644 --- a/src/devices/cpu/tms57002/tms57002.h +++ b/src/devices/cpu/tms57002/tms57002.h @@ -159,8 +159,6 @@ private: inline int movm(UINT32 st1); inline int sfma(UINT32 st1); - const char *get_memadr(UINT32 opcode, char type); - void xm_init(); void xm_step_read(); void xm_step_write(); diff --git a/src/devices/cpu/tms9900/tms9900.cpp b/src/devices/cpu/tms9900/tms9900.cpp index 71f177809eb..0c3de4547c0 100644 --- a/src/devices/cpu/tms9900/tms9900.cpp +++ b/src/devices/cpu/tms9900/tms9900.cpp @@ -1039,7 +1039,7 @@ const tms99xx_device::tms_instruction tms99xx_device::s_command[] = void tms99xx_device::build_command_lookup_table() { int i = 0; - int cmdindex = 0; + int cmdindex; int bitcount; const tms_instruction *inst; UINT16 opcode; @@ -1968,7 +1968,7 @@ void tms99xx_device::alu_f3() void tms99xx_device::alu_multiply() { - UINT32 result = 0; + UINT32 result; switch (m_state) { diff --git a/src/devices/cpu/tms9900/tms9995.cpp b/src/devices/cpu/tms9900/tms9995.cpp index e40cfd94280..6eec831e927 100644 --- a/src/devices/cpu/tms9900/tms9995.cpp +++ b/src/devices/cpu/tms9900/tms9995.cpp @@ -1128,7 +1128,7 @@ const tms9995_device::tms_instruction tms9995_device::s_command[] = void tms9995_device::build_command_lookup_table() { int i = 0; - int cmdindex = 0; + int cmdindex; int bitcount; const tms_instruction *inst; UINT16 opcode; @@ -1599,7 +1599,7 @@ void tms9995_device::command_completed() */ void tms9995_device::service_interrupt() { - int vectorpos = 0; + int vectorpos; if (m_reset) { @@ -2555,7 +2555,7 @@ void tms9995_device::alu_divide() void tms9995_device::alu_divide_signed() { int n=1; - bool overflow = true; + bool overflow; UINT16 w1, w2, dwait; INT16 divisor; INT32 dividend; @@ -2930,8 +2930,8 @@ void tms9995_device::alu_mov() void tms9995_device::alu_multiply() { int n = 0; - UINT32 result = 0; - INT32 results = 0; + UINT32 result; + INT32 results; if (m_instruction->command==MPY) { diff --git a/src/devices/cpu/upd7810/upd7810.cpp b/src/devices/cpu/upd7810/upd7810.cpp index bf699d70fa9..16734940564 100644 --- a/src/devices/cpu/upd7810/upd7810.cpp +++ b/src/devices/cpu/upd7810/upd7810.cpp @@ -1825,7 +1825,7 @@ void upd7810_device::execute_run() { do { - int cc = 0; + int cc; debugger_instruction_hook(this, PC); diff --git a/src/devices/cpu/v60/v60.h b/src/devices/cpu/v60/v60.h index 4427fe2c8fc..acb1c70bfcf 100644 --- a/src/devices/cpu/v60/v60.h +++ b/src/devices/cpu/v60/v60.h @@ -378,12 +378,10 @@ private: UINT32 am2ImmediateQuick(); UINT32 am2Error1(); UINT32 am2Error2(); - UINT32 am2Error3(); UINT32 am2Error4(); UINT32 am2Error5(); UINT32 bam2Error1(); UINT32 bam2Error2(); - UINT32 bam2Error3(); UINT32 bam2Error4(); UINT32 bam2Error5(); UINT32 bam2Error6(); @@ -436,7 +434,6 @@ private: UINT32 am3ImmediateQuick(); UINT32 am3Error1(); UINT32 am3Error2(); - UINT32 am3Error3(); UINT32 am3Error4(); UINT32 am3Error5(); UINT32 am3Group7a(); diff --git a/src/devices/machine/53c7xx.cpp b/src/devices/machine/53c7xx.cpp index f2aad1ad75b..c77baa6a8dc 100644 --- a/src/devices/machine/53c7xx.cpp +++ b/src/devices/machine/53c7xx.cpp @@ -854,7 +854,7 @@ void ncr53c7xx_device::step(bool timeout) if (((m_scntl[0] >> SCNTL0_ARB_SHIFT) & SCNTL0_ARB_MASK) == 3) { int win; - for (win = 7; win >=0 && !(data & (1 << win)); win--); + for (win = 7; win >=0 && !(data & (1 << win)); win--) {}; if ((1 << win) != m_scid) { diff --git a/src/devices/machine/68307.h b/src/devices/machine/68307.h index 555a1ec39e3..60ae61db49a 100644 --- a/src/devices/machine/68307.h +++ b/src/devices/machine/68307.h @@ -109,7 +109,6 @@ public: m68307_portb_write_delegate m_m68307_portb_w; void init16_m68307(address_space &space); - void init_cpu_m68307(void); virtual UINT32 disasm_min_opcode_bytes() const override { return 2; }; virtual UINT32 disasm_max_opcode_bytes() const override { return 10; }; diff --git a/src/devices/machine/74123.h b/src/devices/machine/74123.h index b44354b456b..898dd48e6ea 100644 --- a/src/devices/machine/74123.h +++ b/src/devices/machine/74123.h @@ -125,10 +125,8 @@ private: int timer_running(); void start_pulse(); - void output(INT32 param); void set_output(); attotime compute_duration(); - void clear(); emu_timer *m_timer; int m_connection_type; /* the hook up type - one of the constants above */ diff --git a/src/devices/machine/hdc92x4.cpp b/src/devices/machine/hdc92x4.cpp index 299a4e7c367..54a8f802b99 100644 --- a/src/devices/machine/hdc92x4.cpp +++ b/src/devices/machine/hdc92x4.cpp @@ -1319,7 +1319,7 @@ void hdc92x4_device::tape_backup() */ void hdc92x4_device::poll_drives() { - UINT8 drivebit = 0; + UINT8 drivebit; if (m_substate == UNDEF) { logerror("%s: POLL DRIVES command %02x\n", tag(), current_command()); @@ -3795,7 +3795,7 @@ bool hdc92x4_device::read_from_mfmhd(const attotime &limit) */ bool hdc92x4_device::write_to_mfmhd(const attotime &limit) { - UINT16 data = 0; + UINT16 data; int count; bool offlimit = false; @@ -3918,7 +3918,7 @@ UINT16 hdc92x4_device::encode_a1_hd() */ READ8_MEMBER( hdc92x4_device::read ) { - UINT8 reply = 0; + UINT8 reply; if ((offset & 1) == 0) { // Data register diff --git a/src/devices/machine/i8279.cpp b/src/devices/machine/i8279.cpp index d336dd80858..725d1aa4827 100644 --- a/src/devices/machine/i8279.cpp +++ b/src/devices/machine/i8279.cpp @@ -206,11 +206,11 @@ void i8279_device::set_irq(bool state) void i8279_device::new_key(UINT8 data, bool skey, bool ckey) { UINT8 i, rl, sl; - for (i = 0; BIT(data, i); i++); + for (i = 0; BIT(data, i); i++) {}; rl = i; if (BIT(m_cmd[0], 0)) { - for (i = 0; !BIT(data, i); i++); + for (i = 0; !BIT(data, i); i++) {}; sl = i; } else @@ -315,7 +315,7 @@ void i8279_device::timer_mainloop() UINT8 addr = m_scanner &7; if (decoded) - for (addr=0; !BIT(m_scanner, addr); addr++); + for (addr=0; !BIT(m_scanner, addr); addr++) {}; rl ^= 0xff; // inverted assert(addr < ARRAY_LENGTH(m_s_ram)); diff --git a/src/devices/machine/mc68328.cpp b/src/devices/machine/mc68328.cpp index 4cd578d6a4c..deb73d0eaa4 100644 --- a/src/devices/machine/mc68328.cpp +++ b/src/devices/machine/mc68328.cpp @@ -1794,7 +1794,7 @@ WRITE16_MEMBER( mc68328_device::write ) READ16_MEMBER( mc68328_device::read ) { - UINT16 temp16 = 0; + UINT16 temp16; UINT32 address = offset << 1; switch (address) diff --git a/src/devices/machine/mc68681.cpp b/src/devices/machine/mc68681.cpp index c7abec82b46..00b38347285 100644 --- a/src/devices/machine/mc68681.cpp +++ b/src/devices/machine/mc68681.cpp @@ -878,7 +878,7 @@ void mc68681_channel::update_interrupts() UINT8 mc68681_channel::read_rx_fifo() { - UINT8 rv = 0; + UINT8 rv; // printf("read_rx_fifo: rx_fifo_num %d\n", rx_fifo_num); diff --git a/src/devices/machine/ncr5380n.cpp b/src/devices/machine/ncr5380n.cpp index 7ad2a7fd5d5..cffe173d73c 100644 --- a/src/devices/machine/ncr5380n.cpp +++ b/src/devices/machine/ncr5380n.cpp @@ -165,7 +165,7 @@ void ncr5380n_device::step(bool timeout) break; int win; - for(win=7; win>=0 && !(data & (1<<win)); win--); + for(win=7; win>=0 && !(data & (1<<win)); win--) {}; // printf("arb complete: data %02x win %02x scsi_id %02x\n", data, win, scsi_id); if(win != scsi_id) { scsi_bus->data_w(scsi_refid, 0); diff --git a/src/devices/machine/ncr5390.cpp b/src/devices/machine/ncr5390.cpp index fa29299ff45..9de72de9afe 100644 --- a/src/devices/machine/ncr5390.cpp +++ b/src/devices/machine/ncr5390.cpp @@ -143,7 +143,7 @@ void ncr5390_device::step(bool timeout) break; int win; - for(win=7; win>=0 && !(data & (1<<win)); win--); + for(win=7; win>=0 && !(data & (1<<win)); win--) {}; if(win != scsi_id) { scsi_bus->data_w(scsi_refid, 0); scsi_bus->ctrl_w(scsi_refid, 0, S_ALL); diff --git a/src/devices/machine/nscsi_bus.cpp b/src/devices/machine/nscsi_bus.cpp index 611586a7962..d0508059758 100644 --- a/src/devices/machine/nscsi_bus.cpp +++ b/src/devices/machine/nscsi_bus.cpp @@ -280,7 +280,7 @@ void nscsi_full_device::step(bool timeout) switch(scsi_state & SUB_MASK ? scsi_state & SUB_MASK : scsi_state & STATE_MASK) { case IDLE: if(((ctrl & (S_SEL|S_BSY)) == S_SEL) && (scsi_id != -1) && ((data & (1 << scsi_id)) != 0)) { - for(scsi_initiator_id = 0; scsi_initiator_id != 16 && (scsi_initiator_id == scsi_id || (data & (1 << scsi_initiator_id))); scsi_initiator_id++); + for(scsi_initiator_id = 0; scsi_initiator_id != 16 && (scsi_initiator_id == scsi_id || (data & (1 << scsi_initiator_id))); scsi_initiator_id++) {}; if(scsi_initiator_id == 16) scsi_initiator_id = -1; scsi_state = TARGET_SELECT_WAIT_BUS_SETTLE; diff --git a/src/devices/machine/pci.h b/src/devices/machine/pci.h index c57d3eb3bf8..a88f0a3b7fb 100644 --- a/src/devices/machine/pci.h +++ b/src/devices/machine/pci.h @@ -133,10 +133,6 @@ protected: void set_map_address(int id, UINT64 adr); void set_map_size(int id, UINT64 size); void set_map_flags(int id, int flags); - -private: - void add_map_finish(int bid, UINT64 size, int flags); - }; class agp_device : public pci_device { diff --git a/src/devices/machine/pci9050.cpp b/src/devices/machine/pci9050.cpp index 4a8ad2dd704..6e74a19e284 100644 --- a/src/devices/machine/pci9050.cpp +++ b/src/devices/machine/pci9050.cpp @@ -113,7 +113,7 @@ void pci9050_device::remap_local(int id) return; } int lsize; - for(lsize=1; lsize<28 && !(csbase & (1<<lsize)); lsize++); + for(lsize=1; lsize<28 && !(csbase & (1<<lsize)); lsize++) {}; if(lsize == 28) { set_map_flags(id+2, M_MEM | M_DISABLED); return; diff --git a/src/devices/machine/stvcd.cpp b/src/devices/machine/stvcd.cpp index 09d7b9e09a5..d2734007222 100644 --- a/src/devices/machine/stvcd.cpp +++ b/src/devices/machine/stvcd.cpp @@ -2346,7 +2346,7 @@ void saturn_state::cd_readTOC(void) saturn_state::partitionT *saturn_state::cd_filterdata(filterT *flt, int trktype, UINT8 *p_ok) { int match, keepgoing; - partitionT *filterprt = (partitionT *)nullptr; + partitionT *filterprt; CDROM_LOG(("cd_filterdata, trktype %d\n", trktype)) match = 1; diff --git a/src/devices/machine/upd765.cpp b/src/devices/machine/upd765.cpp index 54c1119d4e7..6587c44d360 100644 --- a/src/devices/machine/upd765.cpp +++ b/src/devices/machine/upd765.cpp @@ -1335,7 +1335,7 @@ void upd765_family_device::start_command(int cmd) main_phase = PHASE_RESULT; int fid; - for(fid=0; fid<4 && !flopi[fid].st0_filled; fid++); + for(fid=0; fid<4 && !flopi[fid].st0_filled; fid++) {}; if(fid == 4) { result[0] = ST0_UNK; result_pos = 1; diff --git a/src/devices/machine/z80sio.h b/src/devices/machine/z80sio.h index 278fa006d45..3eac1e98d69 100644 --- a/src/devices/machine/z80sio.h +++ b/src/devices/machine/z80sio.h @@ -169,7 +169,7 @@ public: DECLARE_WRITE_LINE_MEMBER( write_rx ); DECLARE_WRITE_LINE_MEMBER( cts_w ); DECLARE_WRITE_LINE_MEMBER( dcd_w ); - DECLARE_WRITE_LINE_MEMBER( ri_w ); + //DECLARE_WRITE_LINE_MEMBER( ri_w ); DECLARE_WRITE_LINE_MEMBER( rxc_w ); DECLARE_WRITE_LINE_MEMBER( txc_w ); DECLARE_WRITE_LINE_MEMBER( sync_w ); @@ -457,8 +457,8 @@ class z80sio_device : public device_t, DECLARE_WRITE_LINE_MEMBER( ctsb_w ) { m_chanB->cts_w(state); } DECLARE_WRITE_LINE_MEMBER( dcda_w ) { m_chanA->dcd_w(state); } DECLARE_WRITE_LINE_MEMBER( dcdb_w ) { m_chanB->dcd_w(state); } - DECLARE_WRITE_LINE_MEMBER( ria_w ) { m_chanA->ri_w(state); } - DECLARE_WRITE_LINE_MEMBER( rib_w ) { m_chanB->ri_w(state); } + //DECLARE_WRITE_LINE_MEMBER( ria_w ) { m_chanA->ri_w(state); } + //DECLARE_WRITE_LINE_MEMBER( rib_w ) { m_chanB->ri_w(state); } DECLARE_WRITE_LINE_MEMBER( rxca_w ) { m_chanA->rxc_w(state); } DECLARE_WRITE_LINE_MEMBER( rxcb_w ) { m_chanB->rxc_w(state); } DECLARE_WRITE_LINE_MEMBER( txca_w ) { m_chanA->txc_w(state); } diff --git a/src/devices/sound/aica.cpp b/src/devices/sound/aica.cpp index c8c14fc797d..524ef93d6bd 100644 --- a/src/devices/sound/aica.cpp +++ b/src/devices/sound/aica.cpp @@ -804,7 +804,7 @@ void aica_device::UpdateRegR(address_space &space, int reg) { int slotnum = MSLC(); AICA_SLOT *slot=m_Slots + slotnum; - UINT16 LP = 0; + UINT16 LP; if (!(AFSEL())) { UINT16 SGC; @@ -834,7 +834,7 @@ void aica_device::UpdateRegR(address_space &space, int reg) //m_stream->update(); int slotnum = MSLC(); AICA_SLOT *slot=m_Slots+slotnum; - unsigned int CA = 0; + unsigned int CA; if (PCMS(slot) == 0) // 16-bit samples { diff --git a/src/devices/sound/es5506.cpp b/src/devices/sound/es5506.cpp index 07c25e93151..282ee217e15 100644 --- a/src/devices/sound/es5506.cpp +++ b/src/devices/sound/es5506.cpp @@ -2139,7 +2139,7 @@ inline UINT16 es5505_device::reg_read_test(es550x_voice *voice, offs_t offset) READ16_MEMBER( es5505_device::read ) { es550x_voice *voice = &m_voice[m_current_page & 0x1f]; - UINT16 result = 0; + UINT16 result; if (LOG_COMMANDS && m_eslog) fprintf(m_eslog, "read from %02x/%02x -> ", m_current_page, offset); diff --git a/src/devices/sound/fm.cpp b/src/devices/sound/fm.cpp index 8aa9f157f91..4581ec2fbdf 100644 --- a/src/devices/sound/fm.cpp +++ b/src/devices/sound/fm.cpp @@ -1112,7 +1112,7 @@ static inline void advance_lfo(FM_OPN *OPN) static void advance_eg_channel(FM_OPN *OPN, FM_SLOT *SLOT) { unsigned int out; - unsigned int swap_flag = 0; + unsigned int swap_flag; unsigned int i; diff --git a/src/devices/sound/pokey.cpp b/src/devices/sound/pokey.cpp index e38b92dd6b3..b23980c8b05 100644 --- a/src/devices/sound/pokey.cpp +++ b/src/devices/sound/pokey.cpp @@ -802,7 +802,7 @@ READ8_MEMBER( pokey_device::read ) UINT8 pokey_device::read(offs_t offset) { - int data = 0, pot; + int data, pot; synchronize(SYNC_NOOP); /* force resync */ diff --git a/src/devices/sound/qs1000.h b/src/devices/sound/qs1000.h index a807071fe22..1543a01b057 100644 --- a/src/devices/sound/qs1000.h +++ b/src/devices/sound/qs1000.h @@ -112,7 +112,6 @@ public: }; void start_voice(int ch); - void set_voice_regs(int ch); bool m_external_rom; diff --git a/src/devices/sound/segapcm.cpp b/src/devices/sound/segapcm.cpp index c93d830392e..555ee019b16 100644 --- a/src/devices/sound/segapcm.cpp +++ b/src/devices/sound/segapcm.cpp @@ -46,7 +46,7 @@ void segapcm_device::device_start() if (!mask) mask = BANK_MASK7 >> 16; - for(rom_mask = 1; rom_mask < m_rom.length(); rom_mask *= 2); + for(rom_mask = 1; rom_mask < m_rom.length(); rom_mask *= 2) { }; rom_mask--; m_bankmask = mask & (rom_mask >> m_bankshift); diff --git a/src/devices/sound/sp0256.cpp b/src/devices/sound/sp0256.cpp index 9e5a95441e3..f009516a807 100644 --- a/src/devices/sound/sp0256.cpp +++ b/src/devices/sound/sp0256.cpp @@ -759,7 +759,7 @@ void sp0256_device::bitrevbuff(UINT8 *buffer, unsigned int start, unsigned int l /* ======================================================================== */ UINT32 sp0256_device::getb( int len ) { - UINT32 data = 0; + UINT32 data; UINT32 d0, d1; /* -------------------------------------------------------------------- */ @@ -822,8 +822,8 @@ void sp0256_device::micro() UINT8 immed4; UINT8 opcode; UINT16 cr; - int ctrl_xfer = 0; - int repeat = 0; + int ctrl_xfer; + int repeat; int i, idx0, idx1; /* -------------------------------------------------------------------- */ diff --git a/src/devices/sound/spu.cpp b/src/devices/sound/spu.cpp index 50276f3c486..3686fab3f9d 100644 --- a/src/devices/sound/spu.cpp +++ b/src/devices/sound/spu.cpp @@ -1147,7 +1147,7 @@ void spu_device::kill_sound() READ16_MEMBER( spu_device::read ) { - unsigned short ret=0, *rp=(unsigned short *)(reg+((offset*2)&0x1ff)); + unsigned short ret, *rp=(unsigned short *)(reg+((offset*2)&0x1ff)); m_stream->update(); diff --git a/src/devices/sound/spu.h b/src/devices/sound/spu.h index 77cf99ad700..6381464c7cd 100644 --- a/src/devices/sound/spu.h +++ b/src/devices/sound/spu.h @@ -165,7 +165,6 @@ protected: void *fmnoise_ptr, void *outxptr, unsigned int *tleft); - void process(); void process_until(const unsigned int tsample); void update_voice_loop(const unsigned int v); bool update_voice_state(const unsigned int v); diff --git a/src/devices/sound/ymf271.cpp b/src/devices/sound/ymf271.cpp index 28c4a37f4f3..14dd53be324 100644 --- a/src/devices/sound/ymf271.cpp +++ b/src/devices/sound/ymf271.cpp @@ -574,7 +574,7 @@ void ymf271_device::sound_stream_update(sound_stream &stream, stream_sample_t ** for (i = 0; i < samples; i++) { INT64 output1 = 0, output2 = 0, output3 = 0, output4 = 0; - INT64 phase_mod1 = 0, phase_mod2 = 0, phase_mod3 = 0; + INT64 phase_mod1, phase_mod2, phase_mod3; switch (m_slots[slot1].algorithm) { // <--------| @@ -800,7 +800,7 @@ void ymf271_device::sound_stream_update(sound_stream &stream, stream_sample_t ** for (i = 0; i < samples; i++) { INT64 output1 = 0, output3 = 0; - INT64 phase_mod1, phase_mod3 = 0; + INT64 phase_mod1, phase_mod3; switch (m_slots[slot1].algorithm & 3) { // <--------| @@ -863,7 +863,7 @@ void ymf271_device::sound_stream_update(sound_stream &stream, stream_sample_t ** for (i = 0; i < samples; i++) { INT64 output1 = 0, output2 = 0, output3 = 0; - INT64 phase_mod1 = 0, phase_mod3 = 0; + INT64 phase_mod1, phase_mod3; switch (m_slots[slot1].algorithm & 7) { // <--------| diff --git a/src/devices/video/315_5313.cpp b/src/devices/video/315_5313.cpp index d16874cdb59..22b63f36d5b 100644 --- a/src/devices/video/315_5313.cpp +++ b/src/devices/video/315_5313.cpp @@ -1319,7 +1319,7 @@ void sega315_5313_device::render_spriteline_to_spritebuffer(int scanline) int drawypos; int /*drawwidth,*/ drawheight; int spritemask = 0; - UINT8 height,width=0,link=0,xflip,yflip,colour,pri; + UINT8 height,width,link,xflip,yflip,colour,pri; /* Get Sprite Attribs */ spritenum = 0; @@ -1506,7 +1506,7 @@ void sega315_5313_device::render_videoline_to_videobuffer(int scanline) int x; int window_hsize=0; int window_vsize=0; - int window_is_bugged = 0; + int window_is_bugged; int non_window_firstcol; int non_window_lastcol; int screenheight = MEGADRIVE_REG01_240_LINE?240:224; diff --git a/src/devices/video/clgd542x.cpp b/src/devices/video/clgd542x.cpp index 854611d1c80..f7950c879a9 100644 --- a/src/devices/video/clgd542x.cpp +++ b/src/devices/video/clgd542x.cpp @@ -1094,7 +1094,7 @@ WRITE8_MEMBER(cirrus_gd5428_device::port_03d0_w) UINT8 cirrus_gd5428_device::cirrus_crtc_reg_read(UINT8 index) { - UINT8 res = 0xff; + UINT8 res; switch(index) { diff --git a/src/devices/video/h63484.cpp b/src/devices/video/h63484.cpp index 75b8f881eb0..1e0d7cbb0d8 100644 --- a/src/devices/video/h63484.cpp +++ b/src/devices/video/h63484.cpp @@ -1918,7 +1918,7 @@ READ16_MEMBER( h63484_device::status_r ) READ16_MEMBER( h63484_device::data_r ) { - UINT16 res = 0xffff; + UINT16 res; if(m_ar == 0) // FIFO read { diff --git a/src/devices/video/mc6847.h b/src/devices/video/mc6847.h index a4bdb715923..65767e17e96 100644 --- a/src/devices/video/mc6847.h +++ b/src/devices/video/mc6847.h @@ -623,9 +623,6 @@ private: void record_body_scanline(UINT16 physical_scanline, UINT16 scanline, INT32 start_pos, INT32 end_pos); pixel_t border_value(UINT8 mode, const pixel_t *palette, bool is_mc6847t1); - template<int xscale> - void emit_samples(UINT8 mode, const UINT8 *data, int length, pixel_t *pixels, int x, int y); - // template function for doing video update collection template<int sample_count, int yres> void record_scanline_res(int scanline, INT32 start_pos, INT32 end_pos); diff --git a/src/devices/video/mos6566.cpp b/src/devices/video/mos6566.cpp index d39e8cb041a..f6b9ca75a62 100644 --- a/src/devices/video/mos6566.cpp +++ b/src/devices/video/mos6566.cpp @@ -2138,7 +2138,7 @@ void mos6566_device::draw_sprites() UINT8 snum, sbit; UINT8 spr_coll = 0, gfx_coll = 0; UINT32 plane0_l, plane0_r, plane1_l, plane1_r; - UINT32 sdata_l = 0, sdata_r = 0; + UINT32 sdata_l, sdata_r; for (i = 0; i < 0x400; i++) m_spr_coll_buf[i] = 0; diff --git a/src/devices/video/msm6222b.cpp b/src/devices/video/msm6222b.cpp index 4287916ce1d..efa82d7c119 100644 --- a/src/devices/video/msm6222b.cpp +++ b/src/devices/video/msm6222b.cpp @@ -67,7 +67,7 @@ void msm6222b_device::device_start() void msm6222b_device::control_w(UINT8 data) { int cmd; - for(cmd = 7; cmd >= 0 && !(data & (1<<cmd)); cmd--); + for(cmd = 7; cmd >= 0 && !(data & (1<<cmd)); cmd--) {}; switch(cmd) { case 0: memset(ddram, 0x20, sizeof(ddram)); diff --git a/src/devices/video/pc_vga.cpp b/src/devices/video/pc_vga.cpp index fa8131e5b88..7710e3402c3 100644 --- a/src/devices/video/pc_vga.cpp +++ b/src/devices/video/pc_vga.cpp @@ -992,7 +992,7 @@ UINT32 svga_device::screen_update(screen_device &screen, bitmap_rgb32 &bitmap, c UINT32 s3_vga_device::screen_update(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect) { - UINT8 cur_mode = 0; + UINT8 cur_mode; svga_device::screen_update(screen, bitmap, cliprect); @@ -3387,7 +3387,7 @@ void ibm8514a_device::ibm8514_write_bg(UINT32 offset) void ibm8514a_device::ibm8514_write(UINT32 offset, UINT32 src) { int data_size = 8; - UINT32 xfer = 0; + UINT32 xfer; address_space& space = machine().device("maincpu")->memory().space(AS_PROGRAM); switch(ibm8514.pixel_control & 0x00c0) diff --git a/src/devices/video/snes_ppu.cpp b/src/devices/video/snes_ppu.cpp index ed8fafeefbc..7fdd700278c 100644 --- a/src/devices/video/snes_ppu.cpp +++ b/src/devices/video/snes_ppu.cpp @@ -474,7 +474,7 @@ void snes_ppu_device::device_reset() inline UINT16 snes_ppu_device::get_bgcolor( UINT8 direct_colors, UINT16 palette, UINT8 color ) { - UINT16 c = 0; + UINT16 c; if (direct_colors) { @@ -801,8 +801,8 @@ inline void snes_ppu_device::update_line( UINT16 curline, UINT8 layer, UINT8 pri if (offset_per_tile != SNES_OPT_NONE) { int opt_x = ii + (xoff & 7); - UINT32 haddr = 0, vaddr = 0; - UINT16 hval = 0, vval = 0; + UINT32 haddr, vaddr; + UINT16 hval, vval; if (opt_x >= 8) { @@ -1275,7 +1275,7 @@ void snes_ppu_device::update_objects_rto( UINT16 curline ) UINT8 height, width, vflip, hflip, priority, pal; UINT16 tile; INT16 x, y; - UINT32 name_sel = 0; + UINT32 name_sel; oam_list_build(); @@ -2047,7 +2047,7 @@ inline UINT32 snes_ppu_device::get_vram_address() READ8_MEMBER( snes_ppu_device::vram_read ) { - UINT8 res = 0; + UINT8 res; offset &= 0xffff; // only 64KB are present on SNES if (m_screen_disabled) @@ -2208,7 +2208,7 @@ WRITE8_MEMBER( snes_ppu_device::oam_write ) READ8_MEMBER( snes_ppu_device::cgram_read ) { - UINT8 res = 0; + UINT8 res; offset &= 0x1ff; #if 0 diff --git a/src/devices/video/stvvdp2.cpp b/src/devices/video/stvvdp2.cpp index fcdf2ce2eb2..566b802e553 100644 --- a/src/devices/video/stvvdp2.cpp +++ b/src/devices/video/stvvdp2.cpp @@ -2104,7 +2104,7 @@ bit-> /----15----|----14----|----13----|----12----|----11----|----10----|----09 void saturn_state::stv_vdp2_fill_rotation_parameter_table( UINT8 rot_parameter ) { - UINT32 address = 0; + UINT32 address; address = (((STV_VDP2_RPTAU << 16) | STV_VDP2_RPTAL) << 1); if ( rot_parameter == 1 ) @@ -2390,7 +2390,7 @@ void saturn_state::stv_vdp2_drawgfxzoom( if (gfx->has_pen_usage() && transparency == STV_TRANSPARENCY_PEN) { - int transmask = 0; + int transmask; transmask = 1 << (transparent_color & 0xff); @@ -3579,7 +3579,7 @@ map is always enabled? void saturn_state::stv_vdp2_get_map_page( int x, int y, int *_map, int *_page ) { int page = 0; - int map = 0; + int map; if ( stv2_current_tilemap.map_count == 4 ) { diff --git a/src/devices/video/upd7220.cpp b/src/devices/video/upd7220.cpp index cc892d66b33..7a4bb506aa3 100644 --- a/src/devices/video/upd7220.cpp +++ b/src/devices/video/upd7220.cpp @@ -987,7 +987,7 @@ void upd7220_device::draw_rectangle(int x, int y) void upd7220_device::draw_char(int x, int y) { int isize,psize; - UINT16 tile_data = 0; + UINT16 tile_data; LOG(("uPD7220 char check: %d %d %02x %08x %d %d %02x\n",x,y,m_figs.m_dir,m_ead,m_figs.m_d,m_figs.m_dc,m_figs.m_figure_type)); diff --git a/src/devices/video/vooddefs.h b/src/devices/video/vooddefs.h index bf14947df16..49e5042dbaf 100644 --- a/src/devices/video/vooddefs.h +++ b/src/devices/video/vooddefs.h @@ -2366,7 +2366,7 @@ static inline bool ATTR_FORCE_INLINE chromaKeyTest(voodoo_state *v, stats_block else { INT32 low, high, test; - int results = 0; + int results; /* check blue */ low = v->reg[chromaKey].rgb.b; diff --git a/src/devices/video/voodoo.cpp b/src/devices/video/voodoo.cpp index 72d94e994d4..0b7167fde5f 100644 --- a/src/devices/video/voodoo.cpp +++ b/src/devices/video/voodoo.cpp @@ -3414,7 +3414,7 @@ static INT32 lfb_w(voodoo_state *v, offs_t offset, UINT32 data, UINT32 mem_mask) /* pixel pipeline part 2 handles color combine, fog, alpha, and final output */ PIXEL_PIPELINE_END(v, stats, dither, dither4, dither_lookup, x, dest, depth, v->reg[fbzMode].u, v->reg[fbzColorPath].u, v->reg[alphaMode].u, v->reg[fogMode].u, - iterz, iterw, iterargb); + iterz, iterw, iterargb) {}; nextpixel: /* advance our pointers */ x++; @@ -5317,7 +5317,7 @@ static INT32 swapbuffer(voodoo_state *v, UINT32 data) static INT32 triangle(voodoo_state *v) { - int texcount = 0; + int texcount; UINT16 *drawbuf; int destbuf; int pixels; |