| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
- corefile.cpp, fileio.cpp: Change puts to take a std::string_view parameter
- rendlay.cpp: Use std::string_view instead of bare pointers in various functions
- vecstream.h: Add std::string_view conversion operator to obtain output buffer without needing to make it a C string with explicit null termination
- xmlfile.cpp: Add get_attribute_string_ptr method that distinguishes between empty strings and absent attributes without falling back to C strings
|
| |
|
|
| |
SP/PC (#7440)
|
| | |
|
| |
|
|
| |
use smart pointers.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Memory references in expressions no longer default to the console's visible CPU if no device name was specified, except when entered through the console itself. Expressions in view windows now use the context of the currently selected device instead.
- The pcatmem debug command and similar qt mouseover function now produce an error message if the initial address translation fails.
Related internal changes (nw)
- The debugger_cpu class no longer interprets memory accesses. The existing routines have been moved into symbol_table (which used to invoke them as callbacks), and reimplemented in most other places. Thecode duplication is a bit messy, but could be potentially improved in the future with new utility classes.
- The cheat engine no longer needs to hook into the debugger_cpu class or instantiate a dummy instance of it.
- The inclusion of debug/express.h within emu.h has been undone. Some debugging structures now need unique_ptr to wrap the resulting incomplete classes; hopefully the performance impact of this is negligible. Another direct consequence is that the breakpoint, watchpoint and registerpoint classes are no longer inside device_debug and have their own source file.
- The breakpoint list is now a std::multimap, using the addresses as keys to hopefully expedite lookup.
- The visible CPU pointer has been removed from the debugger_cpu class, being now considered a property of the console instead.
- Many minor bits of code have been simplified.
|
| |
|
|
|
|
|
| |
* Revert "fixed some modernize-use-equals-default clang-tidy warnings (nw)"
This reverts commit 54486ab9
* fixed merge error
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fixed some modernize-redundant-void-arg clang-tidy warnings (nw)
* fixed some modernize-use-bool-literals clang-tidy warnings (nw)
* fixed some modernize-use-emplace clang-tidy warnings (nw)
* fixed some performance-move-const-arg clang-tidy warnings (nw)
* fixed some readability-redundant-control-flow clang-tidy warnings (nw)
* fixed some readability-redundant-string-cstr clang-tidy warnings (nw)
* fixed some performance-unnecessary-value-param clang-tidy warnings (nw)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fixed some bugprone-throw-keyword-missing clang-tidy warnings (nw)
* fixed some modernize-use-nullptr clang-tidy warnings (nw)
* fixed some readability-delete-null-pointer clang-tidy warnings (nw)
* fixed some performance-faster-string-find clang-tidy warnings (nw)
* fixed some performance-for-range-copy clang-tidy warnings (nw)
* fixed some readability-redundant-string-cstr clang-tidy warnings (nw)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(nw) This has been a long time coming but it's here at last. It should
be easier now that logerror, popmessage and osd_printf_* behave like
string_format and stream_format. Remember the differences from printf:
* Any object with a stream out operator works with %s
* %d, %i, %o, %x, %X, etc. work out the size by magic
* No sign extending promotion to int for short/char
* No widening/narrowing conversions for characters/strings
* Same rules on all platforms, insulated from C runtime library
* No format warnings from compiler
* Assert in debug builds if number of arguments doesn't match format
(nw) Also removed a pile of redundant c_str and string_format, and some
workarounds for not being able to portably format 64-bit integers or
long long.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* gdbstub: small cleanup and clarification
Old GDBs expected the regnum values for some registers to be hardcoded.
This is no longer the case with GDB clients that support target.xml.
We expect the GDB client to support target.xml (and won't support the
'g', 'G', 'p', and 'P' commands unless it is sent).
* gdbstub: add mips (tested with indy_4610)
* gdbstub: add m68k (tested with macii)
* gdbstub: add support for executing MAME debugger commands from the GDB client
It's now possible to send MAME debugger commands, such as "cheatinit",
"snap", etc...
Try not to use "bpset" and such commands, they may confuse the GDB
client. Also don't use commands such as "step" and "go", they will
definitely confuse the GDB client.
* gdbstub: fatalerror() when socket can't be opened
|
| |
|
|
| |
I'm assuming atronic.cpp was supposed to be Windows-1252 with Euro currency symbol encoding. Everyone please use UTF-8 for source files.
|
| |
|
|
| |
These unused parameters don't cause any warnings, so I suggest they shouldn't be commented; make the implementations match their declarations.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
z80 was tested with pacman and m6502 was tested with apple2e.
Side-effects must be disabled before reading memory, otherwise apple2e
starts failing after the first read to 0xc080.
Since GDB doesn't support those processors, I made up the features name
with "mame.<cpuname>". I also had to choose the registers to export in
the target.xml file, and since I don't have any experience with these
processors I don't know if I made the best choice.
|
|
|
* gdbstub: added new GDB stub debugger
This debugger can be used to connect to an external debugger that
communicates using the GDB Remote Serial Protocol, such as GDB itself
or many other GDB frontends.
Currently i386 (ct486), arm7 (gba), and ppc (pmac6100) are supported.
* gdbstub: enable GDB stub debugger in mac and windows builds
|