diff options
| author | 2007-12-24 03:41:16 +0000 | |
|---|---|---|
| committer | 2007-12-24 03:41:16 +0000 | |
| commit | b5087df8d2aee1a6f057353952deed45a7703284 (patch) | |
| tree | 73b343cf56c2dbeb3515948ac1d4d6bc2b8eb4a4 /src/tools | |
| parent | a570a7d8c6fa369d0098392b43b6e9239a52ebe4 (diff) | |
(From Atari Ace)
This small patch makes some minor "code quality" improvements to MAME.
First off, some remaing static/const qualifier missed cases were
addressed. Secondly, a few cases of missing #include "foo.h" were
added. Thirdly, a few global names were modified to make them less
generic/more consistent (voodoo.c, vrender0.c, lethal.c, rungun.c,
zac2650.c). Fourthly, some dead/useless code was removed
(i8051.c,model1.c,romcmp.c).
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/chdman.c | 4 | ||||
| -rw-r--r-- | src/tools/makemeta.c | 2 | ||||
| -rw-r--r-- | src/tools/romcmp.c | 12 |
3 files changed, 6 insertions, 12 deletions
diff --git a/src/tools/chdman.c b/src/tools/chdman.c index e154b62c198..c599cccab97 100644 --- a/src/tools/chdman.c +++ b/src/tools/chdman.c @@ -111,7 +111,7 @@ INLINE void put_bigendian_uint32(UINT8 *base, UINT32 value) print_big_int - 64-bit int printing with commas -------------------------------------------------*/ -void print_big_int(UINT64 intvalue, char *output) +static void print_big_int(UINT64 intvalue, char *output) { int chunk; @@ -132,7 +132,7 @@ void print_big_int(UINT64 intvalue, char *output) big_int_string - return a string for a big int -------------------------------------------------*/ -char *big_int_string(UINT64 intvalue) +static char *big_int_string(UINT64 intvalue) { static char buffer[256]; buffer[0] = 0; diff --git a/src/tools/makemeta.c b/src/tools/makemeta.c index 3b01a5ab786..4be3290b729 100644 --- a/src/tools/makemeta.c +++ b/src/tools/makemeta.c @@ -334,7 +334,7 @@ static UINT32 parse_philips_code(char **argptr, const char *endchars) of pattern_data structs -------------------------------------------------*/ -pattern_data *parse_pattern(char *arg, int *countptr) +static pattern_data *parse_pattern(char *arg, int *countptr) { pattern_data *head = NULL; pattern_data **tailptr = &head; diff --git a/src/tools/romcmp.c b/src/tools/romcmp.c index 7e1f4305c46..34557cb7d43 100644 --- a/src/tools/romcmp.c +++ b/src/tools/romcmp.c @@ -27,12 +27,6 @@ #endif -/* for unzip.c */ -void CLIB_DECL logerror(const char *text,...) -{ -} - - /* compare modes when one file is twice as long as the other */ /* A = All file */ @@ -51,7 +45,7 @@ enum { MODE_A, MODE_E, MODE_O, MODE_E12, MODE_O12, MODE_E22, MODE_O22, TOTAL_MODES }; -const char *const modenames[] = +static const char *const modenames[] = { " ", "[bits 0-3]", @@ -113,8 +107,8 @@ struct _fileinfo }; typedef struct _fileinfo fileinfo; -fileinfo files[2][MAX_FILES]; -float matchscore[MAX_FILES][MAX_FILES][TOTAL_MODES][TOTAL_MODES]; +static fileinfo files[2][MAX_FILES]; +static float matchscore[MAX_FILES][MAX_FILES][TOTAL_MODES][TOTAL_MODES]; static void checkintegrity(const fileinfo *file,int side) |
