diff options
author | 2009-01-22 10:21:52 +0000 | |
---|---|---|
committer | 2009-01-22 10:21:52 +0000 | |
commit | 325dadfdc0d0cd2afcad8d04e8c973793f4866fc (patch) | |
tree | bc88745544df69ba4eb523b8ac9f511168f9b193 /src/emu/sound/hc55516.c | |
parent | 58af175636d898f6bda49c9e119c9f4bce373ed0 (diff) |
On Mon, Jan 19, 2009 at 02:48:05PM +0100, Olivier Galibert wrote:
> On Mon, Jan 19, 2009 at 05:37:35AM -0800, R. Belmont wrote:
> > My mistake. I thought you were suggesting that we should actually
> > somehow handle malloc failures. Given that aborting is an OK way to
> > express failure, I'd suggest the return values be changed to DEFER
> > and DONT_DEFER to eliminate the conceptual imbalance of OK/DEFER.
>
> That's where comes the fact that we have 130 OK/DONT_DEFER and 1
> DEFER. It makes me think that the exceptional DEFER case should be
> handled by an exceptional function call.
>
> I know, code talks, but I'm at work right now :-)
Here we go.
OG.
Diffstat (limited to 'src/emu/sound/hc55516.c')
-rw-r--r-- | src/emu/sound/hc55516.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/src/emu/sound/hc55516.c b/src/emu/sound/hc55516.c index 8b414fa018e..1c8115da886 100644 --- a/src/emu/sound/hc55516.c +++ b/src/emu/sound/hc55516.c @@ -52,7 +52,7 @@ static STREAM_UPDATE( hc55516_update ); -static device_start_err start_common(const device_config *device, int clock, +static void start_common(const device_config *device, int clock, UINT8 _shiftreg_mask, int _active_clock_hi) { struct hc55516_data *chip = device->token; @@ -79,27 +79,24 @@ static device_start_err start_common(const device_config *device, int clock, state_save_register_device_item(device, 0, chip->update_count); state_save_register_device_item(device, 0, chip->filter); state_save_register_device_item(device, 0, chip->integrator); - - /* success */ - return DEVICE_START_OK; } static SND_START( hc55516 ) { - return start_common(device, clock, 0x07, TRUE); + start_common(device, clock, 0x07, TRUE); } static SND_START( mc3417 ) { - return start_common(device, clock, 0x07, FALSE); + start_common(device, clock, 0x07, FALSE); } static SND_START( mc3418 ) { - return start_common(device, clock, 0x0f, FALSE); + start_common(device, clock, 0x0f, FALSE); } |