diff options
author | 2021-05-22 09:33:21 -0700 | |
---|---|---|
committer | 2021-05-22 12:33:21 -0400 | |
commit | d9db7d77c4ae521432846b1e817d148131672276 (patch) | |
tree | 86c4742248172cfae16f44d6fe3334636ae75337 /src/devices/sound/ymopn.h | |
parent | 52c226c28eb170c53a2f097603f96c0abdea129f (diff) |
ymfm: Sync with latest, add complete YMF278B support (#8090)
* Sync with upstream. I/O callbacks are now consolidated into a single read callback and a single write callback, with an access type specifier.
* Initial working implementation of YM278B. Most features implemented, except vibrato.
* Implement vibrato and status register flags. Fix envelope rate computation.
* Rename ymfm_interface::external_type to access_class and clean up the fallout.
* Formally replace the old YMF278B engine with the one from ymfm
* Rotated YMF278B outputs into a more logical order.
* Re-evaluted envelope calculations and 2x works better than the weird 15/8 I came up with before. Also changed the way FM resampling is computed to be more precise (and simpler). Turned off extraneous debugging.
* Start of/reset to a null state with no loaded waveforms.
* Fix YM2608 I/O ports.
Diffstat (limited to 'src/devices/sound/ymopn.h')
-rw-r--r-- | src/devices/sound/ymopn.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/devices/sound/ymopn.h b/src/devices/sound/ymopn.h index 7bf72216aff..c65738dee07 100644 --- a/src/devices/sound/ymopn.h +++ b/src/devices/sound/ymopn.h @@ -75,9 +75,8 @@ protected: private: // ADPCM read/write callbacks - virtual uint8_t ymfm_adpcm_a_read(uint32_t address) override; - virtual uint8_t ymfm_adpcm_b_read(uint32_t address) override; - virtual void ymfm_adpcm_b_write(uint32_t address, u8 data) override; + virtual uint8_t ymfm_external_read(ymfm::access_class type, uint32_t address) override; + virtual void ymfm_external_write(ymfm::access_class type, uint32_t address, u8 data) override; // internal state required_memory_region m_internal; // internal memory region @@ -115,8 +114,7 @@ protected: private: // ADPCM read/write callbacks - virtual uint8_t ymfm_adpcm_a_read(offs_t address) override; - virtual uint8_t ymfm_adpcm_b_read(offs_t address) override; + virtual uint8_t ymfm_external_read(ymfm::access_class type, uint32_t address) override; // internal state address_space_config const m_adpcm_a_config; // address space 0 config (ADPCM-A) |