diff options
| author | 2017-08-10 09:59:20 +1000 | |
|---|---|---|
| committer | 2017-08-10 10:07:31 +1000 | |
| commit | bc4bfb40051f912b8afe78bc99ab98383b2e7c15 (patch) | |
| tree | 2a8cc876c501c78bb3ddccd6f67206d8c9590bee /src/devices/machine | |
| parent | 147f1d89b0a42ddd33c4f89abaed2765bc86dd8f (diff) | |
Remove a whole lot of I64 from format strings.
There are a couple of issues here:
* Firstly, the determining factor for whether I64 or ll is needed as the
size qualifier doesn't depend entirely on whether you're using MSVC or
not, it depends on the the C runtime library. The msys64 C runtime
apes the Microsoft runtime and requires I64 as well, so a lot of files
where LLFORMAT had been copy/pasted wouldn't work right if you
depeneded on it anyway.
* Secondly, one of the major benefits of util::string_format,
util::stream_format and logerror in their current forms is that you
don't need size specifiers for integers at all (unless you're using
them to truncate a value, but in that case you're better off casting
the argument for clarity). If you do use them, logerror and friends
will accept both Microsoft- and SUS-style independently of the C
runtime.
So please everyone, don't go gratuitously throwing these around, and if
you must use them (e.g. for osd_printf_* functions), make sure your
conditionals are actually correct. Also, conisder using
util::string_format to do the formatting into a temporary string and
just feeding that to the output function so you can avoid the mess.
Diffstat (limited to 'src/devices/machine')
| -rw-r--r-- | src/devices/machine/68340sim.cpp | 2 | ||||
| -rw-r--r-- | src/devices/machine/68561mpcc.cpp | 2 | ||||
| -rw-r--r-- | src/devices/machine/mc14411.cpp | 2 | ||||
| -rw-r--r-- | src/devices/machine/nvram.cpp | 2 | ||||
| -rw-r--r-- | src/devices/machine/z80sio.cpp | 2 |
5 files changed, 1 insertions, 9 deletions
diff --git a/src/devices/machine/68340sim.cpp b/src/devices/machine/68340sim.cpp index 65090696444..34ce985cc22 100644 --- a/src/devices/machine/68340sim.cpp +++ b/src/devices/machine/68340sim.cpp @@ -26,10 +26,8 @@ #ifdef _MSC_VER #define FUNCNAME __func__ -#define LLFORMAT "%I64d" #else #define FUNCNAME __PRETTY_FUNCTION__ -#define LLFORMAT "%lld" #endif #define m68340SIM_MCR (0x00) diff --git a/src/devices/machine/68561mpcc.cpp b/src/devices/machine/68561mpcc.cpp index 6c262a6f8c0..3f500827cdf 100644 --- a/src/devices/machine/68561mpcc.cpp +++ b/src/devices/machine/68561mpcc.cpp @@ -76,10 +76,8 @@ FEATURES #ifdef _MSC_VER #define FUNCNAME __func__ -#define LLFORMAT "%I64d" #else #define FUNCNAME __PRETTY_FUNCTION__ -#define LLFORMAT "%lld" #endif //************************************************************************** diff --git a/src/devices/machine/mc14411.cpp b/src/devices/machine/mc14411.cpp index 8a3101af0c7..c1c3a62fd78 100644 --- a/src/devices/machine/mc14411.cpp +++ b/src/devices/machine/mc14411.cpp @@ -46,10 +46,8 @@ #ifdef _MSC_VER #define FUNCNAME __func__ -#define LLFORMAT "%I64d" #else #define FUNCNAME __PRETTY_FUNCTION__ -#define LLFORMAT "%lld" #endif diff --git a/src/devices/machine/nvram.cpp b/src/devices/machine/nvram.cpp index f58c8c1de52..ff3f852e050 100644 --- a/src/devices/machine/nvram.cpp +++ b/src/devices/machine/nvram.cpp @@ -166,5 +166,5 @@ void nvram_device::determine_final_base() // if we are region-backed for the default, find it now and make sure it's the right size if (m_region.found() && m_region->bytes() != m_length) - throw emu_fatalerror("%s",string_format("NVRAM device '%s' has a default region, but it should be 0x%I64uX bytes", tag(), m_length).c_str()); + throw emu_fatalerror("%s",string_format("NVRAM device '%s' has a default region, but it should be 0x%X bytes", tag(), m_length).c_str()); } diff --git a/src/devices/machine/z80sio.cpp b/src/devices/machine/z80sio.cpp index 5538f8b7a5a..83a8479f638 100644 --- a/src/devices/machine/z80sio.cpp +++ b/src/devices/machine/z80sio.cpp @@ -84,10 +84,8 @@ #ifdef _MSC_VER #define FUNCNAME __func__ -#define LLFORMAT "%I64d" #else #define FUNCNAME __PRETTY_FUNCTION__ -#define LLFORMAT "%lld" #endif #define CHANA_TAG "cha" |
