diff options
author | 2019-11-15 05:11:51 +1100 | |
---|---|---|
committer | 2019-11-15 05:11:51 +1100 | |
commit | ce3c38914d4b710e2e40c212af0d61aa4b328de0 (patch) | |
tree | 9f68c3964399f72379e3f7c349c57e56756879ca /src/devices/machine/8530scc.h | |
parent | f7e679876fef04ee8d1f1ca5af6466423a265ae7 (diff) |
c64.cpp, c128.cpp: fixed CBM IEC slot address not being set when replacing devices in machine config
bus/c64/rex_ep256.cpp: fixed array of EPROM slots not being populated (subdevices don't exist at construction time)
cleanup: (nw)
* having a macro for a device's expected tag in a header is bad - devices should not make assumptions about their tag or their location in the system hierarchy
* device types exist in the global namespace - you must not use overly generic names for them as this is likely to cause collisions
* device short names and titles each have their own namespace, but they're also global, and it should be possible to work out vaguely what a device is from its names
* POSIX reserves all names ending in "_t" at global scope - we want fewer of these causing potential future issues, not more
* if your device is in the global namespace, you should name it in a way that's not asking for name collisions to happen
* we have a simple convention for device class names - it doesn't hurt to follow it:
- concrete device_t implementations end with "_device"
- device_interface implementations end with "_interface" (and often start with "device_")
- abstract classes that derive from device_t end with "_device_base"
* if you want to give your slot card device classes short, generic names, put them in a namespace for the "bus"
* if you really want to use names ending with "_t", put them in a namespace or nest them inside a class
Diffstat (limited to 'src/devices/machine/8530scc.h')
-rw-r--r-- | src/devices/machine/8530scc.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/devices/machine/8530scc.h b/src/devices/machine/8530scc.h index d0a41a6af96..4f7914f2a5d 100644 --- a/src/devices/machine/8530scc.h +++ b/src/devices/machine/8530scc.h @@ -11,7 +11,7 @@ #ifndef MAME_MACHINE_8530SCC_H #define MAME_MACHINE_8530SCC_H -class scc8530_t : public device_t +class scc8530_legacy_device : public device_t { public: enum IRQType_t { @@ -26,7 +26,7 @@ public: IRQ_B_EXT }; - scc8530_t(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock); + scc8530_legacy_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock); auto intrq_callback() { return intrq_cb.bind(); } @@ -98,6 +98,6 @@ private: MACROS ***************************************************************************/ -DECLARE_DEVICE_TYPE(SCC8530, scc8530_t) +DECLARE_DEVICE_TYPE(SCC8530, scc8530_legacy_device) #endif // MAME_MACHINE_8530SCC_H |