diff options
author | 2017-04-08 20:43:15 -0400 | |
---|---|---|
committer | 2017-04-10 20:47:40 -0400 | |
commit | afa6a83728be7339b7f9e76c719736665af611a2 (patch) | |
tree | b4d5c4abc6a41367736cbd57619165f10eeb4b61 /src/devices/bus/coleco/exp.h | |
parent | 5671a5eeab28af55588c0d0e722fd164a89e5f0c (diff) |
Changes to make get_default_card_software() less stupid
The goals with this change is to make get_default_card_software() a bit more standalone by making it a const method that does not mutate the state of the device_image_interface. This is done by passing in a small structure that encapsulates the minimum of information that get_default_card_software() needs.
This also eliminates the need for device_image_interface::open_image_file()
I agree with Sarayan that get_default_card_software() is terrible and needs to ultimately go away. This is a small step in that direction.
Lastly, I don't care for the name of get_default_card_software_hook (or get_default_card_software() for that matter). If anybody has better ideas, let me know.
Diffstat (limited to 'src/devices/bus/coleco/exp.h')
-rw-r--r-- | src/devices/bus/coleco/exp.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/devices/bus/coleco/exp.h b/src/devices/bus/coleco/exp.h index 7c19af119c2..2c9682381fc 100644 --- a/src/devices/bus/coleco/exp.h +++ b/src/devices/bus/coleco/exp.h @@ -90,7 +90,7 @@ protected: virtual const char *file_extensions() const override { return "rom,col,bin"; } // slot interface overrides - virtual std::string get_default_card_software() override; + virtual std::string get_default_card_software(get_default_card_software_hook &hook) const override; device_colecovision_cartridge_interface *m_card; }; |