summaryrefslogtreecommitdiffstatshomepage
path: root/src/osd/modules/debugger
Commit message (Collapse)AuthorAgeFilesLines
* Added save state window to debugger. Centralized unique/vector/pointer ↵ Aaron Giles2021-04-128-0/+151
| | | | unwrapping.
* srcclean in preparation for branching release Vas Crabb2021-02-211-2/+2
|
* add m68000 to debuger gdbstub nabetse2021-02-151-0/+29
|
* Eliminate ARRAY_LENGTH template in favor of C++17's std::size AJR2021-02-141-1/+1
| | | | | | | | | | * osdcomm.h: Move definition of EQUIVALENT_ARRAY to coretmpl.h * sharc.cpp, gt64xxx.cpp, ym2413.cpp, gb_lcd.cpp, snes_ppu.cpp: Use STRUCT_MEMBER for save state registration * gio/newport.cpp, megadrive/svp.cpp, nes_ctrl/bcbattle.cpp, arm7.cpp, tms9995.cpp, pckeybrd.cpp, sa1110.cpp, sa1111.cpp, jangou_blitter.cpp, vic4567.cpp: Use std::fill(_n) instead of memset * emucore.h: Remove obsolete typedef
* Debuger updates: Vas Crabb2021-01-306-77/+242
| | | | | * Improved behaviour of bottom line in Qt and win32 debugger views. * Ported memory tracking feature from Qt to win32 module.
* Bug fixes and usablility enhancements: Vas Crabb2021-01-291-29/+34
| | | | | | * Declare intent when requesting virtual memory (for NetBSD, 7712) * Improve scrolling behaviour in Qt debugger (MT07795) * Added prompts to input mapping menu to make it less intimidating
* -Qt debugger updates: Vas Crabb2021-01-2819-763/+739
| | | | | | | | * Added context menu with Copy Visible and Paste commands to debug views (partially addresses #6066). * Made memory view last PC display a context menu item. * Fixed crash on right-clicking a memory view showing something other than an address space. -debugger: Fixed commas in dumpkbd output.
* Goodbye 64 suffix on the main executable, it was nice knowing you. Vas Crabb2021-01-262-1/+23
| | | | | | If you want to build 64-bit and 32-bit in the same tree without them stomping on each other, use SEPARATE_BIN=1 (you already need to do this for TOOLS=1 anyway).
* win32 debugger: Added context menu with Copy Visible and Paste commands to ↵ Vas Crabb2021-01-262-30/+183
| | | | debug views (partially addresses #6066).
* Tidy up loose ends: Vas Crabb2021-01-061-4/+3
| | | | | | | | * Fixed a couple of fixed-size buffers in Windows OSD code. * Marked MAME as aware of long paths in Windows manifest. * Made a cleaner, thread-safe API for getting volume names. * Added compile-time option to disable recompiler W^X mode. * NuBus image device current directory doesn't need to be pinned.
* Further additions of std::string_view AJR2021-01-011-1/+1
| | | | | | | - corefile.cpp, fileio.cpp: Change puts to take a std::string_view parameter - rendlay.cpp: Use std::string_view instead of bare pointers in various functions - vecstream.h: Add std::string_view conversion operator to obtain output buffer without needing to make it a C string with explicit null termination - xmlfile.cpp: Add get_attribute_string_ptr method that distinguishes between empty strings and absent attributes without falling back to C strings
* Fairly significant overhaul of Lua engine and some cleanup. Vas Crabb2020-11-254-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The things that were previously called device iterators are not iterators in the C++ sense of the word. This is confusing for newcomers. These have been renamed to be device enumerators. Several Lua methods and properties that previously returned tables now return lightweight wrappers for the underlying objects. This means creating them is a lot faster, but you can't modify them, and the performance characteristics of different operations varies. The render manager's target list uses 1-based indexing to be more like idiomatic Lua. It's now possible to create a device enumerator on any device, and then get subdevices (or sibling devices) using a relative tag. Much more render/layout functionality has been exposed to Lua. Layout scripts now have access to the layout file and can directly set the state of an item with no bindings, or register callbacks to obtain state. Some things that were previously methods are now read-only properties. Layout files are no longer required to supply a "name". This was problematic because the same layout file could be loaded for multiple instances of the same device, and each instance of the layout file should use the correct inputs (and in the future outputs) for the device instance it's associated with. This should also fix video output with MSVC builds by avoiding delegates that return things that don't fit in a register.
* -Switch to building MAME as C++17. Vas Crabb2020-11-153-2/+3
| | | | | | | * Updated sol2 to 3.2.2 * Updated pugixml to 1.10 * Increased minimum clang version to 6 * Cleaned up some stuff that can use new features
* Add "n2a03" (6502 CPU clone) to gdbstub for NES, and swapped 6502 PC/SP to ↵ Lucien Murray-Pitts2020-11-071-1/+2
| | | | SP/PC (#7440)
* Add m6809 support for gdb remote debugger. Gustavo Del Dago2020-11-071-0/+21
|
* emu/debug: Removed more macros, added more const, make a couple more things ↵ Vas Crabb2020-10-121-1/+1
| | | | use smart pointers.
* Miscellaneous cleanup: Vas Crabb2020-10-101-1/+1
| | | | | * osd/windows: Use steady clock for timing double-clicks. * emu/uiinput.cpp: Made the event type a scoped enum.
* Got rid of global_alloc/global_free. Vas Crabb2020-10-036-14/+10
| | | | | | | | | | | | | | | | | | | | | | | | | The global_alloc/global_free functions have outlived their usefulness. They don't allow consistently overriding the default memory allocation behaviour because they aren't used consistently, and we don't have standard library allocator wrappers for them that we'd need to use them consistently with all the standard library containers we're using. If you need to change the default allocator behaviour, you can override the new/delete operators, and there are ways to get more fine-grained control that way. We're already doing that to pre-fill memory in debug builds. Code was already starting to depend on global_alloc/global_free wrapping new/delete. For example some parts of the code (including the UI and Windows debugger) was putting the result of global_alloc in a std::unique_ptr wrappers without custom deleters, and the SPU sound device was assuming it could use global_free to release memory allocated with operator new. There was also code misunderstanding the behaviour of global_alloc, for example the GROM port cartridge code was checking for nullptr when a failure will actually throw std::bad_alloc. As well as substituting new/delete, I've made several things use smart pointers to reduce the chance of leaks, and fixed a couple of leaks, too.
* -util/xmlfile: Escape attribute and element content. Vas Crabb2020-09-061-1/+1
| | | | | | | | | | | | | | | | | | | | The previous behaviour was unintuitive - parsing an XML file and writing it out immediately would produce invalid XML if the file contained any characters that needed escaping. It makes far more sense to escape on writing rather than expecting the user to escape input. -Add preliminary support for visibility toggles to artwork system. This allows the user to show/hide related elements in a view, with nesting. The view can specify whether elements are shown or hidden by default. Settings are saved per host window/screen per view. There is no way to set the initial visibility state on the command line. Legacy "Space Invaders cabinet model" layers are mapped onto visibility toggles. This is not stable yet. In particular, the XML element/attribute names have not been finalised. The new features have not been added to complay.py to prevent them from being used before they're finalised.
* Last memory change fixes (nw) Olivier Galibert2020-05-252-5/+6
|
* Debugger expression and memory access overhaul AJR2020-05-2519-115/+149
| | | | | | | | | | | | | - Memory references in expressions no longer default to the console's visible CPU if no device name was specified, except when entered through the console itself. Expressions in view windows now use the context of the currently selected device instead. - The pcatmem debug command and similar qt mouseover function now produce an error message if the initial address translation fails. Related internal changes (nw) - The debugger_cpu class no longer interprets memory accesses. The existing routines have been moved into symbol_table (which used to invoke them as callbacks), and reimplemented in most other places. Thecode duplication is a bit messy, but could be potentially improved in the future with new utility classes. - The cheat engine no longer needs to hook into the debugger_cpu class or instantiate a dummy instance of it. - The inclusion of debug/express.h within emu.h has been undone. Some debugging structures now need unique_ptr to wrap the resulting incomplete classes; hopefully the performance impact of this is negligible. Another direct consequence is that the breakpoint, watchpoint and registerpoint classes are no longer inside device_debug and have their own source file. - The breakpoint list is now a std::multimap, using the addresses as keys to hopefully expedite lookup. - The visible CPU pointer has been removed from the debugger_cpu class, being now considered a property of the console instead. - Many minor bits of code have been simplified.
* OS X debugger: Avoid crashing when a nonexistent disassembly or memory view ↵ AJR2020-04-202-9/+18
| | | | is selected (which may happen automatically with .cfg files)
* Revert "fixed some modernize-use-equals-default clang-tidy warnings (… (#6360) Oliver Stöneberg2020-04-086-6/+4
| | | | | | | * Revert "fixed some modernize-use-equals-default clang-tidy warnings (nw)" This reverts commit 54486ab9 * fixed merge error
* Hey Travis, go test that for me, thanks (nw) Olivier Galibert2020-03-312-0/+6
|
* Fix some deprecations (nw) Olivier Galibert2020-03-312-3/+3
|
* copy-paste error (nw) Vas Crabb2020-01-311-1/+1
|
* there are reasons for things being the way they were (nw) Vas Crabb2020-01-3120-13/+63
|
* fixed some modernize-use-auto clang-tidy warnings (nw) (#6238) Oliver Stöneberg2020-01-307-23/+23
|
* fixed some modernize-use-equals-default clang-tidy warnings (nw) (#6237) Oliver Stöneberg2020-01-3024-62/+14
|
* fixed some clang-tidy warnings (nw) (#6236) Oliver Stöneberg2020-01-302-15/+15
| | | | | | | | | | | | | | | | * fixed some modernize-redundant-void-arg clang-tidy warnings (nw) * fixed some modernize-use-bool-literals clang-tidy warnings (nw) * fixed some modernize-use-emplace clang-tidy warnings (nw) * fixed some performance-move-const-arg clang-tidy warnings (nw) * fixed some readability-redundant-control-flow clang-tidy warnings (nw) * fixed some readability-redundant-string-cstr clang-tidy warnings (nw) * fixed some performance-unnecessary-value-param clang-tidy warnings (nw)
* Merge pull request #6195 from firewave/includes R. Belmont2020-01-221-1/+1
|\ | | | | use C++ library includes (nw)
| * use C++ library includes (nw) firewave2020-01-221-1/+1
| |
* | fixed some clang-tidy warnings (nw) (#6197) Oliver Stöneberg2020-01-225-16/+16
|/ | | | | | | | | | | | | | * fixed some bugprone-throw-keyword-missing clang-tidy warnings (nw) * fixed some modernize-use-nullptr clang-tidy warnings (nw) * fixed some readability-delete-null-pointer clang-tidy warnings (nw) * fixed some performance-faster-string-find clang-tidy warnings (nw) * fixed some performance-for-range-copy clang-tidy warnings (nw) * fixed some readability-redundant-string-cstr clang-tidy warnings (nw)
* mac: fix copy/paste error, get rid of allocWithZone as it's ignored on ↵ Vas Crabb2019-11-184-8/+8
| | | | 64-bit ABI (nw)
* missed a couple of Mac debugger things (nw) Vas Crabb2019-11-182-28/+24
|
* missed one Windows debugger thing (nw) Vas Crabb2019-11-181-1/+1
|
* misc cleanup: Vas Crabb2019-11-1823-87/+106
| | | | | | | * Got rid of some more simple_list in core debugger code * Fixed a buffer overrun in wavwrite (buffer half requried size) * Slightly reduced dependencies and overhead in wavwrite * Made new disassembly windows in Qt debugger default to current CPU
* (nw) misc cleanup: Vas Crabb2019-10-111-3/+3
| | | | | * imagedev/cassette: add bitwise operators for cassette_state so a lot of ugly casts can go away * audio/leland.cpp, cubeqst.cpp: make better use of loops in machine configuration
* Make osd_printf_* use util/strformat semantics. Vas Crabb2019-09-261-2/+2
| | | | | | | | | | | | | | | | | (nw) This has been a long time coming but it's here at last. It should be easier now that logerror, popmessage and osd_printf_* behave like string_format and stream_format. Remember the differences from printf: * Any object with a stream out operator works with %s * %d, %i, %o, %x, %X, etc. work out the size by magic * No sign extending promotion to int for short/char * No widening/narrowing conversions for characters/strings * Same rules on all platforms, insulated from C runtime library * No format warnings from compiler * Assert in debug builds if number of arguments doesn't match format (nw) Also removed a pile of redundant c_str and string_format, and some workarounds for not being able to portably format 64-bit integers or long long.
* A few files that got missed (nw) arbee2019-09-151-0/+4
|
* Fix QT debugger (nw) AJR2019-09-101-3/+3
|
* Use std::forward_list for breakpoint and registerpoint lists (nw) AJR2019-09-108-88/+32
|
* gdbstub: more improvements (#5569) Ramiro Polla2019-08-311-29/+155
| | | | | | | | | | | | | | | | | | | | | | | | | * gdbstub: small cleanup and clarification Old GDBs expected the regnum values for some registers to be hardcoded. This is no longer the case with GDB clients that support target.xml. We expect the GDB client to support target.xml (and won't support the 'g', 'G', 'p', and 'P' commands unless it is sent). * gdbstub: add mips (tested with indy_4610) * gdbstub: add m68k (tested with macii) * gdbstub: add support for executing MAME debugger commands from the GDB client It's now possible to send MAME debugger commands, such as "cheatinit", "snap", etc... Try not to use "bpset" and such commands, they may confuse the GDB client. Also don't use commands such as "step" and "go", they will definitely confuse the GDB client. * gdbstub: fatalerror() when socket can't be opened
* srcclean (nw) Vas Crabb2019-08-251-23/+23
| | | | I'm assuming atronic.cpp was supposed to be Windows-1252 with Euro currency symbol encoding. Everyone please use UTF-8 for source files.
* debuggdbstub: uncomment parameters (nw) Patrick Mackinlay2019-08-151-3/+3
| | | | These unused parameters don't cause any warnings, so I suggest they shouldn't be commented; make the implementations match their declarations.
* gdbstub: add z80 and m6502 Ramiro Polla2019-08-121-0/+53
| | | | | | | | | | | | z80 was tested with pacman and m6502 was tested with apple2e. Side-effects must be disabled before reading memory, otherwise apple2e starts failing after the first read to 0xc080. Since GDB doesn't support those processors, I made up the features name with "mame.<cpuname>". I also had to choose the registers to export in the target.xml file, and since I don't have any experience with these processors I don't know if I made the best choice.
* gdbstub: added new GDB stub debugger (#5456) Ramiro Polla2019-08-111-0/+1133
| | | | | | | | | | | | * gdbstub: added new GDB stub debugger This debugger can be used to connect to an external debugger that communicates using the GDB Remote Serial Protocol, such as GDB itself or many other GDB frontends. Currently i386 (ct486), arm7 (gba), and ppc (pmac6100) are supported. * gdbstub: enable GDB stub debugger in mac and windows builds
* (nw) updated debug media menu to latest version Robbbert2019-07-132-13/+34
|
* (nw) windebug: fixed bug: in error-log window, Debug,New Memory Window would ↵ Robbbert2019-07-132-4/+2
| | | | clear the log.
* OS X debugger: Update window titles when restoring configuration for ↵ AJR2019-03-272-0/+2
| | | | disassembly and memory viewers