summaryrefslogtreecommitdiffstatshomepage
path: root/src/lib/util/delegate.h
Commit message (Collapse)AuthorAgeFilesLines
* Make devdelegate more like devcb for configuration. This is a Vas Crabb2019-10-261-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* (nw) So we're back to MSVC blowing up on non-trivial templates. Lovely. Vas Crabb2018-12-301-3/+10
| | | | | | | | Someone needs to get MS QA to put some non-trivial modern C++ compliation tests in the acceptance tests for their C++ compiler. Maybe MAME could even be a candidate. Well, that might be a plan if MS still had any QA. At least this makes some lines shorter (at the cost of needing more lines).
* Start cleaning up palette configuration: Vas Crabb2018-12-291-127/+113
| | | | | | | | | | * Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.
* Better support for screen orientation/geometry: Vas Crabb2018-07-261-5/+4
| | | | | | | | | | | | | | | | | | | | | * Eliminates the need for the horizontal/vertical/LCD/SVG layout files * Screens can now have orientation and physical aspect ratio specified * RASTER/VECTOR defaults to 4:3, LCD/SVG defaults to square pixels at config time * System orientation is applied on top of screen orientation Automatically generated single-screen views and orientation flags in XML output now work correctly for systems with multiple screens in different geometries/orientations, e.g. housemnq, rocnms, stepstag, or netmerc. The "core rotation options" only interact with system orientation. Allowing multi-screen systems to work well with one monitor per emulated screen is a complex topic. System orientation also affects the GFX viewer while screen orientation doesn't. The orientation displayed in the system selection menu is from the system orientation. Let me know if I've broken any systems or use cases. Also, add save state support for std::array/C array nested to any depth.
* delegates: Don't crash on late binding if no object is actually needed [O. ↵ Olivier Galibert2016-12-091-1/+1
| | | | | | Galibert] pci9050: Fix the mappings [O. Galibert]
* srcclean (nw) Vas Crabb2016-11-271-3/+3
|
* A round of spelling/typographical fixes to source comments (nw) Scott Stone2016-11-241-1/+1
|
* delegate fix - lambda always have object (nw) Miodrag Milanovic2016-11-081-1/+1
|
* Do not use FUNC in delegate where applicable (nw) Miodrag Milanovic2016-11-061-27/+12
|
* try to make GCC 5.4.0 happy (nw) Miodrag Milanovic2016-11-051-1/+1
|
* Delegate support for lambdas and std::functions in general, also supporting ↵ Miodrag Milanovic2016-11-051-35/+80
| | | | const members now [Miodrag Milanovic]
* Various cleanups suggested by static analyzer (nw) Miodrag Milanovic2016-04-241-1/+1
|
* Add includes for dependency documentation. There is still inconsistent couriersud2016-04-081-1/+1
| | | | | use of assert(...) in src/lib/util. libutil compile will use assert from <assert> while other parts of mame will be compiled with assert from emucore.h.
* Enable the internal delegates for Emscripten too (nw) Justin Kerk2016-03-201-2/+0
|
* Updated delegates, now works on ARM and ARM64 (nw) Miodrag Milanovic2016-03-131-493/+37
|
* updated checks since old versions are anyway not supported (nw) Miodrag Milanovic2015-12-091-3/+2
|
* clang-modernize part 1 (nw) Miodrag Milanovic2015-12-031-18/+18
|
* Cleanups and version bumpmame0168 Miodrag Milanovic2015-11-251-4/+4
|
* Made fast delegates work on VS x64 builds (nw) Miodrag Milanovic2015-11-221-0/+63
|
* as req? (nw) David Haywood2015-11-041-1/+1
|
* made 32 bit mingw-clang build working Miodrag Milanovic2015-11-041-0/+2
|
* Cleanups and version bumpmame0163 Miodrag Milanovic2015-06-241-2/+1
|
* delegate.h now supports mingw 32 bit builds with INTERNAL configuration. couriersud2015-05-311-16/+60
| | | | Member functions are called in this case using __thiscall ABI. [Couriersud]
* get rid of some obsolete/unreachable stuff, get rid of more abuse of ↵ Vas Crabb2015-04-021-3/+3
| | | | SDLMAME_ macros outside OSD
* removed last assert.h occurance in a header (nw) Oliver Stöneberg2015-03-201-1/+0
|
* Fix crashing on ARM Linux targets. [R. Belmont, rjosal] arbee2015-03-041-0/+2
|
* Moved eminline and related files into /src/osd since it's system related (nw) Miodrag Milanovic2014-04-161-0/+943
Moved delegates into /src/lib/util to enable usage of delegates in other project parts Moved mame_printf_* calls into /src/osd/osdcore.c and renamed them to osd_printf_* Changed mess.mak to display compilation of ymmu100.ppm nicely