| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
* sony_news.xml: Added proper compatibility flags for different
generations.
* cpu/pic16x8x: This is very much a derivative work.
* cpu/tms32025.cpp: Allow stack push/pop to be inlined.
* tecmo/bombjack.cpp: Avoid needing to remove and replace devices in
machine configuration.
* Various other cleanup.
|
| | |
|
| |
|
|
|
|
|
| |
printf/logerror. (#12124)
* Use %s to read NUL-terminated strings from emulated memory. Precision sets maximum length.
* Also added left-justification option for numeric and string formats.
* Made documentation more consistent and removed duplication.
|
| |
|
|
|
|
|
|
|
| |
[Patrick Mackinlay]
Also simplified implementation by better leveraging util/strformat.h.
This is from pull request #12124, to get some testing for the
fundamental change before freeze.
|
| |
|
|
| |
Belmont]
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restores ability to give specific/detailed messages removed in
6f7e4141ea14acaaf9cb973c66788fabb3457023 while pandering to obsession
with single return value.
Moved responsibility for displaying the error message in the UI to the
caller rather than device_image_interface, and made
device_image_interface always log the error along with the full path and
error condition content.
Gave several image devices more detailed error messages. Added some
FIXME comments for apparent bugs.
|
| |
|
|
|
| |
- Add names of physical and logical spaces now that one space can map to another
- Correct usage of address space masks
|
| |
|
|
|
|
|
|
|
| |
- Remove the seterror method for recording error messages and conditions. Condition codes have been made return values for call_load, call_create and various related callbacks. Error messages (which many devices weren't generating) are now displayed through osd_printf_error.
- Eliminate the image_init_result and image_verify_result pass/fail enumeration types. Update many functions that were returning these enumerations or simply bools to return std::error_condition instead. In some cases, this type is now passed down from internal parsing/loading functions which were already returning it. In various other cases, the former default UNSPECIFIED has been used as a catchall for I/O errors; anticipated future refactorings should make these error returns more specific.
- Expand the image_error categories to include INVALIDLENGTH, NOSOFTWARE and BADSOFTWARE. The first is largely self-explanatory. The second is generated by the core to indicate failure to find software items in lists. The third is provided for devices to indicate semantic errors in software list entries.
- Change the return type of floppy_image_device::identify to a pair so the potential error condition can be passed along to the UI without storing it in a member variable.
- Move device_image_interface::message down into snapshot_image_device and change its implementation to use string_format instead of printf.
- Correct a typo in the shortname of the generic snapshot device.
|
| |
|
|
| |
of memory when jumping around large address spaces
|
| |
|
|
| |
divtlb: Wrap the constants
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 922d5b3c81459173ce99970dca0e44825f0a4494.
This broke an important use case with MIPS3 address comparisons no
longer behaving intutively.
It's also another case of a debugger change that wasn't followed through
properly, with absolutely no attempt to update the internal debugger
help or the documentation for the web site.
I realise signed maths woud be a useful feature, for the debugger, but
it needs to be done in a way that doesn't break important use cases.
|
| |
|
|
|
|
|
| |
- Perform signed calculations for /, %, >>, /=, %=, >>=, <, >, <=, >= operators in debugger expressions
- Eliminate workarounds in debugger printf method for system printf not reliably handling 64-bit integers (a previous refactoring adopted strformat for this)
- Output signed decimals for %d in debugger printf formats; also add %u format
- Add two-argument sext function to debugger
|
| | |
|
| |
|
|
| |
d8d588262de1f11a529b208e470cff9b89a4cba6, including use-after-move issue
|
| |
|
|
|
|
|
| |
- Added exception points as a new class of "points" triggering on specific exception numbers, with a similar set of commands to breakpoints and registerpoints.
- Removed the per-instruction callback hook from device_debug. Only one driver was using this (rmnimbus.cpp), and what it was doing with it could be done more cleanly with exception points.
- Change the type of the action string parameter for "points"-creating methods and make some parameters optional for those.
- Change trace file logging to use a std::ostream instead of FILE * to take better advantage of strformat.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MSVC isn't smart enough to detect that these can only be used after
being assigned while clang and GCC can work it out fine. Initialising
them to zero at declaration has the potential to mask real bugs if some
code path tries to use them without assigning them. Code flow analysis
(e.g. Coverity) or memory analysers (e.g. valgrind or Purify) won't pick
up on the buggy path because the variable will technically be
initialised.
MSVC is problematic when it comes to warnings about uninitialised
variables in general. Unfortunately MSVC has no option to selectively
treat warnings as errors, unlike clang/GCC which have -Wno-error= which
we use extensively. Until Microsoft addresses these issues, you'll have
to use NOWERROR=1 when building with MSVC.
Also, some cleanup.
|
| |
|
|
| |
std::string to std::string_view
|
| |
|
|
| |
command to prevent denial of service
|
| | |
|
| |
|
|
|
|
|
|
| |
- Add 'gbt' and 'gbf' debugger commands to step until a true or false conditional branch has been detected.
- Update over 100 of the disassemblers in MAME to output a new STEP_COND flag for all conditional branches. Besides being used for execution of the new 'gbt' and 'gbf' commands, this flag also now helps the debugger 'out' command to properly handle conditional return instructions.
- Remove STEP_OVER from many instructions that aren't actually subroutine calls (e.g. DJNZ on Z80). A 'gni' debugger command (go next instruction) has been added to accommodate some of the misuse.
- Add instruction flag support to several more disassemblers that lacked them entirely (e.g. st62xx)
- Don't pass over delay slots for debugging in ASAP core
|
| |
|
|
|
|
|
| |
Also made error messages for missing CHDs and missing files for software
parts using the image file loader show search paths, and changed the
(poorly named) bitbanger device to use the image file loader rather than
the ROM loader for software items.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
- Undo inclusion of screen.h within render.h and update many source files that were stealth-including the former
- Move texture_format enum to rendertypes.h
- rendlay.h: Make a few methods static
- ui/info.cpp: Use C++11-style iteration for render targets
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
debugger: Octal cheats for octal address spaces.
frontend: Pass events for automatically generated menu items to the
plugin - they will have index zero.
frontend: Don't try calling the data plugin from the main menu if the
system isn't starting yet - doing so will prevent the data plugin from
loading at all.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updated cheat commands to work with arbitrary devices and address
spaces. You can still only search RAM areas in a single address space
at a time, but any address space of any device can be used now.
* Made the cheatinit/cheatrange commands not affect current state if the
arguments are invalid. Also fixed some bugs in the cheat commands.
* Updated documentation for cheat commands, and added a simple worked
example. Also added single-sentence descriptions of what
(break|watch|register)points are to the top of the relevant pages.
-frontend improvements:
* Added a bit more info to the about box, moved the VCS revision to the
heading.
* Don't show "not" codes in prompts - they're not helpful.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the default mapping for UI select to not trigger on Alt+Enter
fullscreen toggle. (Fullscreen toggle still doesn't work in menus -
actually fixing that is complicated.)
frontend: Made the about box wrap text properly, made the title and
backtrack menu item always visible, and added a footer with the VCS
revision.
frontend: Don't highlight the favourites and info toolbar buttons if
there's no selection (can happen if filters produce no results). Also
made the info viewer appear even if no info is available - it's less
confusing to see an empty menu than wonder why clicking the button does
nothing.
debugger: Added a register points view to the GUI debuggers, to go with
the breakpoints and watchpoints views.
debugger: Extended [brw]p(clear|(en|dis)able) commands to accept
multiple arguments to perform the same action on multiple
(break|watch|register)points at once. Also made rplist accept a CPU for
showing a single CPU's register points ([bw]plist already support this).
docs: Updated registerpoints debugger commands page, and updated other
pages for latest extensions to syntax.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
frontend: Made it possible to cancel a media audit while it's in
progress. Also made the media audit multi-threaded so it's faster.
frontend: Made the DIP switches in the DIP switch preview clickable.
frontend: Made the system and software selection menus leave focus on
the same system when clearing the search rather than jumping to the
first item. Also fixed a couple of bugs in the logic for keeping the
selected item visible.
frontend: Fixed a few places that weren't showing localised system
names.
frontend: Made UI Cancel clear a search in the file manager the same way
it does on the system and sofware selection menus.
frontend: Made it possible for plugin menus to handle UI Cancel more
naturally, backing up to the previous plugin menu rather than dropping
straight back to the list of plugins. Updated the autofire, cheat and
cheatfind plugins, and fixed a few other issues in the cheatfind plugin.
debugger: Made the mount and unmount commands accept instance names as
well as brief instance names. Also updated another page of debugger
documentation.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
frontend: Allow clicking the adjuster arrows on menu items. This allows
things like video options and DIP switches to be configured using a
mouse only. Also fixed a bug preventing paging menus with a mouse if
the first item scrolled off the bottom is not selectable.
debugger: Allow wplist and bplist to accept a CPU argument to list
breakpoints/watchpoints for a single CPU only.
debugger: Fixed some corner cases in address space syntax in memory
accesses, and allowed memory region accesses to use tags relative to the
visible CPU.
emu/softlist.cpp: Ignore notes elements when loading software lists.
It's effectively a comment that isn't a comment syntactically, it's
being used for things that are not useful to display in the internal UI,
and it slows down startup.
docs: Updated three more pages of debugger documentation. Also updated
more of the built-in debugger help.
minimaws: Fixed up schema for software list notes, made sofware list
notes display initially collapsed.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extended the memory access prefixes in debugger expressions to support
address space names.
Made the debugger history command aware of how much history it has
collected, and added a help topic for it to the built-in debugger help.
Started updating the documentation for the web site, and corrected some
of the more misleading built-in debugger help.
Made some corrections to Chinese localisation after discussion with
YuiFAN.
Darkened the UI red colour a little.
cpu/m6502/st2205u.h: Marked sound imperfect.
|
| |
|
|
| |
360d3a5950f0649270822e2db1ea25028eabd18b)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(#8630)
Added a validity check to ensure address space names are tag-like and unique, since they're now used as identifiers in debugger commands.
Extended the syntax for target addresses to allow them to be qualified with a colon followed by an optional device tag and/or address space name. If only the device needs to be specified, a debugger CPU number may also be used. This makes commands like bpset and wpset more flexible, as they can operate on CPUs other than the currently visible CPU. Commands like find, fill, dump and load are more flexible as they can access any space of any device.
Removed now-redundant CPU parameters from many commands, and renamed pcatmemp to pcatmem for consistency with other commands. Extended region syntax for saver/loadr to support tags relative to the visible CPU (e.g. you can use "." for the region with the same name as the visible CPU, or "^sibling" syntax). Added an optional root device parameter to memdump. Changed interpretation of Boolean values to support numeric expressions as well as true/false strings and literal 1/0.
Added checks that the specified device is CPU-like to various commands that require a CPU (e.g. focus). Previously these commands would crash or trigger an assertion failure if a tag for a non-CPU devices was specified.
Fixed the cpunum symbol so it uses the same rules for determining what is or isn't a CPU as parameter parsing.
Made device_t sanitise subtags better. Previously you could cause an assertion failure or crash MAME by giving it unexpected relative tags via Lua or the debugger.
Added help topic alias support, and reworked the data structures to improve the performance of looking up debugger commands and help topics. Removed the "ref" parameter from debugger command functions (std::bind can hold extra argument values for you if you need them). Also added an error message if duplicate debugger commands are registered.
Updated help for commands that changed syntax, and also updated summaries for some commands that had changed in the past without corresponding help updates.
|
| |
|
|
|
|
|
|
|
| |
Added more modern generic I/O interfaces with implementation backed by stdio, osd_file and core_file, replacing io_generic. Also replaced core_file's build-in zlib compression with a filter.
unzip.cpp, un7z.cpp: Added option to supply abstract I/O interface rather than filename.
Converted osd_file, core_file, archive_file, chd_file and device_image_interface to use std::error_condition rather than their own error enums.
Allow mounting TI-99 RPK from inside archives.
|
| |
|
|
|
|
|
|
|
| |
prefixing the index or name with a # and passing as the first parameter. [smf]"
This reverts commit f4213dc209ebf2247f3c7e46f32d9bd2711bb374.
The issue that the syntax used for this clashes with syntax for decimal
numbers was never resolved.
|
| |
|
|
|
|
|
|
| |
- Remove the hotspot read tracker. This was never robustly implemented, but changes to the memory system made it much less useful, and the "speedup opportunities" which it aimed to determine are not very important from a current emulation standpoint.
- Remove the CURSP/GENSP state symbol and the generic sp() getter. Stacking semantics vary too much between CPU architectures for this to be of much use. (A "SP" symbol has been added to a few CPU cores whose stack pointers were otherwise not being registered.)
- Remove the cached pointer to device_state_interface and the state() fast accessor from device_t. Most users of device_state_interface either already had a pointer to the specific CPU device type or needed to check first for the presence of the interface.
- Change the PC memory write tracker to use pcbase(), which works even when the instruction callback is masked out, instead of peeking at the PC history index.
- Remove some obsolete watchpoint-related definitions from machine.h.
|
| |
|
|
| |
the index or name with a # and passing as the first parameter. [smf]
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
* osdcomm.h: Move definition of EQUIVALENT_ARRAY to coretmpl.h
* sharc.cpp, gt64xxx.cpp, ym2413.cpp, gb_lcd.cpp, snes_ppu.cpp: Use STRUCT_MEMBER for save state registration
* gio/newport.cpp, megadrive/svp.cpp, nes_ctrl/bcbattle.cpp, arm7.cpp, tms9995.cpp, pckeybrd.cpp, sa1110.cpp, sa1111.cpp, jangou_blitter.cpp, vic4567.cpp: Use std::fill(_n) instead of memset
* emucore.h: Remove obsolete typedef
|
| |
|
|
|
|
|
| |
them. Case insensitivity has been preserved for command names, CPU and region tags and certain symbolic parameters (as well as expressions, which were treated as case-insensitive in other contexts), but filenames and character constants are no longer automatically lowercased.
* debugcmd.cpp, debugcon.cpp: Remove some superfluous c_str() calls
* debugcmd.cpp: Remove local member referencing debugger_cpu, which is accessed only rarely since the console now tracks the visible CPU
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove corestr.h from emu.h; update a few source files to not use it at all
- Change strtrimspace, strtrimrightspace and core_filename_extract_* to be pure functions taking a std::string_view by value and returning the same type
- Change strmakeupper and strmakelower to be pure functions taking a std::string_view and constructing a std::string
- Remove the string-modifying version of zippath_parent
- Change tag-based lookup functions in device_t to take std::string_view instead of const std::string & or const char *
- Remove the subdevice tag cache from device_t (since device finders are now recommended) and replace it with a map covering directly owned subdevices only
- Move the working directory setup method out of device_image_interface (only the UI seems to actually use the full version of this)
- Change output_manager to use std::string_view for output name arguments
- Change core_options to accept std::string_view for most name and value arguments (return values are still C strings for now)
- Change miscellaneous other functions to accept std::string_view arguments
- Remove a few string accessor macros from romload.h
- Remove many unnecessary c_str() calls from logging/error messages
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The things that were previously called device iterators are not
iterators in the C++ sense of the word. This is confusing for
newcomers. These have been renamed to be device enumerators.
Several Lua methods and properties that previously returned tables now
return lightweight wrappers for the underlying objects. This means
creating them is a lot faster, but you can't modify them, and the
performance characteristics of different operations varies.
The render manager's target list uses 1-based indexing to be more like
idiomatic Lua.
It's now possible to create a device enumerator on any device, and then
get subdevices (or sibling devices) using a relative tag.
Much more render/layout functionality has been exposed to Lua. Layout
scripts now have access to the layout file and can directly set the
state of an item with no bindings, or register callbacks to obtain
state. Some things that were previously methods are now read-only
properties.
Layout files are no longer required to supply a "name". This was
problematic because the same layout file could be loaded for multiple
instances of the same device, and each instance of the layout file
should use the correct inputs (and in the future outputs) for the device
instance it's associated with.
This should also fix video output with MSVC builds by avoiding delegates
that return things that don't fit in a register.
|
| |
|
|
| |
memory map system. [O. Galibert]
|
| | |
|
| |
|
|
|
|
| |
-emu/rendlay.cpp: Made real component drawing code a bit less gross.
-emu/debugcon.cpp: Less screaming now that things aren't macros.
|
| |
|
|
| |
use smart pointers.
|
| | |
|