summaryrefslogtreecommitdiffstatshomepage
path: root/src/emu/cpu/i86/i286.c
Commit message (Collapse)AuthorAgeFilesLines
* Since nobody checks for NULLs anyway, make Aaron Giles2012-09-191-2/+2
| | | | | | | | | | | | device_memory_interface::space() assert against NULL and return a reference, and pushed references throughout all address space usage in the system. Added a has_space() method to check for those rare case when it is ambiguous. [Aaron Giles] Also reinstated the generic space and added fatal error handlers if anyone tries to actually read/write from it.
* Clean-ups and version bumpmame0147 Miodrag Milanovic2012-09-171-1/+1
| | | note: hoarded dump removed too from coco_cart.xml, this will not be tolerated
* Enum and union normalization. Aaron Giles2012-09-161-2/+2
|
* First pass at modernizing struct definitions. Aaron Giles2012-09-151-2/+1
|
* DEVINFO_* to CPU_INFO_*, and some cleanups (no whatsnew) Miodrag Milanovic2012-09-031-15/+15
|
* Fix for i286 preventing error 104 on ibm5170 [Carl] Miodrag Milanovic2012-05-121-0/+2
|
* Renamed device_irq_callback to device_irq_acknowledge_callback to Aaron Giles2012-04-101-1/+1
| | | | | | | | make its purpose clearer. Added delegate support for interrupt callbacks, and made driver_device variants of the generic interrupt helper callbacks. Did not convert existing callers yet due to logistical issues.
* i286 - fix for OS/2 "interrupts disabled when entering system" problem by ↵ Miodrag Milanovic2011-06-211-1/+2
| | | | Carl (no whatsnew)
* i286 - More protected mode fixes by Carl (no whatsnew) Miodrag Milanovic2011-05-181-2/+5
|
* i286 - Added 286 LOADALL and triple fault resets. [Carl] Miodrag Milanovic2011-05-171-35/+49
| | | | | i286 - Added support for 16-bit protected mode far calls and segment privilege checks. [Carl] i86 - Fixed shift instructions, helps detecting proper CPU [Miodrag Milanovic] i86 - Fixed handling of invalid instructions in 0x60-0x6f section [Miodrag Milanovic]
* Collapsed device_config and device_t into one class. Updated all Aaron Giles2011-04-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | existing modern devices and the legacy wrappers to work in this environment. This in general greatly simplifies writing a modern device. [Aaron Giles] General notes: * some more cleanup probably needs to happen behind this change, but I needed to get it in before the next device modernization or import from MESS :) * new template function device_creator which automatically defines the static function that creates the device; use this instead of creating a static_alloc_device_config function * added device_stop() method which is called at around the time the previous device_t's destructor was called; if you auto_free anything, do it here because the machine is gone when the destructor is called * changed the static_set_* calls to pass a device_t & instead of a device_config * * for many devices, the static config structure member names over- lapped the device's names for devcb_* functions; in these cases the members in the interface were renamed to have a _cb suffix * changed the driver_enumerator to only cache 100 machine_configs because caching them all took a ton of memory; fortunately this implementation detail is completely hidden behind the driver_enumerator interface * got rid of the macros for creating derived classes; doing it manually is now clean enough that it isn't worth hiding the details in a macro
* Created new enum type address_spacenum for specifying an address Aaron Giles2011-03-271-9/+9
| | | | | | | | | | | | space by index. Update functions and methods that accepted an address space index to take an address_spacenum instead. Note that this means you can't use a raw integer in ADDRESS_SPACE macros, so instead of 0 use the enumerated AS_0. Standardized the project on the shortened constants AS_* over the older ADDRESS_SPACE_*. Removed the latter to prevent confusion. Also centralized the location of these definitions to memory.h.
* Get rid of state_save_register_device_* macros in favor of direct Aaron Giles2011-02-091-35/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | calls on the device object. Regex used: state_save_register_device_item( *)\(( *)([^,]+), *([^,]+),( *)([^ )]+)( *)\) \3->save_item\1\(\2NAME\(\6\),\5\4\7\) state_save_register_device_item_array( *)\(( *)([^,]+), *([^,]+),( *)([^ )]+)( *)\) \3->save_item\1\(\2NAME\(\6\),\5\4\7\) state_save_register_device_item_2d_array( *)\(( *)([^,]+), *([^,]+),( *)([^ )]+)( *)\) \3->save_item\1\(\2NAME\(\6\),\5\4\7\) state_save_register_device_item_bitmap( *)\(( *)([^,]+), *([^,]+),( *)([^ )]+)( *)\) \3->save_item\1\(\2NAME\(\*\6\),\5\4\7\) state_save_register_device_item_pointer( *)\(( *)([^,]+), *([^,]+),( *)([^,]+), *([^ )]+)( *)\) \3->save_pointer\1\(\2NAME\(\6\),\5\7,\5\4\8\) this->save_ save_ (save_item[^;]+), *0( *)\); \1\2\); (save_pointer[^;]+), *0( *)\); \1\2\);
* running_device -> device_t Aaron Giles2010-12-311-1/+1
| | | | | They both already existed. No sense in having two names for the same object type.
* 04147: raiden: crashes if you use -debug switch [Alex Jackson] Phil Bennett2010-12-221-2/+2
| | | | | | | | | | | | | | | | ---------- Forwarded message ---------- From: Alex Jackson <awj_in_japan@hotmail.com> Date: Mon, Dec 20, 2010 at 3:37 AM Subject: MT bug 04147 fix; trivial debugger fix To: submit@mamedev.org i86length.diff fixes MT bug 04147: raiden: crashes if you use -debug switch. My patch makes the i386 and nec disassemblers enforce the same maximum instruction length as CPUINFO_INT_MAX_INSTRUCTION_BYTES (previously the disassemblers always enforced a maximum length of 15 bytes, but the value of CPUINFO_INT_MAX_INSTRUCTION_BYTES varied between CPUs... this was my fault, sorry) The maximum legal instruction length on the 80286 is 10 bytes, and on the 80386 and all later Intel and clone CPUs it's 15 bytes. Exceeding the limit causes an illegal instruction exception. Intel CPUs prior to the 80286, and NEC-V CPUs, don't enforce a maximum instruction length (they don't even have an "illegal instruction" exception), but the longest possible instruction without redundant prefixes is 8 bytes on both, so I've made that the maximum instruction length for disassembly purposes. debugger.diff fixes a trivial bug in the debugger dump commands. 0x7f is not a printable character in either ASCII or UTF-8... so don't print it in the "ASCII" column when hex dumping. --AWJ
* i286.c: Partially implemented protected mode. Fixed verw, verr, lar, lsl, ↵ Wilbert Pol2010-10-311-3/+11
| | | | and arpl instructions. [Wilbert Pol]
* i286.c: Moved call of i80286_urinit to CPU_INIT. Fixed display of PC in the ↵ Wilbert Pol2010-10-281-9/+3
| | | | debugger. [Wilbert Pol]
* Added mask-free versions of read_word/read_dword/read_qword to Aaron Giles2010-08-211-4/+2
| | | | | | | | | | | | address_space. Also added unaligned variants that can read unaligned values. Rewrote the core handler as a template that handles all cases, along with a simple unit test to verify that everything is correct. Updated 68k, v60, i86, and nec cores to use unaligned read/ write instead of their own stubs for handling misalinged reads. Fixed memory management of ga2 decryption.
* Fix for i286 regression (no whatsnew) Miodrag Milanovic2010-08-201-0/+1
|
* Remove final set of legacy inlines from memory.h. Mostly affects CPU Aaron Giles2010-08-191-0/+1
| | | | | cores, which all now cache a copy of space->direct() and use it for direct accesses.
* Replace "const address_space" with "address_space" throughout the system. Aaron Giles2010-08-191-2/+2
| | | | | | | | | | | The purpose of making it const before was to discourage direct tampering, but private/protected does a better job of that now anyhow, and it is annoying now. s/const[ \t]+address_space\b/address_space/g; Is basically what I did.
* Created CPU-specific device types for all CPUs, using new macros Aaron Giles2010-07-031-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | DECLARE_LEGACY_CPU_DEVICE and DEFINE_LEGACY_CPU_DEVICE. Changed CPUs to be their own device types, rather than all of type CPU with a special internal subtype. Note that as part of this process I removed the CPU_ prefix from the ALL-CAPS device name, so CPU_Z80 is just plain old Z80 now. This required changing a couple of names like 8080 to I8080 so that there was an alphabetic first character. Added memory interfaces to the list of fast-access interfaces. To do this properly I had to add a separate method to devices which is called immediately after construction, when it is possible to perform dynamic_casts on fully-constructed objects. (This is just internal, no changes necessary to the devices themselves.) Some additional notes: * SH2 and SH4 had typedefs that conflicted with their CPU_-less names so I bulk renamed to structures to sh2_state and sh4_state; RB, feel free to choose alternate names if you don't like 'em * SCSP was caught doing something to the 3rd indexed CPU. Since several systems that use SCSP don't even have 3 CPUs, I had no idea what this was supposed to do, so I changed to it reference "audiocpu" assuming that stv was the assumed target. This is really gross and should be a configuration parameter, not a hard-coded assumption.
* Change cpu_device into a base class. Rename old cpu_device to legacy_cpu_device. Aaron Giles2010-06-171-2/+2
| | | | Update interfaces as appropriate.
* Change cpu execute function to just use the icount stuffed by Aaron Giles2010-06-091-4/+4
| | | | | the scheduler, rather than manging an incoming cycle count. It was confusing to have multiple sources of cycle counts.
* Changed CPU callbacks to use cpu_device, eliminating a bunch of casting. Aaron Giles2010-06-081-4/+4
|
* WARNING: There are likely to be regressions in both functionality and Aaron Giles2010-06-081-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | performance as a result of this change. Do not panic; report issues to the list in the short term and I will look into them. There are probably also some details I forgot to mention. Please ask questions if anything is not clear. NOTE: This is a major internal change to the way devices are handled in MAME. There is a small impact on drivers, but the bulk of the changes are to the devices themselves. Full documentation on the new device handling is in progress at http://mamedev.org/devwiki/index.php/MAME_Device_Basics Defined two new casting helpers: [Aaron Giles] downcast<type>(value) should be used for safe and efficient downcasting from a base class to a derived class. It wraps static_cast<> by adding an assert that a matching dynamic_cast<> returns the same result in debug builds. crosscast<type>(value) should be used for safe casting from one type to another in multiple inheritance scenarios. It compiles to a dynamic_cast<> plus an assert on the result. Since it does not optimize down to static_cast<>, you should prefer downcast<> over crosscast<> when you can. Redefined running_device to be a proper C++ class (now called device_t). Same for device_config (still called device_config). All devices and device_configs must now be derived from these base classes. This means each device type now has a pair of its own unique classes that describe the device. Drivers are encouraged to use the specific device types instead of the generic running_device or device_t classes. Drivers that have a state class defined in their header file are encouraged to use initializers off the constructor to locate devices. [Aaron Giles] Removed the following fields from the device and device configuration classes as they never were necessary or provided any use: device class, device family, source file, version, credits. [Aaron Giles] Added templatized variant of machine->device() which performs a downcast as part of the device fetch. Thus machine->device<timer_device>("timer") will locate a device named "timer", downcast it to a timer_device, and assert if the downcast fails. [Aaron Giles] Removed most publically accessible members of running_device/device_t in favor of inline accessor functions. The only remaining public member is machine. Thus all references to device->type are now device->type(), etc. [Aaron Giles] Created a number of device interface classes which are designed to be mix- ins for the device classes, providing specific extended functionality and information. There are standard interface classes for sound, execution, state, nvram, memory, and disassembly. Devices can opt into 0 or more of these classes. [Aaron Giles] Converted the classic CPU device to a standard device that uses the execution, state, memory, and disassembly interfaces. Used this new class (cpu_device) to implement the existing CPU device interface. In the future it will be possible to convert each CPU core to its own device type, but for now they are still all CPU devices with a cpu_type() that specifies exactly which kind of CPU. [Aaron Giles] Created a new header devlegcy.h which wraps the old device interface using some special template classes. To use these with an existing device, simply remove from the device header the DEVICE_GET_INFO() declaration and the #define mapping the ALL_CAPS name to the DEVICE_GET_INFO. In their place #include "devlegcy.h" and use the DECLARE_LEGACY_DEVICE() macro. In addition, there is a DECLARE_LEGACY_SOUND_DEVICE() macro for wrapping existing sound devices into new-style devices, and a DECLARE_LEGACY_NVRAM_DEVICE() for wrapping NVRAM devices. Also moved the token and inline_config members to the legacy device class, as these are not used in modern devices. [Aaron Giles] Converted the standard base devices (VIDEO_SCREEN, SPEAKER, and TIMER) from legacy devices to the new C++ style. Also renamed VIDEO_SCREEN to simply SCREEN. The various global functions that were previously used to access information or modify the state of these devices are now replaced by methods on the device classes. Specifically: video_screen_configure() == screen->configure() video_screen_set_visarea() == screen->set_visible_area() video_screen_update_partial() == screen->update_partial() video_screen_update_now() == screen->update_now() video_screen_get_vpos() == screen->vpos() video_screen_get_hpos() == screen->hpos() video_screen_get_vblank() == screen->vblank() video_screen_get_hblank() == screen->hblank() video_screen_get_width() == screen->width() video_screen_get_height() == screen->height() video_screen_get_visible_area() == screen->visible_area() video_screen_get_time_until_pos() == screen->time_until_pos() video_screen_get_time_until_vblank_start() == screen->time_until_vblank_start() video_screen_get_time_until_vblank_end() == screen->time_until_vblank_end() video_screen_get_time_until_update() == screen->time_until_update() video_screen_get_scan_period() == screen->scan_period() video_screen_get_frame_period() == screen->frame_period() video_screen_get_frame_number() == screen->frame_number() timer_device_adjust_oneshot() == timer->adjust() timer_device_adjust_periodic() == timer->adjust() timer_device_reset() == timer->reset() timer_device_enable() == timer->enable() timer_device_enabled() == timer->enabled() timer_device_get_param() == timer->param() timer_device_set_param() == timer->set_param() timer_device_get_ptr() == timer->get_ptr() timer_device_set_ptr() == timer->set_ptr() timer_device_timeelapsed() == timer->time_elapsed() timer_device_timeleft() == timer->time_left() timer_device_starttime() == timer->start_time() timer_device_firetime() == timer->fire_time() Updated all drivers that use the above functions to fetch the specific device type (timer_device or screen_device) and call the appropriate method. [Aaron Giles] Changed machine->primary_screen and the 'screen' parameter to VIDEO_UPDATE to specifically pass in a screen_device object. [Aaron Giles] Defined a new custom interface for the Z80 daisy chain. This interface behaves like the standard interfaces, and can be added to any device that implements the Z80 daisy chain behavior. Converted all existing Z80 daisy chain devices to new-style devices that inherit this interface. [Aaron Giles] Changed the way CPU state tables are built up. Previously, these were data structures defined by a CPU core which described all the registers and how to output them. This functionality is now part of the state interface and is implemented via the device_state_entry class. Updated all CPU cores which were using the old data structure to use the new form. The syntax is currently awkward, but will be cleaner for CPUs that are native new devices. [Aaron Giles] Converted the okim6295 and eeprom devices to the new model. These were necessary because they both require multiple interfaces to operate and it didn't make sense to create legacy device templates for these single cases. (okim6295 needs the sound interface and the memory interface, while eeprom requires both the nvram and memory interfaces). [Aaron Giles] Changed parameters in a few callback functions from pointers to references in situations where they are guaranteed to never be NULL. [Aaron Giles] Removed MDRV_CPU_FLAGS() which was only used for disabling a CPU. Changed it to MDRV_DEVICE_DISABLE() instead. Updated drivers. [Aaron Giles] Reorganized the token parsing for machine configurations. The core parsing code knows how to create/replace/remove devices, but all device token parsing is now handled in the device_config class, which in turn will make use of any interface classes or device-specific token handling for custom token processing. [Aaron Giles] Moved many validity checks out of validity.c and into the device interface classes. For example, address space validation is now part of the memory interface class. [Aaron Giles] Consolidated address space parameters (bus width, endianness, etc.) into a single address_space_config class. Updated all code that queried for address space parameters to use the new mechanism. [Aaron Giles]
* Remove some aliases between CPUINFO_ and DEVINFO_ to help clarify Aaron Giles2010-01-211-9/+9
| | | | | | usage. Also converted a few more places to use the new accessors.
* Correct a long-standing design flaw: device configuration state Aaron Giles2010-01-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is now separate from runtime device state. I have larger plans for devices, so there is some temporary scaffolding to hold everything together, but this first step does separate things out. There is a new class 'running_device' which represents the state of a live device. A list of these running_devices sits in machine->devicelist and is created when a running_machine is instantiated. To access the configuration state, use device->baseconfig() which returns a reference to the configuration. The list of running_devices in machine->devicelist has a 1:1 correspondance with the list of device configurations in machine->config->devicelist, and most navigation options work equally on either (scanning by class, type, etc.) For the most part, drivers will now deal with running_device objects instead of const device_config objects. In fact, in order to do this patch, I did the following global search & replace: const device_config -> running_device device->static_config -> device->baseconfig().static_config device->inline_config -> device->baseconfig().inline_config and then fixed up the compiler errors that fell out. Some specifics: Removed device_get_info_* functions and replaced them with methods called get_config_*. Added methods for get_runtime_* to access runtime state from the running_device. DEVICE_GET_INFO callbacks are only passed a device_config *. This means they have no access to the token or runtime state at all. For most cases this is fine. Added new DEVICE_GET_RUNTIME_INFO callback that is passed the running_device for accessing data that is live at runtime. In the future this will go away to make room for a cleaner mechanism. Cleaned up the handoff of memory regions from the memory subsystem to the devices.
* More PPC GCC warning fixes. R. Belmont2010-01-151-1/+1
|
* Within src/emu, basic conversions: Aaron Giles2010-01-121-2/+2
| | | | | | devtag_get_device ... machine->device() memory_find_address_space ... device->space()
* First round of an attempted cleanup of header files in the system. Aaron Giles2010-01-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Created new central header "emu.h"; this should be included by pretty much any driver or device as the first include. This file in turn includes pretty much everything a driver or device will need, minus any other devices it references. Note that emu.h should *never* be included by another header file. - Updated all files in the core (src/emu) to use emu.h. - Removed a ton of redundant and poorly-tracked header includes from within other header files. - Temporarily changed driver.h to map to emu.h until we update files outside of the core. Added class wrapper around tagmap so it can be directly included and accessed within objects that need it. Updated all users to embed tagmap objects and changed them to call through the class. Added nicer functions for finding devices, ports, and regions in a machine: machine->device("tag") -- return the named device, or NULL machine->port("tag") -- return the named port, or NULL machine->region("tag"[, &length[, &flags]]) -- return the named region and optionally its length and flags Made the device tag an astring. This required touching a lot of code that printed the device to explicitly fetch the C-string from it. (Thank you gcc for flagging that issue!)
* Fixed x86 HLT instruction handling [Phill Harvey-Smith] Phil Bennett2009-12-311-3/+14
| | | | | | | | | | | | | | | | | | | | | | Date: Mon, 28 Dec 2009 00:29:31 +0000 From: Phill Harvey-Smith <afra@aurigae.demon.co.uk> To: submit@mamedev.org Subject: i86 patch Hi, Attatched is a patch correcting the operation of the hlt instruction in the i86 core. I have done test builds with both the current mame and mess source for both debug and normal builds, and all seems to be ok. Cheers. Phill. -- Phill Harvey-Smith, Programmer, Hardware hacker, and general eccentric ! "You can twist perceptions, but reality won't budge" -- Rush.
* Results of running the latest srcclean. Aaron Giles2009-12-281-26/+26
|
* Another step. Moved the address-space related get_info constants Aaron Giles2009-07-081-6/+6
| | | | | | to devintrf (including endianness). Removed space array from the CPU class header. Made the memory system much more device-neutral. Various other cleanups along the way.
* Fixed CPU_GET_INFO issues spotted by -validate in MESS debug build Fabio Priuli2009-04-111-1/+1
|
* CPU cores now compile cleanly. Aaron Giles2009-03-151-5/+14
|
* REP instructions with high interleave would never complete. Aaron Giles2008-12-301-0/+3
| | | | Also fixed cpu.mak dependencies for i286.
* More cleanup. Added address-space-specific constants for the various Aaron Giles2008-12-201-9/+9
| | | | | | | | | | | | | | bus width and shift CPU interface constants. Changed all the cores to use them. Minor spacing cleanup in Z80, Z180, TMS34010, ADSP21xx cores. Changed ADSP21xx cores to accept a configuration struct instead of using set_info to specify serial port callbacks. Simplified the ADSP21xx get/set info significantly. Removed support for only including certain variants of the chips; they are now either all supported or all unsupported.
* Renamed CPUINFO_PTR_* to CPUINFO_FCT_* for function get infos. Aaron Giles2008-12-191-7/+7
| | | | Changed Z80 over to the new cpu_state_table mechanism.
* CPU header cleanups.... Aaron Giles2008-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | i86/i286/i386/nec/v30mz: * renamed i86.h -> i86priv.h * renamed i86intrf.h -> i86.h * consolidated i88intrf.h, i186intf.h, i188intf.h, etc into i86.h m6805: * moved memory read/write macros out of public header m37710: * moved memory read/write macros out of public header spc700: * moved many structs/functions/macros out of public header tms32010: * moved memory read/write macros out of public header sm8500: * pointer-ified the core (apparently never had get/set context!) g65816: * moved memory read/write macros out of public header pic16c5x: * moved memory read/write macros out of public header t11: * moved memory read/write macros out of public header
* Removed unneeded segment base changes from the 80286 core. Wilbert Pol2008-12-171-5/+0
|
* Removed get context/set context calls from the CPU interface entirely. Aaron Giles2008-12-111-2/+0
| | | | Pointer-ified the TMS99xx core (missed that one!)
* Pointer-ified the i86/i286 cores. Aaron Giles2008-12-091-216/+206
| | | | Removed unused v20/v30 implementation.
* Removed unused variables Nathan Woods2008-12-051-1/+0
|
* Changed save state system to accept machine parameters where Aaron Giles2008-12-051-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | appropriate, and to keep all global variables hanging off the machine structure. Once again, this means all state registration call sites have been touched: - state_save_register_global* now takes a machine parameter - state_save_register_item* now takes a machine parameter - added new state_save_register_device_item* which now uses the device name and tag to generate the base name Extended the fake sound devices to have more populated fields. Modified sound cores to use tags from the devices and simplified the start function. Renumbered CPU and sound get/set info constants to align with the device constants, and shared values where they were perfectly aligned. Set the type field in the fake device_configs for CPU and sound chips to a get_info stub which calls through to the CPU and sound specific get_info functions. This means the device_get_info() functions work for CPU and sound cores, even in their fake state. Changed device information getters from device_info() to device_get_info() to match the CPU and sound macros.
* CPU_IS_LE -> ENDIANNESS_LITTLE Aaron Giles2008-12-041-1/+1
| | | | | | CPU_IS_BE -> ENDIANNESS_BIG Also fixed help for step over/in to specify correct keys.
* Removed NO_LEGACY_MEMORY_HANDLERS defines. Aaron Giles2008-11-241-1/+0
|
* Converted a bunch of CPU cores over to the new memory functions. Aaron Giles2008-11-221-0/+5
|
* Debugger interfaces cleanup. Still more to do but this compiles and Aaron Giles2008-11-211-1/+1
| | | | | | | works. Added callback parameters to the expression engine. Improved CPU parsing so you can use a CPU tag or index in most commands that take one. Switched to passing CPU and address space objects around where appropriate. Lots of other minor tweaks.
* Added "tag" parameter to state_save_register_item_* calls. Removed Aaron Giles2008-11-171-34/+34
| | | | | | state_save_combine_module_and_tag() function in favor of passing the tag when registering. Revisited all save state item registrations and changed them to use the tag where appropriate.