summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/video/mc6845.cpp
Commit message (Collapse)AuthorAgeFilesLines
* mc6845: enable strobe output (RA4) in transparent mode. Robbbert2020-10-111-4/+4
|
* video/mc6845.cpp: Fix some uninitialised variables. Vas Crabb2020-10-091-0/+2
|
* Cleaned up bitmap API. Vas Crabb2020-09-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Made const-qualified pixel accessors (pix, pixt, raw_pixptr) return const-qualified references/pointers to pixesl, and added non-const versions. This makes bitmap more like standard library containers where const protects the content as well as the dimensions. Made the templated pixt accessor protected - having it public makes it too easy to inadvertently get a pointer to the wrong location. Removed the pix(8|16|32|64) accessors from the specific bitmaps. You could only use the "correct" one anyway, and having the "incorrect" ones available prevented explicit instantiations of the class template because the static assertions would fail. You can still see the pixel type in the bitmap class names, and you can't assign the result of &pix(y, x) to the wrong kind of pointer without a cast. Added fill member functions to the specific bitmap template, and added a explicit instantiations. This allows the bitmap size check to be skipped on most bitmap fills, although the clipping check is still there. Also fixed a couple of places that were trying to fill an indexed 16-bit bitmap with rgb_t::black() exposed by this (replaced with zero to get the same net effect). The explicit template instantiations in the .cpp file mean the compiler can inline the function if necessary, but don't need to generate a local out-of-line body if it chooses not to. Extended the size of the fill value parameter in the base bitmap class to 64 bits so it works correctly for 64-bit bitmaps. Fixed places where IE15 and VGM visualiser weren't accounting for row bytes potentially being larger than width. Fixed an off-by-one in an HP-DIO card where it was treating the Topcat cursor right edge as exclusive. Updated everything to work with the API changes, reduced the scope of many variables, added more const, and replaced a few fill/copy loops with stuff from <algorithm>.
* mc6845: Fix off-by-one error in calculating bottom of DE window AJR2020-09-251-1/+1
|
* hd6345: Added all registers and implemented screen split. Nigel Barnes2020-08-171-44/+161
|
* video/mc6845.cpp: Copying some switch statements doesn't constitute ↵ Vas Crabb2020-08-171-1/+1
| | | | copyrightable creative work (thanks Nigel Barnes for pointing this out)
* ams40041: Move PC1512 VDU emulation down into device AJR2020-05-131-29/+0
|
* mc6845: max visible lines might not be what really is displayed, see 8088mph ↵ cracyc2020-04-301-1/+1
| | | | (nw)
* mc6845: Note (nw) AJR2020-04-291-0/+1
|
* hd6345: Derive from hd6845s to maintain compatibility (nw) Nigel Barnes2019-11-081-2/+8
|
* Make devdelegate more like devcb for configuration. This is a Vas Crabb2019-10-261-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* srcclean (nw) Vas Crabb2019-10-261-11/+11
|
* Review comments fixed Joakim Larsson Edstrom2019-09-261-1/+0
|
* mc6845.cpp: more logging and reduced (not eliminated) warning spam ↵ Joakim Larsson Edstrom2019-09-261-9/+39
| | | | significantly at startup when register values doesn't make sense
* srcclean (nw) Vas Crabb2019-09-221-2/+2
|
* HD6845: specialize the cursor emulation (#5598) 68bit2019-09-081-8/+28
| | | For the HD6845 the cursor does not wrap around as it does for the MC6845.
* mc6845: address cursor display edge case in interlaced mode. 68bit2019-08-291-1/+9
| | | | | | | | | It appears that the cursor is not displayed when the start raster address is equal to the maximum raster address in the 'interlace and video' mode. At least this addresses a claimed regression in the 'apricot' machine. To be explore further on hardware. The maximum raster address was also off by one in these calculations.
* MC6845: correct cursor. 68bit2019-08-281-1/+7
| | | | | | | | | | The MC6845 shows a full cursor if the cursor end raster address is greater than the maximum raster address, restore that case in general. The issue on the BBC, that uses the HD6845S, might be the use of the maximum raster address here, it appears to be programmed differently on the HD6845S and also to depend on the interlaced mode. This patch fixes the BBC while preserving the cursor emulation for the MC6845.
* mc6845: Fix height of cursor on BBC Micro (nw) AJR2019-08-271-5/+0
|
* mc6845: improve the cursor emulation 68bit2019-08-261-12/+42
| | | | Implements partial cursors.
* mc6845: More consistent identification of HD6845S variant (nw) AJR2019-05-181-29/+10
|
* mc6845: Use standard device method to adjust input clock (nw) AJR2019-04-281-35/+24
|
* mc6845: Fix MT #7282; improve logging (nw) AJR2019-04-201-6/+15
|
* (nw) Clean up the mess on master Vas Crabb2019-03-261-28/+45
| | | | | | | | | | | | | This effectively reverts b380514764cf857469bae61c11143a19f79a74c5 and c24473ddff715ecec2e258a6eb38960cf8c8e98e, restoring the state at 598cd5227223c3b04ca31f0dbc1981256d9ea3ff. Before pushing, please check that what you're about to push is sane. Check your local commit log and ensure there isn't anything out-of-place before pushing to mainline. When things like this happen, it wastes everyone's time. I really don't need this in a week when real work™ is busting my balls and I'm behind where I want to be with preparing for MAME release.
* Revert "conflict resolution (nw)" andreasnaive2019-03-251-45/+28
| | | | | This reverts commit c24473ddff715ecec2e258a6eb38960cf8c8e98e, reversing changes made to 009cba4fb8102102168ef32870892438327f3705.
* mc6845.cpp: Check for vsync on frame reset only if vsync witdh is supported AmatCoder2019-03-121-2/+5
| | | Regression caused by 12d8a146 (see comments there).
* Merge pull request #4730 from AmatCoder/AmatCoder-mc6845-2 R. Belmont2019-03-081-14/+27
|\ | | | | mc6845.cpp: Check if vsync should be enabled when frame is reset
| * mc6845.cpp: Check if vsync should be enabled when frame is reset AmatCoder2019-03-071-14/+27
| | | | | | | | Fix MT 06927
* | mc6845.cpp: Fix mk88 machine AmatCoder2019-03-081-0/+2
|/ | | | Regression caused by commit c4f0852c. Thanks to Tafoid for catch it.
* mc6845.cpp: Do not reset line counter when screen parameters changed AmatCoder2019-03-061-2/+0
| | | | Fix MT 06997, 06854 and 06423. Also others games like "Profanation 2" works now.
* mc6845, crtc_ega: Simplify read/write handlers (nw) AJR2019-02-191-11/+11
|
* Eliminate the default address map member of address_space_config (nw) AJR2019-02-171-2/+3
| | | | | | Since all device address maps are now class methods defined in ordinary C++, default RAM maps can be provided more simply with an explicit has_configured_map check in an internal map definition. A number of default address maps that probably weren't meant to be overridden have also been changed to ordinary internal maps.
* as if millions of this pointers suddenly cried out in terror, and were ↵ Vas Crabb2018-06-081-24/+4
| | | | | | | suddenly silenced * streamline templates in addrmap.h * get rid of overloads on read/write member names - this will become even more important in the near future
* mos8563: Use device_palette_interface instead of creating palette subdevice (nw) AJR2018-06-011-34/+22
|
* maps: Finish devices/video (nw) Olivier Galibert2018-04-201-3/+4
|
* API change: Memory maps are now methods of the owner class [O. Galibert] Olivier Galibert2018-02-121-2/+2
| | | | | Also, a lot more freedom happened, that's going to be more visible soon.
* API Change: Machine configs are now a method of the owner class, and the ↵ Olivier Galibert2018-01-171-1/+1
| | | | | | | | | | prototype is simplified [O. Galibert] Beware, the device context does not follow in MCFG_FRAGMENT_ADD anymore due to the prototype change. So creating a device then configuring through a fragment doesn't work as-is. The simplest solution is just to add a MCFG_DEVICE_MODIFY at the start of the fragment with the correct tag.
* Privatize m_screen and other variables of device_video_interface (nw) AJR2018-01-051-4/+4
|
* memory: Remove some space parameters from the apple2 domain [O. Galibert] Olivier Galibert2017-12-191-0/+20
|
* mc6845: Minor transparent update refactoring (nw) AJR2017-11-161-40/+25
|
* make device_memory_interface slightly less of a special case, use a typedef ↵ Vas Crabb2017-07-101-2/+2
| | | | to avoid nested templates everywhere (nw)
* dimemory: Lift the cap on the number of address spaces per device [O. Galibert] Olivier Galibert2017-07-031-9/+7
|
* updated devices/video devices to use device_add_mconfig insted of ↵ Ivan Vangelista2017-05-241-6/+1
| | | | device_mconfig_additions (nw)
* Goodbye MACHINE_CONFIG_FRAGMENT, it was nice knowing you. Vas Crabb2017-05-221-1/+1
| | | | | | | | | (nw) This is a pretty minimal change. The point where the root device is added has been moved from the MACHINE_CONFIG_START macro to the constructor of the machine configuration class (made possible by giving drivers their own device types). This isn't the final change in this area. The root device is still being handled specially in that its configuration comes from the game driver structure. This needs to be harmonised with regular devices. But that's a job for another day.
* Move static data out of devices into the device types. This is a ↵ Vas Crabb2017-05-141-56/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | significant change, so please pay attention. The core changes are: * Short name, full name and source file are no longer members of device_t, they are part of the device type * MACHINE_COFIG_START no longer needs a driver class * MACHINE_CONFIG_DERIVED_CLASS is no longer necessary * Specify the state class you want in the GAME/COMP/CONS line * The compiler will work out the base class where the driver init member is declared * There is one static device type object per driver rather than one per machine configuration Use DECLARE_DEVICE_TYPE or DECLARE_DEVICE_TYPE_NS to declare device type. * DECLARE_DEVICE_TYPE forward-declares teh device type and class, and declares extern object finders. * DECLARE_DEVICE_TYPE_NS is for devices classes in namespaces - it doesn't forward-declare the device type. Use DEFINE_DEVICE_TYPE or DEFINE_DEVICE_TYPE_NS to define device types. * These macros declare storage for the static data, and instantiate the device type and device finder templates. The rest of the changes are mostly just moving stuff out of headers that shouldn't be there, renaming stuff for consistency, and scoping stuff down where appropriate. Things I've actually messed with substantially: * More descriptive names for a lot of devices * Untangled the fantasy sound from the driver state, which necessitates breaking up sound/flip writes * Changed DECO BSMT2000 ready callback into a device delegate * Untangled Microprose 3D noise from driver state * Used object finders for CoCo multipak, KC85 D002, and Irem sound subdevices * Started to get TI-99 stuff out of the TI-990 directory and arrange bus devices properly * Started to break out common parts of Samsung ARM SoC devices * Turned some of FM, SID, SCSP DSP, EPIC12 and Voodoo cores into something resmbling C++ * Tried to make Z180 table allocation/setup a bit safer * Converted generic keyboard/terminal to not use WRITE8 - space/offset aren't relevant * Dynamically allocate generic terminal buffer so derived devices (e.g. teleprinter) can specify size * Imporved encapsulation of Z80DART channels * Refactored the SPC7110 bit table generator loop to make it more readable * Added wrappers for SNES PPU operations so members can be made protected * Factored out some boilerplate for YM chips with PSG * toaplan2 gfx * stic/intv resolution * Video System video * Out Run/Y-board sprite alignment * GIC video hookup * Amstrad CPC ROM box members * IQ151 ROM cart region * MSX cart IRQ callback resolution time * SMS passthrough control devices starting subslots I've smoke-tested several drivers, but I've probably missed something. Things I've missed will likely blow up spectacularly with failure to bind errors and the like. Let me know if there's more subtle breakage (could have happened in FM or Voodoo). And can everyone please, please try to keep stuff clean. In particular, please stop polluting the global namespace. Keep things out of headers that don't need to be there, and use things that can be scoped down rather than macros. It feels like an uphill battle trying to get this stuff under control while more of it's added.
* added (partial) correct register mappings to HD6345 bwodok2017-04-251-3/+57
|
* amusco.cpp: Generate blink state in a way more likely to represent hardware; ↵ AJR2017-03-181-6/+0
| | | | remove kludged-in MC6845 accessor (nw)
* Self-registering devices prep: Vas Crabb2017-02-271-13/+15
| | | | | | | | | | | | | | * Make device_creator a variable template and get rid of the ampersands * Remove screen.h and speaker.h from emu.h and add where necessary * Centralise instantiations of screen and speaker finder templates * Add/standardise #include guards in many hearers * Remove many redundant #includes * Order #includesr to help catch headers that can't be #included alone (nw) This changes #include order to be prefix, unit header if applicable then other stuff roughly in order from most dependent to least dependent library. This helps catch headers that don't #include things that they use.
* Fix scanout of mc6845 Mark Garlanger2017-02-171-1/+1
|
* osborne1nv: scroll fix (nw) Robbbert2017-02-091-1/+1
|