summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/machine/6522via.cpp
Commit message (Collapse)AuthorAgeFilesLines
* (nw) via6522: removed unneeded space and offset Robbbert2019-04-201-2/+2
|
* via6522: Fix timing for shifting under control of system clock Mathis Rosenhauer2018-12-291-1/+1
|
* 6522via.cpp: Count negative PB6 pulses in T2 counter mode AJR2018-12-271-53/+101
| | | | (nw) VIA interrupt remains disconnected in tv950 due to CRTC-related problems. This is fairly likely to cause regressions in other drivers which may need explicit writes to PB6.
* Previous commit examples of use (nw) Olivier Galibert2018-08-021-2/+2
|
* devcb3 Vas Crabb2018-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are multiple issues with the current device callbacks: * They always dispatch through a pointer-to-member * Chained callbacks are a linked list so the branch unit can't predict the early * There's a runtime decision made on the left/right shift direction * There are runtime NULL checks on various objects * Binding a lambda isn't practical * Arbitrary transformations are not supported * When chaining callbacks it isn't clear what the MCFG_DEVCB_ modifiers apply to * It isn't possible to just append to a callback in derived configuration * The macros need a magic, hidden local called devcb * Moving code that uses the magic locals around is error-prone * Writing the MCFG_ macros to make a device usable is a pain * You can't discover applicable MCFG_ macros with intellisense * Macros are not scoped * Using an inappropriate macro isn't detected at compile time * Lots of other things This changeset overcomes the biggest obstacle to remving MCFG_ macros altogether. Essentially, to allow a devcb to be configured, call .bind() and expose the result (a bind target for the callback). Bind target methods starting with "set" repace the current callbacks; methods starting with "append" append to them. You can't reconfigure a callback after resolving it. There's no need to use a macro matching the handler signatures - use FUNC for everything. Current device is implied if no tag/finder is supplied (no need for explicit this). Lambdas are supported, and the memory space and offset are optional. These kinds of things work: * .read_cb().set([this] () { return something; }); * .read_cb().set([this] (offs_t offset) { return ~offset; }); * .write_cb().set([this] (offs_t offset, u8 data) { m_array[offset] = data; }); * .write_cb().set([this] (int state) { some_var = state; }); Arbitrary transforms are allowed, and they can modify offset/mask for example: * .read_cb().set(FUNC(my_state::handler)).transform([] (u8 data) { return bitswap<4>(data, 1, 3, 0, 2); }); * .read_cb().set(m_dev, FUNC(some_device::member)).transform([] (offs_t &offset, u8 data) { offset ^= 3; return data; }); It's possible to stack arbitrary transforms, at the cost of compile time (the whole transform stack gets inlined at compile time). Shifts count as an arbitrary transform, but mask/exor does not. Order of mask/shift/exor now matters. Modifications are applied in the specified order. These are NOT EQUIVALENT: * .read_cb().set(FUNC(my_state::handler)).mask(0x06).lshift(2); * .read_cb().set(FUNC(my_state::handler)).lshift(2).mask(0x06); The bit helper no longer reverses its behaviour for read callbacks, and I/O ports are no longer aware of the field mask. Binding a read callback to no-op is not supported - specify a constant. The GND and VCC aliases have been removed intentionally - they're TTL-centric, and were already being abused. Other quirks have been preserved, including write logger only logging when the data is non-zero (quite unhelpful in many of the cases where it's used). Legacy syntax is still supported for simple cases, but will be phased out. New devices should not have MCFG_ macros. I don't think I've missed any fundamental issues, but if I've broken something, let me know.
* as if millions of this pointers suddenly cried out in terror, and were ↵ Vas Crabb2018-06-081-1/+1
| | | | | | | suddenly silenced * streamline templates in addrmap.h * get rid of overloads on read/write member names - this will become even more important in the near future
* maps: Finish map.m() (nw) Olivier Galibert2018-04-191-3/+4
|
* Grammar police (nw) Olivier Galibert2018-02-241-1/+1
|
* API change: Memory maps are now methods of the owner class [O. Galibert] Olivier Galibert2018-02-121-1/+1
| | | | | Also, a lot more freedom happened, that's going to be more visible soon.
* Revert "Revert "Merge branch 'master' of https://github.com/mamedev/mame"" Firehawke2017-12-131-9/+0
| | | | This reverts commit 54155441e9ba9941e85d80c4834a66376a11e791.
* Revert "Merge branch 'master' of https://github.com/mamedev/mame" Firehawke2017-12-131-0/+9
| | | | | This reverts commit f537428e5a40ba6dde8ca9bf0fe9ae6b1f189ac4, reversing changes made to 0d70d798107d4e4e8fb9f230410aeb1e888d65c5.
* via6522: Eliminate truly ancient hack to default clock to that of first CPU (nw) AJR2017-12-071-9/+0
| | | | All VIAs in MAME now have properly configured clocks.
* via6522: Added some interrupt LOGs Joakim Larsson Edstrom2017-10-181-0/+17
|
* srcclean (nw) Vas Crabb2017-05-281-72/+72
|
* Typo fix (nw) AJR2017-05-251-1/+1
|
* Move static data out of devices into the device types. This is a ↵ Vas Crabb2017-05-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | significant change, so please pay attention. The core changes are: * Short name, full name and source file are no longer members of device_t, they are part of the device type * MACHINE_COFIG_START no longer needs a driver class * MACHINE_CONFIG_DERIVED_CLASS is no longer necessary * Specify the state class you want in the GAME/COMP/CONS line * The compiler will work out the base class where the driver init member is declared * There is one static device type object per driver rather than one per machine configuration Use DECLARE_DEVICE_TYPE or DECLARE_DEVICE_TYPE_NS to declare device type. * DECLARE_DEVICE_TYPE forward-declares teh device type and class, and declares extern object finders. * DECLARE_DEVICE_TYPE_NS is for devices classes in namespaces - it doesn't forward-declare the device type. Use DEFINE_DEVICE_TYPE or DEFINE_DEVICE_TYPE_NS to define device types. * These macros declare storage for the static data, and instantiate the device type and device finder templates. The rest of the changes are mostly just moving stuff out of headers that shouldn't be there, renaming stuff for consistency, and scoping stuff down where appropriate. Things I've actually messed with substantially: * More descriptive names for a lot of devices * Untangled the fantasy sound from the driver state, which necessitates breaking up sound/flip writes * Changed DECO BSMT2000 ready callback into a device delegate * Untangled Microprose 3D noise from driver state * Used object finders for CoCo multipak, KC85 D002, and Irem sound subdevices * Started to get TI-99 stuff out of the TI-990 directory and arrange bus devices properly * Started to break out common parts of Samsung ARM SoC devices * Turned some of FM, SID, SCSP DSP, EPIC12 and Voodoo cores into something resmbling C++ * Tried to make Z180 table allocation/setup a bit safer * Converted generic keyboard/terminal to not use WRITE8 - space/offset aren't relevant * Dynamically allocate generic terminal buffer so derived devices (e.g. teleprinter) can specify size * Imporved encapsulation of Z80DART channels * Refactored the SPC7110 bit table generator loop to make it more readable * Added wrappers for SNES PPU operations so members can be made protected * Factored out some boilerplate for YM chips with PSG * toaplan2 gfx * stic/intv resolution * Video System video * Out Run/Y-board sprite alignment * GIC video hookup * Amstrad CPC ROM box members * IQ151 ROM cart region * MSX cart IRQ callback resolution time * SMS passthrough control devices starting subslots I've smoke-tested several drivers, but I've probably missed something. Things I've missed will likely blow up spectacularly with failure to bind errors and the like. Let me know if there's more subtle breakage (could have happened in FM or Voodoo). And can everyone please, please try to keep stuff clean. In particular, please stop polluting the global namespace. Keep things out of headers that don't need to be there, and use things that can be scoped down rather than macros. It feels like an uphill battle trying to get this stuff under control while more of it's added.
* via6522: fixed the flank timer value which improved but not completelly ↵ Joakim Larsson Edstrom2017-05-041-7/+7
| | | | reverted the vectrex regression
* via6522: tuned shifter IRQ timing to be more cycle accurate Joakim Larsson Edstrom2017-04-281-8/+20
|
* via6522: Removed old code and cleaned up a bit Joakim Larsson Edstrom2017-04-281-111/+26
|
* via6522: refactored shifter supporting more fetures and fixed a few bugs Joakim Larsson Edstrom2017-04-271-59/+110
|
* Since we're close to release, revert for now (nw) arbee2017-04-201-2/+2
|
* Turn off global logging (nw) Scott Stone2017-04-201-2/+2
|
* Revert most of previous fix, instead change VIA6522 to work better. (nw) arbee2017-04-191-4/+4
|
* debugger_access: Refactor [O. Galibert] Olivier Galibert2017-03-021-1/+1
|
* Self-registering devices prep: Vas Crabb2017-02-271-1/+1
| | | | | | | | | | | | | | * Make device_creator a variable template and get rid of the ampersands * Remove screen.h and speaker.h from emu.h and add where necessary * Centralise instantiations of screen and speaker finder templates * Add/standardise #include guards in many hearers * Remove many redundant #includes * Order #includesr to help catch headers that can't be #included alone (nw) This changes #include order to be prefix, unit header if applicable then other stuff roughly in order from most dependent to least dependent library. This helps catch headers that don't #include things that they use.
* srcclean (nw) Vas Crabb2017-02-191-6/+6
|
* Added missing final and leading flanks when shifting out and in respectivelly Joakim Larsson Edstrom2017-02-171-21/+87
|
* via6522: fixed so shift out and in flank is not controlled by pcr in ↵ Joakim Larsson Edstrom2017-02-011-2/+14
| | | | accordance with datasheet
* via6522: added stop of device_timer when going from internaly to externaly ↵ Joakim Larsson Edstrom2017-02-011-15/+41
| | | | clocked shift modes
* via6522: fixed 50/50 duty cycle for T2 and O2 driven CB1 shift IN & OUT on CB2 Joakim Larsson Edstrom2017-01-301-19/+23
|
* via6522: updated LOG messages to latest cut and added some new Joakim Larsson Edstrom2017-01-301-15/+32
|
* Revert "moved debugger_access() from address space to machine & removed the ↵ Vas Crabb2016-11-211-1/+1
| | | | | | anti-patterns that updated cascading address spaces. [smf]" This reverts commit 5f05fbf61348c65204fde1e2aeed72de4cb56593.
* moved debugger_access() from address space to machine & removed the ↵ smf-2016-11-191-1/+1
| | | | anti-patterns that updated cascading address spaces. [smf]
* NOTICE (TYPE NAME CONSOLIDATION) Miodrag Milanovic2016-10-221-9/+9
| | | | | Use standard uint64_t, uint32_t, uint16_t or uint8_t instead of UINT64, UINT32, UINT16 or UINT8 also use standard int64_t, int32_t, int16_t or int8_t instead of INT64, INT32, INT16 or INT8
* reverting: Miodrag Milanovic2016-01-201-5/+5
| | | | | | | SHA-1: 1f90ceab075c4869298e963bf0a14a0aac2f1caa * tags are now strings (nw) fix start project for custom builds in Visual Studio (nw)
* tags are now strings (nw) Miodrag Milanovic2016-01-161-5/+5
| | | | fix start project for custom builds in Visual Studio (nw)
* Rename *.c -> *.cpp in our source (nw) Miodrag Milanovic2015-11-081-0/+985