summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/bus/ti99/gromport
Commit message (Collapse)AuthorAgeFilesLines
...
* ti99: Kill some more MCFGs. (nw) Michael Zapf2018-08-213-12/+15
|
* ti99: Forgot to remove the logerror. (nw) Michael Zapf2018-08-211-1/+0
|
* ti99: Use a config command instead of a subclass. (nw) Michael Zapf2018-08-212-20/+13
|
* ti99: Adapting to common devcb3 slot device handling. (nw) Michael Zapf2018-08-202-23/+40
|
* tms99xx: Various devcb3 updates. (nw) Michael Zapf2018-08-181-5/+21
|
* ti99: devcb3 for the slot devices (nw) Michael Zapf2018-08-132-31/+15
|
* ti99: Modernized logging. (nw) Michael Zapf2018-08-111-1/+1
|
* devcb3 Vas Crabb2018-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are multiple issues with the current device callbacks: * They always dispatch through a pointer-to-member * Chained callbacks are a linked list so the branch unit can't predict the early * There's a runtime decision made on the left/right shift direction * There are runtime NULL checks on various objects * Binding a lambda isn't practical * Arbitrary transformations are not supported * When chaining callbacks it isn't clear what the MCFG_DEVCB_ modifiers apply to * It isn't possible to just append to a callback in derived configuration * The macros need a magic, hidden local called devcb * Moving code that uses the magic locals around is error-prone * Writing the MCFG_ macros to make a device usable is a pain * You can't discover applicable MCFG_ macros with intellisense * Macros are not scoped * Using an inappropriate macro isn't detected at compile time * Lots of other things This changeset overcomes the biggest obstacle to remving MCFG_ macros altogether. Essentially, to allow a devcb to be configured, call .bind() and expose the result (a bind target for the callback). Bind target methods starting with "set" repace the current callbacks; methods starting with "append" append to them. You can't reconfigure a callback after resolving it. There's no need to use a macro matching the handler signatures - use FUNC for everything. Current device is implied if no tag/finder is supplied (no need for explicit this). Lambdas are supported, and the memory space and offset are optional. These kinds of things work: * .read_cb().set([this] () { return something; }); * .read_cb().set([this] (offs_t offset) { return ~offset; }); * .write_cb().set([this] (offs_t offset, u8 data) { m_array[offset] = data; }); * .write_cb().set([this] (int state) { some_var = state; }); Arbitrary transforms are allowed, and they can modify offset/mask for example: * .read_cb().set(FUNC(my_state::handler)).transform([] (u8 data) { return bitswap<4>(data, 1, 3, 0, 2); }); * .read_cb().set(m_dev, FUNC(some_device::member)).transform([] (offs_t &offset, u8 data) { offset ^= 3; return data; }); It's possible to stack arbitrary transforms, at the cost of compile time (the whole transform stack gets inlined at compile time). Shifts count as an arbitrary transform, but mask/exor does not. Order of mask/shift/exor now matters. Modifications are applied in the specified order. These are NOT EQUIVALENT: * .read_cb().set(FUNC(my_state::handler)).mask(0x06).lshift(2); * .read_cb().set(FUNC(my_state::handler)).lshift(2).mask(0x06); The bit helper no longer reverses its behaviour for read callbacks, and I/O ports are no longer aware of the field mask. Binding a read callback to no-op is not supported - specify a constant. The GND and VCC aliases have been removed intentionally - they're TTL-centric, and were already being abused. Other quirks have been preserved, including write logger only logging when the data is non-zero (quite unhelpful in many of the cases where it's used). Legacy syntax is still supported for simple cases, but will be phased out. New devices should not have MCFG_ macros. I don't think I've missed any fundamental issues, but if I've broken something, let me know.
* ti99: Removed deprecated function calls, simplified GROM access, added ↵ Michael Zapf2018-06-3010-122/+158
| | | | logmacro. (nw)
* Streamline machine configuration macros - everyone's a device edition. Vas Crabb2018-05-061-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start replacing special device macros with additional constructors, starting with ISA, INTELLEC 4 and RS-232 buses. Allow an object finder to take on the target of another object finder. (For a combination of the previous two things in action, see either the INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out looping over a device finder array to instantiate devices in some places. Lots of things no longer need to pass tags around.) Start supplying default clocks for things that have a standard clock or have all clocks internal. Eliminate the separate DEV versions of the DEVCB_ macros. Previously, the plain versions were a shortcut for DEVICE_SELF as the target. You can now supply a string tag (relative to current device being configured), an object finder (takes on the base and relative tag), or a reference to a device/interface (only do this if you know the device won't be replaced out from under it, but that's a safe assumption for your subdevices). In almost all cases, you can get the effect you want by supplying *this as the target. Eliminate sound and CPU versions of macros. They serve no useful purpose, provide no extra checks, make error messages longer, add indirection, and mislead newbies into thinking there's a difference. Remove a lot of now-unnecessary ":" prefixes binding things relative to machine root. Clean up some miscellaneous rot. Examples of new functionality in use in (some more subtle than others): * src/mame/drivers/intellec4.cpp * src/mame/drivers/tranz330.cpp * src/mame/drivers/osboren1.cpp * src/mame/drivers/zorba.cpp * src/mame/devices/smioc.cpp * src/devices/bus/a2bus/pc_xporter.cpp * src/devices/bus/isa/isa.h * src/devices/bus/isa/isa.h * src/devices/bus/intellec4/intellec4.h
* Make MCFG_DEVICE_ADD and callable device types more flexible: Vas Crabb2018-05-042-12/+14
| | | | | | | | | | | | | | | | | | | | | * Allows defaulted clocks (see subtle example with vboy) * Allows additional constructors (see RS232 port in tranz330) * Allows use of device finder in place of tag in MCFG_DEVICE_ADD * Requires out-of-line destructor for devices using incomplete types * Requires XTAL or explicit u32 for clocks for devices with private types Devices must still define the standard constructor. When writing additional constructors, be aware that the constructor runs before device_add_mconfig in the context of the existing device, not the new device. See osborne1, zorba, tranz330, and vboy for examples of this in use. Compilation is a bit slower, but this is temporary while refactoring is in progress. Eliminated the need for MCFG_SOUND_ROUTE_EX. Removed macros from slot option configuration - they just obfuscated code and slowed it down with needless dynamic casts, but didn't actually simplify it.
* destaticify initializations (nw) (#3289) wilbertpol2018-03-041-7/+7
| | | | | | * destaticify initializations (nw) * fix this->set_screen (nw)
* Fixes for Coverity "Resource leak" warnings (#3089) Oliver Stöneberg2018-01-211-1/+1
| | | | | | | | | | * lib/util/chdcd.cpp: fixed Coverity "Resource Leak" warning (nw) * src/lib/util/chdcd.cpp: fixed more Coverity "Resource Leak" warnings (nw) * tools/imgtool/modules/mac.cpp: fixed Coverity "Resource Leak" warnings (nw) * devices/bus/ti99/gromport/cartridges.cpp: fixed Coverity "Resource Leak" warning (nw)
* bus/ti99/gromport/cartridges: Really eliminate core_strdup (nw) AJR2018-01-202-14/+11
|
* removed core_strdup() usage from ti99 cartridge code (nw) firewave2018-01-212-6/+6
|
* API Change: Machine configs are now a method of the owner class, and the ↵ Olivier Galibert2018-01-174-4/+4
| | | | | | | | | | prototype is simplified [O. Galibert] Beware, the device context does not follow in MCFG_FRAGMENT_ADD anymore due to the prototype change. So creating a device then configuring through a fragment doesn't work as-is. The simplest solution is just to add a MCFG_DEVICE_MODIFY at the start of the fragment with the correct tag.
* * Make XML file a class of its own managed with smart poitners Vas Crabb2017-07-211-5/+1
| | | | * Save/restore a little more of Cocoa debugger state
* ti99: Added new cartridge type paged7 for TI-CALC. Michael Zapf2017-06-242-2/+86
|
* finally got rid of machine_mconfig_additions (nw) Ivan Vangelista2017-06-148-29/+10
|
* ti99: Architectural cleanup for slot devices; constant renaming Michael Zapf2017-06-084-11/+15
|
* added missing emu.h (nw) smf-2017-05-262-0/+2
|
* ti99: Created bus gromport, split monster file gromport Michael Zapf2017-05-2510-0/+3616