| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This effectively reverts b380514764cf857469bae61c11143a19f79a74c5 and
c24473ddff715ecec2e258a6eb38960cf8c8e98e, restoring the state at
598cd5227223c3b04ca31f0dbc1981256d9ea3ff.
Before pushing, please check that what you're about to push is sane.
Check your local commit log and ensure there isn't anything out-of-place
before pushing to mainline. When things like this happen, it wastes
everyone's time. I really don't need this in a week when real work™ is
busting my balls and I'm behind where I want to be with preparing for
MAME release.
|
|
|
|
|
| |
This reverts commit c24473ddff715ecec2e258a6eb38960cf8c8e98e, reversing
changes made to 009cba4fb8102102168ef32870892438327f3705.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Remove all MCFG_ macros and use devcb3 for callback configuration
- Use address space finder to replace one call to machine().device
- Require accessor for slot cards to access bus space
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* enable sub-second snapshot timers (nw)
* switch to attotime, accept doubles
* support LLVM extension in MSVC
make vsllvm
using extension from here:
https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
qix, quizpun2, stfight, tigeroad: Removed MACHINE_CONFIG. [Ryan Holtz]
-m68705, m68hc05: Removed MCFG. [Ryan Holtz]
-qix: First-pass cleanup. [Ryan Holtz]
-core: Fixed spelling of "nonexistent". [Ryan Holtz]
|
| |
|
|
|
|
| |
template parameters, etc.)
|
| |
|
| |
|
|
|
|
| |
mac128k: fix code rot (nw)
|
| |
|
|
|
|
|
|
|
|
| |
* Add A1000 keyboards, with "new" MCU program as bad dump until we get the real 6500-1 dump - gets the correct number of keys at least
* Fix Amiga 600 keyboard matrix errors
* Don't allow 555 to retrigger
* Add some more notes about keyboards
* Add more notes and pinout for 6500/1
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement Mitsumi Amiga 500, 600, and 2000/3000/4000/CDTV keyboards
* Add unlabeled keys to UK layout
* Restrict available keyboards depending on system type
* Note that C-A-A reset is now broken on "big box" Amigas as MAME doesn't implement it properly, and the hack providing a fake dedicated reset line has been removed
6502 MCU: fix execute loop
6500/1: implement as device with onboard peripherals
Fix some bogus comments
|
|
|
|
|
|
| |
a2232: Add input merger device to handle IRQs (nw)
superpet: 6809 type identification (nw)
|
|
|
|
| |
option
|
|
|
|
| |
removal, nw
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
manufactured by Cherry
(nw) New keyboard only has U.S./Canada and UK variants for now. This keyboard doesn't
drive a dedicated reset line, instead using some sequence on the clock line detected by
the host chipset. MAME doesn't support this, so keyboard reset won't work. Also started
documenting the character labels on the keypad NumLock/ScrLock keys for language variants
but still need more pictures.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
econet/e01, ieee488/d9060, video/huc622, x68k_scsiext:
device_add_mconfig modernization. [Ryan Holtz]
-amiga_dmac: Replaced old devcb with devcb3. [Ryan Holtz]
-mc6854, ataintf, mb89352, mc6854, wd33c93: Added devcb3 support. [Ryan Holtz]
-8042kbdc, i8255, idectrl, intelfsh, mb89352, ram, wd33c93, volt_reg: Default clocks to 0 (nw)
-bebox, indy_indigo2: machine_config modernization. [Ryan Holtz]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are multiple issues with the current device callbacks:
* They always dispatch through a pointer-to-member
* Chained callbacks are a linked list so the branch unit can't predict the early
* There's a runtime decision made on the left/right shift direction
* There are runtime NULL checks on various objects
* Binding a lambda isn't practical
* Arbitrary transformations are not supported
* When chaining callbacks it isn't clear what the MCFG_DEVCB_ modifiers apply to
* It isn't possible to just append to a callback in derived configuration
* The macros need a magic, hidden local called devcb
* Moving code that uses the magic locals around is error-prone
* Writing the MCFG_ macros to make a device usable is a pain
* You can't discover applicable MCFG_ macros with intellisense
* Macros are not scoped
* Using an inappropriate macro isn't detected at compile time
* Lots of other things
This changeset overcomes the biggest obstacle to remving MCFG_ macros
altogether. Essentially, to allow a devcb to be configured, call
.bind() and expose the result (a bind target for the callback). Bind
target methods starting with "set" repace the current callbacks; methods
starting with "append" append to them. You can't reconfigure a callback
after resolving it. There's no need to use a macro matching the
handler signatures - use FUNC for everything. Current device is implied
if no tag/finder is supplied (no need for explicit this).
Lambdas are supported, and the memory space and offset are optional.
These kinds of things work:
* .read_cb().set([this] () { return something; });
* .read_cb().set([this] (offs_t offset) { return ~offset; });
* .write_cb().set([this] (offs_t offset, u8 data) { m_array[offset] = data; });
* .write_cb().set([this] (int state) { some_var = state; });
Arbitrary transforms are allowed, and they can modify offset/mask for example:
* .read_cb().set(FUNC(my_state::handler)).transform([] (u8 data) { return bitswap<4>(data, 1, 3, 0, 2); });
* .read_cb().set(m_dev, FUNC(some_device::member)).transform([] (offs_t &offset, u8 data) { offset ^= 3; return data; });
It's possible to stack arbitrary transforms, at the cost of compile
time (the whole transform stack gets inlined at compile time). Shifts
count as an arbitrary transform, but mask/exor does not.
Order of mask/shift/exor now matters. Modifications are applied in the
specified order. These are NOT EQUIVALENT:
* .read_cb().set(FUNC(my_state::handler)).mask(0x06).lshift(2);
* .read_cb().set(FUNC(my_state::handler)).lshift(2).mask(0x06);
The bit helper no longer reverses its behaviour for read callbacks, and
I/O ports are no longer aware of the field mask. Binding a read
callback to no-op is not supported - specify a constant. The GND and
VCC aliases have been removed intentionally - they're TTL-centric, and
were already being abused.
Other quirks have been preserved, including write logger only logging
when the data is non-zero (quite unhelpful in many of the cases where
it's used). Legacy syntax is still supported for simple cases, but will
be phased out. New devices should not have MCFG_ macros.
I don't think I've missed any fundamental issues, but if I've broken
something, let me know.
|
|
|
|
|
|
|
| |
suddenly silenced
* streamline templates in addrmap.h
* get rid of overloads on read/write member names - this will become even more important in the near future
|
|
|
|
|
|
|
|
|
| |
confusing people for far too long. Yes, this is a change in behaviour.
Add a valdiation check for ROMs with BIOS flag set that are
unselectable, fix the things it uncovers.
(nw) Fix other random stuff.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start replacing special device macros with additional constructors,
starting with ISA, INTELLEC 4 and RS-232 buses.
Allow an object finder to take on the target of another object finder.
(For a combination of the previous two things in action, see either the
INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out
looping over a device finder array to instantiate devices in some
places. Lots of things no longer need to pass tags around.)
Start supplying default clocks for things that have a standard clock or
have all clocks internal.
Eliminate the separate DEV versions of the DEVCB_ macros. Previously,
the plain versions were a shortcut for DEVICE_SELF as the target. You
can now supply a string tag (relative to current device being
configured), an object finder (takes on the base and relative tag), or
a reference to a device/interface (only do this if you know the device
won't be replaced out from under it, but that's a safe assumption for
your subdevices). In almost all cases, you can get the effect you want
by supplying *this as the target.
Eliminate sound and CPU versions of macros. They serve no useful
purpose, provide no extra checks, make error messages longer, add
indirection, and mislead newbies into thinking there's a difference.
Remove a lot of now-unnecessary ":" prefixes binding things relative to
machine root.
Clean up some miscellaneous rot.
Examples of new functionality in use in (some more subtle than others):
* src/mame/drivers/intellec4.cpp
* src/mame/drivers/tranz330.cpp
* src/mame/drivers/osboren1.cpp
* src/mame/drivers/zorba.cpp
* src/mame/devices/smioc.cpp
* src/devices/bus/a2bus/pc_xporter.cpp
* src/devices/bus/isa/isa.h
* src/devices/bus/isa/isa.h
* src/devices/bus/intellec4/intellec4.h
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Allows defaulted clocks (see subtle example with vboy)
* Allows additional constructors (see RS232 port in tranz330)
* Allows use of device finder in place of tag in MCFG_DEVICE_ADD
* Requires out-of-line destructor for devices using incomplete types
* Requires XTAL or explicit u32 for clocks for devices with private types
Devices must still define the standard constructor. When writing
additional constructors, be aware that the constructor runs before
device_add_mconfig in the context of the existing device, not the new
device. See osborne1, zorba, tranz330, and vboy for examples of this in
use. Compilation is a bit slower, but this is temporary while
refactoring is in progress.
Eliminated the need for MCFG_SOUND_ROUTE_EX.
Removed macros from slot option configuration - they just obfuscated
code and slowed it down with needless dynamic casts, but didn't actually
simplify it.
|
|
|
|
|
|
| |
That's it for ADDRESS_MAP_START. Please don't try to remove the
macros yet, let's wait for a full release before that so that the
forks can catch up.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCII.
This has not been done unilaterally - I have the support of @galibert,
@Tafoid, and @rb6502 to do something about the current free-for-all.
The trouble with the ROM label field in MAME is that it serves multiple
competing purposes: it's supposed to identify the device in the original
system, and also act as a filename when searching for media image files
to load. It also has to appear in listings of needed/missing files
(e.g. in cases where the image _isn't_ found).
To identify the original device, the ROM label field in MAME often
contains text derived from some combination of one or more of the text
on a label if present, the silkscreen on an IC package, the location on
the circuit board, and the device designation. There's no standard for
the order in which these appear and how they're separated. Some people
add arbitrary filename extensions and other annotations.
There are practical limitations on what can appear in the string, given
it's used as a filename:
* Path/name length limits.
* Restrictions on characters that can appear in a filename.
* Practicality of using the filename in a command-line environment.
* Ambiguity when describing a filename.
Filesystems themselves typically restrict characters in filenames:
* Windows defines MAX_PATH as 260 characters - longer paths are
difficult to use with Win32 APIs and don't work properly in Windows
Explorer
* Most filesystems don't allow ^@ or the path separator in names.
* Windows doesn't allow C0 control characters or <>:"/\|?* characters in
filenames.
* Filesystems may have collation, e.g. FAT16 is case-folding, NTFS and
HFS+ are case-preserving but case-insensitive, while EXT and XFS are
case-sensitive.
* Filesystems may perform Unicode normalisation, e.g. NTFS forces NFC,
HFS+ forces NFD, while ZFS stores filenames as supplied at creation,
but may be configured to apply normalisation when testing equality.
Shells use various ASCII characters for special purposes:
* C0 control characters for line editing and control (e.g. ^C to cancel
a line, ^V for control charecter escape, ^R for history search).
* The "'\ chracaters for quoting/escaping.
* The ><| characters for redirection.
* The *?[] characters for pattern matching.
* The ${}~ characters for variable substitution/sequence expansion.
* The ! or ^ characters for history substitution.
* The ()` characters for controlling subshells.
* The %& characters for job control.
* The ; character as a command separator.
* The # character for comments.
There's also the issue of whether users across a range of locales will
be able to type/display characters. We still don't have good support
for Unicode console output on Windows (std::wcout doesn't seem to work
properly), many users don't install C/J/K fonts, and many users aren't
comfortable entering text in unfamiliar languages. This means we're
limited to printable ASCII for practical purposes.
The practical limitations mean the subset of "safe" characters is
limited to ASCII digits, either uppercase or lowercase English Latin
(but not both due to collation behaving differently across systems), and
the +,-.=_ punctuation chracters. We've decided on lowercase, digits,
and safe punctuation. In addition to this, spaces are allowed, as they
can be quoted/escaped easily enough if no other special characters are
used.
There have been some arguments that allowing uppercase is "more
accurate", but in practical terms it doesn't add much value. A string
in a C++ program can't represent layout, relative size of text, colour
and shape of the label, text font, graphics, and many other details. It
also does nothing to address labels with text outside the English Latin
alphabet (e.g. labels with Chinese ideographs). Besides missing
information, the lack of hard and fast rules means you need to intuit
what a label string in MAME is trying to represent. There is simply no
substitute for photographs. There wasn't even any consistency in case
within individual machine sets. For example, several games in
vigilant.cpp had inconsistent case for "ic" vs "IC" in designation
suffixes, and ibm6850.cpp had inconsistent case for filename extensions
withing a set. There were sets that used uppercase for text from the
label but not from the part number/PCB location, and vice versa. It was
a huge mess.
There's some merit to the idea of allowing a wider variety of characters
in the label strings in the source, and mapping to a more restricted set
when searching for files. However it creates more issues than it
solves. It would require a change to the XML output to provide both the
label and filename, and a corresponding change to external ROM
management tools. It would be impractical to do for software lists,
because it would require ROM management tools to implement the exact
same mapping algorithm as MAME.
But that aside, actually doing useful mapping would be impractical.
What would you do with C/J/K ideographs, like the chip labelled
東方不敗 (Dongfang Bubai)? There's no intuitive way to do the mapping
wtihout incluing something like Unihan data, which would add a lot of
bloat. Even the, without a language hint the Romanisation would be less
than ideal in many cases (using Chinese reading for Japanese text and
vice versa). There's still the messy issue of filesystem collation to
deal with.
We do allow full Unicode in comments in the source. If you want to
provide a more detailed description of a ROM label, that's the place for
it. You've got more characters available, and the possibility of using
mulitple lines. There are too many other competing requirements on the
label field in the ROM definitions.
|
| |
|
|
|
|
|
|
| |
* destaticify initializations (nw)
* fix this->set_screen (nw)
|
| |
|
| |
|
|
|
|
|
| |
Also, a lot more freedom happened, that's going to be more visible
soon.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
prototype is simplified [O. Galibert]
Beware, the device context does not follow in MCFG_FRAGMENT_ADD
anymore due to the prototype change. So creating a device then
configuring through a fragment doesn't work as-is. The simplest
solution is just to add a MCFG_DEVICE_MODIFY at the start of the
fragment with the correct tag.
|
|
|
|
| |
methods. Removed the memory system read/write handler trampolines from the ATA devices as they are not required. (nw)
|
| |
|
| |
|
|
|
|
|
|
| |
allows Alt-combos on European Amiga keyboards to be restored as MAME
will now prefer the simpler Shift-combos to get characters that can be
typed in more than one way
|
| |
|
| |
|
| |
|