diff options
author | 2015-12-25 20:53:59 +0100 | |
---|---|---|
committer | 2015-12-25 20:53:59 +0100 | |
commit | c6d27c753f68cb22d8f88d031ae0645ab80c72b6 (patch) | |
tree | 814fb384b0024aa03da79a806d7674624abace47 /src | |
parent | a8ef53fa51dcc81dbb9a647dfc1777ef72ee2f93 (diff) |
cleanups (nw)
Diffstat (limited to 'src')
169 files changed, 143 insertions, 314 deletions
diff --git a/src/devices/bus/a7800/a78_slot.cpp b/src/devices/bus/a7800/a78_slot.cpp index 7fda107b70c..9fc76685842 100644 --- a/src/devices/bus/a7800/a78_slot.cpp +++ b/src/devices/bus/a7800/a78_slot.cpp @@ -532,7 +532,7 @@ void a78_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "a78_rom"; + const char *slot_string; dynamic_buffer head(128); int type = A78_TYPE0, mapper; diff --git a/src/devices/bus/a7800/a78_slot.h b/src/devices/bus/a7800/a78_slot.h index 4d006c7d94d..2ba457e6274 100644 --- a/src/devices/bus/a7800/a78_slot.h +++ b/src/devices/bus/a7800/a78_slot.h @@ -99,7 +99,6 @@ public: virtual bool call_softlist_load(software_list_device &swlist, const char *swname, const rom_entry *start_entry) override; int get_cart_type() { return m_type; }; - int identify_cart_type(UINT8 *ROM, UINT32 len); bool has_cart() { return m_cart != nullptr; } virtual iodevice_t image_type() const override { return IO_CARTSLOT; } diff --git a/src/devices/bus/a800/a800_slot.cpp b/src/devices/bus/a800/a800_slot.cpp index 148ab38ed03..952975a649a 100644 --- a/src/devices/bus/a800/a800_slot.cpp +++ b/src/devices/bus/a800/a800_slot.cpp @@ -410,7 +410,7 @@ void a800_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "a800_8k"; + const char *slot_string; dynamic_buffer head(0x10); UINT32 len = core_fsize(m_file); int type = A800_8K; @@ -447,7 +447,7 @@ void a5200_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "a5200"; + const char *slot_string; dynamic_buffer head(0x10); UINT32 len = core_fsize(m_file); int type = A5200_8K; @@ -480,7 +480,7 @@ void xegs_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "xegs"; + const char *slot_string; dynamic_buffer head(0x10); UINT32 len = core_fsize(m_file); int type = A800_8K; diff --git a/src/devices/bus/adam/exp.cpp b/src/devices/bus/adam/exp.cpp index a8ac09cf676..2e907aca39a 100644 --- a/src/devices/bus/adam/exp.cpp +++ b/src/devices/bus/adam/exp.cpp @@ -90,7 +90,7 @@ bool adam_expansion_slot_device::call_load() { if (m_card) { - size_t size = 0; + size_t size; if (software_entry() == nullptr) { diff --git a/src/devices/bus/amiga/zorro/buddha.cpp b/src/devices/bus/amiga/zorro/buddha.cpp index 7ea65396afa..6f21e86d9be 100644 --- a/src/devices/bus/amiga/zorro/buddha.cpp +++ b/src/devices/bus/amiga/zorro/buddha.cpp @@ -220,7 +220,7 @@ WRITE_LINE_MEMBER( buddha_device::ide_1_interrupt_w) READ16_MEMBER( buddha_device::ide_0_interrupt_r ) { - UINT16 data = 0xffff; + UINT16 data; data = m_ide_0_interrupt << 15; @@ -234,7 +234,7 @@ READ16_MEMBER( buddha_device::ide_0_interrupt_r ) READ16_MEMBER( buddha_device::ide_1_interrupt_r ) { - UINT16 data = 0xffff; + UINT16 data; data = m_ide_1_interrupt << 15; @@ -255,7 +255,7 @@ WRITE16_MEMBER( buddha_device::ide_interrupt_enable_w ) READ16_MEMBER( buddha_device::ide_0_cs0_r ) { - UINT16 data = 0xffff; + UINT16 data; mem_mask = (mem_mask << 8) | (mem_mask >> 8); data = m_ata_0->read_cs0(space, (offset >> 1) & 0x07, mem_mask); @@ -279,7 +279,7 @@ WRITE16_MEMBER( buddha_device::ide_0_cs0_w ) READ16_MEMBER( buddha_device::ide_0_cs1_r ) { - UINT16 data = 0xffff; + UINT16 data; mem_mask = (mem_mask << 8) | (mem_mask >> 8); data = m_ata_0->read_cs1(space, (offset >> 1) & 0x07, mem_mask); @@ -303,7 +303,7 @@ WRITE16_MEMBER( buddha_device::ide_0_cs1_w ) READ16_MEMBER( buddha_device::ide_1_cs0_r ) { - UINT16 data = 0xffff; + UINT16 data; mem_mask = (mem_mask << 8) | (mem_mask >> 8); data = m_ata_1->read_cs0(space, (offset >> 1) & 0x07, mem_mask); @@ -327,7 +327,7 @@ WRITE16_MEMBER( buddha_device::ide_1_cs0_w ) READ16_MEMBER( buddha_device::ide_1_cs1_r ) { - UINT16 data = 0xffff; + UINT16 data; mem_mask = (mem_mask << 8) | (mem_mask >> 8); data = m_ata_1->read_cs1(space, (offset >> 1) & 0x07, mem_mask); diff --git a/src/devices/bus/apf/slot.cpp b/src/devices/bus/apf/slot.cpp index b94f286798c..89c04a95dc6 100644 --- a/src/devices/bus/apf/slot.cpp +++ b/src/devices/bus/apf/slot.cpp @@ -225,7 +225,7 @@ void apf_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "std"; + const char *slot_string; UINT32 size = core_fsize(m_file); int type = APF_STD; diff --git a/src/devices/bus/astrocde/slot.cpp b/src/devices/bus/astrocde/slot.cpp index 877df4773a0..80b429a18c3 100644 --- a/src/devices/bus/astrocde/slot.cpp +++ b/src/devices/bus/astrocde/slot.cpp @@ -202,7 +202,7 @@ void astrocade_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom"; + const char *slot_string; UINT32 size = core_fsize(m_file); int type = ASTROCADE_STD; diff --git a/src/devices/bus/astrocde/slot.h b/src/devices/bus/astrocde/slot.h index 42e8026305e..76eb2f8ed20 100644 --- a/src/devices/bus/astrocde/slot.h +++ b/src/devices/bus/astrocde/slot.h @@ -30,7 +30,6 @@ public: virtual DECLARE_READ8_MEMBER(read_rom) { return 0xff; } void rom_alloc(UINT32 size, const char *tag); - void ram_alloc(UINT32 size); UINT8* get_rom_base() { return m_rom; } UINT32 get_rom_size() { return m_rom_size; } diff --git a/src/devices/bus/c64/exp.cpp b/src/devices/bus/c64/exp.cpp index 1155cf54d69..8ffc963d0e2 100644 --- a/src/devices/bus/c64/exp.cpp +++ b/src/devices/bus/c64/exp.cpp @@ -117,7 +117,7 @@ bool c64_expansion_slot_device::call_load() { if (m_card) { - size_t size = 0; + size_t size; if (software_entry() == nullptr) { diff --git a/src/devices/bus/c64/geocable.h b/src/devices/bus/c64/geocable.h index 373fcd25a73..6b823b9a668 100644 --- a/src/devices/bus/c64/geocable.h +++ b/src/devices/bus/c64/geocable.h @@ -51,8 +51,6 @@ protected: private: required_device<centronics_device> m_centronics; - - void update_output(); }; diff --git a/src/devices/bus/c64/magic_voice.h b/src/devices/bus/c64/magic_voice.h index cfcd2aaded8..f5e8af19e59 100644 --- a/src/devices/bus/c64/magic_voice.h +++ b/src/devices/bus/c64/magic_voice.h @@ -40,8 +40,6 @@ public: DECLARE_WRITE8_MEMBER( tpi_pa_w ); DECLARE_READ8_MEMBER( tpi_pb_r ); DECLARE_WRITE8_MEMBER( tpi_pb_w ); - DECLARE_READ8_MEMBER( tpi_pc_r ); - DECLARE_WRITE8_MEMBER( tpi_pc_w ); DECLARE_WRITE_LINE_MEMBER( tpi_ca_w ); DECLARE_WRITE_LINE_MEMBER( tpi_cb_w ); diff --git a/src/devices/bus/cbm2/exp.cpp b/src/devices/bus/cbm2/exp.cpp index 4eb95e81bb2..8e9c03c022a 100644 --- a/src/devices/bus/cbm2/exp.cpp +++ b/src/devices/bus/cbm2/exp.cpp @@ -103,7 +103,7 @@ void cbm2_expansion_slot_device::device_reset() bool cbm2_expansion_slot_device::call_load() { - size_t size = 0; + size_t size; if (m_card) { diff --git a/src/devices/bus/cbm2/hrg.h b/src/devices/bus/cbm2/hrg.h index 604229e9da4..25f68a5c7a2 100644 --- a/src/devices/bus/cbm2/hrg.h +++ b/src/devices/bus/cbm2/hrg.h @@ -28,8 +28,7 @@ class cbm2_graphic_cartridge_device : public device_t, public: // construction/destruction cbm2_graphic_cartridge_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); - cbm2_graphic_cartridge_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/cbmiec/c1541.cpp b/src/devices/bus/cbmiec/c1541.cpp index a25aa7a434f..3259f4aa3ff 100644 --- a/src/devices/bus/cbmiec/c1541.cpp +++ b/src/devices/bus/cbmiec/c1541.cpp @@ -590,7 +590,7 @@ READ8_MEMBER( c1541_base_t::via0_pb_r ) */ - UINT8 data = 0; + UINT8 data; // data in data = !m_bus->data_r() && !m_ga->atn_r(); diff --git a/src/devices/bus/cbmiec/c1571.cpp b/src/devices/bus/cbmiec/c1571.cpp index 97ec044b271..82a688abce3 100644 --- a/src/devices/bus/cbmiec/c1571.cpp +++ b/src/devices/bus/cbmiec/c1571.cpp @@ -303,7 +303,7 @@ READ8_MEMBER( c1571_t::via0_pb_r ) */ - UINT8 data = 0; + UINT8 data; // data in data = !m_bus->data_r(); diff --git a/src/devices/bus/cbmiec/c1571.h b/src/devices/bus/cbmiec/c1571.h index fde13dd0b66..cd0da9a3a3d 100644 --- a/src/devices/bus/cbmiec/c1571.h +++ b/src/devices/bus/cbmiec/c1571.h @@ -73,8 +73,6 @@ public: DECLARE_WRITE_LINE_MEMBER( byte_w ); - DECLARE_WRITE_LINE_MEMBER( wpt_w ); - DECLARE_FLOPPY_FORMATS( floppy_formats ); void wpt_callback(floppy_image_device *floppy, int state); diff --git a/src/devices/bus/cbmiec/c1581.cpp b/src/devices/bus/cbmiec/c1581.cpp index 33bc082241e..60ae856901f 100644 --- a/src/devices/bus/cbmiec/c1581.cpp +++ b/src/devices/bus/cbmiec/c1581.cpp @@ -192,7 +192,7 @@ READ8_MEMBER( c1581_t::cia_pb_r ) */ - UINT8 data = 0; + UINT8 data; // data in data = !m_bus->data_r(); diff --git a/src/devices/bus/centronics/epson_ex800.h b/src/devices/bus/centronics/epson_ex800.h index 23d960a055a..26d862cf098 100644 --- a/src/devices/bus/centronics/epson_ex800.h +++ b/src/devices/bus/centronics/epson_ex800.h @@ -30,8 +30,7 @@ class epson_ex800_t : public device_t, public: // construction/destruction epson_ex800_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - epson_ex800_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; virtual machine_config_constructor device_mconfig_additions() const override; diff --git a/src/devices/bus/cgenie/expansion/floppy.h b/src/devices/bus/cgenie/expansion/floppy.h index a85f26a68fe..540b2febebe 100644 --- a/src/devices/bus/cgenie/expansion/floppy.h +++ b/src/devices/bus/cgenie/expansion/floppy.h @@ -50,8 +50,6 @@ protected: virtual void device_reset() override; private: - void update_irq(); - required_device<fd1793_t> m_fdc; required_device<floppy_connector> m_floppy0; required_device<floppy_connector> m_floppy1; diff --git a/src/devices/bus/chanf/slot.cpp b/src/devices/bus/chanf/slot.cpp index f46abf3b7c3..a533c85bb05 100644 --- a/src/devices/bus/chanf/slot.cpp +++ b/src/devices/bus/chanf/slot.cpp @@ -221,7 +221,7 @@ void channelf_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "chess"; + const char *slot_string; UINT32 len = core_fsize(m_file); int type; diff --git a/src/devices/bus/coco/coco_fdc.cpp b/src/devices/bus/coco/coco_fdc.cpp index f510993473d..6e434ea3e0a 100644 --- a/src/devices/bus/coco/coco_fdc.cpp +++ b/src/devices/bus/coco/coco_fdc.cpp @@ -266,7 +266,7 @@ void coco_fdc_device::update_lines() void coco_fdc_device::dskreg_w(UINT8 data) { UINT8 drive = 0; - UINT8 head = 0; + UINT8 head; if (LOG_FDC) { diff --git a/src/devices/bus/coco/cococart.cpp b/src/devices/bus/coco/cococart.cpp index e3f25389eb1..9943378996c 100644 --- a/src/devices/bus/coco/cococart.cpp +++ b/src/devices/bus/coco/cococart.cpp @@ -160,7 +160,7 @@ WRITE8_MEMBER(cococart_slot_device::write) static const char *line_value_string(cococart_line_value value) { - const char *s = nullptr; + const char *s; switch(value) { case COCOCART_LINE_VALUE_CLEAR: @@ -326,7 +326,7 @@ bool cococart_slot_device::call_load() { if (m_cart) { - offs_t read_length = 0; + offs_t read_length; if (software_entry() == nullptr) { read_length = fread(m_cart->get_cart_base(), 0x8000); diff --git a/src/devices/bus/crvision/slot.cpp b/src/devices/bus/crvision/slot.cpp index 207105ea1d6..5953c1c5cb6 100644 --- a/src/devices/bus/crvision/slot.cpp +++ b/src/devices/bus/crvision/slot.cpp @@ -233,7 +233,7 @@ void crvision_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "crv_rom4k"; + const char *slot_string; UINT32 size = core_fsize(m_file); int type = CRV_4K; diff --git a/src/devices/bus/econet/e01.cpp b/src/devices/bus/econet/e01.cpp index 162e8c7f6d6..8593dc235c9 100644 --- a/src/devices/bus/econet/e01.cpp +++ b/src/devices/bus/econet/e01.cpp @@ -482,7 +482,7 @@ void e01_device::device_timer(emu_timer &timer, device_timer_id id, int param, v READ8_MEMBER( e01_device::read ) { - UINT8 data = 0; + UINT8 data; if (m_ram_en) { diff --git a/src/devices/bus/econet/e01.h b/src/devices/bus/econet/e01.h index 07c84969239..e83b9a0b6bd 100644 --- a/src/devices/bus/econet/e01.h +++ b/src/devices/bus/econet/e01.h @@ -47,7 +47,6 @@ public: DECLARE_WRITE8_MEMBER( network_irq_enable_w ); DECLARE_READ8_MEMBER( hdc_data_r ); DECLARE_WRITE8_MEMBER( hdc_data_w ); - DECLARE_READ8_MEMBER( hdc_status_r ); DECLARE_WRITE8_MEMBER( hdc_select_w ); DECLARE_WRITE8_MEMBER( hdc_irq_enable_w ); DECLARE_READ8_MEMBER( rtc_address_r ); diff --git a/src/devices/bus/gameboy/gb_slot.cpp b/src/devices/bus/gameboy/gb_slot.cpp index e70eb07c6d2..32e0f46db29 100644 --- a/src/devices/bus/gameboy/gb_slot.cpp +++ b/src/devices/bus/gameboy/gb_slot.cpp @@ -262,7 +262,7 @@ bool base_gb_cart_slot_device::call_load() { if (m_cart) { - UINT32 offset = 0; + UINT32 offset; UINT32 len = (software_entry() == nullptr) ? length() : get_software_region_length("rom"); UINT8 *ROM; int rambanks = 0; @@ -604,7 +604,7 @@ void base_gb_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom"; + const char *slot_string; UINT32 len = core_fsize(m_file), offset = 0; dynamic_buffer rom(len); int type; @@ -793,7 +793,7 @@ void base_gb_cart_slot_device::internal_header_logging(UINT8 *ROM, UINT32 len) static const int ramsize[8] = { 0, 2, 8, 32, 128, 64, 0, 0 }; char soft[17]; - UINT32 tmp = 0; + UINT32 tmp; int csum = 0, i = 0; int rom_banks; diff --git a/src/devices/bus/gba/gba_slot.cpp b/src/devices/bus/gba/gba_slot.cpp index 4e7c9f62060..82ef6663a93 100644 --- a/src/devices/bus/gba/gba_slot.cpp +++ b/src/devices/bus/gba/gba_slot.cpp @@ -404,7 +404,7 @@ void gba_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "gba_rom"; + const char *slot_string; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type; diff --git a/src/devices/bus/gba/gba_slot.h b/src/devices/bus/gba/gba_slot.h index 107334004ac..339be075733 100644 --- a/src/devices/bus/gba/gba_slot.h +++ b/src/devices/bus/gba/gba_slot.h @@ -76,7 +76,6 @@ public: int get_type() { return m_type; } int get_cart_type(UINT8 *ROM, UINT32 len); - void setup_ram(UINT8 banks); void internal_header_logging(UINT8 *ROM, UINT32 len); void save_nvram() { if (m_cart && m_cart->get_nvram_size()) m_cart->save_nvram(); } diff --git a/src/devices/bus/ieee488/c2040.h b/src/devices/bus/ieee488/c2040.h index ef62555f1b9..74539e6524d 100644 --- a/src/devices/bus/ieee488/c2040.h +++ b/src/devices/bus/ieee488/c2040.h @@ -47,8 +47,6 @@ public: DECLARE_READ8_MEMBER( riot1_pb_r ); DECLARE_WRITE8_MEMBER( riot1_pb_w ); DECLARE_WRITE8_MEMBER( via_pb_w ); - DECLARE_WRITE_LINE_MEMBER( mode_sel_w ); - DECLARE_WRITE_LINE_MEMBER( rw_sel_w ); DECLARE_FLOPPY_FORMATS( floppy_formats ); diff --git a/src/devices/bus/ieee488/c8050.h b/src/devices/bus/ieee488/c8050.h index 3dd65dfc742..71bd9ae42cf 100644 --- a/src/devices/bus/ieee488/c8050.h +++ b/src/devices/bus/ieee488/c8050.h @@ -47,8 +47,6 @@ public: DECLARE_READ8_MEMBER( riot1_pb_r ); DECLARE_WRITE8_MEMBER( riot1_pb_w ); DECLARE_WRITE8_MEMBER( via_pb_w ); - DECLARE_READ8_MEMBER( pi_r ); - DECLARE_WRITE8_MEMBER( pi_w ); DECLARE_FLOPPY_FORMATS( floppy_formats ); diff --git a/src/devices/bus/ieee488/d9060.h b/src/devices/bus/ieee488/d9060.h index e5681dae310..104daec4a11 100644 --- a/src/devices/bus/ieee488/d9060.h +++ b/src/devices/bus/ieee488/d9060.h @@ -52,7 +52,6 @@ public: DECLARE_WRITE8_MEMBER( riot1_pa_w ); DECLARE_READ8_MEMBER( riot1_pb_r ); DECLARE_WRITE8_MEMBER( riot1_pb_w ); - DECLARE_READ8_MEMBER( via_pb_r ); DECLARE_WRITE8_MEMBER( via_pb_w ); DECLARE_WRITE_LINE_MEMBER( ack_w ); DECLARE_WRITE_LINE_MEMBER( enable_w ); diff --git a/src/devices/bus/imi7000/imi7000.h b/src/devices/bus/imi7000/imi7000.h index 391899a63f9..e374fedb6d9 100644 --- a/src/devices/bus/imi7000/imi7000.h +++ b/src/devices/bus/imi7000/imi7000.h @@ -76,8 +76,6 @@ public: // construction/destruction imi7000_bus_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - void add_device(imi7000_slot_device *slot, device_t *target); - protected: // device-level overrides virtual void device_start() override; diff --git a/src/devices/bus/intv/slot.cpp b/src/devices/bus/intv/slot.cpp index 05e55e49318..3cb214753f0 100644 --- a/src/devices/bus/intv/slot.cpp +++ b/src/devices/bus/intv/slot.cpp @@ -409,8 +409,8 @@ bool intv_cart_slot_device::call_load() if (m_type == INTV_WSMLB) extra_bank = true; - UINT32 size = 0; - UINT16 address = 0; + UINT32 size; + UINT16 address; UINT8 *ROM, *region; m_cart->rom_alloc(extra_bank ? 0x22000 : 0x20000, tag()); @@ -463,7 +463,7 @@ void intv_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "intv_rom"; + const char *slot_string; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type = INTV_STD; diff --git a/src/devices/bus/iq151/iq151.cpp b/src/devices/bus/iq151/iq151.cpp index de7f9355cb3..1a3f2d3018f 100644 --- a/src/devices/bus/iq151/iq151.cpp +++ b/src/devices/bus/iq151/iq151.cpp @@ -167,7 +167,7 @@ bool iq151cart_slot_device::call_load() { if (m_cart) { - offs_t read_length = 0; + offs_t read_length; UINT8 *cart_base = m_cart->get_cart_base(); if (cart_base != nullptr) diff --git a/src/devices/bus/isa/3c505.h b/src/devices/bus/isa/3c505.h index 36b90369540..e31317792da 100644 --- a/src/devices/bus/isa/3c505.h +++ b/src/devices/bus/isa/3c505.h @@ -212,8 +212,6 @@ private: void log_command(); void log_response(); - void log_tx_data(); - void log_rx_data(); void do_receive_command(); void set_command_pending(int onoff); diff --git a/src/devices/bus/isa/aga.cpp b/src/devices/bus/isa/aga.cpp index 1e798680b58..9146f2ce581 100644 --- a/src/devices/bus/isa/aga.cpp +++ b/src/devices/bus/isa/aga.cpp @@ -985,7 +985,7 @@ WRITE8_MEMBER( isa8_aga_pc200_device::pc200_cga_w ) READ8_MEMBER ( isa8_aga_pc200_device::pc200_cga_r ) { - UINT8 result = 0xff; + UINT8 result; switch(offset) { case 8: diff --git a/src/devices/bus/isa/ega.cpp b/src/devices/bus/isa/ega.cpp index 762f1d05a77..85d943b92ac 100644 --- a/src/devices/bus/isa/ega.cpp +++ b/src/devices/bus/isa/ega.cpp @@ -854,7 +854,7 @@ CRTC_EGA_ROW_UPDATE( isa8_ega_device::pc_ega_text ) UINT16 offset = ma + i; UINT8 chr = m_plane[0][ offset ]; UINT8 attr = m_plane[1][ offset ]; - UINT8 data = 0; + UINT8 data; UINT16 fg = m_attribute.data[ attr & 0x07 ]; UINT16 bg = m_attribute.data[ ( attr >> 4 ) & 0x07 ]; @@ -1329,7 +1329,7 @@ WRITE8_MEMBER(isa8_ega_device::pc_ega8_3c0_w ) 0x0F, 0x0F, 0x0F, 0x1F, 0x07, 0x3F, 0x0F, 0x0F, 0xFF, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; - int index = 0; + int index; if ( VERBOSE_EGA ) { diff --git a/src/devices/bus/isa/gus.cpp b/src/devices/bus/isa/gus.cpp index 2a8edf69145..2928aaa252c 100644 --- a/src/devices/bus/isa/gus.cpp +++ b/src/devices/bus/isa/gus.cpp @@ -479,7 +479,7 @@ WRITE8_MEMBER(gf1_device::global_reg_select_w) READ8_MEMBER(gf1_device::global_reg_data_r) { - UINT16 ret = 0x00; + UINT16 ret; switch(m_current_reg) { @@ -1430,7 +1430,7 @@ READ8_MEMBER(isa16_gus_device::joy_r) { if(offset == 1) { - UINT8 data = 0; + UINT8 data; int delta; attotime new_time = machine().time(); diff --git a/src/devices/bus/isa/hdc.cpp b/src/devices/bus/isa/hdc.cpp index e7b386b2f7b..7708d341abd 100644 --- a/src/devices/bus/isa/hdc.cpp +++ b/src/devices/bus/isa/hdc.cpp @@ -430,7 +430,7 @@ void xt_hdc_device::dack_ws(int data) void xt_hdc_device::execute_read() { - hard_disk_file *disk = nullptr; + hard_disk_file *disk; int size = sector_cnt[drv] * 512; int read_ = 0; @@ -460,7 +460,7 @@ void xt_hdc_device::execute_read() void xt_hdc_device::execute_write() { - hard_disk_file *disk = nullptr; + hard_disk_file *disk; int size = sector_cnt[drv] * 512; int write_ = 512; diff --git a/src/devices/bus/isa/ibm_mfc.cpp b/src/devices/bus/isa/ibm_mfc.cpp index 2bc6c513ace..b6445c9385f 100644 --- a/src/devices/bus/isa/ibm_mfc.cpp +++ b/src/devices/bus/isa/ibm_mfc.cpp @@ -313,7 +313,7 @@ MACHINE_CONFIG_END READ8_MEMBER( isa8_ibm_mfc_device::ibm_mfc_r ) { - UINT8 val = 0xff; + UINT8 val; switch (offset) { diff --git a/src/devices/bus/isa/omti8621.cpp b/src/devices/bus/isa/omti8621.cpp index 8e41becfccc..5f42c31200b 100644 --- a/src/devices/bus/isa/omti8621.cpp +++ b/src/devices/bus/isa/omti8621.cpp @@ -273,7 +273,7 @@ const rom_entry *omti8621_apollo_device::device_rom_region() const { // OMTI 8621 boards for Apollo workstations never use a BIOS ROM // They don't even have a socket for the BIOS ROM - return NULL; + return nullptr; } ioport_constructor omti8621_device::device_input_ports() const @@ -1239,7 +1239,7 @@ UINT32 omti8621_apollo_device::get_sector(INT32 diskaddr, UINT8 *data_buffer, UI { omti_disk_image_device *disk = our_disks[lun]; - if (disk == NULL || disk->m_image == NULL || !disk->m_image->exists()) + if (disk == nullptr || disk->m_image == nullptr || !disk->m_image->exists()) { return 0; } diff --git a/src/devices/bus/isa/sc499.cpp b/src/devices/bus/isa/sc499.cpp index 0e0c6438410..d7ab74f50c0 100644 --- a/src/devices/bus/isa/sc499.cpp +++ b/src/devices/bus/isa/sc499.cpp @@ -1085,7 +1085,7 @@ void sc499_device::eop_w(int state) UINT8 sc499_device::dack_r(int line) { - UINT8 data = 0xff; + UINT8 data; // set_dma_drq(CLEAR_LINE); diff --git a/src/devices/bus/isa/sc499.h b/src/devices/bus/isa/sc499.h index d8c347e2859..db412af926b 100644 --- a/src/devices/bus/isa/sc499.h +++ b/src/devices/bus/isa/sc499.h @@ -63,8 +63,6 @@ public: // construction/destruction sc499_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - int sc499_receive(const UINT8 data[], int length); - required_ioport m_iobase; required_ioport m_irqdrq; diff --git a/src/devices/bus/kc/kc.cpp b/src/devices/bus/kc/kc.cpp index b87e3f34314..fdd2de706e6 100644 --- a/src/devices/bus/kc/kc.cpp +++ b/src/devices/bus/kc/kc.cpp @@ -333,7 +333,7 @@ bool kccart_slot_device::call_load() { if (m_cart) { - offs_t read_length = 0; + offs_t read_length; UINT8 *cart_base = m_cart->get_cart_base(); if (cart_base != nullptr) diff --git a/src/devices/bus/lpci/i82439tx.cpp b/src/devices/bus/lpci/i82439tx.cpp index ceee9a4a032..e2c64f49473 100644 --- a/src/devices/bus/lpci/i82439tx.cpp +++ b/src/devices/bus/lpci/i82439tx.cpp @@ -55,7 +55,7 @@ void i82439tx_device::i82439tx_configure_memory(UINT8 val, offs_t begin, offs_t UINT32 i82439tx_device::pci_read(pci_bus_device *pcibus, int function, int offset, UINT32 mem_mask) { - UINT32 result = 0; + UINT32 result; if (function != 0) return 0; diff --git a/src/devices/bus/macpds/macpds.h b/src/devices/bus/macpds/macpds.h index f1a67dfc1be..db572d553f2 100644 --- a/src/devices/bus/macpds/macpds.h +++ b/src/devices/bus/macpds/macpds.h @@ -118,7 +118,6 @@ public: void set_macpds_device(); // helper functions for card devices - void install_declaration_rom(device_t *dev, const char *romregion, bool mirror_all_mb = false, bool reverse_rom = false); void install_bank(offs_t start, offs_t end, offs_t mask, offs_t mirror, const char *tag, UINT8 *data); void install_rom(device_t *dev, const char *romregion, UINT32 addr); diff --git a/src/devices/bus/megadrive/md_slot.cpp b/src/devices/bus/megadrive/md_slot.cpp index 2d0ff90acb6..f1a5700b0e1 100644 --- a/src/devices/bus/megadrive/md_slot.cpp +++ b/src/devices/bus/megadrive/md_slot.cpp @@ -904,7 +904,7 @@ void base_md_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom"; + const char *slot_string; UINT32 len = core_fsize(m_file), offset = 0; dynamic_buffer rom(len); int type; diff --git a/src/devices/bus/megadrive/rom.cpp b/src/devices/bus/megadrive/rom.cpp index 5af9f0a64a2..2ce6d353e35 100644 --- a/src/devices/bus/megadrive/rom.cpp +++ b/src/devices/bus/megadrive/rom.cpp @@ -597,7 +597,7 @@ READ16_MEMBER(md_rom_chinf3_device::read) and the writes made at the start of the game.. */ if (offset >= 0x400000/2 && offset < 0x500000/2) { - UINT32 retdat = 0; + UINT32 retdat; /* 04dc10 chifi3, prot_r? 2800 04cefa chifi3, prot_r? 65262 diff --git a/src/devices/bus/neogeo/bootleg_prot.cpp b/src/devices/bus/neogeo/bootleg_prot.cpp index a577528e271..8c023f00091 100644 --- a/src/devices/bus/neogeo/bootleg_prot.cpp +++ b/src/devices/bus/neogeo/bootleg_prot.cpp @@ -1033,7 +1033,7 @@ void ngbootleg_prot_device::matrimbl_decrypt(UINT8* sprrom, UINT32 sprrom_size, /* decrypt Z80 */ UINT8 *rom = audiorom+0x10000; dynamic_buffer buf( 0x20000 ); - int i, j=0; + int i, j; memcpy( &buf[0], rom, 0x20000 ); for( i=0x00000; i<0x20000; i++ ) { diff --git a/src/devices/bus/nes/act53.cpp b/src/devices/bus/nes/act53.cpp index b0f7a8dae23..225be65d449 100644 --- a/src/devices/bus/nes/act53.cpp +++ b/src/devices/bus/nes/act53.cpp @@ -105,7 +105,7 @@ void nes_action53_device::pcb_reset() void nes_action53_device::update_prg() { - UINT8 prg_lo = 0, prg_hi = 0, helper = 0; + UINT8 prg_lo, prg_hi, helper; UINT8 out = (m_reg[3] & 0x3f) << 1; // Outer PRG reg UINT8 size = (m_reg[2] & 0x30) >> 4; // Game size UINT8 mask = (1 << (size + 1)) - 1; // Bits to be taken from PRG reg diff --git a/src/devices/bus/nes/aladdin.cpp b/src/devices/bus/nes/aladdin.cpp index 3022bd49f0a..ff3598d9052 100644 --- a/src/devices/bus/nes/aladdin.cpp +++ b/src/devices/bus/nes/aladdin.cpp @@ -97,7 +97,7 @@ bool nes_aladdin_slot_device::call_load() if (m_cart) { UINT8 *ROM = m_cart->get_cart_base(); - UINT32 size = 0; + UINT32 size; if (!ROM) return IMAGE_INIT_FAIL; diff --git a/src/devices/bus/nes/bootleg.cpp b/src/devices/bus/nes/bootleg.cpp index 87910440771..5ae9729db14 100644 --- a/src/devices/bus/nes/bootleg.cpp +++ b/src/devices/bus/nes/bootleg.cpp @@ -978,7 +978,7 @@ WRITE8_MEMBER(nes_smb2j_device::write_ex) if (offset == 2) { - int temp = 0; + int temp; // According to hardware tests if (data & 1) diff --git a/src/devices/bus/nes/disksys.cpp b/src/devices/bus/nes/disksys.cpp index d517b7d4a67..38b24438408 100644 --- a/src/devices/bus/nes/disksys.cpp +++ b/src/devices/bus/nes/disksys.cpp @@ -289,7 +289,7 @@ WRITE8_MEMBER(nes_disksys_device::write_ex) READ8_MEMBER(nes_disksys_device::read_ex) { LOG_MMC(("Famicom Disk System read_ex, offset: %04x\n", offset)); - UINT8 ret = 0x00; + UINT8 ret; if (offset >= 0x20 && offset < 0x60) { diff --git a/src/devices/bus/nes/mmc5.h b/src/devices/bus/nes/mmc5.h index 9bf73c9ac4b..44569d3d561 100644 --- a/src/devices/bus/nes/mmc5.h +++ b/src/devices/bus/nes/mmc5.h @@ -32,7 +32,6 @@ public: protected: void set_mirror(int page, int src); - void update_render_mode(); void update_prg(); inline UINT8 base_chr_r(int bank, UINT32 offset); diff --git a/src/devices/bus/nes_ctrl/arkpaddle.cpp b/src/devices/bus/nes_ctrl/arkpaddle.cpp index 5e7e6bc992e..15755d283ca 100644 --- a/src/devices/bus/nes_ctrl/arkpaddle.cpp +++ b/src/devices/bus/nes_ctrl/arkpaddle.cpp @@ -103,7 +103,7 @@ UINT8 nes_vaus_device::read_bit34() UINT8 nes_vausfc_device::read_exp(offs_t offset) { - UINT8 ret = 0; + UINT8 ret; if (offset == 0) //$4016 ret = m_button->read() << 1; else //$4017 diff --git a/src/devices/bus/nubus/nubus_image.cpp b/src/devices/bus/nubus/nubus_image.cpp index 037414d2cef..412925fc351 100644 --- a/src/devices/bus/nubus/nubus_image.cpp +++ b/src/devices/bus/nubus/nubus_image.cpp @@ -271,7 +271,7 @@ READ32_MEMBER( nubus_image_device::image_super_r ) WRITE32_MEMBER( nubus_image_device::file_cmd_w ) { - const osd_directory_entry *dp = nullptr; + const osd_directory_entry *dp; char fullpath[1024]; UINT64 filesize; diff --git a/src/devices/bus/odyssey2/slot.cpp b/src/devices/bus/odyssey2/slot.cpp index e4d3f4c8d3c..fe12540494f 100644 --- a/src/devices/bus/odyssey2/slot.cpp +++ b/src/devices/bus/odyssey2/slot.cpp @@ -213,7 +213,7 @@ void o2_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "o2_rom"; + const char *slot_string; UINT32 size = core_fsize(m_file); int type = O2_STD; diff --git a/src/devices/bus/pce/pce_slot.cpp b/src/devices/bus/pce/pce_slot.cpp index 254993a4714..913f22110b8 100644 --- a/src/devices/bus/pce/pce_slot.cpp +++ b/src/devices/bus/pce/pce_slot.cpp @@ -226,7 +226,7 @@ bool pce_cart_slot_device::call_load() { if (m_cart) { - UINT32 offset = 0; + UINT32 offset; UINT32 len = (software_entry() == nullptr) ? length() : get_software_region_length("rom"); UINT8 *ROM; @@ -343,7 +343,7 @@ void pce_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom"; + const char *slot_string; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type; diff --git a/src/devices/bus/pce/pce_slot.h b/src/devices/bus/pce/pce_slot.h index cb9036b02c7..2b859d7236f 100644 --- a/src/devices/bus/pce/pce_slot.h +++ b/src/devices/bus/pce/pce_slot.h @@ -73,7 +73,6 @@ public: int get_type() { return m_type; } int get_cart_type(UINT8 *ROM, UINT32 len); - void setup_ram(UINT8 banks); void internal_header_logging(UINT8 *ROM, UINT32 len); void set_intf(const char * interface) { m_interface = interface; } diff --git a/src/devices/bus/pet/64k.cpp b/src/devices/bus/pet/64k.cpp index 4bc9c01d596..dfdc278a77d 100644 --- a/src/devices/bus/pet/64k.cpp +++ b/src/devices/bus/pet/64k.cpp @@ -28,7 +28,7 @@ const device_type PET_64K = &device_creator<pet_64k_expansion_device>; inline UINT8 pet_64k_expansion_device::read_ram(offs_t offset) { - UINT8 data = 0; + UINT8 data; if (offset < 0xc000) { diff --git a/src/devices/bus/pet/hsg.h b/src/devices/bus/pet/hsg.h index 3b5dcaeb9ee..30f958f74b1 100644 --- a/src/devices/bus/pet/hsg.h +++ b/src/devices/bus/pet/hsg.h @@ -28,8 +28,7 @@ class cbm8000_hsg_t : public device_t, public: // construction/destruction cbm8000_hsg_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); - cbm8000_hsg_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/plus4/c1551.h b/src/devices/bus/plus4/c1551.h index 04a8a1a7a47..af10e75daed 100644 --- a/src/devices/bus/plus4/c1551.h +++ b/src/devices/bus/plus4/c1551.h @@ -45,13 +45,9 @@ public: DECLARE_WRITE8_MEMBER( tcbm_data_w ); DECLARE_READ8_MEMBER( tpi0_r ); DECLARE_WRITE8_MEMBER( tpi0_w ); - DECLARE_READ8_MEMBER( yb_r ); - DECLARE_WRITE8_MEMBER( yb_w ); DECLARE_READ8_MEMBER( tpi0_pc_r ); DECLARE_WRITE8_MEMBER( tpi0_pc_w ); - DECLARE_READ8_MEMBER( tpi1_pa_r ); - DECLARE_WRITE8_MEMBER( tpi1_pa_w ); DECLARE_READ8_MEMBER( tpi1_pb_r ); DECLARE_READ8_MEMBER( tpi1_pc_r ); DECLARE_WRITE8_MEMBER( tpi1_pc_w ); diff --git a/src/devices/bus/ql/cst_q_plus4.h b/src/devices/bus/ql/cst_q_plus4.h index 29437632b1a..03ba20bef06 100644 --- a/src/devices/bus/ql/cst_q_plus4.h +++ b/src/devices/bus/ql/cst_q_plus4.h @@ -28,8 +28,7 @@ class cst_q_plus4_t : public device_t, public: // construction/destruction cst_q_plus4_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - cst_q_plus4_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; virtual machine_config_constructor device_mconfig_additions() const override; diff --git a/src/devices/bus/ql/cst_qdisc.h b/src/devices/bus/ql/cst_qdisc.h index ec9f5a253e9..35fe9f6e257 100644 --- a/src/devices/bus/ql/cst_qdisc.h +++ b/src/devices/bus/ql/cst_qdisc.h @@ -27,8 +27,7 @@ class cst_ql_disc_interface_t : public device_t, public: // construction/destruction cst_ql_disc_interface_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - cst_ql_disc_interface_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/cumana_fdi.h b/src/devices/bus/ql/cumana_fdi.h index fa3d0d0a7ae..eb9c75f991e 100644 --- a/src/devices/bus/ql/cumana_fdi.h +++ b/src/devices/bus/ql/cumana_fdi.h @@ -27,8 +27,7 @@ class cumana_floppy_disk_interface_t : public device_t, public: // construction/destruction cumana_floppy_disk_interface_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - cumana_floppy_disk_interface_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/kempston_di.h b/src/devices/bus/ql/kempston_di.h index f0fe15a0f34..97082e1a68e 100644 --- a/src/devices/bus/ql/kempston_di.h +++ b/src/devices/bus/ql/kempston_di.h @@ -27,8 +27,7 @@ class kempston_disk_interface_t : public device_t, public: // construction/destruction kempston_disk_interface_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - kempston_disk_interface_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/miracle_gold_card.h b/src/devices/bus/ql/miracle_gold_card.h index 694ce2af578..c60f490c6d9 100644 --- a/src/devices/bus/ql/miracle_gold_card.h +++ b/src/devices/bus/ql/miracle_gold_card.h @@ -27,8 +27,7 @@ class miracle_gold_card_t : public device_t, public: // construction/destruction miracle_gold_card_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - miracle_gold_card_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/miracle_hd.h b/src/devices/bus/ql/miracle_hd.h index df4dc99a47b..7c24af7aa95 100644 --- a/src/devices/bus/ql/miracle_hd.h +++ b/src/devices/bus/ql/miracle_hd.h @@ -27,8 +27,7 @@ class miracle_hard_disk_t : public device_t, public: // construction/destruction miracle_hard_disk_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - miracle_hard_disk_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/mp_fdi.h b/src/devices/bus/ql/mp_fdi.h index d5e485ba3af..a064ffcff86 100644 --- a/src/devices/bus/ql/mp_fdi.h +++ b/src/devices/bus/ql/mp_fdi.h @@ -27,8 +27,7 @@ class micro_peripherals_floppy_disk_interface_t : public device_t, public: // construction/destruction micro_peripherals_floppy_disk_interface_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - micro_peripherals_floppy_disk_interface_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/opd_basic_master.h b/src/devices/bus/ql/opd_basic_master.h index 3edf027fe92..793bfeb9370 100644 --- a/src/devices/bus/ql/opd_basic_master.h +++ b/src/devices/bus/ql/opd_basic_master.h @@ -27,8 +27,7 @@ class opd_basic_master_t : public device_t, public: // construction/destruction opd_basic_master_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - opd_basic_master_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/pcml_qdisk.h b/src/devices/bus/ql/pcml_qdisk.h index a4062c8ab9f..47cbe4ab85e 100644 --- a/src/devices/bus/ql/pcml_qdisk.h +++ b/src/devices/bus/ql/pcml_qdisk.h @@ -27,8 +27,7 @@ class pcml_q_disk_interface_t : public device_t, public: // construction/destruction pcml_q_disk_interface_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - pcml_q_disk_interface_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; diff --git a/src/devices/bus/ql/qubide.h b/src/devices/bus/ql/qubide.h index 29e1fde3fa8..d64b05cf742 100644 --- a/src/devices/bus/ql/qubide.h +++ b/src/devices/bus/ql/qubide.h @@ -28,8 +28,7 @@ class qubide_t : public device_t, public: // construction/destruction qubide_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - qubide_t(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source, int ram_size); - + // optional information overrides virtual const rom_entry *device_rom_region() const override; virtual machine_config_constructor device_mconfig_additions() const override; diff --git a/src/devices/bus/ql/rom.cpp b/src/devices/bus/ql/rom.cpp index 6474957a7da..3a1dc4dd171 100644 --- a/src/devices/bus/ql/rom.cpp +++ b/src/devices/bus/ql/rom.cpp @@ -79,7 +79,7 @@ bool ql_rom_cartridge_slot_t::call_load() { if (m_card) { - size_t size = 0; + size_t size; if (software_entry() == nullptr) { diff --git a/src/devices/bus/rs232/keyboard.h b/src/devices/bus/rs232/keyboard.h index 38d9dfbc56e..37e2097b8fb 100644 --- a/src/devices/bus/rs232/keyboard.h +++ b/src/devices/bus/rs232/keyboard.h @@ -18,7 +18,6 @@ public: serial_keyboard_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); virtual DECLARE_WRITE_LINE_MEMBER( input_txd ) override { device_serial_interface::rx_w(state); } - DECLARE_READ_LINE_MEMBER(tx_r); virtual ioport_constructor device_input_ports() const override; diff --git a/src/devices/bus/rs232/xvd701.h b/src/devices/bus/rs232/xvd701.h index 5f7b6a7ba64..29f6dd0a5a9 100644 --- a/src/devices/bus/rs232/xvd701.h +++ b/src/devices/bus/rs232/xvd701.h @@ -14,9 +14,6 @@ public: virtual machine_config_constructor device_mconfig_additions() const override; virtual WRITE_LINE_MEMBER( input_txd ) override { device_serial_interface::rx_w(state); } - - DECLARE_WRITE_LINE_MEMBER(update_serial); - protected: virtual ioport_constructor device_input_ports() const override; virtual void device_start() override; diff --git a/src/devices/bus/scv/slot.cpp b/src/devices/bus/scv/slot.cpp index e29221b411a..e2c6dece7c0 100644 --- a/src/devices/bus/scv/slot.cpp +++ b/src/devices/bus/scv/slot.cpp @@ -263,7 +263,7 @@ void scv_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom8k"; + const char *slot_string; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type; diff --git a/src/devices/bus/sega8/sega8_slot.cpp b/src/devices/bus/sega8/sega8_slot.cpp index c88be013d3f..a3fee762e91 100644 --- a/src/devices/bus/sega8/sega8_slot.cpp +++ b/src/devices/bus/sega8/sega8_slot.cpp @@ -607,7 +607,7 @@ void sega8_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "rom"; + const char *slot_string; UINT32 len = core_fsize(m_file), offset = 0; dynamic_buffer rom(len); int type; @@ -725,7 +725,7 @@ void sega8_cart_slot_device::internal_header_logging(UINT8 *ROM, UINT32 len, UIN char reserved[10]; UINT8 version, csum_size, region, serial[3]; UINT16 checksum, csum = 0; - UINT32 csum_end = 0; + UINT32 csum_end; // LOG FILE DETAILS logerror("FILE DETAILS\n" ); diff --git a/src/devices/bus/sega8/sega8_slot.h b/src/devices/bus/sega8/sega8_slot.h index 64f332e5e81..cf56effa4f0 100644 --- a/src/devices/bus/sega8/sega8_slot.h +++ b/src/devices/bus/sega8/sega8_slot.h @@ -71,9 +71,6 @@ public: UINT32 get_rom_size() { return m_rom_size; } UINT32 get_ram_size() { return m_ram.size(); } - void rom_map_setup(UINT32 size); - void ram_map_setup(UINT8 banks); - void save_ram() { device().save_item(NAME(m_ram)); } //private: diff --git a/src/devices/bus/sms_ctrl/rfu.cpp b/src/devices/bus/sms_ctrl/rfu.cpp index 3da326aa378..2b43b31a6b8 100644 --- a/src/devices/bus/sms_ctrl/rfu.cpp +++ b/src/devices/bus/sms_ctrl/rfu.cpp @@ -81,7 +81,7 @@ void sms_rapid_fire_device::device_start() UINT8 sms_rapid_fire_device::peripheral_r() { - UINT8 data = 0xff; + UINT8 data; int num_intervals = (machine().time() - m_start_time).as_double() / m_interval.as_double(); m_read_state = num_intervals & 1; diff --git a/src/devices/bus/snes/rom.cpp b/src/devices/bus/snes/rom.cpp index daac69bbc72..3763f11ed91 100644 --- a/src/devices/bus/snes/rom.cpp +++ b/src/devices/bus/snes/rom.cpp @@ -377,7 +377,7 @@ WRITE8_MEMBER( sns_rom_tekken2_device::chip_write ) // Banks $c0-$ff return open bus. READ8_MEMBER( sns_rom_soulblad_device::chip_read ) { - UINT8 value = 0; + UINT8 value; offset &= 3; switch (offset) { diff --git a/src/devices/bus/snes/sa1.cpp b/src/devices/bus/snes/sa1.cpp index be4f4c039fe..b22af792a97 100644 --- a/src/devices/bus/snes/sa1.cpp +++ b/src/devices/bus/snes/sa1.cpp @@ -819,8 +819,8 @@ void sns_sa1_device::write_iram(UINT32 offset, UINT8 data) UINT8 sns_sa1_device::read_bwram(UINT32 offset) { - int shift = 0; - UINT8 mask = 0xff; + int shift; + UINT8 mask; if (m_nvram.empty()) return 0xff; // this should probably never happen, or are there SA-1 games with no BWRAM? @@ -852,7 +852,7 @@ UINT8 sns_sa1_device::read_bwram(UINT32 offset) void sns_sa1_device::write_bwram(UINT32 offset, UINT8 data) { - UINT8 mask = 0xff; + UINT8 mask; if (m_nvram.empty()) return; // this should probably never happen, or are there SA-1 games with no BWRAM? @@ -894,7 +894,7 @@ void sns_sa1_device::write_bwram(UINT32 offset, UINT8 data) READ8_MEMBER(sns_sa1_device::read_l) { - int bank = 0; + int bank; if (offset == 0xffea && BIT(m_scpu_ctrl, 4)) return (m_nmi_vector >> 0) & 0xff; if (offset == 0xffeb && BIT(m_scpu_ctrl, 4)) return (m_nmi_vector >> 8) & 0xff; @@ -929,7 +929,7 @@ READ8_MEMBER(sns_sa1_device::read_l) READ8_MEMBER(sns_sa1_device::read_h) { - int bank = 0; + int bank; // ROM is mapped to [80-bf][8000-ffff] & [c0-ff][0000-ffff] if (offset < 0x200000) diff --git a/src/devices/bus/snes/sdd1.cpp b/src/devices/bus/snes/sdd1.cpp index 87041e3ffb8..9570b5110ad 100644 --- a/src/devices/bus/snes/sdd1.cpp +++ b/src/devices/bus/snes/sdd1.cpp @@ -256,7 +256,7 @@ UINT8 SDD1_CM::CM_getBit(UINT8 *ROM, UINT32 *mmc) { UINT8 currContext; UINT16 *context_bits; - UINT8 bit = 0; + UINT8 bit; switch (m_bitplanesInfo) { @@ -319,7 +319,7 @@ void SDD1_OL::OL_prepareDecomp(UINT8 *ROM, UINT32 *mmc, UINT32 first_byte, UINT1 void SDD1_OL::OL_launch(UINT8 *ROM, UINT32 *mmc) { UINT8 i; - UINT8 register1 = 0, register2 = 0; + UINT8 register1, register2 = 0; switch (m_bitplanesInfo) { diff --git a/src/devices/bus/snes/snes_slot.cpp b/src/devices/bus/snes/snes_slot.cpp index 10add2da1cc..6098824921f 100644 --- a/src/devices/bus/snes/snes_slot.cpp +++ b/src/devices/bus/snes/snes_slot.cpp @@ -797,7 +797,7 @@ void base_sns_cart_slot_device::setup_addon_from_fullpath() if (!m_cart->get_addon_bios_size()) { std::string region = std::string(m_cart->device().tag()).append(":addon"); - UINT8 *ROM = nullptr; + UINT8 *ROM; switch (m_addon) { @@ -1005,8 +1005,8 @@ void base_sns_cart_slot_device::get_default_card_software(std::string &result) if (fullpath) { - const char *slot_string = "lorom"; - UINT32 offset = 0; + const char *slot_string; + UINT32 offset; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type = 0, addon = 0; diff --git a/src/devices/bus/snes/spc7110.cpp b/src/devices/bus/snes/spc7110.cpp index 5e5561af3d7..b9b0ee77cd3 100644 --- a/src/devices/bus/snes/spc7110.cpp +++ b/src/devices/bus/snes/spc7110.cpp @@ -1233,7 +1233,7 @@ READ8_MEMBER(sns_rom_spc7110_device::chip_read) case 0x4840: return m_r4840; case 0x4841: { - UINT8 data = 0; + UINT8 data; if (m_rtc_state == RTCS_Inactive || m_rtc_state == RTCS_ModeSelect) return 0x00; diff --git a/src/devices/bus/ti99_peb/bwg.cpp b/src/devices/bus/ti99_peb/bwg.cpp index 89c0b5d69ea..4085dcfe230 100644 --- a/src/devices/bus/ti99_peb/bwg.cpp +++ b/src/devices/bus/ti99_peb/bwg.cpp @@ -338,7 +338,7 @@ WRITE8_MEMBER(snug_bwg_device::write) */ READ8Z_MEMBER(snug_bwg_device::crureadz) { - UINT8 reply = 0; + UINT8 reply; if ((offset & 0xff00)==m_cru_base) { diff --git a/src/devices/bus/ti99_peb/bwg.h b/src/devices/bus/ti99_peb/bwg.h index db0ba735792..6a301b5cb59 100644 --- a/src/devices/bus/ti99_peb/bwg.h +++ b/src/devices/bus/ti99_peb/bwg.h @@ -28,9 +28,6 @@ public: DECLARE_WRITE8_MEMBER(write) override; DECLARE_SETADDRESS_DBIN_MEMBER(setaddress_dbin) override; - DECLARE_WRITE_LINE_MEMBER( intrq_w ); - DECLARE_WRITE_LINE_MEMBER( drq_w ); - DECLARE_READ8Z_MEMBER(crureadz) override; DECLARE_WRITE8_MEMBER(cruwrite) override; diff --git a/src/devices/bus/ti99_peb/hfdc.h b/src/devices/bus/ti99_peb/hfdc.h index 7e62a22f253..63cdbb441e7 100644 --- a/src/devices/bus/ti99_peb/hfdc.h +++ b/src/devices/bus/ti99_peb/hfdc.h @@ -182,7 +182,6 @@ private: void set_bits(UINT8& byte, int mask, bool set); // Joined ready line towards the controller - void set_ready(int dev, bool ready); int m_readyflags; }; #endif diff --git a/src/devices/bus/ti99_peb/memex.cpp b/src/devices/bus/ti99_peb/memex.cpp index 17cc6fe4283..66dd2f7b291 100644 --- a/src/devices/bus/ti99_peb/memex.cpp +++ b/src/devices/bus/ti99_peb/memex.cpp @@ -48,7 +48,7 @@ bool geneve_memex_device::access_enabled(offs_t offset) // Some traditional cards will not decode the AMx lines, so // we may have to lock out those areas int page = (offset >> 13)&0xff; - int index = 0; + int index; // SW2: "off" locks // 10xxx010 diff --git a/src/devices/bus/ti99_peb/myarcmem.cpp b/src/devices/bus/ti99_peb/myarcmem.cpp index 159152ddef5..08e8f893a95 100644 --- a/src/devices/bus/ti99_peb/myarcmem.cpp +++ b/src/devices/bus/ti99_peb/myarcmem.cpp @@ -52,7 +52,7 @@ m_ram(nullptr), m_dsrrom(nullptr), m_bank(0), m_size(0) int myarc_memory_expansion_device::get_base(int offset) { - int base = 0; + int base; if (m_size == SIZE_128) { base = ((m_bank & 0x03) << 15); diff --git a/src/devices/bus/ti99_peb/samsmem.cpp b/src/devices/bus/ti99_peb/samsmem.cpp index 3951294f3c7..0ff3e27d928 100644 --- a/src/devices/bus/ti99_peb/samsmem.cpp +++ b/src/devices/bus/ti99_peb/samsmem.cpp @@ -37,7 +37,7 @@ sams_memory_expansion_device::sams_memory_expansion_device(const machine_config */ READ8Z_MEMBER(sams_memory_expansion_device::readz) { - int base = 0; + int base; if (m_access_mapper && ((offset & 0xe000)==0x4000)) { @@ -61,7 +61,7 @@ READ8Z_MEMBER(sams_memory_expansion_device::readz) WRITE8_MEMBER(sams_memory_expansion_device::write) { - int base = 0; + int base; if (m_access_mapper && ((offset & 0xe000)==0x4000)) { diff --git a/src/devices/bus/ti99_peb/spchsyn.h b/src/devices/bus/ti99_peb/spchsyn.h index 38af09dd6d7..44e7aca54c4 100644 --- a/src/devices/bus/ti99_peb/spchsyn.h +++ b/src/devices/bus/ti99_peb/spchsyn.h @@ -32,10 +32,6 @@ public: DECLARE_WRITE_LINE_MEMBER( speech_ready ); - DECLARE_READ8_MEMBER( spchrom_read ); - DECLARE_WRITE8_MEMBER( spchrom_load_address ); - DECLARE_WRITE8_MEMBER( spchrom_read_and_branch ); - protected: virtual void device_start() override; virtual void device_reset(void) override; diff --git a/src/devices/bus/ti99_peb/ti_fdc.h b/src/devices/bus/ti99_peb/ti_fdc.h index ababee22aae..ed1082d3b0a 100644 --- a/src/devices/bus/ti99_peb/ti_fdc.h +++ b/src/devices/bus/ti99_peb/ti_fdc.h @@ -27,9 +27,6 @@ public: DECLARE_WRITE8_MEMBER(write) override; DECLARE_SETADDRESS_DBIN_MEMBER(setaddress_dbin) override; - DECLARE_WRITE_LINE_MEMBER( intrq_w ); - DECLARE_WRITE_LINE_MEMBER( drq_w ); - DECLARE_READ8Z_MEMBER(crureadz) override; DECLARE_WRITE8_MEMBER(cruwrite) override; diff --git a/src/devices/bus/ti99_peb/ti_rs232.cpp b/src/devices/bus/ti99_peb/ti_rs232.cpp index 14565537ea8..e93bb86d015 100644 --- a/src/devices/bus/ti99_peb/ti_rs232.cpp +++ b/src/devices/bus/ti99_peb/ti_rs232.cpp @@ -176,7 +176,7 @@ int ti_rs232_attached_device::get_index_from_tagname() */ bool ti_rs232_attached_device::call_load() { - tms9902_device* tms9902 = nullptr; + tms9902_device* tms9902; // ti_rs232_pio_device* card = static_cast<ti_rs232_pio_device*>(owner()); int devnumber = get_index_from_tagname(); @@ -206,7 +206,7 @@ bool ti_rs232_attached_device::call_load() void ti_rs232_attached_device::call_unload() { - tms9902_device* tms9902 = nullptr; + tms9902_device* tms9902; int devnumber = get_index_from_tagname(); if (devnumber==0) diff --git a/src/devices/bus/ti99_peb/ti_rs232.h b/src/devices/bus/ti99_peb/ti_rs232.h index 18db7d3533e..24c190aac2d 100644 --- a/src/devices/bus/ti99_peb/ti_rs232.h +++ b/src/devices/bus/ti99_peb/ti_rs232.h @@ -45,7 +45,6 @@ public: DECLARE_WRITE8_MEMBER( xmit1_callback ); DECLARE_WRITE8_MEMBER( ctrl0_callback ); DECLARE_WRITE8_MEMBER( ctrl1_callback ); - DECLARE_WRITE_LINE_MEMBER( senila ); protected: virtual void device_start(void) override; diff --git a/src/devices/bus/ti99x/998board.cpp b/src/devices/bus/ti99x/998board.cpp index d59313bc57c..6df84271cc4 100644 --- a/src/devices/bus/ti99x/998board.cpp +++ b/src/devices/bus/ti99x/998board.cpp @@ -295,7 +295,7 @@ void mainboard8_device::PTGE_set(bool state) READ8_MEMBER( mainboard8_device::readm ) { UINT8 value = 0; - bool found = false; + bool found; if (TRACE_MEM) logerror("%s: read from %04x\n", tag(), offset); found = access_logical_r(space, offset, &value, mem_mask); m_waitcount = 2; @@ -323,7 +323,7 @@ READ8_MEMBER( mainboard8_device::readm ) WRITE8_MEMBER( mainboard8_device::writem ) { - bool found = false; + bool found; // Look for components responding to the logical address found = access_logical_w(space, offset, data, mem_mask); @@ -485,7 +485,7 @@ bool mainboard8_device::access_logical_r(address_space& space, offs_t offset, UI { bool found = false; logically_addressed_device *ldev = m_logcomp.first(); - bus8z_device *bdev = nullptr; + bus8z_device *bdev; if (TRACE_MEM) logerror("%s: offset=%04x; CRUS=%d, PTGEN=%d\n", tag(), offset, m_CRUS? 1:0, m_PTGE? 0:1); while (ldev != nullptr) @@ -531,7 +531,7 @@ bool mainboard8_device::access_logical_w(address_space& space, offs_t offset, UI { bool found = false; logically_addressed_device *ldev = m_logcomp.first(); - bus8z_device *bdev = nullptr; + bus8z_device *bdev; while (ldev != nullptr) { @@ -573,7 +573,7 @@ bool mainboard8_device::access_logical_w(address_space& space, offs_t offset, UI void mainboard8_device::access_physical_r( address_space& space, offs_t pas_address, UINT8 *value, UINT8 mem_mask ) { physically_addressed_device *pdev = m_physcomp.first(); - bus8z_device *bdev = nullptr; + bus8z_device *bdev; while (pdev != nullptr) { @@ -621,7 +621,7 @@ void mainboard8_device::access_physical_r( address_space& space, offs_t pas_addr void mainboard8_device::access_physical_w( address_space& space, offs_t pas_address, UINT8 data, UINT8 mem_mask ) { physically_addressed_device *pdev = m_physcomp.first(); - bus8z_device *bdev = nullptr; + bus8z_device *bdev; while (pdev != nullptr) { diff --git a/src/devices/bus/ti99x/998board.h b/src/devices/bus/ti99x/998board.h index d7f8e5f7fc7..9231d9be647 100644 --- a/src/devices/bus/ti99x/998board.h +++ b/src/devices/bus/ti99x/998board.h @@ -157,10 +157,6 @@ public: DECLARE_WRITE_LINE_MEMBER( speech8_ready ); - DECLARE_READ8_MEMBER( spchrom_read ); - DECLARE_WRITE8_MEMBER( spchrom_load_address ); - DECLARE_WRITE8_MEMBER( spchrom_read_and_branch ); - protected: virtual void device_start() override; virtual void device_reset(void) override; diff --git a/src/devices/bus/ti99x/datamux.cpp b/src/devices/bus/ti99x/datamux.cpp index a17ebf95d77..1b8ec8de02f 100644 --- a/src/devices/bus/ti99x/datamux.cpp +++ b/src/devices/bus/ti99x/datamux.cpp @@ -429,7 +429,7 @@ void ti99_datamux_device::device_reset(void) } else { - UINT32 set = 0; + UINT32 set; bool active_device = true; if (list[i].setting!=nullptr) { diff --git a/src/devices/bus/ti99x/genboard.cpp b/src/devices/bus/ti99x/genboard.cpp index 1817aad95a2..9d6aeef7e76 100644 --- a/src/devices/bus/ti99x/genboard.cpp +++ b/src/devices/bus/ti99x/genboard.cpp @@ -1186,7 +1186,7 @@ void geneve_mapper_device::decode(address_space& space, offs_t offset, bool read */ READ8_MEMBER( geneve_mapper_device::read_from_pfm ) { - UINT8 value = 0; + UINT8 value; if (!m_pfm_output_enable) return 0; int address = (offset & 0x01ffff) | (m_pfm_bank<<17); diff --git a/src/devices/bus/ti99x/gromport.cpp b/src/devices/bus/ti99x/gromport.cpp index d75ca72d469..ff8b780fd1d 100644 --- a/src/devices/bus/ti99x/gromport.cpp +++ b/src/devices/bus/ti99x/gromport.cpp @@ -1796,7 +1796,7 @@ WRITE8_MEMBER(ti99_mbx_cartridge::write) */ int ti99_paged379i_cartridge::get_paged379i_bank(int rompage) { - int mask = 0; + int mask; if (m_rom_size > 16384) { if (m_rom_size > 32768) diff --git a/src/devices/bus/ti99x/gromport.h b/src/devices/bus/ti99x/gromport.h index 768bf7d51e8..7655173b10d 100644 --- a/src/devices/bus/ti99x/gromport.h +++ b/src/devices/bus/ti99x/gromport.h @@ -208,7 +208,6 @@ private: void set_slot(int slotnumber); int get_active_slot(bool changebase, offs_t offset); - void change_slot(bool inserted, int index); }; /* @@ -370,8 +369,6 @@ public: ~ti99_paged378_cartridge() { }; DECLARE_READ8Z_MEMBER(readz) override; DECLARE_WRITE8_MEMBER(write) override; -private: - int get_paged378_bank(int rompage); }; /********************** Paged 377 ************************************/ @@ -382,8 +379,6 @@ public: ~ti99_paged377_cartridge() { }; DECLARE_READ8Z_MEMBER(readz) override; DECLARE_WRITE8_MEMBER(write) override; -private: - int get_paged377_bank(int rompage); }; /********************** Paged CRU ************************************/ diff --git a/src/devices/bus/ti99x/handset.h b/src/devices/bus/ti99x/handset.h index 17b2eac8190..3f9de1b6221 100644 --- a/src/devices/bus/ti99x/handset.h +++ b/src/devices/bus/ti99x/handset.h @@ -73,7 +73,6 @@ class ti99_twin_joystick : public joyport_attached_device { public: ti99_twin_joystick(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); - DECLARE_READ8_MEMBER( read ); virtual void device_start(void) override; UINT8 read_dev() override; diff --git a/src/devices/bus/vboy/slot.h b/src/devices/bus/vboy/slot.h index 3f2b15698ce..c663b37252b 100644 --- a/src/devices/bus/vboy/slot.h +++ b/src/devices/bus/vboy/slot.h @@ -69,7 +69,6 @@ public: virtual bool call_softlist_load(software_list_device &swlist, const char *swname, const rom_entry *start_entry) override; int get_type() { return m_type; } - int get_cart_type(UINT8 *ROM, UINT32 len); void save_eeprom() { if (m_cart && m_cart->get_eeprom_size()) m_cart->save_eeprom(); } diff --git a/src/devices/bus/vc4000/slot.cpp b/src/devices/bus/vc4000/slot.cpp index ecfc63b42dd..88d7b9b4f7e 100644 --- a/src/devices/bus/vc4000/slot.cpp +++ b/src/devices/bus/vc4000/slot.cpp @@ -239,7 +239,7 @@ void vc4000_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "std"; + const char *slot_string; UINT32 size = core_fsize(m_file); int type = VC4000_STD; diff --git a/src/devices/bus/vcs/vcs_slot.cpp b/src/devices/bus/vcs/vcs_slot.cpp index caa46ef358b..73d01ef1547 100755 --- a/src/devices/bus/vcs/vcs_slot.cpp +++ b/src/devices/bus/vcs/vcs_slot.cpp @@ -785,7 +785,7 @@ void vcs_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "a26_4k"; + const char *slot_string; UINT32 len = core_fsize(m_file); dynamic_buffer rom(len); int type; diff --git a/src/devices/bus/vcs_ctrl/ctrl.h b/src/devices/bus/vcs_ctrl/ctrl.h index bdcc9f5abe0..41f7c12e75a 100644 --- a/src/devices/bus/vcs_ctrl/ctrl.h +++ b/src/devices/bus/vcs_ctrl/ctrl.h @@ -95,7 +95,6 @@ public: DECLARE_READ8_MEMBER( pot_y_r ) { return pot_y_r(); } void joy_w( UINT8 data ) { if ( exists() ) m_device->vcs_joy_w( data ); } - DECLARE_WRITE8_MEMBER( joy_w ); bool exists() { return m_device != nullptr; } bool has_pot_x() { return exists() && m_device->has_pot_x(); } diff --git a/src/devices/bus/vectrex/slot.cpp b/src/devices/bus/vectrex/slot.cpp index a7322b0b994..c97b007642a 100644 --- a/src/devices/bus/vectrex/slot.cpp +++ b/src/devices/bus/vectrex/slot.cpp @@ -221,7 +221,7 @@ void vectrex_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "vec_rom"; + const char *slot_string; UINT32 size = core_fsize(m_file); dynamic_buffer rom(size); int type = VECTREX_STD; diff --git a/src/devices/bus/vic10/exp.cpp b/src/devices/bus/vic10/exp.cpp index 23c20e6b93f..6aca9930c13 100644 --- a/src/devices/bus/vic10/exp.cpp +++ b/src/devices/bus/vic10/exp.cpp @@ -113,7 +113,7 @@ bool vic10_expansion_slot_device::call_load() { if (m_card) { - size_t size = 0; + size_t size; if (software_entry() == nullptr) { diff --git a/src/devices/bus/vidbrain/exp.cpp b/src/devices/bus/vidbrain/exp.cpp index a100e4eeebe..2aea10bfc8a 100644 --- a/src/devices/bus/vidbrain/exp.cpp +++ b/src/devices/bus/vidbrain/exp.cpp @@ -116,7 +116,7 @@ bool videobrain_expansion_slot_device::call_load() { if (m_cart) { - size_t size = 0; + size_t size; if (software_entry() == nullptr) { diff --git a/src/devices/bus/wangpc/tig.cpp b/src/devices/bus/wangpc/tig.cpp index 47bda2c6747..efadfc332dc 100644 --- a/src/devices/bus/wangpc/tig.cpp +++ b/src/devices/bus/wangpc/tig.cpp @@ -282,7 +282,7 @@ void wangpc_tig_device::wangpcbus_aiowc_w(address_space &space, offs_t offset, U UINT8 wangpc_tig_device::wangpcbus_dack_r(address_space &space, int line) { - UINT8 data = 0; + UINT8 data; if (DMA_GRAPHICS) { diff --git a/src/devices/bus/wswan/slot.cpp b/src/devices/bus/wswan/slot.cpp index 749f82596e1..0a7383ea8a9 100644 --- a/src/devices/bus/wswan/slot.cpp +++ b/src/devices/bus/wswan/slot.cpp @@ -310,7 +310,7 @@ void ws_cart_slot_device::get_default_card_software(std::string &result) { if (open_image_file(mconfig().options())) { - const char *slot_string = "ws_rom"; + const char *slot_string; UINT32 size = core_fsize(m_file); dynamic_buffer rom(size); int type; diff --git a/src/devices/bus/z88/z88.cpp b/src/devices/bus/z88/z88.cpp index 2cbc97c53dd..228805142be 100644 --- a/src/devices/bus/z88/z88.cpp +++ b/src/devices/bus/z88/z88.cpp @@ -121,7 +121,7 @@ bool z88cart_slot_device::call_load() { if (m_cart) { - offs_t read_length = 0; + offs_t read_length; UINT8 *cart_base = m_cart->get_cart_base(); if (cart_base != nullptr) diff --git a/src/devices/cpu/arcompact/arcompactdasm.cpp b/src/devices/cpu/arcompact/arcompactdasm.cpp index 0b917a05d56..755106ce90c 100644 --- a/src/devices/cpu/arcompact/arcompactdasm.cpp +++ b/src/devices/cpu/arcompact/arcompactdasm.cpp @@ -26,7 +26,7 @@ extern char *output; CPU_DISASSEMBLE(arcompact) { - int size = 2; + int size; UINT32 op = oprom[0] | (oprom[1] << 8); output = buffer; diff --git a/src/devices/cpu/arcompact/arcompactdasm_ops.cpp b/src/devices/cpu/arcompact/arcompactdasm_ops.cpp index eeac8cac2f8..b9cfc30b545 100644 --- a/src/devices/cpu/arcompact/arcompactdasm_ops.cpp +++ b/src/devices/cpu/arcompact/arcompactdasm_ops.cpp @@ -504,7 +504,7 @@ int arcompact_handle04_p01_helper_dasm(DASM_OPS_32, const char* optext, int igno int arcompact_handle04_p10_helper_dasm(DASM_OPS_32, const char* optext, int b_reserved) { int size = 4; - UINT32 limm = 0; + UINT32 limm; //int got_limm = 0; COMMON32_GET_breg; @@ -599,7 +599,7 @@ int arcompact_handle04_p11_m0_helper_dasm(DASM_OPS_32, const char* optext, int b int arcompact_handle04_p11_m1_helper_dasm(DASM_OPS_32, const char* optext, int b_reserved) { int size = 4; - UINT32 limm = 0; + UINT32 limm; //int got_limm = 0; COMMON32_GET_breg; diff --git a/src/devices/cpu/arm7/arm7dasm.cpp b/src/devices/cpu/arm7/arm7dasm.cpp index b749d3624a2..68a2bb38654 100644 --- a/src/devices/cpu/arm7/arm7dasm.cpp +++ b/src/devices/cpu/arm7/arm7dasm.cpp @@ -494,7 +494,7 @@ static UINT32 arm7_disasm( char *pBuf, UINT32 pc, UINT32 opcode ) } else if( (opcode&0x0c000000)==0x04000000 ) //bits 27-26 == 01 { - UINT32 rn = 0; + UINT32 rn; UINT32 rnv = 0; /* Data Transfer */ diff --git a/src/devices/cpu/avr8/avr8.h b/src/devices/cpu/avr8/avr8.h index 715b12a0432..45174d48741 100644 --- a/src/devices/cpu/avr8/avr8.h +++ b/src/devices/cpu/avr8/avr8.h @@ -79,9 +79,6 @@ class avr8_device; class avr8_device : public cpu_device { public: - // construction/destruction - avr8_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock, const device_type type, UINT32 address_mask); - // inline configuration helpers static void set_eeprom_tag(device_t &device, const char *tag) { downcast<avr8_device &>(device).m_eeprom_tag = tag; } @@ -188,13 +185,6 @@ protected: UINT64 m_elapsed_cycles; // memory access - inline UINT8 program_read8(UINT32 addr); - inline UINT16 program_read16(UINT32 addr); - inline void program_write8(UINT32 addr, UINT8 data); - inline void program_write16(UINT32 addr, UINT16 data); - inline UINT8 io_read8(UINT16 addr); - inline void io_write8(UINT16 addr, UINT8 data); - inline UINT16 opcode_read(); inline void push(UINT8 val); inline UINT8 pop(); inline bool is_long_opcode(UINT16 op); @@ -204,7 +194,6 @@ protected: // interrupts void set_irq_line(UINT16 vector, int state); - void update_interrupt_internal(int source); // timers void timer_tick(int cycles); diff --git a/src/devices/cpu/avr8/avr8dasm.cpp b/src/devices/cpu/avr8/avr8dasm.cpp index 31b149d5737..cc5fcecf3a9 100644 --- a/src/devices/cpu/avr8/avr8dasm.cpp +++ b/src/devices/cpu/avr8/avr8dasm.cpp @@ -31,7 +31,7 @@ CPU_DISASSEMBLE( avr8 ) int pos = 0; UINT32 op = oprom[pos++]; op |= oprom[pos++] << 8; - UINT32 addr = 0; + UINT32 addr; const char* register_names[0x40] = {"PINA", "DDRA", "PORTA", "PINB", "DDRB", "PORTB", "PINC", "DDRC", "PORTC", "PIND", "DDRD", "PORTD", "PINE", "DDRE", "PORTE", "PINF", "DDRF", "PORTF", "PING", "DDRG", "PORTG", "TIFR0", "TIFR1", "TIFR2","TIFR3", "TIFR4", "TIFR5", "PCIFR", "EIFR", "EIMSK", "GPIOR0", "EECR", "EEDR", "EEARL", "EEARH", "GTCCR", "TCCR0A", "TCCR0B", "TCNT0", "OCR0A", "OCR0B", "0x29", "GPIOR1", "GPIOR2", "SPCR", "SPSR", "SPDR", "0x2F", "ACSR", "OCDR", "0x32", "SMCR", "MCUSR", "MCUCR", "0x36", "SPMCSR", "0x38", "0x39", "0x3A", "RAMPZ", "EIND", "SPL", "SPH", "SREG"}; const char* register_bit_names[0x40][8] = { diff --git a/src/devices/cpu/e0c6200/e0c6200d.cpp b/src/devices/cpu/e0c6200/e0c6200d.cpp index 4fc0599ac24..4935b257470 100644 --- a/src/devices/cpu/e0c6200/e0c6200d.cpp +++ b/src/devices/cpu/e0c6200/e0c6200d.cpp @@ -114,7 +114,7 @@ CPU_DISASSEMBLE(e0c6200) { UINT16 op = (oprom[1] | oprom[0] << 8) & 0xfff; - int m = -1; + int m; int p1 = -1; int p2 = -1; diff --git a/src/devices/cpu/e132xs/32xsdasm.cpp b/src/devices/cpu/e132xs/32xsdasm.cpp index d165f2fdc42..48f3e97968f 100644 --- a/src/devices/cpu/e132xs/32xsdasm.cpp +++ b/src/devices/cpu/e132xs/32xsdasm.cpp @@ -394,7 +394,7 @@ static UINT32 RRdis_format(char *source, char *dest, UINT16 op, UINT16 next_op, unsigned dasm_hyperstone(char *buffer, unsigned pc, const UINT8 *oprom, unsigned h_flag, int private_fp) { - UINT16 op = 0; + UINT16 op; UINT8 op_num; UINT8 source_code, dest_code, source_bit, dest_bit; diff --git a/src/devices/cpu/e132xs/e132xs.h b/src/devices/cpu/e132xs/e132xs.h index ccfd74f1e5e..3448522a2cc 100644 --- a/src/devices/cpu/e132xs/e132xs.h +++ b/src/devices/cpu/e132xs/e132xs.h @@ -225,8 +225,6 @@ protected: virtual void device_reset() override; virtual void device_stop() override; - void make_ops(); - // device_execute_interface overrides virtual UINT32 execute_min_cycles() const override; virtual UINT32 execute_max_cycles() const override; diff --git a/src/devices/cpu/h8/h83008.h b/src/devices/cpu/h8/h83008.h index f8132f4bc37..8a19568f43f 100644 --- a/src/devices/cpu/h8/h83008.h +++ b/src/devices/cpu/h8/h83008.h @@ -24,7 +24,6 @@ class h83008_device : public h8h_device { public: - h83008_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); h83008_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); DECLARE_READ8_MEMBER(syscr_r); diff --git a/src/devices/cpu/h8/h8_intc.h b/src/devices/cpu/h8/h8_intc.h index 80275d40017..b6a6da31af7 100644 --- a/src/devices/cpu/h8/h8_intc.h +++ b/src/devices/cpu/h8/h8_intc.h @@ -102,9 +102,6 @@ public: DECLARE_WRITE8_MEMBER(ipr_w); DECLARE_READ8_MEMBER(iprk_r); DECLARE_WRITE8_MEMBER(iprk_w); - - void set_mode_8(bool mode_8); - private: static const int vector_to_slot[]; UINT8 ipr[11]; diff --git a/src/devices/cpu/h8/h8_timer16.h b/src/devices/cpu/h8/h8_timer16.h index c7bedbbcfe8..f8f6c1efda2 100644 --- a/src/devices/cpu/h8/h8_timer16.h +++ b/src/devices/cpu/h8/h8_timer16.h @@ -88,8 +88,6 @@ public: DECLARE_WRITE8_MEMBER(tier_w); DECLARE_READ8_MEMBER(tsr_r); DECLARE_WRITE8_MEMBER(tsr_w); - DECLARE_READ8_MEMBER(tocr_r); - DECLARE_WRITE8_MEMBER(tocr_w); DECLARE_READ16_MEMBER(tcnt_r); DECLARE_WRITE16_MEMBER(tcnt_w); DECLARE_READ16_MEMBER(tgr_r); diff --git a/src/devices/cpu/hcd62121/hcd62121d.cpp b/src/devices/cpu/hcd62121/hcd62121d.cpp index 2283c0682af..0c6bc082b11 100644 --- a/src/devices/cpu/hcd62121/hcd62121d.cpp +++ b/src/devices/cpu/hcd62121/hcd62121d.cpp @@ -131,7 +131,9 @@ static const hcd62121_dasm hcd62121_ops[256] = CPU_DISASSEMBLE( hcd62121 ) { - UINT8 op, op1=0, op2=0; + UINT8 op; + UINT8 op1; + UINT8 op2; int pos = 0; const hcd62121_dasm *inst; diff --git a/src/devices/cpu/hd61700/hd61700d.cpp b/src/devices/cpu/hd61700/hd61700d.cpp index 719fade4f49..b5461ec58e8 100644 --- a/src/devices/cpu/hd61700/hd61700d.cpp +++ b/src/devices/cpu/hd61700/hd61700d.cpp @@ -399,7 +399,7 @@ UINT32 get_dasmflags(UINT8 op) CPU_DISASSEMBLE( hd61700 ) { const hd61700_dasm *inst; - UINT32 dasmflags = 0; + UINT32 dasmflags; UINT8 op, op1; int pos = 0, type = EXT_ROM; diff --git a/src/devices/cpu/hphybrid/hphybrid_dasm.cpp b/src/devices/cpu/hphybrid/hphybrid_dasm.cpp index b83352cf7fb..3c6efb68f58 100644 --- a/src/devices/cpu/hphybrid/hphybrid_dasm.cpp +++ b/src/devices/cpu/hphybrid/hphybrid_dasm.cpp @@ -356,7 +356,7 @@ static const dis_entry_t dis_table_emc[] = { {0xffff , 0x7b61 , "MLY" , param_none , 0 }, {0xffff , 0x7b8f , "MPY" , param_none , 0 }, // *** END *** - {0 , 0 , NULL , NULL , 0 } + {0 , 0 , nullptr , nullptr , 0 } }; static offs_t disassemble_table(UINT16 opcode , offs_t pc , const dis_entry_t *table , bool is_3001 , char *buffer) diff --git a/src/devices/cpu/i860/i860.h b/src/devices/cpu/i860/i860.h index fc9b5b83abf..f6afe2069ba 100644 --- a/src/devices/cpu/i860/i860.h +++ b/src/devices/cpu/i860/i860.h @@ -208,8 +208,6 @@ private: void writememi_emu (UINT32 addr, int size, UINT32 data); void fp_readmem_emu (UINT32 addr, int size, UINT8 *dest); void fp_writemem_emu (UINT32 addr, int size, UINT8 *data, UINT32 wmask); - void dump_pipe (int type); - void dump_state (); void unrecog_opcode (UINT32 pc, UINT32 insn); void insn_ld_ctrl (UINT32 insn); void insn_st_ctrl (UINT32 insn); @@ -278,8 +276,6 @@ private: void insn_faddp (UINT32 insn); void insn_faddz (UINT32 insn); void decode_exec (UINT32 insn, UINT32 non_shadow); - void disasm (UINT32 addr, int len); - void dbg_db (UINT32 addr, int len); float get_fregval_s (int fr); double get_fregval_d (int fr); void set_fregval_s (int fr, float s); diff --git a/src/devices/cpu/i860/i860dis.cpp b/src/devices/cpu/i860/i860dis.cpp index b158221ddc8..85851817c22 100644 --- a/src/devices/cpu/i860/i860dis.cpp +++ b/src/devices/cpu/i860/i860dis.cpp @@ -243,7 +243,7 @@ static void int_ldx(char *buf, char *mnemonic, UINT32 pc, UINT32 insn) /* Operand size, in bytes. */ int sizes[4] = { 1, 1, 2, 4 }; const char *const suffix[4] = { "b", "b", "s", "l" }; - UINT32 idx = 0; + UINT32 idx; /* Bits 28 and 0 determine the operand size. */ idx = ((insn >> 27) & 2) | (insn & 1); @@ -270,7 +270,7 @@ static void int_stx(char *buf, char *mnemonic, UINT32 pc, UINT32 insn) /* Operand size, in bytes. */ int sizes[4] = { 1, 1, 2, 4 }; const char *const suffix[4] = { "b", "b", "s", "l" }; - int idx = 0; + int idx; int size; INT32 immsrc = sign_ext ((((insn >> 5) & 0xf800) | (insn & 0x07ff)), 16); @@ -297,8 +297,8 @@ static void int_fldst(char *buf, char *mnemonic, UINT32 pc, UINT32 insn) /* Operand size, in bytes. */ int sizes[4] = { 8, 4, 16, 4 }; const char *const suffix[4] = { "d", "l", "q", "l" }; - int idx = 0; - int size = 0; + int idx; + int size; int auto_inc = (insn & 1); const char *const auto_suff[2] = { "", "++" }; int piped = (insn & 0x40000000) >> 29; diff --git a/src/devices/cpu/lr35902/lr35902d.cpp b/src/devices/cpu/lr35902/lr35902d.cpp index 8fe9bf8977a..3458c5094e6 100644 --- a/src/devices/cpu/lr35902/lr35902d.cpp +++ b/src/devices/cpu/lr35902/lr35902d.cpp @@ -195,9 +195,9 @@ CPU_DISASSEMBLE( lr35902 ) const lr35902dasm *d; const char /* *symbol,*/ *src; char *dst; - INT8 offset = 0; + INT8 offset; UINT8 op, op1; - UINT16 ea = 0; + UINT16 ea; int pos = 0; dst = buffer; diff --git a/src/devices/cpu/m6502/m6510.h b/src/devices/cpu/m6502/m6510.h index be555b866df..dbd0132baff 100644 --- a/src/devices/cpu/m6502/m6510.h +++ b/src/devices/cpu/m6502/m6510.h @@ -25,7 +25,6 @@ public: m6510_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); UINT8 get_port(); - void set_port(UINT8 val); void set_pulls(UINT8 pullup, UINT8 pulldown); template<class _read, class _write> void set_callbacks(_read rd, _write wr) { diff --git a/src/devices/cpu/m6805/m6805.h b/src/devices/cpu/m6805/m6805.h index dc85fd6eaaa..a56443f1880 100644 --- a/src/devices/cpu/m6805/m6805.h +++ b/src/devices/cpu/m6805/m6805.h @@ -119,7 +119,7 @@ protected: void rorx(); void asrx(); void aslx(); - void lslx(); +// void lslx(); void rolx(); void decx(); void incx(); diff --git a/src/devices/cpu/mc68hc11/hc11dasm.cpp b/src/devices/cpu/mc68hc11/hc11dasm.cpp index eed3df13c5e..2594634671f 100644 --- a/src/devices/cpu/mc68hc11/hc11dasm.cpp +++ b/src/devices/cpu/mc68hc11/hc11dasm.cpp @@ -1286,7 +1286,7 @@ static UINT32 decode_opcode(UINT32 pc, const M68HC11_OPCODE *op_table) CPU_DISASSEMBLE( hc11 ) { - UINT32 flags = 0; + UINT32 flags; UINT8 opcode; output = buffer; diff --git a/src/devices/cpu/minx/minxd.cpp b/src/devices/cpu/minx/minxd.cpp index 58789942409..31f4a1f51d7 100644 --- a/src/devices/cpu/minx/minxd.cpp +++ b/src/devices/cpu/minx/minxd.cpp @@ -424,8 +424,8 @@ CPU_DISASSEMBLE( minx ) { const minxdasm *instr; UINT8 op, op1; - INT8 ofs8 = 0; - UINT16 ea = 0; + INT8 ofs8; + UINT16 ea; int pos = 0; char *dst = buffer; diff --git a/src/devices/cpu/pic16c62x/pic16c62x.h b/src/devices/cpu/pic16c62x/pic16c62x.h index c373bd64ec2..300fc6d77e5 100644 --- a/src/devices/cpu/pic16c62x/pic16c62x.h +++ b/src/devices/cpu/pic16c62x/pic16c62x.h @@ -56,15 +56,6 @@ class pic16c62x_device : public cpu_device public: // construction/destruction pic16c62x_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, int program_width, int picmodel); - - /**************************************************************************** - * Function to configure the CONFIG register. This is actually hard-wired - * during ROM programming, so should be called in the driver INIT, with - * the value if known (available in HEX dumps of the ROM). - */ - - void pic16c62x_set_config(device_t *cpu, int data); - protected: // device-level overrides virtual void device_start() override; diff --git a/src/devices/cpu/pps4/pps4.h b/src/devices/cpu/pps4/pps4.h index 7993a34743e..44c9f27d00e 100644 --- a/src/devices/cpu/pps4/pps4.h +++ b/src/devices/cpu/pps4/pps4.h @@ -95,9 +95,6 @@ private: UINT8 m_I2; //!< Most recent parameter I2(8:1) UINT8 m_Ip; //!< Previous instruction I(8:1) - //! return the contents of B register (made of BU, BM and BL) - inline UINT16 B() const; - //! return memory at address B(12:1) inline UINT8 M(); diff --git a/src/devices/cpu/psx/dma.h b/src/devices/cpu/psx/dma.h index 809bcaf035a..e241dfac9ac 100644 --- a/src/devices/cpu/psx/dma.h +++ b/src/devices/cpu/psx/dma.h @@ -63,8 +63,6 @@ private: void dma_timer_adjust( int n_channel ); void dma_interrupt_update(); void dma_finished( int n_channel ); - void write( offs_t offset, UINT32 data, UINT32 mem_mask ); - UINT32 read( offs_t offset, UINT32 mem_mask ); psx_dma_channel m_channel[7]; UINT32 m_dpcp; diff --git a/src/devices/cpu/psx/psx.h b/src/devices/cpu/psx/psx.h index f5ec1423293..c0b4eb0a1cd 100644 --- a/src/devices/cpu/psx/psx.h +++ b/src/devices/cpu/psx/psx.h @@ -240,11 +240,6 @@ protected: // internal stuff UINT32 m_op; - // memory access - inline UINT32 program_read(UINT32 addr); - inline void program_write(UINT32 addr, UINT32 data); - inline UINT32 opcode_read(); - // address spaces const address_space_config m_program_config; address_space *m_program; diff --git a/src/devices/cpu/psx/sio.h b/src/devices/cpu/psx/sio.h index 4610f249700..93d8428bc9e 100644 --- a/src/devices/cpu/psx/sio.h +++ b/src/devices/cpu/psx/sio.h @@ -66,7 +66,6 @@ public: DECLARE_WRITE_LINE_MEMBER(write_rxd); DECLARE_WRITE_LINE_MEMBER(write_dsr); - DECLARE_WRITE_LINE_MEMBER(write_cts); protected: // device-level overrides diff --git a/src/devices/cpu/rsp/rsp.h b/src/devices/cpu/rsp/rsp.h index 958c4268bb8..5688dbdab59 100644 --- a/src/devices/cpu/rsp/rsp.h +++ b/src/devices/cpu/rsp/rsp.h @@ -159,7 +159,6 @@ public: void ccfunc_write32(); void ccfunc_get_cop0_reg(); void ccfunc_set_cop0_reg(); - void ccfunc_unimplemented_opcode(); void ccfunc_sp_set_status_cb(); void ccfunc_unimplemented(); @@ -317,11 +316,9 @@ private: void generate_sequence_instruction(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); void generate_delay_slot_and_branch(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc, UINT8 linkreg); void generate_branch(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); - int generate_vector_opcode(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); int generate_opcode(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); int generate_special(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); int generate_regimm(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); - int generate_cop2(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); int generate_cop0(drcuml_block *block, compiler_state *compiler, const opcode_desc *desc); void log_add_disasm_comment(drcuml_block *block, UINT32 pc, UINT32 op); }; diff --git a/src/devices/cpu/sharc/sharcdsm.cpp b/src/devices/cpu/sharc/sharcdsm.cpp index c498dcb78e5..af754afe66b 100644 --- a/src/devices/cpu/sharc/sharcdsm.cpp +++ b/src/devices/cpu/sharc/sharcdsm.cpp @@ -1208,8 +1208,8 @@ static UINT32 sharc_dasm_one(char *buffer, offs_t pc, UINT64 opcode) CPU_DISASSEMBLE( sharc ) { - UINT64 op = 0; - UINT32 flags = 0; + UINT64 op; + UINT32 flags; op = ((UINT64)oprom[0] << 0) | ((UINT64)oprom[1] << 8) | ((UINT64)oprom[2] << 16) | ((UINT64)oprom[3] << 24) | diff --git a/src/devices/cpu/sm8500/sm8500d.cpp b/src/devices/cpu/sm8500/sm8500d.cpp index 06b37795d54..f5fc1341365 100644 --- a/src/devices/cpu/sm8500/sm8500d.cpp +++ b/src/devices/cpu/sm8500/sm8500d.cpp @@ -178,8 +178,9 @@ CPU_DISASSEMBLE( sm8500 ) const sm8500dasm *instr; char *dst; UINT8 op; - INT8 offset = 0; - UINT16 ea = 0, ea2 = 0; + INT8 offset; + UINT16 ea; + UINT16 ea2; int pos = 0; dst = buffer; diff --git a/src/devices/cpu/tlcs900/tlcs900.h b/src/devices/cpu/tlcs900/tlcs900.h index 0481d96db21..515a25b58e5 100644 --- a/src/devices/cpu/tlcs900/tlcs900.h +++ b/src/devices/cpu/tlcs900/tlcs900.h @@ -49,7 +49,6 @@ class tlcs900h_device : public cpu_device { public: // construction/destruction - tlcs900h_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); tlcs900h_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, UINT32 clock, const char *shortname); // static configuration helpers diff --git a/src/devices/cpu/tms32031/tms32031.h b/src/devices/cpu/tms32031/tms32031.h index 0dbc85fdf96..46706f774c8 100644 --- a/src/devices/cpu/tms32031/tms32031.h +++ b/src/devices/cpu/tms32031/tms32031.h @@ -199,7 +199,6 @@ protected: bool condition(int which); // floating point helpers - void double_to_dsp_with_flags(double val, tmsreg &result); void int2float(tmsreg &srcdst); void float2int(tmsreg &srcdst, bool setflags); void negf(tmsreg &dst, tmsreg &src); diff --git a/src/devices/cpu/tms32082/dis_pp.cpp b/src/devices/cpu/tms32082/dis_pp.cpp index 54f8a6d7004..8bc6af719a9 100644 --- a/src/devices/cpu/tms32082/dis_pp.cpp +++ b/src/devices/cpu/tms32082/dis_pp.cpp @@ -258,7 +258,7 @@ static void format_transfer(UINT64 op) int reg = (bank << 3) | d; - UINT16 offset = 0; + UINT16 offset; if (s) { offset = op & 0x7fff; diff --git a/src/devices/cpu/tms9900/tms9900.h b/src/devices/cpu/tms9900/tms9900.h index be2c8a4ba3b..32953477172 100644 --- a/src/devices/cpu/tms9900/tms9900.h +++ b/src/devices/cpu/tms9900/tms9900.h @@ -301,7 +301,7 @@ private: void alu_abs(void); void alu_x(void); void alu_b(void); - void alu_bl(void); + //void alu_bl(void); void alu_blwp(void); void alu_ldcr(void); void alu_stcr(void); diff --git a/src/devices/cpu/upd7725/upd7725.h b/src/devices/cpu/upd7725/upd7725.h index 063360e6d34..856014dc7d1 100644 --- a/src/devices/cpu/upd7725/upd7725.h +++ b/src/devices/cpu/upd7725/upd7725.h @@ -188,9 +188,6 @@ private: void exec_jp(UINT32 opcode); void exec_ld(UINT32 opcode); - void stack_push(); - void stack_pull(); - int m_icount; int m_irq; // old irq line state, for detecting rising edges. diff --git a/src/devices/cpu/v60/v60.h b/src/devices/cpu/v60/v60.h index 4ef35d130b0..4427fe2c8fc 100644 --- a/src/devices/cpu/v60/v60.h +++ b/src/devices/cpu/v60/v60.h @@ -286,8 +286,6 @@ private: UINT32 bam1Error1(); UINT32 am1Error2(); UINT32 bam1Error2(); - UINT32 am1Error3(); - UINT32 bam1Error3(); UINT32 am1Error4(); UINT32 bam1Error4(); UINT32 am1Error5(); diff --git a/src/devices/cpu/z180/z180dasm.cpp b/src/devices/cpu/z180/z180dasm.cpp index 4d89d6ac673..e44f6d67ae4 100644 --- a/src/devices/cpu/z180/z180dasm.cpp +++ b/src/devices/cpu/z180/z180dasm.cpp @@ -399,7 +399,7 @@ CPU_DISASSEMBLE( z180 ) unsigned PC = pc; INT8 offset = 0; UINT8 op, op1 = 0; - UINT16 ea = 0; + UINT16 ea; int pos = 0; UINT32 flags = 0; diff --git a/src/devices/machine/53c810.h b/src/devices/machine/53c810.h index 7ce9f444d79..509e69a1638 100644 --- a/src/devices/machine/53c810.h +++ b/src/devices/machine/53c810.h @@ -25,9 +25,6 @@ public: static void set_dma_callback(device_t &device, lsi53c810_dma_delegate callback) { downcast<lsi53c810_device &>(device).m_dma_cb = callback; } static void set_fetch_callback(device_t &device, lsi53c810_fetch_delegate callback) { downcast<lsi53c810_device &>(device).m_fetch_cb = callback; } - void lsi53c810_read_data(int bytes, UINT8 *pData); - void lsi53c810_write_data(int bytes, UINT8 *pData); - UINT8 lsi53c810_reg_r( int offset ); void lsi53c810_reg_w(int offset, UINT8 data); @@ -65,7 +62,6 @@ private: void dmaop_load(); void dma_exec(); void add_opcode(UINT8 op, UINT8 mask, opcode_handler_delegate handler); - void lsi53c810_init(); UINT32 lsi53c810_dasm_fetch(UINT32 pc); unsigned lsi53c810_dasm(char *buf, UINT32 pc); diff --git a/src/devices/machine/atahle.h b/src/devices/machine/atahle.h index 1841bdb2be8..8c83625c1d4 100644 --- a/src/devices/machine/atahle.h +++ b/src/devices/machine/atahle.h @@ -33,9 +33,6 @@ public: virtual DECLARE_WRITE_LINE_MEMBER(write_dasp) override; virtual DECLARE_WRITE_LINE_MEMBER(write_dmack) override; virtual DECLARE_WRITE_LINE_MEMBER(write_pdiag) override; - - TIMER_CALLBACK_MEMBER(buffer_empty_timer_work); - protected: virtual void device_start() override; virtual void device_reset() override; diff --git a/src/devices/machine/dp8390.h b/src/devices/machine/dp8390.h index 09dd590f176..49341e30e49 100644 --- a/src/devices/machine/dp8390.h +++ b/src/devices/machine/dp8390.h @@ -72,7 +72,6 @@ private: void set_cr(UINT8 newcr); void check_dma_complete(); void do_tx(); - bool mcast_ck(const UINT8 *buf, int len); void check_irq() { m_irq_cb((m_regs.imr & m_regs.isr & 0x7f)?ASSERT_LINE:CLEAR_LINE); } void recv_overflow(); void stop(); diff --git a/src/devices/machine/i8271.h b/src/devices/machine/i8271.h index dcc5f470713..e4409bed389 100644 --- a/src/devices/machine/i8271.h +++ b/src/devices/machine/i8271.h @@ -244,8 +244,6 @@ private: void set_irq(bool state); bool get_ready(int fid); - void enable_transfer(); - void disable_transfer(); int calc_sector_size(UINT8 size); int check_command(); diff --git a/src/devices/machine/i8279.h b/src/devices/machine/i8279.h index c5e56239b9e..3da46da3121 100644 --- a/src/devices/machine/i8279.h +++ b/src/devices/machine/i8279.h @@ -106,9 +106,7 @@ private: void clear_display(); void new_key(UINT8 data, bool skey, bool ckey); void new_fifo(UINT8 data); - UINT8 get_segments(); void set_irq(bool state); - void set_display_mode(UINT8 data); devcb_write_line m_out_irq_cb; // IRQ devcb_write8 m_out_sl_cb; // Scanlines SL0-3 diff --git a/src/devices/machine/i8355.h b/src/devices/machine/i8355.h index 037e281cd70..7337fa0193d 100644 --- a/src/devices/machine/i8355.h +++ b/src/devices/machine/i8355.h @@ -84,7 +84,6 @@ public: DECLARE_WRITE8_MEMBER( io_w ); DECLARE_READ8_MEMBER( memory_r ); - DECLARE_WRITE8_MEMBER( memory_w ); protected: // device-level overrides diff --git a/src/devices/machine/microtch.h b/src/devices/machine/microtch.h index a3d64804de5..4ee60abede7 100644 --- a/src/devices/machine/microtch.h +++ b/src/devices/machine/microtch.h @@ -11,7 +11,6 @@ class microtouch_device : public device_serial_interface { public: - microtouch_device(const machine_config &mconfig, device_type type, const char* name, const char *tag, device_t *owner, UINT32 clock, const char *shortname, const char *source); microtouch_device(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); template<class _Object> static devcb_base &static_set_stx_callback(device_t &device, _Object object) { return downcast<microtouch_device &>(device).m_out_stx_func.set_callback(object); } diff --git a/src/devices/machine/netlist.h b/src/devices/machine/netlist.h index 568199444d7..c242649d160 100644 --- a/src/devices/machine/netlist.h +++ b/src/devices/machine/netlist.h @@ -178,9 +178,6 @@ public: // construction/destruction netlist_mame_cpu_device_t(const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock); virtual ~netlist_mame_cpu_device_t() {} - - static void static_set_constructor(device_t &device, void (*setup_func)(netlist::setup_t &)); - protected: // netlist_mame_device_t virtual void nl_register_devices() override; diff --git a/src/devices/machine/roc10937.h b/src/devices/machine/roc10937.h index 81ab7a31a63..3acf90726b0 100644 --- a/src/devices/machine/roc10937.h +++ b/src/devices/machine/roc10937.h @@ -55,10 +55,8 @@ public: static void static_set_value(device_t &device, int val); virtual void update_display(); UINT8 m_port_val; - void blank(int data); void shift_clock(int data); void write_char(int data); - void setdata(int segdata, int data); UINT32 set_display(UINT32 segin); DECLARE_WRITE_LINE_MEMBER( sclk ); DECLARE_WRITE_LINE_MEMBER( data ); diff --git a/src/devices/machine/rp5c15.h b/src/devices/machine/rp5c15.h index 03f8cd91d66..1e36dfaf60f 100644 --- a/src/devices/machine/rp5c15.h +++ b/src/devices/machine/rp5c15.h @@ -55,7 +55,6 @@ public: DECLARE_READ8_MEMBER( read ); DECLARE_WRITE8_MEMBER( write ); - DECLARE_WRITE_LINE_MEMBER( adj_w ); protected: // device-level overrides diff --git a/src/devices/machine/tc009xlvc.h b/src/devices/machine/tc009xlvc.h index 9cd3cf3a11e..66911acd4e5 100644 --- a/src/devices/machine/tc009xlvc.h +++ b/src/devices/machine/tc009xlvc.h @@ -43,9 +43,6 @@ public: DECLARE_READ8_MEMBER( tc0091lvc_tvram_r ); DECLARE_WRITE8_MEMBER( tc0091lvc_tvram_w ); - DECLARE_WRITE8_MEMBER( tc0091lvc_bg0_scroll_w ); - DECLARE_WRITE8_MEMBER( tc0091lvc_bg1_scroll_w ); - TILE_GET_INFO_MEMBER(get_bg0_tile_info); TILE_GET_INFO_MEMBER(get_bg1_tile_info); TILE_GET_INFO_MEMBER(get_tx_tile_info); diff --git a/src/devices/machine/v3021.h b/src/devices/machine/v3021.h index 8764c4c3eff..7e4844216c4 100644 --- a/src/devices/machine/v3021.h +++ b/src/devices/machine/v3021.h @@ -53,9 +53,6 @@ protected: virtual void device_start() override; virtual void device_reset() override; - inline UINT8 rtc_read(UINT8 offset); - inline void rtc_write(UINT8 offset,UINT8 data); - static TIMER_CALLBACK( rtc_inc_callback ); UINT8 m_cal_mask,m_cal_com,m_cal_cnt,m_cal_val; diff --git a/src/devices/machine/z80scc.h b/src/devices/machine/z80scc.h index 7c12d8430f6..edd0d9b6992 100644 --- a/src/devices/machine/z80scc.h +++ b/src/devices/machine/z80scc.h @@ -137,7 +137,7 @@ public: UINT8 do_sccreg_rr5(); UINT8 do_sccreg_rr6(); UINT8 do_sccreg_rr7(); - UINT8 do_sccreg_rr8(); +// UINT8 do_sccreg_rr8(); UINT8 do_sccreg_rr9(); UINT8 do_sccreg_rr10(); UINT8 do_sccreg_rr11(); diff --git a/src/devices/sound/mpeg_audio.h b/src/devices/sound/mpeg_audio.h index 615116b6021..e89988d24ae 100644 --- a/src/devices/sound/mpeg_audio.h +++ b/src/devices/sound/mpeg_audio.h @@ -54,9 +54,6 @@ public: // Clear audio buffer void clear(); - // Change the base pointer - void set_base(const void *base); - private: struct limit_hit {}; @@ -111,7 +108,6 @@ private: void build_amplitudes(); void build_next_segments(int step); void retrieve_subbuffer(int step); - void handle_block(int &pos); void idct32(const double *input, double *output); void resynthesis(const double *input, double *output); void scale_and_clamp(const double *input, short *output, int step); diff --git a/src/devices/sound/multipcm.h b/src/devices/sound/multipcm.h index 388dfe6b84c..3abb6bd214e 100644 --- a/src/devices/sound/multipcm.h +++ b/src/devices/sound/multipcm.h @@ -126,7 +126,6 @@ private: // Internal LFO functions void lfo_init(); - INT32 lfo_float_to_fixed(const float value); void lfo_compute_step(lfo_t *lfo, UINT32 lfo_frequency, UINT32 LFOS, INT32 amplitude_lfo); INT32 pitch_lfo_step(lfo_t *lfo); INT32 amplitude_lfo_step(lfo_t *lfo); diff --git a/src/devices/sound/s14001a.h b/src/devices/sound/s14001a.h index 86131138697..c7337bfcdf9 100644 --- a/src/devices/sound/s14001a.h +++ b/src/devices/sound/s14001a.h @@ -55,8 +55,6 @@ private: INT16 m_filtervals[8]; UINT8 m_VSU1000_amp; // amplitude setting on VSU-1000 board - INT16 audiofilter(); - void shiftIntoFilter(INT16 inputvalue); void PostPhoneme(); void s14001a_clock(); }; diff --git a/src/devices/sound/spu.h b/src/devices/sound/spu.h index 4c0a090bd71..77cf99ad700 100644 --- a/src/devices/sound/spu.h +++ b/src/devices/sound/spu.h @@ -233,8 +233,6 @@ public: void reinit_sound(); void kill_sound(); - void update(); - void start_dma(UINT8 *mainram, bool to_spu, UINT32 size); bool play_xa(const unsigned int sector, const unsigned char *sec); bool play_cdda(const unsigned int sector, const unsigned char *sec); diff --git a/src/devices/sound/spureverb.h b/src/devices/sound/spureverb.h index 8a8cb040ba8..9f64c5c7f19 100644 --- a/src/devices/sound/spureverb.h +++ b/src/devices/sound/spureverb.h @@ -66,7 +66,6 @@ const int wetvol_r, const unsigned int sz); - void reset(); }; #endif diff --git a/src/devices/sound/tms5110.h b/src/devices/sound/tms5110.h index 5b5eb3c5124..6dd6c707fff 100644 --- a/src/devices/sound/tms5110.h +++ b/src/devices/sound/tms5110.h @@ -66,10 +66,6 @@ public: DECLARE_READ8_MEMBER( romclk_hack_r ); void set_frequency(int frequency); - - int _speech_rom_read_bit(); - void _speech_rom_set_addr(int addr); - protected: // device-level overrides virtual void device_start() override; diff --git a/src/devices/video/msm6222b.h b/src/devices/video/msm6222b.h index 50268e9e0f1..d86bcd63629 100644 --- a/src/devices/video/msm6222b.h +++ b/src/devices/video/msm6222b.h @@ -27,7 +27,6 @@ public: void control_w(UINT8 data); UINT8 control_r(); void data_w(UINT8 data); - UINT8 data_r(); // Character n bits are at bytes n*16..n*16+7 when 8-high, +10 when 11-high. Only the low 5 bits are used. // In one line mode n = 0..79. In two line mode first line is 0..39 and second is 40..79. diff --git a/src/devices/video/snes_ppu.h b/src/devices/video/snes_ppu.h index 0fa3f830aef..68634c5db60 100644 --- a/src/devices/video/snes_ppu.h +++ b/src/devices/video/snes_ppu.h @@ -256,7 +256,6 @@ public: void set_latch_hv(INT16 x, INT16 y); void dynamic_res_change(); inline UINT32 get_vram_address(); - UINT8 dbg_video(UINT16 curline); UINT8 read(address_space &space, UINT32 offset, UINT8 wrio_bit7); void write(address_space &space, UINT32 offset, UINT8 data); diff --git a/src/devices/video/upd7220.h b/src/devices/video/upd7220.h index 3f96783f7ec..dbde33a93f8 100644 --- a/src/devices/video/upd7220.h +++ b/src/devices/video/upd7220.h @@ -101,10 +101,6 @@ public: DECLARE_WRITE_LINE_MEMBER( ext_sync_w ); DECLARE_WRITE_LINE_MEMBER( lpen_w ); - DECLARE_WRITE8_MEMBER( bank_w ); - DECLARE_READ8_MEMBER( vram_r ); - DECLARE_WRITE8_MEMBER( vram_w ); - UINT32 screen_update(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect); virtual const rom_entry *device_rom_region() const override; virtual const address_space_config *memory_space_config(address_spacenum spacenum = AS_0) const override; |