diff options
author | 2019-11-04 22:04:11 +0100 | |
---|---|---|
committer | 2019-11-04 22:04:11 +0100 | |
commit | 2cf61b2e4c72a80eb688d1b6ffcacfdeaf55bf26 (patch) | |
tree | 0d056f80f69db1a17a680c6e3d8fac06aa6b3e45 /src/lib/netlist/prg/nltool.cpp | |
parent | e89f009945652ea15d941d4491cb8d9c0d2e3b65 (diff) |
netlist: code maintenance. (nw)
- more const
- explicitly raise exceptions instead of leaving this to log.fatal()
- correct a number of cppcheck findings.
- dead code removal
- clang lint corrections, e.g. include order
Diffstat (limited to 'src/lib/netlist/prg/nltool.cpp')
-rw-r--r-- | src/lib/netlist/prg/nltool.cpp | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/src/lib/netlist/prg/nltool.cpp b/src/lib/netlist/prg/nltool.cpp index d1d9ceb89e0..ed4659a12b1 100644 --- a/src/lib/netlist/prg/nltool.cpp +++ b/src/lib/netlist/prg/nltool.cpp @@ -150,7 +150,7 @@ NETLIST_END() class netlist_data_folder_t : public netlist::source_data_t { public: - netlist_data_folder_t(const pstring &folder) + explicit netlist_data_folder_t(const pstring &folder) : netlist::source_data_t() , m_folder(folder) { @@ -176,7 +176,7 @@ private: class netlist_tool_callbacks_t : public netlist::callbacks_t { public: - netlist_tool_callbacks_t(tool_app_t &app) + explicit netlist_tool_callbacks_t(tool_app_t &app) : netlist::callbacks_t() , m_app(app) { } @@ -196,10 +196,6 @@ public: { } - void init() - { - } - netlist::setup_t &setup() { return nlstate().setup(); } void read_netlist(const pstring &filename, const pstring &name, @@ -384,7 +380,6 @@ void tool_app_t::run() //plib::perftime_t<plib::exact_ticks> t; nt.enable_stats(opt_stats()); - nt.init(); if (!opt_verb()) nt.log().verbose.set_enabled(false); @@ -470,7 +465,6 @@ void tool_app_t::run() void tool_app_t::validate() { - std::vector<input_t> inps; netlist_tool_t nt(*this, "netlist"); if (!opt_verb()) @@ -485,8 +479,6 @@ void tool_app_t::validate() try { - nt.init(); - nt.read_netlist(opt_file(), opt_name(), opt_logs(), m_defines, opt_rfolders(), opt_includes()); @@ -515,8 +507,6 @@ void tool_app_t::static_compile() netlist_tool_t nt(*this, "netlist"); - nt.init(); - nt.log().verbose.set_enabled(false); nt.log().info.set_enabled(false); nt.log().warning.set_enabled(false); @@ -623,8 +613,6 @@ void tool_app_t::create_header() { netlist_tool_t nt(*this, "netlist"); - nt.init(); - nt.log().verbose.set_enabled(false); nt.log().info.set_enabled(false); @@ -667,8 +655,6 @@ void tool_app_t::create_docheader() { netlist_tool_t nt(*this, "netlist"); - nt.init(); - nt.log().verbose.set_enabled(false); nt.log().info.set_enabled(false); @@ -716,7 +702,6 @@ void tool_app_t::create_docheader() void tool_app_t::listdevices() { netlist_tool_t nt(*this, "netlist"); - nt.init(); nt.log().verbose.set_enabled(false); nt.log().info.set_enabled(false); @@ -726,8 +711,6 @@ void tool_app_t::listdevices() nt.setup().register_source(plib::make_unique<netlist::source_proc_t>("dummy", &netlist_dummy)); nt.setup().include("dummy"); - - nt.setup().prepare_to_run(); std::vector<netlist::unique_pool_ptr<netlist::core_device_t>> devs; |