summaryrefslogtreecommitdiffstatshomepage
path: root/src/emu/debug/dvdisasm.cpp
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2019-11-18 05:08:36 +1100
committer Vas Crabb <vas@vastheman.com>2019-11-18 05:08:36 +1100
commit88ce545cdda64659894b87fc0b98e1b044eea3e0 (patch)
tree9a1f05f459b773c70a2ef64443cbe8fee2a3ccd1 /src/emu/debug/dvdisasm.cpp
parent1fbfa9e071fe1824ea47c567c23778d8ab33cacf (diff)
misc cleanup:
* Got rid of some more simple_list in core debugger code * Fixed a buffer overrun in wavwrite (buffer half requried size) * Slightly reduced dependencies and overhead in wavwrite * Made new disassembly windows in Qt debugger default to current CPU
Diffstat (limited to 'src/emu/debug/dvdisasm.cpp')
-rw-r--r--src/emu/debug/dvdisasm.cpp13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/emu/debug/dvdisasm.cpp b/src/emu/debug/dvdisasm.cpp
index 667542483a4..f7361ee2229 100644
--- a/src/emu/debug/dvdisasm.cpp
+++ b/src/emu/debug/dvdisasm.cpp
@@ -52,14 +52,14 @@ debug_view_disasm::debug_view_disasm(running_machine &machine, debug_view_osd_up
{
// fail if no available sources
enumerate_sources();
- if(m_source_list.count() == 0)
+ if(m_source_list.empty())
throw std::bad_alloc();
// count the number of comments
int total_comments = 0;
- for(const debug_view_source &source : m_source_list)
+ for(auto &source : m_source_list)
{
- const debug_view_disasm_source &dasmsource = downcast<const debug_view_disasm_source &>(source);
+ const debug_view_disasm_source &dasmsource = downcast<const debug_view_disasm_source &>(*source);
total_comments += dasmsource.device()->debug()->comment_count();
}
@@ -86,7 +86,7 @@ debug_view_disasm::~debug_view_disasm()
void debug_view_disasm::enumerate_sources()
{
// start with an empty list
- m_source_list.reset();
+ m_source_list.clear();
// iterate over devices with disassembly interfaces
std::string name;
@@ -94,11 +94,12 @@ void debug_view_disasm::enumerate_sources()
{
name = string_format("%s '%s'", dasm.device().name(), dasm.device().tag());
if(dasm.device().memory().space_config(AS_PROGRAM)!=nullptr)
- m_source_list.append(*global_alloc(debug_view_disasm_source(name.c_str(), dasm.device())));
+ m_source_list.emplace_back(std::make_unique<debug_view_disasm_source>(name.c_str(), dasm.device()));
}
// reset the source to a known good entry
- set_source(*m_source_list.first());
+ if (!m_source_list.empty())
+ set_source(*m_source_list[0]);
}