diff options
author | 2020-05-25 16:42:42 +0200 | |
---|---|---|
committer | 2020-05-25 16:42:57 +0200 | |
commit | 22513fb6fe281f5ccb75aaddb6417a12a66c313d (patch) | |
tree | 3cf84032cc6482d685a8dbb57e015bd17c7f7fdc /src/devices/cpu/tms32031/tms32031.cpp | |
parent | e42c2d2874cf9c1092c01ab5ce9ef997d465ce25 (diff) |
emumem: A little more speedup. cache and specific change syntax, and are not pointers anymore [O. Galibert]
The last(?) two changes are:
- Add a template parameter to everything (theoretically the address
space width, in practice a level derived from it to keep as much
compatibility between widths as possible) so that the shift size
becomes a constant.
- Change the syntax of declaring and initializing the caches and
specifics so that they're embedded in the owner device. Solves
lifetime issues and also removes one indirection (looking up the base
dispatch pointer through the cache/specific pointer).
Diffstat (limited to 'src/devices/cpu/tms32031/tms32031.cpp')
-rw-r--r-- | src/devices/cpu/tms32031/tms32031.cpp | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/src/devices/cpu/tms32031/tms32031.cpp b/src/devices/cpu/tms32031/tms32031.cpp index d7ace7fdb08..a90455c8bd4 100644 --- a/src/devices/cpu/tms32031/tms32031.cpp +++ b/src/devices/cpu/tms32031/tms32031.cpp @@ -392,8 +392,6 @@ tms3203x_device::tms3203x_device(const machine_config &mconfig, device_type type m_irq_pending(false), m_is_idling(false), m_icount(0), - m_program(nullptr), - m_cache(nullptr), m_internal_rom(*this, "internal_rom"), m_mcbl_mode(false), m_xf0_cb(*this), @@ -463,7 +461,7 @@ const tiny_rom_entry *tms3203x_device::device_rom_region() const inline uint32_t tms3203x_device::ROPCODE(offs_t pc) { - return m_cache->read_dword(pc); + return m_cache.read_dword(pc); } @@ -473,7 +471,7 @@ inline uint32_t tms3203x_device::ROPCODE(offs_t pc) inline uint32_t tms3203x_device::RMEM(offs_t addr) { - return m_program->read_dword(addr); + return m_program.read_dword(addr); } @@ -483,7 +481,7 @@ inline uint32_t tms3203x_device::RMEM(offs_t addr) inline void tms3203x_device::WMEM(offs_t addr, uint32_t data) { - m_program->write_dword(addr, data); + m_program.write_dword(addr, data); } @@ -494,8 +492,8 @@ inline void tms3203x_device::WMEM(offs_t addr, uint32_t data) void tms3203x_device::device_start() { // find address spaces - m_program = &space(AS_PROGRAM); - m_cache = m_program->cache<2, -2, ENDIANNESS_LITTLE>(); + space(AS_PROGRAM).cache(m_cache); + space(AS_PROGRAM).specific(m_program); // resolve devcb handlers m_xf0_cb.resolve_safe(); @@ -507,9 +505,9 @@ void tms3203x_device::device_start() if (m_mcbl_mode) { if (m_internal_rom->base() != nullptr) - m_program->install_rom(0x000000, 0x000fff, m_internal_rom->base()); + m_program.space().install_rom(0x000000, 0x000fff, m_internal_rom->base()); else - m_program->unmap_read(0x000000, 0x000fff); + m_program.space().unmap_read(0x000000, 0x000fff); } // save state @@ -853,9 +851,9 @@ void tms3203x_device::execute_set_input(int inputnum, int state) if (m_mcbl_mode != old_mode) { if (m_mcbl_mode && (m_internal_rom->base() != nullptr)) - m_program->install_rom(0x000000, 0x000fff, m_internal_rom->base()); + m_program.space().install_rom(0x000000, 0x000fff, m_internal_rom->base()); else - m_program->unmap_read(0x000000, 0x000fff); + m_program.space().unmap_read(0x000000, 0x000fff); } return; } |