summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2025-08-31 04:54:10 +1000
committer Vas Crabb <vas@vastheman.com>2025-08-31 04:54:10 +1000
commita17c87d7e5c6c635cdeedb1a7d6d2d5b8fca556c (patch)
treed8c230d6a1cc5456b89cda6360d21746b90460f7
parent345f8de2a272f116a5d0d5094ae5b154fe6f275f (diff)
Tidied various things, added side effect checks for some reads.
-rw-r--r--scripts/src/bus.lua12
-rw-r--r--scripts/src/machine.lua36
-rw-r--r--src/devices/bus/isa/amgda.cpp9
-rw-r--r--src/devices/machine/sega_md_ioport.cpp (renamed from src/devices/bus/megadrive/ctrl/mdioport.cpp)2
-rw-r--r--src/devices/machine/sega_md_ioport.h (renamed from src/devices/bus/megadrive/ctrl/mdioport.h)6
-rw-r--r--src/mame/gaelco/ds5002fp_programmer.cpp26
-rw-r--r--src/mame/nintendo/nes_vt32.cpp2
-rw-r--r--src/mame/nintendo/nes_vt369_vtunknown.cpp1
-rw-r--r--src/mame/pc/teradrive.cpp2
-rw-r--r--src/mame/philips/mcd212.cpp24
-rw-r--r--src/mame/sega/megadriv.h2
-rw-r--r--src/mame/sega/megadriv_firecore.cpp18
-rw-r--r--src/mame/sega/megadriv_unksoc.cpp6
-rw-r--r--src/mame/sega/sms.h2
-rw-r--r--src/mame/skeleton/blaucds32.cpp1
-rw-r--r--src/mame/ta/alphatpx.cpp59
16 files changed, 106 insertions, 102 deletions
diff --git a/scripts/src/bus.lua b/scripts/src/bus.lua
index d96d031cc1f..48bab075b1a 100644
--- a/scripts/src/bus.lua
+++ b/scripts/src/bus.lua
@@ -3861,18 +3861,6 @@ if (BUSES["MEGADRIVE"]~=null) then
}
end
----------------------------------------------------
---
---@src/devices/bus/megadrive/ctrl/mdioport.h,BUSES["MEGADRIVE_CTRL"] = true
----------------------------------------------------
-
-if (BUSES["MEGADRIVE_CTRL"]~=null) then
- files {
- MAME_DIR .. "src/devices/bus/megadrive/ctrl/mdioport.cpp",
- MAME_DIR .. "src/devices/bus/megadrive/ctrl/mdioport.h",
- }
-end
-
---------------------------------------------------
--
diff --git a/scripts/src/machine.lua b/scripts/src/machine.lua
index 87732d0df8d..7619769a554 100644
--- a/scripts/src/machine.lua
+++ b/scripts/src/machine.lua
@@ -3388,6 +3388,30 @@ end
---------------------------------------------------
--
+--@src/devices/machine/sega_md_ioport.h,MACHINES["SEGA_MD_IOPORT"] = true
+---------------------------------------------------
+
+if (BUSES["SEGA_MD_IOPORT"]~=null) then
+ files {
+ MAME_DIR .. "src/devices/machine/sega_md_ioport.cpp",
+ MAME_DIR .. "src/devices/machine/sega_md_ioport.h",
+ }
+end
+
+---------------------------------------------------
+--
+--@src/devices/machine/sega_scu.h,MACHINES["SEGA_SCU"] = true
+---------------------------------------------------
+
+if (MACHINES["SEGA_SCU"]~=null) then
+ files {
+ MAME_DIR .. "src/devices/machine/sega_scu.cpp",
+ MAME_DIR .. "src/devices/machine/sega_scu.h",
+ }
+end
+
+---------------------------------------------------
+--
--@src/devices/machine/sensorboard.h,MACHINES["SENSORBOARD"] = true
---------------------------------------------------
@@ -3424,18 +3448,6 @@ end
---------------------------------------------------
--
---@src/devices/machine/sega_scu.h,MACHINES["SEGA_SCU"] = true
----------------------------------------------------
-
-if (MACHINES["SEGA_SCU"]~=null) then
- files {
- MAME_DIR .. "src/devices/machine/sega_scu.cpp",
- MAME_DIR .. "src/devices/machine/sega_scu.h",
- }
-end
-
----------------------------------------------------
---
--@src/devices/machine/spg2xx.h,MACHINES["SPG2XX"] = true
--@src/devices/machine/spg110.h,MACHINES["SPG2XX"] = true
--@src/devices/machine/generalplus_gpl16250soc.h,MACHINES["SPG2XX"] = true
diff --git a/src/devices/bus/isa/amgda.cpp b/src/devices/bus/isa/amgda.cpp
index 04ca7f37c92..e2add83d4a4 100644
--- a/src/devices/bus/isa/amgda.cpp
+++ b/src/devices/bus/isa/amgda.cpp
@@ -42,6 +42,9 @@
//#define VERBOSE (LOG_GENERAL|LOG_REGR|LOG_REGW|LOG_MODE|LOG_VRAM)
#include "logmacro.h"
+
+namespace {
+
class isa16_amgda_device
: public device_t
, public device_isa16_card_interface
@@ -124,8 +127,6 @@ private:
bool m_aw; // automatic write
};
-DEFINE_DEVICE_TYPE_PRIVATE(ISA16_AMGDA, device_isa16_card_interface, isa16_amgda_device, "isa16_amgda_device", "IBM Advanced Monochrome Graphics Display Adapter")
-
void isa16_amgda_device::device_add_mconfig(machine_config &config)
{
// monitor has 25.7MHz nominal bandwidth
@@ -461,3 +462,7 @@ u8 isa16_amgda_device::alu(unsigned const byte) const
// FIXME: undocumented functions 1 and 3
return 0;
}
+
+} // anonymous namespace
+
+DEFINE_DEVICE_TYPE_PRIVATE(ISA16_AMGDA, device_isa16_card_interface, isa16_amgda_device, "isa16_amgda_device", "IBM Advanced Monochrome Graphics Display Adapter")
diff --git a/src/devices/bus/megadrive/ctrl/mdioport.cpp b/src/devices/machine/sega_md_ioport.cpp
index 3dc1a239f8d..6a7606a7992 100644
--- a/src/devices/bus/megadrive/ctrl/mdioport.cpp
+++ b/src/devices/machine/sega_md_ioport.cpp
@@ -15,7 +15,7 @@
***********************************************************************/
#include "emu.h"
-#include "mdioport.h"
+#include "sega_md_ioport.h"
#include <cassert>
diff --git a/src/devices/bus/megadrive/ctrl/mdioport.h b/src/devices/machine/sega_md_ioport.h
index eddefb02326..0c87023395a 100644
--- a/src/devices/bus/megadrive/ctrl/mdioport.h
+++ b/src/devices/machine/sega_md_ioport.h
@@ -14,8 +14,8 @@
connector.
***********************************************************************/
-#ifndef MAME_BUS_MEGADRIVE_CTRL_MDIOPORT_H
-#define MAME_BUS_MEGADRIVE_CTRL_MDIOPORT_H
+#ifndef MAME_MACHINE_SEGA_MD_IOPORT_H
+#define MAME_MACHINE_SEGA_MD_IOPORT_H
#pragma once
@@ -206,4 +206,4 @@ private:
DECLARE_DEVICE_TYPE(MEGADRIVE_IO_PORT, megadrive_io_port_device)
DECLARE_DEVICE_TYPE(GAMEGEAR_IO_PORT, gamegear_io_port_device)
-#endif // MAME_BUS_MEGADRIVE_CTRL_MDIOPORT_H
+#endif // MAME_MACHINE_SEGA_MD_IOPORT_H
diff --git a/src/mame/gaelco/ds5002fp_programmer.cpp b/src/mame/gaelco/ds5002fp_programmer.cpp
index 3161bcaa2f5..c6d229251a6 100644
--- a/src/mame/gaelco/ds5002fp_programmer.cpp
+++ b/src/mame/gaelco/ds5002fp_programmer.cpp
@@ -57,10 +57,9 @@ public:
: driver_device(mconfig, type, tag)
, m_maincpu(*this, "maincpu")
, m_cart(*this, "cartslot")
- , m_cart_region(nullptr)
{ }
- void ds5002fp_programmer(machine_config &config);
+ void ds5002fp_programmer(machine_config &config) ATTR_COLD;
private:
virtual void machine_start() override ATTR_COLD;
@@ -68,25 +67,16 @@ private:
uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect);
- DECLARE_DEVICE_IMAGE_LOAD_MEMBER(cart_load);
+ DECLARE_DEVICE_IMAGE_LOAD_MEMBER(cart_load) ATTR_COLD;
void prg_map(address_map &map);
- u16 cart_r(offs_t offset);
-
required_device<cpu_device> m_maincpu;
required_device<generic_slot_device> m_cart;
- memory_region *m_cart_region;
};
void ds5002fp_programmer_state::machine_start()
{
- // if there's a cart, override the standard mapping
- if (m_cart && m_cart->exists())
- {
- std::string region_tag;
- m_cart_region = memregion(region_tag.assign(m_cart->tag()).append(GENERIC_ROM_REGION_TAG).c_str());
- }
}
void ds5002fp_programmer_state::machine_reset()
@@ -95,7 +85,7 @@ void ds5002fp_programmer_state::machine_reset()
void ds5002fp_programmer_state::prg_map(address_map &map)
{
- map(0x000000, 0x01ffff).r(FUNC(ds5002fp_programmer_state::cart_r));
+ map(0x000000, 0x01ffff).r(m_cart, FUNC(generic_slot_device::read16_rom));
}
@@ -103,17 +93,15 @@ DEVICE_IMAGE_LOAD_MEMBER(ds5002fp_programmer_state::cart_load)
{
uint32_t const size = m_cart->common_get_size("rom");
+ if ((size > 0x020000) | (size & 0x000001))
+ return std::make_pair(image_error::INVALIDLENGTH, "Unsupported ROM size (must be 16 bits wide and no larger than 128K)");
+
m_cart->rom_alloc(size, GENERIC_ROM16_WIDTH, ENDIANNESS_BIG);
m_cart->common_load_rom(m_cart->get_rom_base(), size, "rom");
return std::make_pair(std::error_condition(), std::string());
}
-u16 ds5002fp_programmer_state::cart_r(offs_t offset)
-{
- return m_cart->read_rom(offset * 2) | (m_cart->read_rom((offset * 2) + 1) << 8);
-}
-
static INPUT_PORTS_START( ds5002fp_programmer )
INPUT_PORTS_END
@@ -137,4 +125,4 @@ ROM_END
} // anonymous namespace
-CONS( 1992, gaelcods, 0, 0, ds5002fp_programmer, ds5002fp_programmer, ds5002fp_programmer_state, empty_init, "Gaelco", "Gaelco DS5002FP Programmer", MACHINE_NO_SOUND_HW | MACHINE_NOT_WORKING )
+SYST( 1992, gaelcods, 0, 0, ds5002fp_programmer, ds5002fp_programmer, ds5002fp_programmer_state, empty_init, "Gaelco", "Gaelco DS5002FP Programmer", MACHINE_NO_SOUND_HW | MACHINE_NOT_WORKING )
diff --git a/src/mame/nintendo/nes_vt32.cpp b/src/mame/nintendo/nes_vt32.cpp
index 16d8a9ffe07..067d305f939 100644
--- a/src/mame/nintendo/nes_vt32.cpp
+++ b/src/mame/nintendo/nes_vt32.cpp
@@ -448,8 +448,6 @@ ROM_START( retror30 )
ROM_LOAD( "s29gl032n90tfi03.u2", 0x00000, 0x400000, CRC(dfb89ef7) SHA1(401539b73521e018e3af70b8019e6b59ba67fcad) )
ROM_END
-
-
} // anonymous namespace
diff --git a/src/mame/nintendo/nes_vt369_vtunknown.cpp b/src/mame/nintendo/nes_vt369_vtunknown.cpp
index 5c12d91e592..e4b4233f6f9 100644
--- a/src/mame/nintendo/nes_vt369_vtunknown.cpp
+++ b/src/mame/nintendo/nes_vt369_vtunknown.cpp
@@ -1205,7 +1205,6 @@ CONS( 2017, rtvgc300fz,0, 0, vt36x_32mb_2banks_lexi300, vt369, vt36x_state, em
(Handheld units, but different form factor to Compact Cyber Arcade, charged via USB, different menus)
Lexibook Console Colour - Barbie
-
(units for use with TV)
Lexibook Retro TV Game Console (300 Games) - Cars
Lexibook Retro TV Game Console (300 Games) - PJ Masks
diff --git a/src/mame/pc/teradrive.cpp b/src/mame/pc/teradrive.cpp
index 14c3bd1dc50..e397edbd9c0 100644
--- a/src/mame/pc/teradrive.cpp
+++ b/src/mame/pc/teradrive.cpp
@@ -54,7 +54,6 @@ TODO:
#include "bus/isa/isa.h"
#include "bus/isa/isa_cards.h"
#include "bus/isa/svga_paradise.h"
-#include "bus/megadrive/ctrl/mdioport.h"
#include "bus/pc_kbd/keyboards.h"
#include "bus/pc_kbd/pc_kbdc.h"
#include "bus/sms_ctrl/controllers.h"
@@ -65,6 +64,7 @@ TODO:
#include "cpu/z80/z80.h"
#include "machine/input_merger.h"
#include "machine/ram.h"
+#include "machine/sega_md_ioport.h"
#include "machine/wd7600.h"
#include "sound/spkrdev.h"
#include "sound/ymopn.h"
diff --git a/src/mame/philips/mcd212.cpp b/src/mame/philips/mcd212.cpp
index 3dad8021cd4..e69cea450da 100644
--- a/src/mame/philips/mcd212.cpp
+++ b/src/mame/philips/mcd212.cpp
@@ -332,7 +332,7 @@ void mcd212_device::process_ica()
uint16_t *ica = Path ? m_planeb.target() : m_planea.target();
const int max_to_process = m_ica_height * 120;
// LCT depends on the current frame parity
- uint32_t addr = (BIT(m_csrr[0], CSR1R_PA_BIT) == 0) ? 0x200 : 0x202;
+ uint32_t addr = !BIT(m_csrr[0], CSR1R_PA_BIT) ? 0x200 : 0x202;
for (int i = 0; i < max_to_process; i++)
{
@@ -973,14 +973,15 @@ uint32_t mcd212_device::screen_update(screen_device &screen, bitmap_rgb32 &bitma
return 0; // Do nothing on the extended rows.
}
+ // FIXME this should use the clipping rectangle to determine which lines need drawing
int scanline = screen.vpos();
// Process VSR and mix if we're in the visible region
if (scanline >= m_ica_height)
{
- uint32_t bitmap_line = ((scanline - m_ica_height) << 1) + m_ica_height;
- uint32_t *out = &bitmap.pix(bitmap_line + (!BIT(m_csrr[0], CSR1R_PA_BIT)));
- uint32_t* out2 = &bitmap.pix(bitmap_line + (BIT(m_csrr[0], CSR1R_PA_BIT)));
+ uint32_t const bitmap_line = ((scanline - m_ica_height) << 1) + m_ica_height;
+ uint32_t *const out = &bitmap.pix(bitmap_line + BIT(~m_csrr[0], CSR1R_PA_BIT));
+ uint32_t *const out2 = &bitmap.pix(bitmap_line + BIT(m_csrr[0], CSR1R_PA_BIT));
bool draw_line = true;
if (!BIT(m_dcr[0], DCR_FD_BIT) && BIT(m_csrw[0], CSR1W_ST_BIT))
@@ -1035,14 +1036,16 @@ uint32_t mcd212_device::screen_update(screen_device &screen, bitmap_rgb32 &bitma
draw_cursor(out);
}
- if (BIT(m_dcr[0], DCR_SM_BIT)) {
+ if (BIT(m_dcr[0], DCR_SM_BIT))
+ {
// Interlace Output
- memcpy(out2, m_interlace_field[scanline], 768 * sizeof(uint32_t));
- memcpy(m_interlace_field[scanline], out, 768 * sizeof(uint32_t));
+ std::copy_n(m_interlace_field[scanline], 768, out2);
+ std::copy_n(out, 768, m_interlace_field[scanline]);
}
- else {
+ else
+ {
// Single Field Output (duplicate lines)
- memcpy(out2, out, 768 * sizeof(uint32_t));
+ std::copy_n(out, 768, out2);
}
}
@@ -1134,9 +1137,8 @@ void mcd212_device::device_reset()
m_ica_height = 32;
m_total_height = 312;
m_blink_time = 0;
- for (int i = 0; i < 312; i++) {
+ for (int i = 0; i < 312; i++)
std::fill_n(m_interlace_field[i], 768, 0);
- }
m_int_callback(CLEAR_LINE);
diff --git a/src/mame/sega/megadriv.h b/src/mame/sega/megadriv.h
index 30a786928c6..ac670e5c2c3 100644
--- a/src/mame/sega/megadriv.h
+++ b/src/mame/sega/megadriv.h
@@ -5,9 +5,9 @@
#pragma once
-#include "bus/megadrive/ctrl/mdioport.h"
#include "cpu/m68000/m68000.h"
#include "cpu/z80/z80.h"
+#include "machine/sega_md_ioport.h"
#include "sound/sn76496.h"
#include "sound/ymopn.h"
#include "video/315_5313.h"
diff --git a/src/mame/sega/megadriv_firecore.cpp b/src/mame/sega/megadriv_firecore.cpp
index 2dc7b2f1f55..d47eb960f7a 100644
--- a/src/mame/sega/megadriv_firecore.cpp
+++ b/src/mame/sega/megadriv_firecore.cpp
@@ -29,15 +29,15 @@ public:
m_rom(*this, "maincpu")
{ }
- void megadriv_firecore_3button_ntsc(machine_config &config);
- void megadriv_firecore_3button_pal(machine_config &config);
- void megadriv_firecore_6button_ntsc(machine_config &config);
-
- void init_atgame40();
- void init_dcat();
- void init_mdhh100();
- void init_sarc110();
- void init_reactmd();
+ void megadriv_firecore_3button_ntsc(machine_config &config) ATTR_COLD;
+ void megadriv_firecore_3button_pal(machine_config &config) ATTR_COLD;
+ void megadriv_firecore_6button_ntsc(machine_config &config) ATTR_COLD;
+
+ void init_atgame40() ATTR_COLD;
+ void init_dcat() ATTR_COLD;
+ void init_mdhh100() ATTR_COLD;
+ void init_sarc110() ATTR_COLD;
+ void init_reactmd() ATTR_COLD;
private:
virtual void machine_start() override ATTR_COLD;
diff --git a/src/mame/sega/megadriv_unksoc.cpp b/src/mame/sega/megadriv_unksoc.cpp
index 221f034340e..f0cd1473c54 100644
--- a/src/mame/sega/megadriv_unksoc.cpp
+++ b/src/mame/sega/megadriv_unksoc.cpp
@@ -25,9 +25,9 @@ public:
m_rom(*this, "maincpu")
{ }
- void megadriv_dgunl_ntsc(machine_config &config);
+ void megadriv_dgunl_ntsc(machine_config &config) ATTR_COLD;
- void init_dgunl3227();
+ void init_dgunl3227() ATTR_COLD;
protected:
virtual void machine_start() override ATTR_COLD;
@@ -59,7 +59,7 @@ public:
void megadriv_ra145_ntsc(machine_config &config);
- void init_ra145();
+ void init_ra145() ATTR_COLD;
protected:
virtual void machine_reset() override ATTR_COLD;
diff --git a/src/mame/sega/sms.h b/src/mame/sega/sms.h
index 5ae97e5c684..2b68a72498c 100644
--- a/src/mame/sega/sms.h
+++ b/src/mame/sega/sms.h
@@ -10,11 +10,11 @@
#pragma once
-#include "bus/megadrive/ctrl/mdioport.h"
#include "bus/sega8/sega8_slot.h"
#include "bus/sg1000_exp/sg1000exp.h"
#include "bus/sms_ctrl/smsctrl.h"
#include "bus/sms_exp/smsexp.h"
+#include "machine/sega_md_ioport.h"
#include "machine/timer.h"
#include "sound/ymopl.h"
#include "video/315_5124.h"
diff --git a/src/mame/skeleton/blaucds32.cpp b/src/mame/skeleton/blaucds32.cpp
index 2e2863bf9e6..9384cec37fc 100644
--- a/src/mame/skeleton/blaucds32.cpp
+++ b/src/mame/skeleton/blaucds32.cpp
@@ -139,6 +139,7 @@ ROM_START( blaucds32 )
ROM_REGION( 0x0eb, "prom", 0 )
ROM_LOAD( "n82s153n.v4245", 0x00000, 0x000eb, NO_DUMP ) // On main PCB
ROM_END
+
} // anonymous namespace
diff --git a/src/mame/ta/alphatpx.cpp b/src/mame/ta/alphatpx.cpp
index d9a7665ca0b..1e07ec4dd6e 100644
--- a/src/mame/ta/alphatpx.cpp
+++ b/src/mame/ta/alphatpx.cpp
@@ -343,17 +343,20 @@ void alphatp_34_state::alphatp30_8088_io(address_map &map)
u8 alphatp_34_state::start88_r(offs_t offset)
{
- if(!offset)
+ if (!machine().side_effects_disabled())
{
- if(m_i8088 && !m_88_started)
+ if (!offset)
{
- m_i8088->resume(SUSPEND_REASON_DISABLE);
- m_88_started = true;
+ if (m_i8088 && !m_88_started)
+ {
+ m_i8088->resume(SUSPEND_REASON_DISABLE);
+ m_88_started = true;
+ }
+ m_i8088->set_input_line(INPUT_LINE_TEST, ASSERT_LINE);
}
- m_i8088->set_input_line(INPUT_LINE_TEST, ASSERT_LINE);
+ else
+ m_i8088->set_input_line(INPUT_LINE_TEST, CLEAR_LINE);
}
- else
- m_i8088->set_input_line(INPUT_LINE_TEST, CLEAR_LINE);
return 0;
}
@@ -364,28 +367,34 @@ void alphatp_34_state::bank_w(u8 data)
u8 alphatp_34_state::comm88_r(offs_t offset)
{
- if(!offset)
+ if (!offset)
return (m_85_da ? 0 : 1) | (m_88_da ? 0 : 0x80);
- if(m_i8088)
- m_i8088->set_input_line(INPUT_LINE_TEST, ASSERT_LINE);
- m_85_da = false;
+ if (!machine().side_effects_disabled())
+ {
+ if (m_i8088)
+ m_i8088->set_input_line(INPUT_LINE_TEST, ASSERT_LINE);
+ m_85_da = false;
+ }
return m_85_data;
}
void alphatp_34_state::comm88_w(u8 data)
{
m_88_data = data;
- if(m_pic)
+ if (m_pic)
m_pic->ir2_w(ASSERT_LINE);
m_88_da = true;
}
u8 alphatp_34_state::comm85_r(offs_t offset)
{
- if(!offset)
+ if (!offset)
return m_88_da ? 0 : 1;
- m_pic->ir2_w(CLEAR_LINE);
- m_88_da = false;
+ if (!machine().side_effects_disabled())
+ {
+ m_pic->ir2_w(CLEAR_LINE);
+ m_88_da = false;
+ }
return m_88_data;
}
@@ -417,7 +426,7 @@ u8* alphatp_34_state::vramext_addr_xlate(offs_t offset)
offset = offset >> 3;
int bank = offset >> 7;
int offs = offset & 0x7f;
- if(offs < 80)
+ if (offs < 80)
return &m_vramext[(((((m_gfxext2 & 0xf8) << 2) + bank) * 80) + offs) % (371*80)];
else
return &m_vramchr[(((((m_gfxext2 & 0x8) << 2) ^ bank) * 48) + (offs - 80)) % (256*12)];
@@ -425,23 +434,25 @@ u8* alphatp_34_state::vramext_addr_xlate(offs_t offset)
u8 alphatp_34_state::gfxext_r(offs_t offset)
{
- switch(m_gfxext1)
+ switch (m_gfxext1)
{
case 0x33:
- m_vramlatch = *vramext_addr_xlate(offset);
+ if (!machine().side_effects_disabled())
+ m_vramlatch = *vramext_addr_xlate(offset);
return 0;
}
- logerror("gfxext read offset %x %x\n", offset, m_gfxext1);
+ if (!machine().side_effects_disabled())
+ logerror("gfxext read offset %x %x\n", offset, m_gfxext1);
return 0;
}
void alphatp_34_state::gfxext_w(offs_t offset, u8 data)
{
- switch(m_gfxext1)
+ switch (m_gfxext1)
{
case 5:
{
- if(m_gfxext3 == 0xe0f)
+ if (m_gfxext3 == 0xe0f)
data = ~data;
u8 mask = 1 << (offset & 7);
u8 *addr = vramext_addr_xlate(offset);
@@ -458,7 +469,7 @@ void alphatp_34_state::gfxext_w(offs_t offset, u8 data)
default:
logerror("gfxext write offset %x %x %x\n", offset, data, m_gfxext1);
}
- if((offset & 0x3ff) > 0x280)
+ if ((offset & 0x3ff) > 0x280)
m_gfxdecode->gfx(1)->mark_dirty(((uintptr_t)vramext_addr_xlate(offset) - (uintptr_t)m_vramchr) / 12);
}
@@ -965,7 +976,7 @@ u32 alphatp_34_state::screen_update(screen_device &screen, bitmap_rgb32 &bitmap,
if (scrext)
{
offs_t offset = (((vramy * 12) + line) * 80) + x;
- if(offset < (371 * 80))
+ if (offset < (371 * 80))
data = m_vramext[offset];
code = 0;
}
@@ -1271,7 +1282,7 @@ void alphatp_34_state::machine_start()
save_item(NAME(m_vramext));
m_kbdclk = 0; // must be initialized here b/c mcs48_reset() causes write of 0xff to all ports
- if(m_i8088)
+ if (m_i8088)
m_gfxdecode->set_gfx(1, std::make_unique<gfx_element>(m_palette, extcharlayout, &m_vramchr[0], 0, 1, 0));
}