diff options
author | 2020-04-08 17:10:21 +0200 | |
---|---|---|
committer | 2020-04-08 11:10:21 -0400 | |
commit | e9f6bd8d019ee808f592f0fce846dba3b129ebed (patch) | |
tree | 3499aa6f0631f0bbdfdfc17a213b2f16ef47adb2 | |
parent | efceabc768ceacdaa6d88ff9eb23f909efc1723a (diff) |
Revert "fixed some modernize-use-equals-default clang-tidy warnings (… (#6360)
* Revert "fixed some modernize-use-equals-default clang-tidy warnings (nw)"
This reverts commit 54486ab9
* fixed merge error
40 files changed, 137 insertions, 40 deletions
diff --git a/src/lib/util/avhuff.cpp b/src/lib/util/avhuff.cpp index 73a41df50d7..50eea9f24dc 100644 --- a/src/lib/util/avhuff.cpp +++ b/src/lib/util/avhuff.cpp @@ -679,6 +679,18 @@ uint16_t *avhuff_encoder::deltarle_encoder::rle_and_histo_bitmap(const uint8_t * //************************************************************************** /** + * @fn avhuff_decoder::avhuff_decoder() + * + * @brief ------------------------------------------------- + * avhuff_decoder - constructor + * -------------------------------------------------. + */ + +avhuff_decoder::avhuff_decoder() +{ +} + +/** * @fn void avhuff_decoder::configure(const avhuff_decompress_config &config) * * @brief ------------------------------------------------- diff --git a/src/lib/util/avhuff.h b/src/lib/util/avhuff.h index d14046e1f62..90ef43e977f 100644 --- a/src/lib/util/avhuff.h +++ b/src/lib/util/avhuff.h @@ -144,7 +144,7 @@ class avhuff_decoder { public: // construction/destruction - avhuff_decoder() = default; + avhuff_decoder(); // configuration void configure(const avhuff_decompress_config &config); diff --git a/src/lib/util/aviio.cpp b/src/lib/util/aviio.cpp index 067f81fef27..8722017d3e8 100644 --- a/src/lib/util/aviio.cpp +++ b/src/lib/util/aviio.cpp @@ -3803,3 +3803,13 @@ const char *avi_file::error_string(error err) default: return "undocumented error"; } } + + +avi_file::avi_file() +{ +} + + +avi_file::~avi_file() +{ +} diff --git a/src/lib/util/aviio.h b/src/lib/util/aviio.h index 8aa36d80b8b..c951f71b22f 100644 --- a/src/lib/util/aviio.h +++ b/src/lib/util/aviio.h @@ -111,7 +111,7 @@ public: static error open(std::string const &filename, ptr &file); static error create(std::string const &filename, movie_info const &info, ptr &file); - virtual ~avi_file() = default; + virtual ~avi_file(); virtual void printf_chunks() = 0; static const char *error_string(error err); @@ -128,7 +128,7 @@ public: virtual error append_sound_samples(int channel, std::int16_t const *samples, std::uint32_t numsamples, std::uint32_t sampleskip) = 0; protected: - avi_file() = default; + avi_file(); }; #endif // MAME_LIB_UTIL_AVIIO_H diff --git a/src/lib/util/chdcodec.cpp b/src/lib/util/chdcodec.cpp index 3f76af302bd..58f7b4291db 100644 --- a/src/lib/util/chdcodec.cpp +++ b/src/lib/util/chdcodec.cpp @@ -124,7 +124,7 @@ class chd_lzma_compressor : public chd_compressor public: // construction/destruction chd_lzma_compressor(chd_file &chd, uint32_t hunkbytes, bool lossy); - ~chd_lzma_compressor() = default; + ~chd_lzma_compressor(); // core functionality virtual uint32_t compress(const uint8_t *src, uint32_t srclen, uint8_t *dest) override; @@ -497,6 +497,15 @@ chd_codec::chd_codec(chd_file &chd, uint32_t hunkbytes, bool lossy) //------------------------------------------------- +// ~chd_codec - destructor +//------------------------------------------------- + +chd_codec::~chd_codec() +{ +} + + +//------------------------------------------------- // configure - configuration //------------------------------------------------- @@ -1045,6 +1054,15 @@ chd_lzma_compressor::chd_lzma_compressor(chd_file &chd, uint32_t hunkbytes, bool //------------------------------------------------- +// ~chd_lzma_compressor - destructor +//------------------------------------------------- + +chd_lzma_compressor::~chd_lzma_compressor() +{ +} + + +//------------------------------------------------- // compress - compress data using the LZMA codec //------------------------------------------------- diff --git a/src/lib/util/chdcodec.h b/src/lib/util/chdcodec.h index 8be99b2e710..e688b41a108 100644 --- a/src/lib/util/chdcodec.h +++ b/src/lib/util/chdcodec.h @@ -50,7 +50,7 @@ protected: public: // allow public deletion - virtual ~chd_codec() = default; + virtual ~chd_codec(); // accessors chd_file &chd() const { return m_chd; } diff --git a/src/lib/util/corefile.cpp b/src/lib/util/corefile.cpp index d241dac6ed1..2de0d7c378d 100644 --- a/src/lib/util/corefile.cpp +++ b/src/lib/util/corefile.cpp @@ -143,7 +143,7 @@ class core_proxy_file : public core_file { public: core_proxy_file(core_file &file) : m_file(file) { } - virtual ~core_proxy_file() override = default; + virtual ~core_proxy_file() override { } virtual osd_file::error compress(int level) override { return m_file.compress(level); } virtual int seek(std::int64_t offset, int whence) override { return m_file.seek(offset, whence); } @@ -1233,6 +1233,15 @@ osd_file::error core_file::load(std::string const &filename, std::vector<uint8_t return osd_file::error::NONE; } + +/*------------------------------------------------- + protected constructor +-------------------------------------------------*/ + +core_file::core_file() +{ +} + } // namespace util diff --git a/src/lib/util/corefile.h b/src/lib/util/corefile.h index 99496b964e8..d286cb866ac 100644 --- a/src/lib/util/corefile.h +++ b/src/lib/util/corefile.h @@ -128,7 +128,7 @@ public: protected: - core_file() = default; + core_file(); }; diff --git a/src/lib/util/huffman.cpp b/src/lib/util/huffman.cpp index d8900b45e17..1d531fdd634 100644 --- a/src/lib/util/huffman.cpp +++ b/src/lib/util/huffman.cpp @@ -678,6 +678,14 @@ void huffman_context_base::build_lookup_table() // 8-BIT ENCODER //************************************************************************** +//------------------------------------------------- +// huffman_8bit_encoder - constructor +//------------------------------------------------- + +huffman_8bit_encoder::huffman_8bit_encoder() +{ +} + //------------------------------------------------- // encode - encode a full buffer @@ -714,6 +722,14 @@ huffman_error huffman_8bit_encoder::encode(const uint8_t *source, uint32_t sleng // 8-BIT DECODER //************************************************************************** +//------------------------------------------------- +// huffman_8bit_decoder - constructor +//------------------------------------------------- + +huffman_8bit_decoder::huffman_8bit_decoder() +{ +} + /** * @fn huffman_error huffman_8bit_decoder::decode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t dlength) * diff --git a/src/lib/util/huffman.h b/src/lib/util/huffman.h index 233146e8e20..0eac393f380 100644 --- a/src/lib/util/huffman.h +++ b/src/lib/util/huffman.h @@ -149,7 +149,7 @@ class huffman_8bit_encoder : public huffman_encoder<> { public: // construction/destruction - huffman_8bit_encoder() = default; + huffman_8bit_encoder(); // operations huffman_error encode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t destlength, uint32_t &complength); @@ -163,7 +163,7 @@ class huffman_8bit_decoder : public huffman_decoder<> { public: // construction/destruction - huffman_8bit_decoder() = default; + huffman_8bit_decoder(); // operations huffman_error decode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t destlength); diff --git a/src/lib/util/opresolv.cpp b/src/lib/util/opresolv.cpp index 210dde4f224..034f9418426 100644 --- a/src/lib/util/opresolv.cpp +++ b/src/lib/util/opresolv.cpp @@ -63,6 +63,15 @@ option_resolution::option_resolution(const option_guide &guide) // ------------------------------------------------- +// dtor +// ------------------------------------------------- + +option_resolution::~option_resolution() +{ +} + + +// ------------------------------------------------- // lookup_in_specification // ------------------------------------------------- diff --git a/src/lib/util/opresolv.h b/src/lib/util/opresolv.h index a102dcd8c83..3781b602393 100644 --- a/src/lib/util/opresolv.h +++ b/src/lib/util/opresolv.h @@ -243,7 +243,7 @@ public: // ctor/dtor option_resolution(const option_guide &guide); - ~option_resolution() = default; + ~option_resolution(); // sets a specification void set_specification(const std::string &specification); diff --git a/src/lib/util/options.cpp b/src/lib/util/options.cpp index fd0783ccaae..3e5cb001378 100644 --- a/src/lib/util/options.cpp +++ b/src/lib/util/options.cpp @@ -423,6 +423,15 @@ const char *core_options::simple_entry::maximum() const noexcept //************************************************************************** //------------------------------------------------- +// core_options - constructor +//------------------------------------------------- + +core_options::core_options() +{ +} + + +//------------------------------------------------- // ~core_options - destructor //------------------------------------------------- diff --git a/src/lib/util/options.h b/src/lib/util/options.h index a28720a0373..457ec08dd1d 100644 --- a/src/lib/util/options.h +++ b/src/lib/util/options.h @@ -147,7 +147,7 @@ public: }; // construction/destruction - core_options() = default; + core_options(); core_options(const core_options &) = delete; core_options(core_options &&) = default; core_options& operator=(const core_options &) = delete; @@ -213,7 +213,7 @@ private: simple_entry(simple_entry &&) = delete; simple_entry& operator=(const simple_entry &) = delete; simple_entry& operator=(simple_entry &&) = delete; - virtual ~simple_entry(); + ~simple_entry(); // getters virtual const char *value() const noexcept override; diff --git a/src/lib/util/palette.cpp b/src/lib/util/palette.cpp index 47fa06c05bd..59a63b2c8f5 100644 --- a/src/lib/util/palette.cpp +++ b/src/lib/util/palette.cpp @@ -256,6 +256,15 @@ palette_t::palette_t(uint32_t numcolors, uint32_t numgroups) // palette_t - destructor //------------------------------------------------- +palette_t::~palette_t() +{ +} + + +//------------------------------------------------- +// palette_t - destructor +//------------------------------------------------- + void palette_t::deref() { if (--m_refcount == 0) diff --git a/src/lib/util/palette.h b/src/lib/util/palette.h index 0407a87c29b..ff2c7bb80c9 100644 --- a/src/lib/util/palette.h +++ b/src/lib/util/palette.h @@ -191,7 +191,7 @@ public: private: // construction/destruction palette_t(uint32_t numcolors, uint32_t numgroups = 1); - ~palette_t() = default; + ~palette_t(); // internal helpers rgb_t adjust_palette_entry(rgb_t entry, float brightness, float contrast, const uint8_t *gamma_map); diff --git a/src/lib/util/xmlfile.cpp b/src/lib/util/xmlfile.cpp index 8ba2cec92c3..445c3fbb4f7 100644 --- a/src/lib/util/xmlfile.cpp +++ b/src/lib/util/xmlfile.cpp @@ -68,6 +68,9 @@ static void expat_element_end(void *data, const XML_Char *name); XML FILE OBJECTS ***************************************************************************/ +file::file() { } +file::~file() { } + /*------------------------------------------------- create - create a new, empty XML file diff --git a/src/lib/util/xmlfile.h b/src/lib/util/xmlfile.h index 659ad59ae31..8d09b2b7e1e 100644 --- a/src/lib/util/xmlfile.h +++ b/src/lib/util/xmlfile.h @@ -215,7 +215,7 @@ public: using ptr = std::unique_ptr<file>; - ~file() = default; + ~file(); // create a new, empty XML file static ptr create(); @@ -231,7 +231,7 @@ public: private: - file() = default; + file(); }; diff --git a/src/osd/modules/debugger/debuggdbstub.cpp b/src/osd/modules/debugger/debuggdbstub.cpp index c993eaa5c66..63dbd420184 100644 --- a/src/osd/modules/debugger/debuggdbstub.cpp +++ b/src/osd/modules/debugger/debuggdbstub.cpp @@ -327,7 +327,7 @@ public: { } - virtual ~debug_gdbstub() = default; + virtual ~debug_gdbstub() { } virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/debugger/debugimgui.cpp b/src/osd/modules/debugger/debugimgui.cpp index d34f256de8e..c1e3a4de21d 100644 --- a/src/osd/modules/debugger/debugimgui.cpp +++ b/src/osd/modules/debugger/debugimgui.cpp @@ -116,7 +116,7 @@ public: { } - virtual ~debug_imgui() = default; + virtual ~debug_imgui() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override {}; diff --git a/src/osd/modules/debugger/debugwin.cpp b/src/osd/modules/debugger/debugwin.cpp index 2b1fb212ef0..975e7ba6bc6 100644 --- a/src/osd/modules/debugger/debugwin.cpp +++ b/src/osd/modules/debugger/debugwin.cpp @@ -44,7 +44,7 @@ public: { } - virtual ~debugger_windows() = default; + virtual ~debugger_windows() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override; diff --git a/src/osd/modules/debugger/none.cpp b/src/osd/modules/debugger/none.cpp index 1ef02c98fa7..3ce8d6572bc 100644 --- a/src/osd/modules/debugger/none.cpp +++ b/src/osd/modules/debugger/none.cpp @@ -22,7 +22,7 @@ public: { } - virtual ~debug_none() = default; + virtual ~debug_none() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/debugger/win/consolewininfo.cpp b/src/osd/modules/debugger/win/consolewininfo.cpp index 6ca18743945..27a6228d2f5 100644 --- a/src/osd/modules/debugger/win/consolewininfo.cpp +++ b/src/osd/modules/debugger/win/consolewininfo.cpp @@ -95,7 +95,6 @@ consolewin_info::~consolewin_info() { } - void consolewin_info::set_cpu(device_t &device) { // exit if this cpu is already selected diff --git a/src/osd/modules/debugger/win/logwininfo.cpp b/src/osd/modules/debugger/win/logwininfo.cpp index 6ed0f63a1c3..6d2cd59b554 100644 --- a/src/osd/modules/debugger/win/logwininfo.cpp +++ b/src/osd/modules/debugger/win/logwininfo.cpp @@ -53,7 +53,6 @@ logwin_info::~logwin_info() { } - bool logwin_info::handle_command(WPARAM wparam, LPARAM lparam) { if ((HIWORD(wparam) == 0) && (LOWORD(wparam) == ID_CLEAR_LOG)) diff --git a/src/osd/modules/diagnostics/none.cpp b/src/osd/modules/diagnostics/none.cpp index e4028124514..8a731fe9009 100644 --- a/src/osd/modules/diagnostics/none.cpp +++ b/src/osd/modules/diagnostics/none.cpp @@ -11,7 +11,9 @@ class diagnostics_none : public diagnostics_module { public: - diagnostics_none() = default; + diagnostics_none() + { + } int init_crash_diagnostics() override { diff --git a/src/osd/modules/font/font_none.cpp b/src/osd/modules/font/font_none.cpp index a36514899a2..dc6116625a8 100644 --- a/src/osd/modules/font/font_none.cpp +++ b/src/osd/modules/font/font_none.cpp @@ -11,7 +11,7 @@ class osd_font_none : public osd_font { public: - virtual ~osd_font_none() = default; + virtual ~osd_font_none() { } virtual bool open(std::string const &font_path, std::string const &name, int &height) override { return false; } virtual void close() override { } diff --git a/src/osd/modules/midi/none.cpp b/src/osd/modules/midi/none.cpp index 72fc07fb4e2..822de79bd08 100644 --- a/src/osd/modules/midi/none.cpp +++ b/src/osd/modules/midi/none.cpp @@ -21,7 +21,7 @@ public: : osd_module(OSD_MIDI_PROVIDER, "pm"), midi_module() { } - virtual ~none_module() = default; + virtual ~none_module() { } virtual int init(const osd_options &options) override; virtual void exit() override; @@ -34,7 +34,7 @@ public: class osd_midi_device_none : public osd_midi_device { public: - virtual ~osd_midi_device_none() = default; + virtual ~osd_midi_device_none() { } virtual bool open_input(const char *devname) override; virtual bool open_output(const char *devname) override; virtual void close() override; diff --git a/src/osd/modules/midi/portmidi.cpp b/src/osd/modules/midi/portmidi.cpp index e5c35c91162..64f71ca6689 100644 --- a/src/osd/modules/midi/portmidi.cpp +++ b/src/osd/modules/midi/portmidi.cpp @@ -24,7 +24,7 @@ public: : osd_module(OSD_MIDI_PROVIDER, "pm"), midi_module() { } - virtual ~pm_module() = default; + virtual ~pm_module() { } virtual int init(const osd_options &options)override; virtual void exit()override; @@ -43,7 +43,7 @@ class osd_midi_device_pm : public osd_midi_device { public: osd_midi_device_pm(): pmStream(nullptr), xmit_cnt(0), last_status(0), rx_sysex(false) { } - virtual ~osd_midi_device_pm() = default; + virtual ~osd_midi_device_pm() { } virtual bool open_input(const char *devname) override; virtual bool open_output(const char *devname) override; virtual void close() override; diff --git a/src/osd/modules/netdev/none.cpp b/src/osd/modules/netdev/none.cpp index 97bc3d435da..a5b520f26a5 100644 --- a/src/osd/modules/netdev/none.cpp +++ b/src/osd/modules/netdev/none.cpp @@ -16,7 +16,7 @@ public: { } - virtual ~netdev_none() = default; + virtual ~netdev_none() { } virtual int init(const osd_options &options) override { return 0; } }; diff --git a/src/osd/modules/netdev/pcap.cpp b/src/osd/modules/netdev/pcap.cpp index 4e4ed81b1ae..799cff9ec0e 100644 --- a/src/osd/modules/netdev/pcap.cpp +++ b/src/osd/modules/netdev/pcap.cpp @@ -46,7 +46,7 @@ public: { } - virtual ~pcap_module() = default; + virtual ~pcap_module() { } virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/netdev/taptun.cpp b/src/osd/modules/netdev/taptun.cpp index b6012224081..1b549f5b3b2 100644 --- a/src/osd/modules/netdev/taptun.cpp +++ b/src/osd/modules/netdev/taptun.cpp @@ -40,7 +40,7 @@ public: taptun_module() : osd_module(OSD_NETDEV_PROVIDER, "taptun"), netdev_module() { } - virtual ~taptun_module() = default; + virtual ~taptun_module() { } virtual int init(const osd_options &options); virtual void exit(); diff --git a/src/osd/modules/output/console.cpp b/src/osd/modules/output/console.cpp index 58896737829..c9983736fb0 100644 --- a/src/osd/modules/output/console.cpp +++ b/src/osd/modules/output/console.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "console"), output_module() { } - virtual ~output_console() = default; + virtual ~output_console() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/output/network.cpp b/src/osd/modules/output/network.cpp index eafbf7b95e2..4fc4b382da6 100644 --- a/src/osd/modules/output/network.cpp +++ b/src/osd/modules/output/network.cpp @@ -26,7 +26,7 @@ class output_client { public: - virtual ~output_client() = default; + virtual ~output_client() {} virtual void deliver(std::string &msg) = 0; }; @@ -197,7 +197,9 @@ public: { } - virtual ~output_network() = default; + virtual ~output_network() + { + } virtual int init(const osd_options &options) override { diff --git a/src/osd/modules/output/none.cpp b/src/osd/modules/output/none.cpp index a5f142c9766..a4a613ef29f 100644 --- a/src/osd/modules/output/none.cpp +++ b/src/osd/modules/output/none.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "none"), output_module() { } - virtual ~output_none() = default; + virtual ~output_none() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/output/win32_output.cpp b/src/osd/modules/output/win32_output.cpp index 8d7c0f7ba67..f01c46b735d 100644 --- a/src/osd/modules/output/win32_output.cpp +++ b/src/osd/modules/output/win32_output.cpp @@ -69,7 +69,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "windows"), output_module(), m_output_hwnd(nullptr), m_clientlist(nullptr) { } - virtual ~output_win32() = default; + virtual ~output_win32() { } virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/render/bgfx/inputpair.h b/src/osd/modules/render/bgfx/inputpair.h index 8060ce8c4dd..fb3fc58e1f7 100644 --- a/src/osd/modules/render/bgfx/inputpair.h +++ b/src/osd/modules/render/bgfx/inputpair.h @@ -27,7 +27,7 @@ class bgfx_input_pair : public slider_changed_notifier { public: bgfx_input_pair(int index, std::string sampler, std::string texture, std::vector<std::string> available_textures, std::string selection, chain_manager& chains, uint32_t screen_index); - virtual ~bgfx_input_pair(); + ~bgfx_input_pair(); void bind(bgfx_effect *effect, const int32_t screen) const; int32_t texture_changed(int32_t index, std::string *str, int32_t newval); diff --git a/src/osd/modules/sound/direct_sound.cpp b/src/osd/modules/sound/direct_sound.cpp index c7943362e61..05333674541 100644 --- a/src/osd/modules/sound/direct_sound.cpp +++ b/src/osd/modules/sound/direct_sound.cpp @@ -60,7 +60,7 @@ public: m_buffer_overflows(0) { } - virtual ~sound_direct_sound() = default; + virtual ~sound_direct_sound() { } virtual int init(osd_options const &options) override; virtual void exit() override; diff --git a/src/osd/modules/sound/none.cpp b/src/osd/modules/sound/none.cpp index c13a1951e27..685cdc884c2 100644 --- a/src/osd/modules/sound/none.cpp +++ b/src/osd/modules/sound/none.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_SOUND_PROVIDER, "none"), sound_module() { } - virtual ~sound_none() = default; + virtual ~sound_none() { } virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/sound/pa_sound.cpp b/src/osd/modules/sound/pa_sound.cpp index 0f67d86d828..41645318672 100644 --- a/src/osd/modules/sound/pa_sound.cpp +++ b/src/osd/modules/sound/pa_sound.cpp @@ -38,7 +38,7 @@ public: : osd_module(OSD_SOUND_PROVIDER, "portaudio"), sound_module() { } - virtual ~sound_pa() = default; + virtual ~sound_pa() { } virtual int init(osd_options const &options) override; virtual void exit() override; diff --git a/src/osd/modules/sound/xaudio2_sound.cpp b/src/osd/modules/sound/xaudio2_sound.cpp index da78dfb3aa7..1d9e1036f9a 100644 --- a/src/osd/modules/sound/xaudio2_sound.cpp +++ b/src/osd/modules/sound/xaudio2_sound.cpp @@ -226,7 +226,7 @@ public: { } - virtual ~sound_xaudio2() = default; + virtual ~sound_xaudio2() { } bool probe() override; int init(osd_options const &options) override; |