diff options
author | 2020-09-28 22:00:16 +0200 | |
---|---|---|
committer | 2020-09-28 22:00:16 +0200 | |
commit | c93702f9a3697625788704fdddea5bf881e0c97f (patch) | |
tree | 6a8b8f4ba11c09f0841f7f72183a962b1848b7bb | |
parent | 0ba5d9f342617fc9b39701f3673c617c44106317 (diff) |
netlist: Remove "extended validation mode"
* No longer added value.
-rw-r--r-- | src/devices/machine/netlist.cpp | 1 | ||||
-rw-r--r-- | src/lib/netlist/core/netlist_state.h | 22 | ||||
-rw-r--r-- | src/lib/netlist/devices/nlid_proxy.cpp | 16 | ||||
-rw-r--r-- | src/lib/netlist/nl_base.cpp | 1 | ||||
-rw-r--r-- | src/lib/netlist/nl_setup.cpp | 2 | ||||
-rw-r--r-- | src/lib/netlist/prg/nltool.cpp | 4 | ||||
-rw-r--r-- | src/lib/netlist/solver/nld_ms_gcr.h | 5 |
7 files changed, 7 insertions, 44 deletions
diff --git a/src/devices/machine/netlist.cpp b/src/devices/machine/netlist.cpp index 988c21c33e1..a13349e318f 100644 --- a/src/devices/machine/netlist.cpp +++ b/src/devices/machine/netlist.cpp @@ -987,7 +987,6 @@ std::unique_ptr<netlist::netlist_state_t> netlist_mame_device::base_validity_che auto lnetlist = std::make_unique<netlist::netlist_state_t>("netlist", plib::plog_delegate(&validity_logger::log, &logger)); // enable validation mode - lnetlist->set_extended_validation(true); lnetlist->set_static_solver_lib(std::make_unique<plib::dynlib_static>(nullptr)); diff --git a/src/lib/netlist/core/netlist_state.h b/src/lib/netlist/core/netlist_state.h index 8f24fb09d94..dc9888579f5 100644 --- a/src/lib/netlist/core/netlist_state.h +++ b/src/lib/netlist/core/netlist_state.h @@ -217,24 +217,6 @@ namespace netlist device_arena &pool() noexcept { return m_pool; } const device_arena &pool() const noexcept { return m_pool; } - /// \brief set extended validation mode. - /// - /// The extended validation mode is not intended for running. - /// The intention is to identify power pins which are not properly - /// connected. The downside is that this mode creates a netlist which - /// is different (and not able to run). - /// - /// Extended validation is supported by nltool validate option. - /// - /// \param val Boolean value enabling/disabling extended validation mode - void set_extended_validation(bool val) { m_extended_validation = val; } - - /// \brief State of extended validation mode. - /// - /// \returns boolean value indicating if extended validation mode is - /// turned on. - bool is_extended_validation() const { return m_extended_validation; } - struct stats_info { const detail::queue_t &m_queue;// performance @@ -263,7 +245,7 @@ namespace netlist plib::state_manager_t m_state; log_type m_log; - // FIXME: should only be available during device construcion + // FIXME: should only be available during device construction host_arena::unique_ptr<setup_t> m_setup; nets_collection_type m_nets; @@ -271,8 +253,6 @@ namespace netlist devices_collection_type m_devices; // sole use is to manage lifetime of family objects family_collection_type m_family_cache; - bool m_extended_validation; - // dummy version int m_dummy_version; }; diff --git a/src/lib/netlist/devices/nlid_proxy.cpp b/src/lib/netlist/devices/nlid_proxy.cpp index fb93d642a79..e8cc27fc987 100644 --- a/src/lib/netlist/devices/nlid_proxy.cpp +++ b/src/lib/netlist/devices/nlid_proxy.cpp @@ -124,19 +124,9 @@ namespace netlist { register_subalias("Q", "RN.1"); - log().verbose("D/A Proxy: Found power terminals on device {1}", out_proxied->device().name()); - if (anetlist.is_extended_validation()) - { - // During validation, don't connect to terminals found - // This will cause terminals not connected to a rail net to - // fail connection stage. - connect(m_RN.N(), m_RP.P()); - } - else - { - connect(m_RN.N(), *m_tn); - connect(m_RP.P(), *m_tp); - } + connect(m_RN.N(), *m_tn); + connect(m_RP.P(), *m_tp); + connect(m_RN.P(), m_RP.N()); } diff --git a/src/lib/netlist/nl_base.cpp b/src/lib/netlist/nl_base.cpp index 10dc7cf635c..7e0e5f0425f 100644 --- a/src/lib/netlist/nl_base.cpp +++ b/src/lib/netlist/nl_base.cpp @@ -106,7 +106,6 @@ namespace netlist netlist_state_t::netlist_state_t(const pstring &name, plib::plog_delegate logger) : m_log(logger) - , m_extended_validation(false) , m_dummy_version(1) { m_setup = plib::make_unique<setup_t, host_arena>(*this); diff --git a/src/lib/netlist/nl_setup.cpp b/src/lib/netlist/nl_setup.cpp index 11584bceb48..d28ba51e476 100644 --- a/src/lib/netlist/nl_setup.cpp +++ b/src/lib/netlist/nl_setup.cpp @@ -9,6 +9,7 @@ #include "nl_factory.h" #include "nl_parser.h" #include "nl_setup.h" +#include "nl_errstr.h" #include "plib/penum.h" #include "plib/pstonum.h" #include "plib/pstrutil.h" @@ -1192,6 +1193,7 @@ void setup_t::resolve_inputs() log().warning(MW_TERMINAL_1_WITHOUT_CONNECTIONS(name_da)); } } + log().verbose("checking tristate consistency ..."); for (auto & i : m_terminals) { diff --git a/src/lib/netlist/prg/nltool.cpp b/src/lib/netlist/prg/nltool.cpp index 44b96bf0d6d..313ec4e8b2e 100644 --- a/src/lib/netlist/prg/nltool.cpp +++ b/src/lib/netlist/prg/nltool.cpp @@ -82,7 +82,6 @@ public: opt_type(*this, "y", "type", 0, std::vector<pstring>({"spice","eagle","rinf"}), "type of file to be converted: spice,eagle,rinf"), opt_grp6(*this, "Options for validate command", "These options are only used by the validate command."), - opt_extended_validation(*this, "", "extended", "Identify issues with power terminals."), opt_grp7(*this, "Options for header command", "These options are only used by the header command."), opt_tabwidth(*this, "", "tab-width", 4, "Tab width for output."), @@ -153,7 +152,6 @@ private: plib::option_str_limit<unsigned> opt_type; plib::option_group opt_grp6; - plib::option_bool opt_extended_validation; plib::option_group opt_grp7; plib::option_num<unsigned> opt_tabwidth; plib::option_num<unsigned> opt_linewidth; @@ -548,8 +546,6 @@ void tool_app_t::validate() m_errors = 0; m_warnings = 0; - nt.set_extended_validation(opt_extended_validation()); - try { nt.read_netlist(opt_files()[0], opt_name(), diff --git a/src/lib/netlist/solver/nld_ms_gcr.h b/src/lib/netlist/solver/nld_ms_gcr.h index 5d8440e5d1d..71388dc867e 100644 --- a/src/lib/netlist/solver/nld_ms_gcr.h +++ b/src/lib/netlist/solver/nld_ms_gcr.h @@ -93,10 +93,7 @@ namespace solver // FIXME: Move me // - // During extended validation there is no reason to check for - // differences in the generated code since during - // extended validation this will be different (and non-functional) - if (!this->state().is_extended_validation() && this->state().static_solver_lib().isLoaded()) + if (this->state().static_solver_lib().isLoaded()) { pstring symname = static_compile_name(); m_proc.load(this->state().static_solver_lib(), symname); |