From 88ce545cdda64659894b87fc0b98e1b044eea3e0 Mon Sep 17 00:00:00 2001 From: Vas Crabb Date: Mon, 18 Nov 2019 05:08:36 +1100 Subject: misc cleanup: * Got rid of some more simple_list in core debugger code * Fixed a buffer overrun in wavwrite (buffer half requried size) * Slightly reduced dependencies and overhead in wavwrite * Made new disassembly windows in Qt debugger default to current CPU --- src/osd/modules/debugger/qt/memorywindow.cpp | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'src/osd/modules/debugger/qt/memorywindow.cpp') diff --git a/src/osd/modules/debugger/qt/memorywindow.cpp b/src/osd/modules/debugger/qt/memorywindow.cpp index c799ab66c65..6c95e04df80 100644 --- a/src/osd/modules/debugger/qt/memorywindow.cpp +++ b/src/osd/modules/debugger/qt/memorywindow.cpp @@ -166,7 +166,7 @@ MemoryWindow::~MemoryWindow() void MemoryWindow::memoryRegionChanged(int index) { - m_memTable->view()->set_source(*m_memTable->view()->source_list().find(index)); + m_memTable->view()->set_source(*m_memTable->view()->source(index)); m_memTable->viewport()->update(); // Update the data format radio buttons to the memory region's default @@ -283,9 +283,9 @@ void MemoryWindow::populateComboBox() return; m_memoryComboBox->clear(); - for (const debug_view_source &source : m_memTable->view()->source_list()) + for (auto &source : m_memTable->view()->source_list()) { - m_memoryComboBox->addItem(source.name()); + m_memoryComboBox->addItem(source->name()); } } @@ -293,9 +293,15 @@ void MemoryWindow::populateComboBox() void MemoryWindow::setToCurrentCpu() { device_t* curCpu = m_machine->debugger().cpu().get_visible_cpu(); - const debug_view_source *source = m_memTable->view()->source_for_device(curCpu); - const int listIndex = m_memTable->view()->source_list().indexof(*source); - m_memoryComboBox->setCurrentIndex(listIndex); + if (curCpu) + { + const debug_view_source *source = m_memTable->view()->source_for_device(curCpu); + if (source) + { + const int listIndex = m_memTable->view()->source_index(*source); + m_memoryComboBox->setCurrentIndex(listIndex); + } + } } -- cgit v1.2.3-70-g09d2