From 22513fb6fe281f5ccb75aaddb6417a12a66c313d Mon Sep 17 00:00:00 2001 From: Olivier Galibert Date: Mon, 25 May 2020 16:42:42 +0200 Subject: emumem: A little more speedup. cache and specific change syntax, and are not pointers anymore [O. Galibert] The last(?) two changes are: - Add a template parameter to everything (theoretically the address space width, in practice a level derived from it to keep as much compatibility between widths as possible) so that the shift size becomes a constant. - Change the syntax of declaring and initializing the caches and specifics so that they're embedded in the owner device. Solves lifetime issues and also removes one indirection (looking up the base dispatch pointer through the cache/specific pointer). --- src/devices/cpu/tms34010/tms34010.cpp | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) (limited to 'src/devices/cpu/tms34010/tms34010.cpp') diff --git a/src/devices/cpu/tms34010/tms34010.cpp b/src/devices/cpu/tms34010/tms34010.cpp index bd039d7e706..cda86ced222 100644 --- a/src/devices/cpu/tms34010/tms34010.cpp +++ b/src/devices/cpu/tms34010/tms34010.cpp @@ -82,8 +82,6 @@ tms340x0_device::tms340x0_device(const machine_config &mconfig, device_type type , m_hblank_stable(0) , m_external_host_access(0) , m_executing(0) - , m_program(nullptr) - , m_cache(nullptr) , m_pixclock(0) , m_pixperclock(0) , m_scantimer(nullptr) @@ -236,32 +234,32 @@ inline uint32_t tms340x0_device::ROPCODE() { uint32_t pc = m_pc; m_pc += 2 << 3; - return m_cache->read_word(pc); + return m_cache.read_word(pc); } inline int16_t tms340x0_device::PARAM_WORD() { uint32_t pc = m_pc; m_pc += 2 << 3; - return m_cache->read_word(pc); + return m_cache.read_word(pc); } inline int32_t tms340x0_device::PARAM_LONG() { uint32_t pc = m_pc; m_pc += 4 << 3; - return (uint16_t)m_cache->read_word(pc) | (m_cache->read_word(pc + 16) << 16); + return (uint16_t)m_cache.read_word(pc) | (m_cache.read_word(pc + 16) << 16); } inline int16_t tms340x0_device::PARAM_WORD_NO_INC() { - return m_cache->read_word(m_pc); + return m_cache.read_word(m_pc); } inline int32_t tms340x0_device::PARAM_LONG_NO_INC() { uint32_t pc = m_pc; - return (uint16_t)m_cache->read_word(pc) | (m_cache->read_word(pc + 16) << 16); + return (uint16_t)m_cache.read_word(pc) | (m_cache.read_word(pc + 16) << 16); } /* read memory byte */ @@ -333,7 +331,7 @@ uint32_t tms340x0_device::read_pixel_32(offs_t offset) uint32_t tms340x0_device::read_pixel_shiftreg(offs_t offset) { if (!m_to_shiftreg_cb.isnull()) - m_to_shiftreg_cb(*m_program, offset, &m_shiftreg[0]); + m_to_shiftreg_cb(m_program, offset, &m_shiftreg[0]); else fatalerror("To ShiftReg function not set. PC = %08X\n", m_pc); return m_shiftreg[0]; @@ -475,7 +473,7 @@ void tms340x0_device::write_pixel_r_t_32(offs_t offset, uint32_t data) void tms340x0_device::write_pixel_shiftreg(offs_t offset, uint32_t data) { if (!m_from_shiftreg_cb.isnull()) - m_from_shiftreg_cb(*m_program, offset, &m_shiftreg[0]); + m_from_shiftreg_cb(m_program, offset, &m_shiftreg[0]); else fatalerror("From ShiftReg function not set. PC = %08X\n", m_pc); } @@ -642,8 +640,8 @@ void tms340x0_device::device_start() m_external_host_access = false; - m_program = &space(AS_PROGRAM); - m_cache = m_program->cache<1, 3, ENDIANNESS_LITTLE>(); + space(AS_PROGRAM).cache(m_cache); + space(AS_PROGRAM).specific(m_program); /* set up the state table */ { -- cgit v1.2.3-70-g09d2