From 22513fb6fe281f5ccb75aaddb6417a12a66c313d Mon Sep 17 00:00:00 2001 From: Olivier Galibert Date: Mon, 25 May 2020 16:42:42 +0200 Subject: emumem: A little more speedup. cache and specific change syntax, and are not pointers anymore [O. Galibert] The last(?) two changes are: - Add a template parameter to everything (theoretically the address space width, in practice a level derived from it to keep as much compatibility between widths as possible) so that the shift size becomes a constant. - Change the syntax of declaring and initializing the caches and specifics so that they're embedded in the owner device. Solves lifetime issues and also removes one indirection (looking up the base dispatch pointer through the cache/specific pointer). --- src/devices/cpu/rsp/rsp.cpp | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'src/devices/cpu/rsp/rsp.cpp') diff --git a/src/devices/cpu/rsp/rsp.cpp b/src/devices/cpu/rsp/rsp.cpp index 17b1682b8bd..07deffc6e10 100644 --- a/src/devices/cpu/rsp/rsp.cpp +++ b/src/devices/cpu/rsp/rsp.cpp @@ -78,7 +78,7 @@ DEFINE_DEVICE_TYPE(RSP, rsp_device, "rsp", "Nintendo & SGI Reality Signal Proces #define CLEAR_ZERO_FLAG(x) { m_vflag[ZERO][x & 7] = 0; } #define CLEAR_CLIP2_FLAG(x) { m_vflag[CLIP2][x & 7] = 0; } -#define ROPCODE(pc) m_program->read_dword(pc) +#define ROPCODE(pc) m_pcache.read_dword(pc) /*************************************************************************** @@ -232,7 +232,7 @@ uint8_t rsp_device::READ8(uint32_t address) { uint8_t ret; address &= 0xfff; - ret = m_program->read_byte(address); + ret = m_program.read_byte(address); //printf("R8:%08x=%02x\n", address, ret); return ret; } @@ -242,7 +242,7 @@ uint16_t rsp_device::READ16(uint32_t address) uint16_t ret; address &= 0xfff; - ret = (m_program->read_byte(address) << 8) | (m_program->read_byte(address + 1) & 0xff); + ret = (m_program.read_byte(address) << 8) | (m_program.read_byte(address + 1) & 0xff); //printf("R16:%08x=%04x\n", address, ret); return ret; @@ -253,10 +253,10 @@ uint32_t rsp_device::READ32(uint32_t address) uint32_t ret; address &= 0xfff; - ret = (m_program->read_byte(address) << 24) | - (m_program->read_byte(address + 1) << 16) | - (m_program->read_byte(address + 2) << 8) | - (m_program->read_byte(address + 3) << 0); + ret = (m_program.read_byte(address) << 24) | + (m_program.read_byte(address + 1) << 16) | + (m_program.read_byte(address + 2) << 8) | + (m_program.read_byte(address + 3) << 0); //printf("R32:%08x=%08x\n", address, ret); return ret; @@ -265,7 +265,7 @@ uint32_t rsp_device::READ32(uint32_t address) void rsp_device::WRITE8(uint32_t address, uint8_t data) { address &= 0xfff; - m_program->write_byte(address, data); + m_program.write_byte(address, data); //printf("W8:%08x=%02x\n", address, data); } @@ -273,8 +273,8 @@ void rsp_device::WRITE16(uint32_t address, uint16_t data) { address &= 0xfff; - m_program->write_byte(address, data >> 8); - m_program->write_byte(address + 1, data & 0xff); + m_program.write_byte(address, data >> 8); + m_program.write_byte(address + 1, data & 0xff); //printf("W16:%08x=%04x\n", address, data); } @@ -282,10 +282,10 @@ void rsp_device::WRITE32(uint32_t address, uint32_t data) { address &= 0xfff; - m_program->write_byte(address, data >> 24); - m_program->write_byte(address + 1, (data >> 16) & 0xff); - m_program->write_byte(address + 2, (data >> 8) & 0xff); - m_program->write_byte(address + 3, data & 0xff); + m_program.write_byte(address, data >> 24); + m_program.write_byte(address + 1, (data >> 16) & 0xff); + m_program.write_byte(address + 2, (data >> 8) & 0xff); + m_program.write_byte(address + 3, data & 0xff); //printf("W32:%08x=%08x\n", address, data); } @@ -381,8 +381,8 @@ void rsp_device::device_start() if (LOG_INSTRUCTION_EXECUTION) m_exec_output = fopen("rsp_execute.txt", "wt"); - m_program = &space(AS_PROGRAM); - m_pcache = m_program->cache<2, 0, ENDIANNESS_BIG>(); + space(AS_PROGRAM).cache(m_pcache); + space(AS_PROGRAM).specific(m_program); resolve_cb(); if (m_isdrc) -- cgit v1.2.3-70-g09d2