From 22513fb6fe281f5ccb75aaddb6417a12a66c313d Mon Sep 17 00:00:00 2001 From: Olivier Galibert Date: Mon, 25 May 2020 16:42:42 +0200 Subject: emumem: A little more speedup. cache and specific change syntax, and are not pointers anymore [O. Galibert] The last(?) two changes are: - Add a template parameter to everything (theoretically the address space width, in practice a level derived from it to keep as much compatibility between widths as possible) so that the shift size becomes a constant. - Change the syntax of declaring and initializing the caches and specifics so that they're embedded in the owner device. Solves lifetime issues and also removes one indirection (looking up the base dispatch pointer through the cache/specific pointer). --- src/devices/cpu/cosmac/cosmac.cpp | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) (limited to 'src/devices/cpu/cosmac/cosmac.cpp') diff --git a/src/devices/cpu/cosmac/cosmac.cpp b/src/devices/cpu/cosmac/cosmac.cpp index cc773ebd8a3..6f824b90d64 100644 --- a/src/devices/cpu/cosmac/cosmac.cpp +++ b/src/devices/cpu/cosmac/cosmac.cpp @@ -381,10 +381,7 @@ cosmac_device::cosmac_device(const machine_config &mconfig, device_type type, co m_clear(true), m_irq(CLEAR_LINE), m_dmain(CLEAR_LINE), - m_dmaout(CLEAR_LINE), - m_program(nullptr), - m_io(nullptr), - m_cache(nullptr) + m_dmaout(CLEAR_LINE) { for (auto & elem : m_ef) elem = CLEAR_LINE; @@ -467,9 +464,9 @@ void cosmac_device::device_start() m_write_tpb.resolve_safe(); // get our address spaces - m_program = &space(AS_PROGRAM); - m_cache = m_program->cache<0, 0, ENDIANNESS_LITTLE>(); - m_io = &space(AS_IO); + space(AS_PROGRAM).cache(m_cache); + space(AS_PROGRAM).specific(m_program); + space(AS_IO).specific(m_io); // register our state for the debugger state_add(STATE_GENPC, "GENPC", m_pc).callimport().callexport().noshow(); @@ -644,7 +641,7 @@ std::unique_ptr cdp1805_device::create_disassembler() inline uint8_t cosmac_device::read_opcode(offs_t pc) { - return m_cache->read_byte(pc); + return m_cache.read_byte(pc); } @@ -654,7 +651,7 @@ inline uint8_t cosmac_device::read_opcode(offs_t pc) inline uint8_t cosmac_device::read_byte(offs_t address) { - return m_program->read_byte(address); + return m_program.read_byte(address); } @@ -665,7 +662,7 @@ inline uint8_t cosmac_device::read_byte(offs_t address) inline uint8_t cosmac_device::read_io_byte(offs_t address) { - return m_io->read_byte(address); + return m_io.read_byte(address); } @@ -675,7 +672,7 @@ inline uint8_t cosmac_device::read_io_byte(offs_t address) inline void cosmac_device::write_byte(offs_t address, uint8_t data) { - m_program->write_byte(address, data); + m_program.write_byte(address, data); } @@ -686,7 +683,7 @@ inline void cosmac_device::write_byte(offs_t address, uint8_t data) inline void cosmac_device::write_io_byte(offs_t address, uint8_t data) { - m_io->write_byte(address, data); + m_io.write_byte(address, data); } -- cgit v1.2.3-70-g09d2