From b6a03219f67a18fe3fde4ff82712decaaa805327 Mon Sep 17 00:00:00 2001 From: Vas Crabb Date: Tue, 24 Dec 2024 20:45:09 +1100 Subject: Revert "machine/ncr5385.cpp: clear status bits first when updating so they aren't stuck on (#13109)" This reverts commit ff6d52d56a9dcac133e5fee805a277bf0f9b60a4. Neither of the changes make sense. The addition to ncr5385_device::update_int is redundant is the bits are cleared just above the if statement. The addition to ncr5385_device::aux_status_r is unnecessary as the bits are only set when an interrupt is asserted (if they're set when it isn't, there's a logic bug elsewhere). --- src/devices/machine/ncr5385.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/devices/machine/ncr5385.cpp b/src/devices/machine/ncr5385.cpp index 77a9090bc59..10451885345 100644 --- a/src/devices/machine/ncr5385.cpp +++ b/src/devices/machine/ncr5385.cpp @@ -245,9 +245,6 @@ u8 ncr5385_device::aux_status_r() if (!m_int_status) { - // mask out any bits - data &= ~(AUX_STATUS_MSG | AUX_STATUS_CD | AUX_STATUS_IO); - // return current phase u32 const ctrl = scsi_bus->ctrl_r(); if (ctrl & S_MSG) @@ -832,9 +829,6 @@ void ncr5385_device::update_int() { m_cmd = 0; - // mask out any bits - m_aux_status &= ~(AUX_STATUS_MSG | AUX_STATUS_CD | AUX_STATUS_IO); - // latch current phase u32 const ctrl = scsi_bus->ctrl_r(); if (ctrl & S_MSG) -- cgit v1.2.3