From 9f33f0a2bdcd0707c682c949dc4ca794d30ebd1b Mon Sep 17 00:00:00 2001 From: hap Date: Tue, 7 Jan 2025 15:52:50 +0100 Subject: espial: update notes --- src/mame/orca/espial.cpp | 9 ++++++--- src/mame/orca/zodiack.cpp | 8 ++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/mame/orca/espial.cpp b/src/mame/orca/espial.cpp index 500efa83f76..ca509683931 100644 --- a/src/mame/orca/espial.cpp +++ b/src/mame/orca/espial.cpp @@ -13,6 +13,9 @@ Espial: The Orca logo is displayed, but looks to be "blacked out" via the TODO: - merge with orca/zodiack.cpp +- where do the sound NMIs come from exactly? +- locks up on soft reset (press F3) + Stephh's notes (based on the games Z80 code and some tests) : @@ -98,7 +101,7 @@ protected: uint8_t m_main_nmi_enabled = 0; uint8_t m_sound_nmi_enabled = 0; uint8_t m_sound_nmi_freq = 0; - emu_timer *sound_nmi_timer; + emu_timer *m_sound_nmi_timer; // devices required_device m_maincpu; @@ -161,7 +164,7 @@ void espial_state::machine_start() save_item(NAME(m_sound_nmi_enabled)); save_item(NAME(m_sound_nmi_freq)); - sound_nmi_timer = timer_alloc(FUNC(espial_state::sound_nmi_gen), this); + m_sound_nmi_timer = timer_alloc(FUNC(espial_state::sound_nmi_gen), this); } void espial_state::machine_reset() @@ -427,7 +430,7 @@ void espial_state::porta_w(offs_t offset, uint8_t data, uint8_t mem_mask) return; } - sound_nmi_timer->adjust(period, 0, period); + m_sound_nmi_timer->adjust(period, 0, period); } } diff --git a/src/mame/orca/zodiack.cpp b/src/mame/orca/zodiack.cpp index 5bdbdc55089..cb69240a5aa 100644 --- a/src/mame/orca/zodiack.cpp +++ b/src/mame/orca/zodiack.cpp @@ -26,7 +26,7 @@ Notes: TODO: - improve video emulation (especially moguchan colors) -- where do the sound related irqs come from exactly? +- where do the sound NMIs come from exactly? - can eventually be merged with orca/espial.cpp ============================================================================ @@ -148,7 +148,7 @@ private: uint8_t m_main_irq_enabled = 0; uint8_t m_sound_nmi_enabled = 0; uint8_t m_sound_nmi_freq = 0; - emu_timer *sound_nmi_timer; + emu_timer *m_sound_nmi_timer; TIMER_CALLBACK_MEMBER(sound_nmi_gen); void vblank(int state); @@ -173,7 +173,7 @@ void zodiack_state::machine_start() save_item(NAME(m_sound_nmi_enabled)); save_item(NAME(m_sound_nmi_freq)); - sound_nmi_timer = timer_alloc(FUNC(zodiack_state::sound_nmi_gen), this); + m_sound_nmi_timer = timer_alloc(FUNC(zodiack_state::sound_nmi_gen), this); } void zodiack_state::machine_reset() @@ -258,7 +258,7 @@ void zodiack_state::porta_w(offs_t offset, uint8_t data, uint8_t mem_mask) return; } - sound_nmi_timer->adjust(period, 0, period); + m_sound_nmi_timer->adjust(period, 0, period); } } -- cgit v1.2.3