From 972c6b25444381a23d89df01e02df3484f3e3f1e Mon Sep 17 00:00:00 2001
From: hap <happppp@users.noreply.github.com>
Date: Thu, 28 Nov 2024 10:35:41 +0100
Subject: s2650: add logerror o illegal opcodes

---
 src/devices/cpu/s2650/s2650.cpp | 24 +++++-------------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/src/devices/cpu/s2650/s2650.cpp b/src/devices/cpu/s2650/s2650.cpp
index 66a5d7ec568..5423038f86f 100644
--- a/src/devices/cpu/s2650/s2650.cpp
+++ b/src/devices/cpu/s2650/s2650.cpp
@@ -1033,10 +1033,6 @@ void s2650_device::execute_run()
 				M_LOD(m_reg[m_r], RDMEM(m_ea));
 				break;
 
-			case 0x10:      // illegal
-			case 0x11:      // illegal
-				m_icount -= 7;
-				break;
 			case 0x12:      // SPSU
 				m_icount -= 6;
 				M_SPSU();
@@ -1338,10 +1334,6 @@ void s2650_device::execute_run()
 				M_ADD(m_reg[m_r], RDMEM(m_ea));
 				break;
 
-			case 0x90:      // illegal
-			case 0x91:      // illegal
-				m_icount -= 7;
-				break;
 			case 0x92:      // LPSU
 				m_icount -= 6;
 				set_psu((R0 & ~PSU34 & ~SI) | (m_psu & SI));
@@ -1434,10 +1426,6 @@ void s2650_device::execute_run()
 				m_icount -= 9;
 				M_TPSL();
 				break;
-			case 0xb6:      // illegal
-			case 0xb7:      // illegal
-				m_icount -= 7;
-				break;
 
 			case 0xb8:      // BSFR,0 (*)a
 			case 0xb9:      // BSFR,1 (*)a
@@ -1471,13 +1459,6 @@ void s2650_device::execute_run()
 				M_LOD(m_reg[m_r], R0);
 				break;
 
-			case 0xc4:      // illegal
-			case 0xc5:      // illegal
-			case 0xc6:      // illegal
-			case 0xc7:      // illegal
-				m_icount -= 7;
-				break;
-
 			case 0xc8:      // STRR,0 (*)a
 			case 0xc9:      // STRR,1 (*)a
 			case 0xca:      // STRR,2 (*)a
@@ -1593,6 +1574,11 @@ void s2650_device::execute_run()
 				m_icount -= 9;
 				M_BRA(--m_reg[m_r]);
 				break;
+
+			default:        // illegal
+				m_icount -= 6;
+				logerror("%s: illegal opcode $%02X @ $%04X\n", tag(), m_ppc, m_ir);
+				break;
 		}
 	} while (m_icount > 0);
 }
-- 
cgit v1.2.3