From 519cd8b99af8264e4117e3061b0e2391902cfc02 Mon Sep 17 00:00:00 2001 From: hap Date: Sun, 16 Jul 2023 09:57:35 +0200 Subject: rbisland: fix p2 left input not working --- src/mame/taito/rbisland.cpp | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/mame/taito/rbisland.cpp b/src/mame/taito/rbisland.cpp index c3cc256d63f..ba56cb9fe74 100644 --- a/src/mame/taito/rbisland.cpp +++ b/src/mame/taito/rbisland.cpp @@ -475,12 +475,9 @@ the Y settings are active low. void jumping_state::machine_start() { base_state::machine_start(); + save_item(NAME(m_sprite_ctrl)); m_pc080sn->set_trans_pen(1, 15); - - m_sprite_ctrl = 0; - - save_item(NAME(m_sprite_ctrl)); } @@ -520,9 +517,6 @@ uint32_t jumping_state::screen_update(screen_device &screen, bitmap_ind16 &bitma m_pc080sn->tilemap_draw(screen, bitmap, cliprect, 1, 0, 0); -#if 0 - popmessage("sprite_ctrl: %04x", m_sprite_ctrl); -#endif return 0; } @@ -556,7 +550,6 @@ void rbisland_state::main_map(address_map &map) } - void jumping_state::main_map(address_map &map) { map(0x000000, 0x09ffff).rom(); @@ -610,6 +603,7 @@ void jumping_state::sound_map(address_map &map) map(0xc000, 0xffff).rom(); } + /*********************************************************** INPUT PORTS, DIPs ***********************************************************/ @@ -698,11 +692,11 @@ static INPUT_PORTS_START( rbisland ) PORT_BIT( 0x01, IP_ACTIVE_LOW, IPT_UNKNOWN ) PORT_BIT( 0x02, IP_ACTIVE_LOW, IPT_UNKNOWN ) PORT_BIT( 0x04, IP_ACTIVE_LOW, IPT_UNKNOWN ) - PORT_BIT( 0x08, IP_ACTIVE_LOW, IPT_UNUSED ) // 0x08 and 0x80 are swapped due to read through ADC + PORT_BIT( 0x08, IP_ACTIVE_LOW, IPT_JOYSTICK_LEFT ) PORT_2WAY PORT_COCKTAIL PORT_BIT( 0x10, IP_ACTIVE_LOW, IPT_JOYSTICK_RIGHT ) PORT_2WAY PORT_COCKTAIL PORT_BIT( 0x20, IP_ACTIVE_LOW, IPT_BUTTON1 ) PORT_COCKTAIL PORT_BIT( 0x40, IP_ACTIVE_LOW, IPT_BUTTON2 ) PORT_COCKTAIL - PORT_BIT( 0x80, IP_ACTIVE_LOW, IPT_JOYSTICK_LEFT ) PORT_2WAY PORT_COCKTAIL + PORT_BIT( 0x80, IP_ACTIVE_LOW, IPT_UNKNOWN ) INPUT_PORTS_END static INPUT_PORTS_START( jumping ) @@ -1034,9 +1028,9 @@ ROM_START( jumping ) ROM_LOAD32_BYTE( "jb2_i119", 0x80000, 0x08000, CRC(7e1d58d8) SHA1(d586a018c3ec3e6e6a39992170d324361e03c68a) ) ROM_REGION( 0x200, "pals", 0 ) - ROM_LOAD( "jumping-pal16r6.bin", 0x000, 0x104, CRC(12e9a7b8) SHA1(a0ce8b6083c9adfcb4bdbca87f63a01f292525f3) ) - ROM_LOAD( "jumping-pal20l8.bin", 0x000, 0x144, CRC(76944f81) SHA1(ab78e4e157ffdc13aea5dc360268b2640e60d19c) ) - ROM_LOAD( "pal16l8a.ic51.bin", 0x000, 0x104, CRC(c1e6cb8f) SHA1(9908e62bb9b806047b7a344bb62334bd696b9fc8) ) // z80 address decoder? + ROM_LOAD( "jumping-pal16r6.bin", 0x000, 0x104, CRC(12e9a7b8) SHA1(a0ce8b6083c9adfcb4bdbca87f63a01f292525f3) ) + ROM_LOAD( "jumping-pal20l8.bin", 0x000, 0x144, CRC(76944f81) SHA1(ab78e4e157ffdc13aea5dc360268b2640e60d19c) ) + ROM_LOAD( "pal16l8a.ic51.bin", 0x000, 0x104, CRC(c1e6cb8f) SHA1(9908e62bb9b806047b7a344bb62334bd696b9fc8) ) // z80 address decoder? ROM_END ROM_START( jumpinga ) @@ -1081,9 +1075,9 @@ ROM_START( jumpinga ) ROM_LOAD32_BYTE( "jb2_i119", 0x80000, 0x08000, CRC(7e1d58d8) SHA1(d586a018c3ec3e6e6a39992170d324361e03c68a) ) ROM_REGION( 0x200, "pals", 0 ) - ROM_LOAD( "jumping-pal16r6.bin", 0x000, 0x104, CRC(12e9a7b8) SHA1(a0ce8b6083c9adfcb4bdbca87f63a01f292525f3) ) - ROM_LOAD( "jumping-pal20l8.bin", 0x000, 0x144, CRC(76944f81) SHA1(ab78e4e157ffdc13aea5dc360268b2640e60d19c) ) - ROM_LOAD( "pal16l8a.ic51.bin", 0x000, 0x104, CRC(c1e6cb8f) SHA1(9908e62bb9b806047b7a344bb62334bd696b9fc8) ) // z80 address decoder? + ROM_LOAD( "jumping-pal16r6.bin", 0x000, 0x104, CRC(12e9a7b8) SHA1(a0ce8b6083c9adfcb4bdbca87f63a01f292525f3) ) + ROM_LOAD( "jumping-pal20l8.bin", 0x000, 0x144, CRC(76944f81) SHA1(ab78e4e157ffdc13aea5dc360268b2640e60d19c) ) + ROM_LOAD( "pal16l8a.ic51.bin", 0x000, 0x104, CRC(c1e6cb8f) SHA1(9908e62bb9b806047b7a344bb62334bd696b9fc8) ) // z80 address decoder? ROM_END // red 'Imnoe' PCB -- cgit v1.2.3