From 3cb694eda3f23c5b213700bdf9d1e5abf50554da Mon Sep 17 00:00:00 2001
From: angelosa <lordkale4@gmail.com>
Date: Sat, 5 Oct 2024 19:43:06 +0200
Subject: nec/pc9801_v.cpp: kanji attribute doesn't want tile_lr

---
 src/mame/nec/pc9801_v.cpp | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/mame/nec/pc9801_v.cpp b/src/mame/nec/pc9801_v.cpp
index c888c1c1d9d..f7570b4f2d2 100644
--- a/src/mame/nec/pc9801_v.cpp
+++ b/src/mame/nec/pc9801_v.cpp
@@ -107,15 +107,16 @@ void pc9801_state::draw_text(bitmap_rgb32 &bitmap, uint32_t addr, int y, int wd,
 		uint8_t knj_tile = m_video_ram[0][tile_addr & 0xfff] >> 8;
 		if(knj_tile)
 		{
-			/* Note: bit 7 doesn't really count, if a kanji is enabled then the successive tile is always the second part of it.
-			   Trusted with Alice no Yakata, Animahjong V3, Aki no Tsukasa no Fushigi no Kabe, Apros ...
-			*/
+			// Note: bit 7 doesn't really count for normal kanjis,
+			// if a kanji is enabled then the successive tile is always the second part of it.
+			// Trusted with alice, animjv3, akitsuka, apros ...
 			//kanji_lr = (knj_tile & 0x80) >> 7;
-			//kanji_lr |= (tile & 0x80) >> 7; // Tokimeki Sports Gal 3
+			//kanji_lr |= (tile & 0x80) >> 7; // tokisg3
 			tile &= 0x7f;
 			tile <<= 8;
 			tile |= (knj_tile & 0x7f);
 			kanji_sel = 1;
+			// ginga and gage wants to dispatch PCG depending on the attribute
 			if((tile & 0xfe00) == 0x5600)
 			{
 				tile_lr = knj_tile & 0x80 ? 1 : 0;
@@ -132,9 +133,9 @@ void pc9801_state::draw_text(bitmap_rgb32 &bitmap, uint32_t addr, int y, int wd,
 
 		for(kanji_lr=0;kanji_lr<x_step;kanji_lr++)
 		{
-			/* Rori Rori Rolling definitely uses different colors for brake stop PCG elements,
-			   assume that all attributes are recalculated on different strips */
-			uint8_t attr = (m_video_ram[0][((tile_addr+kanji_lr+tile_lr) & 0xfff) | 0x1000] & 0xff);
+			// - roliroli wants to read the current strip for brake stop PCG elements
+			// - flixx selects attribute by the linear X in ranking (i.e. no tile_lr)
+			uint8_t attr = (m_video_ram[0][((tile_addr + kanji_lr) & 0xfff) | 0x1000] & 0xff);
 
 			uint8_t secret = (attr & 1) ^ 1;
 			uint8_t blink = attr & 2;
-- 
cgit v1.2.3