summaryrefslogtreecommitdiffstatshomepage
path: root/src/osd/modules/debugger/debugimgui.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Got rid of global_alloc/global_free. Vas Crabb2020-10-031-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | The global_alloc/global_free functions have outlived their usefulness. They don't allow consistently overriding the default memory allocation behaviour because they aren't used consistently, and we don't have standard library allocator wrappers for them that we'd need to use them consistently with all the standard library containers we're using. If you need to change the default allocator behaviour, you can override the new/delete operators, and there are ways to get more fine-grained control that way. We're already doing that to pre-fill memory in debug builds. Code was already starting to depend on global_alloc/global_free wrapping new/delete. For example some parts of the code (including the UI and Windows debugger) was putting the result of global_alloc in a std::unique_ptr wrappers without custom deleters, and the SPU sound device was assuming it could use global_free to release memory allocated with operator new. There was also code misunderstanding the behaviour of global_alloc, for example the GROM port cartridge code was checking for nullptr when a failure will actually throw std::bad_alloc. As well as substituting new/delete, I've made several things use smart pointers to reduce the chance of leaks, and fixed a couple of leaks, too.
* Debugger expression and memory access overhaul AJR2020-05-251-18/+18
| | | | | | | | | | | | | - Memory references in expressions no longer default to the console's visible CPU if no device name was specified, except when entered through the console itself. Expressions in view windows now use the context of the currently selected device instead. - The pcatmem debug command and similar qt mouseover function now produce an error message if the initial address translation fails. Related internal changes (nw) - The debugger_cpu class no longer interprets memory accesses. The existing routines have been moved into symbol_table (which used to invoke them as callbacks), and reimplemented in most other places. Thecode duplication is a bit messy, but could be potentially improved in the future with new utility classes. - The cheat engine no longer needs to hook into the debugger_cpu class or instantiate a dummy instance of it. - The inclusion of debug/express.h within emu.h has been undone. Some debugging structures now need unique_ptr to wrap the resulting incomplete classes; hopefully the performance impact of this is negligible. Another direct consequence is that the breakpoint, watchpoint and registerpoint classes are no longer inside device_debug and have their own source file. - The breakpoint list is now a std::multimap, using the addresses as keys to hopefully expedite lookup. - The visible CPU pointer has been removed from the debugger_cpu class, being now considered a property of the console instead. - Many minor bits of code have been simplified.
* Revert "fixed some modernize-use-equals-default clang-tidy warnings (… (#6360) Oliver Stöneberg2020-04-081-1/+1
| | | | | | | * Revert "fixed some modernize-use-equals-default clang-tidy warnings (nw)" This reverts commit 54486ab9 * fixed merge error
* fixed some modernize-use-auto clang-tidy warnings (nw) (#6238) Oliver Stöneberg2020-01-301-12/+12
|
* fixed some modernize-use-equals-default clang-tidy warnings (nw) (#6237) Oliver Stöneberg2020-01-301-1/+1
|
* fixed some clang-tidy warnings (nw) (#6236) Oliver Stöneberg2020-01-301-1/+1
| | | | | | | | | | | | | | | | * fixed some modernize-redundant-void-arg clang-tidy warnings (nw) * fixed some modernize-use-bool-literals clang-tidy warnings (nw) * fixed some modernize-use-emplace clang-tidy warnings (nw) * fixed some performance-move-const-arg clang-tidy warnings (nw) * fixed some readability-redundant-control-flow clang-tidy warnings (nw) * fixed some readability-redundant-string-cstr clang-tidy warnings (nw) * fixed some performance-unnecessary-value-param clang-tidy warnings (nw)
* fixed some clang-tidy warnings (nw) (#6197) Oliver Stöneberg2020-01-221-4/+4
| | | | | | | | | | | | | | * fixed some bugprone-throw-keyword-missing clang-tidy warnings (nw) * fixed some modernize-use-nullptr clang-tidy warnings (nw) * fixed some readability-delete-null-pointer clang-tidy warnings (nw) * fixed some performance-faster-string-find clang-tidy warnings (nw) * fixed some performance-for-range-copy clang-tidy warnings (nw) * fixed some readability-redundant-string-cstr clang-tidy warnings (nw)
* misc cleanup: Vas Crabb2019-11-181-25/+13
| | | | | | | * Got rid of some more simple_list in core debugger code * Fixed a buffer overrun in wavwrite (buffer half requried size) * Slightly reduced dependencies and overhead in wavwrite * Made new disassembly windows in Qt debugger default to current CPU
* 3rdparty: Updated bgfx, bimg, and bx to latest upstream. [Ryan Holtz] mooglyguy2018-12-051-3/+3
|
* fix building with clang 6.0.1 (nw) smf-2018-07-071-2/+0
|
* Convert zippath directory to a C++ interface Vas Crabb2018-01-101-11/+11
|
* Updated GENie, BGFX, BX, added BIMG since it is separated now, updated all ↵ Miodrag Milanovic2017-12-011-10/+7
| | | | shader binaries and MAME part of code to support new interfaces [Miodrag Milanovic]
* Don't process every character individually when searching - this reduces Vas Crabb2017-08-101-1/+1
| | | | | | lag if you keep typing while a big list is searched. (nw) patch up German translation
* general cleanup: Vas Crabb2017-05-231-1/+1
| | | | | | | | | | | * move rarely-used output and pty interfaces out of emu.h * consolidate and de-duplicate forward declarations, also remove some obsolete ones * clean up more #include guard macros * scope down a few more things (nw) Everyone, please keep forward declarations for src/emu in src/emu/emufwd.h - this will make it far easier to keep them in sync with declarations than having them scattered through all the other files.
* fix compile with Xcode 8.2 (nw) arbee2016-12-151-1/+1
|
* debugimgui: sort directory entries in mount dialog, as zippath_readdir() ↵ mahlemiut2016-12-161-0/+5
| | | | does not guarantee entries are in any particular order.
* debugimgui: lighten combo box list so that it's easier to read (nw) mahlemiut2016-12-041-2/+2
|
* simplified memory allocation for osd_module (nw) Miodrag Milanovic2016-11-111-0/+1
|
* NOTICE (TYPE NAME CONSOLIDATION) Miodrag Milanovic2016-10-221-8/+8
| | | | | Use standard uint64_t, uint32_t, uint16_t or uint8_t instead of UINT64, UINT32, UINT16 or UINT8 also use standard int64_t, int32_t, int16_t or int8_t instead of INT64, INT32, INT16 or INT8
* srcclean and translation regeneration Vas Crabb2016-08-291-9/+9
|
* debugimgui: added very crude create image dialog mahlemiut2016-08-251-54/+201
|
* debugimgui: added images menu, with crude file select dialog [Barry Rodewald] mahlemiut2016-08-161-2/+202
|
* Fix order of evaluation making imgui debugger not fail on starting without ↵ Miodrag Milanovic2016-07-231-1/+1
| | | | driver selected (nw)
* Cleanup and version bumpmame0175 Miodrag Milanovic2016-06-291-5/+5
|
* debugimgui: allow debugger console and log window scrollbars to stay at ↵ mahlemiut2016-06-251-1/+16
| | | | their maximum value if already there
* debugimgui: don't add command to history if it's the same as the previous one mahlemiut2016-06-231-1/+8
|
* debugimgui: when using history, set the cursor position to the end of the text mahlemiut2016-06-201-2/+2
|
* debugimgui: added history functionality to debugger console, fixed issue ↵ mahlemiut2016-06-191-4/+39
| | | | with main views being re-allocated when no extra windows have been created.
* debugimgui: if console window is active, then give console input widget ↵ mahlemiut2016-06-141-0/+2
| | | | focus. Note that this means that the disassmbly view in the console cannot get focus at all (but separate disasm windows still can).
* debugimgui: use IM_COL32 macro mahlemiut2016-06-131-3/+3
|
* debugimgui: draw a light rectangle around a view if it has focus, gives a ↵ mahlemiut2016-06-111-0/+10
| | | | visual cue as which view accepts input.
* Major refactoring of debugger core [Ryan Holtz] therealmogminer@gmail.com2016-06-081-22/+22
| | | | | | | | * Eliminate globals/file statics * Remove lots of stuff from global scope * Use std::function for custom command registration * Eliminate some trampolines * Build fixes from Vas Crabb and balr0g
* debugimgui: send character inputs to the debugger view with focus, allows ↵ mahlemiut2016-06-061-0/+12
| | | | editing in memory views.
* debugimgui: make new window shortcut keypresses not repeat mahlemiut2016-06-061-5/+5
|
* debugimgui: made debugger keys also use ImGui keypress functions mahlemiut2016-06-061-41/+41
|
* debugimgui: adjust key repeat rate a bit mahlemiut2016-06-051-0/+5
|
* debugimgui: fix exception when un-collapsing a single window. mahlemiut2016-06-051-11/+16
|
* debugimgui: use ImGui functions to handle view inputs, allows key repeating ↵ mahlemiut2016-06-051-12/+12
| | | | to work in the debugger views.
* debugimgui: actually map cursor keys so that they can be used in input text ↵ mahlemiut2016-06-041-29/+4
| | | | widgets. Duh.
* debugimgui: add auto select-all flag to disassembly and memory expression ↵ mahlemiut2016-06-041-4/+2
| | | | inputs.
* debugimgui: pressing Enter on an empty console input box does a single step. mahlemiut2016-06-031-2/+8
|
* debugimgui: removed scrollbar from memory windows, and let the view itself ↵ mahlemiut2016-06-021-8/+20
| | | | control what is displays. Use cursors/pageup/pagedown to control the memory window when the view cursor is visible.
* Cleanups and version bumpmame0174 Miodrag Milanovic2016-05-251-5/+5
|
* debugimgui: made a start on rendering just the visible areas of a debugger ↵ mahlemiut2016-05-201-55/+50
| | | | view. Generally works, but the scrollbar doesn't appear when viewing a 32-bit or larger address space (imgui bug?)
* Ioport refactoring and cleanups (nw) AJR2016-05-181-0/+1
| | | | | | - Completely move mouse hit testing down into the UI input module. This reduces some dependencies. - Never return a null pointer from ioport_field::name() to prevent potential crashes. All anonymous inputs are classified as INPUT_CLASS_INTERNAL, so several frontend functions now check type_class instead. - Correct a couple of typos.
* debugimgui: move view drawing into a single function, few more minor colour ↵ mahlemiut2016-05-141-318/+89
| | | | fixes.
* debugimgui: fix up title and menu bar colours. mahlemiut2016-05-121-8/+11
|
* Fix colors due to defaults change (nw) Miodrag Milanovic2016-05-121-3/+3
|
* debugimgui: Use a getter function for combo boxes. Memory windows are now ↵ mahlemiut2016-05-041-23/+11
| | | | much faster.
* debugimgui: move building of source lists for disasm and memory windows so ↵ mahlemiut2016-05-021-23/+24
| | | | they are done once when created.