summaryrefslogtreecommitdiffstats
path: root/src/mame/drivers/sshangha.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Spring cleaning:GravatarGravatar Vas Crabb2019-11-011-1/+1
| | | | | | | | | | | | * Changed emu_fatalerror to use util::string_format semantics * Fixed some incorrectly marked up stuff in build scripts * Make internal layout compression type a scoped enum (only zlib is supported still, but at least the values aren't magic numbers now) * Fixed memory leaks in Xbox USB * There can only be one "perfect quantum" device - enforce that only the root machine can set it, as allowing subdevices to will cause weird issues with slot cards overiding it * Allow multiple devices to set maximum quantum and use the most restrictive one (it's maximum quantum, it would be minimum interleave) * Got rid of device_slot_card_interface as it wasn't providing value * Added a helper template to reduce certain kinds of boilerplate in slots/buses * Cleaned up some particularly bad slot code (plenty more of that to do), and made some slots more idiomatic
* Make devdelegate more like devcb for configuration. This is aGravatarGravatar Vas Crabb2019-10-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* (nw) segas18.cpp: Add in Sega ID# for Alien Storm (Japan) & other misc clean upsGravatarGravatar braintro2019-08-241-1/+1
|
* (nw) Better description of copyright ownerGravatarGravatar braintro2019-08-181-4/+4
|
* New working cloneGravatarGravatar braintro2019-08-121-1/+27
| | | | | | New working clone ------------------ Super Shanghai Dragon's Eye (Korea) [Team Europe, Brian Troha, The Dumping Union]
* deco146.cpp : UpdatesGravatarGravatar cam9002019-04-141-2/+2
| | | | | Reduce unnecessary arguments, Duplicates, Unnecessary lines, Fix spacings, Debugger issues, Use shorter type values deco104.cpp : Reduce unnecessary line, Use shorter type values
* deco146.cpp : Simplify handlers, Reduce some unnecessary linesGravatarGravatar cam9002019-03-311-2/+2
|
* Merge pull request #4779 from cam900/deco16_splitGravatarGravatar R. Belmont2019-03-301-1/+0
|\ | | | | deco16ic.cpp : Move cninja exclusive transmask function into cninja.cpp
| * deco16ic.cpp : Move cninja exclusive transmask function into cninja.cppGravatarGravatar cam9002019-03-201-1/+0
| |
* | emupal.cpp : Remove MCFGs, Simplify handlers (#4713)GravatarGravatar cam9002019-03-291-2/+2
|/
* Start cleaning up palette configuration:GravatarGravatar Vas Crabb2018-12-291-1/+1
| | | | | | | | | | * Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.
* srcclean (nw)GravatarGravatar Vas Crabb2018-09-231-2/+2
|
* sshangha.cpp: added save state support, removed MCFG macros (nw)GravatarGravatar Ivan Vangelista2018-09-101-101/+92
|
* sshangha.cpp : Fix OKI clock/pin7GravatarGravatar cam9002018-09-051-1/+1
| | | Reference : https://www.youtube.com/watch?v=buCb-exoJWo
* improve sshangha mixing and palette handling (#3959)GravatarGravatar David Haywood2018-09-051-61/+81
| | | | | | | | | * improve sshangha mixing and palette handling helps with the issues listed in MT6020 ( https://mametesters.org/view.php?id=6020 ) * improve (nw) * don't think we have to pri-split spr1 (nw)
* midwunit.cpp: Document alternate style rom labels which show dates of roms ↵GravatarGravatar braintro2018-08-251-2/+2
| | | | for MK3 (nw)
* sshangha.cpp: Added PCB layout for Super Shanghai Dragon's Eye and corrected ↵GravatarGravatar braintro2018-08-161-13/+47
| | | | the clocks based off of actual OSC. [Brian Troha]
* new working cloneGravatarGravatar Ivan Vangelista2018-08-111-2/+23
| | | | | ---------------------------- Super Shanghai Dragon's Eye (World) [Fabrice Arzeno, The Dumping Union]
* as if millions of this pointers suddenly cried out in terror, and were ↵GravatarGravatar Vas Crabb2018-06-081-16/+16
| | | | | | | suddenly silenced * streamline templates in addrmap.h * get rid of overloads on read/write member names - this will become even more important in the near future
* More cleanup/streamlining of machine configuration and macros:GravatarGravatar Vas Crabb2018-05-151-2/+2
| | | | | | | | | | | | | * Get rid of implicit prefix for GFX decode names and prefix them all * Get rid of special macro for adding GFXDECODE in favour of constructor * Make empty GFX decode a static member of interface * Allow palette to be specified to GFXDECODE as a device finder * Removed diserial.h from emu.h as it's used relatively infrequently Also fix darkseal and vaportra propely. The palette device automatically attaches itself to a share with matching tag. The correct solution here is to rename one or the other out of the way, since it was never attached to a share before.
* Removed DRIVER_INIT-related macros, made driver init entry in GAME/COMP/CONS ↵GravatarGravatar MooglyGuy2018-05-131-3/+3
| | | | | | | | | | | | explicit. (#3565) * -Removed DRIVER_INIT macros in favor of explicitly-named member functions, nw * -Removed DRIVER_INIT_related macros. Made init_ prefix on driver initializers explicit. Renamed init_0 to empty_init. Fixed up GAME/COMP/CONS macro spacing. [Ryan Holtz] * Missed some files, nw * Fix compile, (nw)
* dsp16: fix condition mask in disassembler (nw)GravatarGravatar Vas Crabb2018-05-091-1/+2
| | | | (nw) remove more MCFG macros and make speaker config more explicit
* (nw) checkpoint since Midway SSIO sound is fixed - periodic interrupt ↵GravatarGravatar Vas Crabb2018-05-071-1/+1
| | | | doesn't support derived clock, kill off some more low-value macros, add a validity check, fix changes to Okim M6295 pin 7 in vgmplay
* Streamline machine configuration macros - everyone's a device edition.GravatarGravatar Vas Crabb2018-05-061-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start replacing special device macros with additional constructors, starting with ISA, INTELLEC 4 and RS-232 buses. Allow an object finder to take on the target of another object finder. (For a combination of the previous two things in action, see either the INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out looping over a device finder array to instantiate devices in some places. Lots of things no longer need to pass tags around.) Start supplying default clocks for things that have a standard clock or have all clocks internal. Eliminate the separate DEV versions of the DEVCB_ macros. Previously, the plain versions were a shortcut for DEVICE_SELF as the target. You can now supply a string tag (relative to current device being configured), an object finder (takes on the base and relative tag), or a reference to a device/interface (only do this if you know the device won't be replaced out from under it, but that's a safe assumption for your subdevices). In almost all cases, you can get the effect you want by supplying *this as the target. Eliminate sound and CPU versions of macros. They serve no useful purpose, provide no extra checks, make error messages longer, add indirection, and mislead newbies into thinking there's a difference. Remove a lot of now-unnecessary ":" prefixes binding things relative to machine root. Clean up some miscellaneous rot. Examples of new functionality in use in (some more subtle than others): * src/mame/drivers/intellec4.cpp * src/mame/drivers/tranz330.cpp * src/mame/drivers/osboren1.cpp * src/mame/drivers/zorba.cpp * src/mame/devices/smioc.cpp * src/devices/bus/a2bus/pc_xporter.cpp * src/devices/bus/isa/isa.h * src/devices/bus/isa/isa.h * src/devices/bus/intellec4/intellec4.h
* Address maps macros removal, pass 1 [O. Galibert]GravatarGravatar Olivier Galibert2018-03-141-66/+69
|
* (nw) screw you macros and the horse you rode in onGravatarGravatar Vas Crabb2018-02-141-1/+2
| | | | | | There's no voodoo involved in derived machine configurations and fragments any more. The macros were just obfuscating things at this point.
* API change: Memory maps are now methods of the owner class [O. Galibert]GravatarGravatar Olivier Galibert2018-02-121-3/+3
| | | | | Also, a lot more freedom happened, that's going to be more visible soon.
* deco16ic : Split pf1/2 size (#3124)GravatarGravatar cam9002018-01-251-1/+2
| | | cninja : cleanup ioprot
* API Change: Machine configs are now a method of the owner class, and the ↵GravatarGravatar Olivier Galibert2018-01-171-2/+2
| | | | | | | | | | prototype is simplified [O. Galibert] Beware, the device context does not follow in MCFG_FRAGMENT_ADD anymore due to the prototype change. So creating a device then configuring through a fragment doesn't work as-is. The simplest solution is just to add a MCFG_DEVICE_MODIFY at the start of the fragment with the correct tag.
* Revert "Revert "Merge branch 'master' of https://github.com/mamedev/mame""GravatarGravatar Firehawke2017-12-131-4/+4
| | | | This reverts commit 54155441e9ba9941e85d80c4834a66376a11e791.
* Revert "Merge branch 'master' of https://github.com/mamedev/mame"GravatarGravatar Firehawke2017-12-131-4/+4
| | | | | This reverts commit f537428e5a40ba6dde8ca9bf0fe9ae6b1f189ac4, reversing changes made to 0d70d798107d4e4e8fb9f230410aeb1e888d65c5.
* get rid of legacy BITSWAP* (nw)GravatarGravatar Vas Crabb2017-12-131-4/+4
|
* deco146: Use DEVCB for input ports and explicitly define these in all ↵GravatarGravatar AJR2017-08-311-0/+3
| | | | drivers (nw)
* Move static data out of devices into the device types. This is a ↵GravatarGravatar Vas Crabb2017-05-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | significant change, so please pay attention. The core changes are: * Short name, full name and source file are no longer members of device_t, they are part of the device type * MACHINE_COFIG_START no longer needs a driver class * MACHINE_CONFIG_DERIVED_CLASS is no longer necessary * Specify the state class you want in the GAME/COMP/CONS line * The compiler will work out the base class where the driver init member is declared * There is one static device type object per driver rather than one per machine configuration Use DECLARE_DEVICE_TYPE or DECLARE_DEVICE_TYPE_NS to declare device type. * DECLARE_DEVICE_TYPE forward-declares teh device type and class, and declares extern object finders. * DECLARE_DEVICE_TYPE_NS is for devices classes in namespaces - it doesn't forward-declare the device type. Use DEFINE_DEVICE_TYPE or DEFINE_DEVICE_TYPE_NS to define device types. * These macros declare storage for the static data, and instantiate the device type and device finder templates. The rest of the changes are mostly just moving stuff out of headers that shouldn't be there, renaming stuff for consistency, and scoping stuff down where appropriate. Things I've actually messed with substantially: * More descriptive names for a lot of devices * Untangled the fantasy sound from the driver state, which necessitates breaking up sound/flip writes * Changed DECO BSMT2000 ready callback into a device delegate * Untangled Microprose 3D noise from driver state * Used object finders for CoCo multipak, KC85 D002, and Irem sound subdevices * Started to get TI-99 stuff out of the TI-990 directory and arrange bus devices properly * Started to break out common parts of Samsung ARM SoC devices * Turned some of FM, SID, SCSP DSP, EPIC12 and Voodoo cores into something resmbling C++ * Tried to make Z180 table allocation/setup a bit safer * Converted generic keyboard/terminal to not use WRITE8 - space/offset aren't relevant * Dynamically allocate generic terminal buffer so derived devices (e.g. teleprinter) can specify size * Imporved encapsulation of Z80DART channels * Refactored the SPC7110 bit table generator loop to make it more readable * Added wrappers for SNES PPU operations so members can be made protected * Factored out some boilerplate for YM chips with PSG * toaplan2 gfx * stic/intv resolution * Video System video * Out Run/Y-board sprite alignment * GIC video hookup * Amstrad CPC ROM box members * IQ151 ROM cart region * MSX cart IRQ callback resolution time * SMS passthrough control devices starting subslots I've smoke-tested several drivers, but I've probably missed something. Things I've missed will likely blow up spectacularly with failure to bind errors and the like. Let me know if there's more subtle breakage (could have happened in FM or Voodoo). And can everyone please, please try to keep stuff clean. In particular, please stop polluting the global namespace. Keep things out of headers that don't need to be there, and use things that can be scoped down rather than macros. It feels like an uphill battle trying to get this stuff under control while more of it's added.
* Self-registering devices prep:GravatarGravatar Vas Crabb2017-02-271-1/+5
| | | | | | | | | | | | | | * Make device_creator a variable template and get rid of the ampersands * Remove screen.h and speaker.h from emu.h and add where necessary * Centralise instantiations of screen and speaker finder templates * Add/standardise #include guards in many hearers * Remove many redundant #includes * Order #includesr to help catch headers that can't be #included alone (nw) This changes #include order to be prefix, unit header if applicable then other stuff roughly in order from most dependent to least dependent library. This helps catch headers that don't #include things that they use.
* NOTICE (TYPE NAME CONSOLIDATION)GravatarGravatar Miodrag Milanovic2016-10-221-8/+8
| | | | | Use standard uint64_t, uint32_t, uint16_t or uint8_t instead of UINT64, UINT32, UINT16 or UINT8 also use standard int64_t, int32_t, int16_t or int8_t instead of INT64, INT32, INT16 or INT8
* more trampolines removal (nw)GravatarGravatar Ivan Vangelista2016-06-141-6/+1
|
* Reduce the incidence of required_device<palette_device> in subdevicesGravatarGravatar AJR2016-04-021-3/+0
| | | | | | Any device implementing device_gfx_interface will require a palette and, once it has started (which many video devices already check for), allow other devices to access it through a getter. This makes it unnecessary in most cases for devices to require both a gfxdecode and a palette; indeed, many devices went on to not use the palette at all. Most cases have been solved in one of two contrasting ways: remove the palette finder and associated macros for configuring it, or implement device_gfx_interface and remove the gfxdecode finder. The latter solution, generally adopted for devices that decoded their own graphics internally or through their own subdevice, has doubled the number of implementations of device_gfx_interface and eliminated the need for Konami games to provide empty gfxdecodes.
* Rename *.c -> *.cpp in our source (nw)GravatarGravatar Miodrag Milanovic2015-11-081-0/+513