| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
src/tools).
|
| |
|
| |
|
|
|
|
| |
are not verified
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fundamental change to show device delegates are configured.
Device delegates are now aware of the current device during
configuration and will resolve string tags relative to it. This means
that device delegates need a device to be supplied on construction so
they can find the machine configuration object. There's a
one-dimensional array helper to make it easier to construct arrays of
device delegates with the same owner. (I didn't make an n-dimensional
one because I didn't hit a use case, but it would be a simple addition.)
There's no more bind_relative_to member - just call resolve() like you
would for a devcb. There's also no need to cast nullptr when creating a
late bind device delegate. The flip side is that for an overloaded or
non-capturing lambda you'll need to cast to the desired type.
There is one less conditional branch in the hot path for calls for
delegates bound to a function pointer of member function pointer. This
comes at the cost of one additional unconditional branch in the hot
path for calls to delegates bound to functoids (lambdas, functions that
don't take an object reference, other callable objects). This applies
to all delegates, not just device delegates.
Address spaces will now print an error message if a late bind error is
encountered while installing a handler. This will give the range and
address range, hopefully making it easier to guess which memory map is
faulty.
For the simple case of allowing a device_delegate member to be
configured, use a member like this:
template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); }
For a case where different delegates need to be used depending on the
function signature, see src/emu/screen.h (the screen update function
setters).
Device delegates now take a target specification and function pointer.
The target may be:
* Target omitted, implying the current device being configured. This
can only be used during configuration. It will work as long as the
current device is not removed/replaced.
* A tag string relative to the current device being configured. This
can only be used during configuration. It will not be callable until
.resolve() is called. It will work as long as the current device is
not removed/replaced.
* A device finder (required_device/optional_device). The delegate will
late bind to the current target of the device finder. It will not
be callable until .resolve() is called. It will work properly if the
target device is replaced, as long as the device finder's base object
isn't removed/replaced.
* A reference to an object. It will be callable immediately. It will
work as long as the target object is not removed/replaced.
The target types and restrictions are pretty similar to what you already
have on object finders and devcb, so it shouldn't cause any surprises.
Note that dereferencing a device finder will changes the effect. To
illustrate this:
...
required_device<some_device> m_dev;
...
m_dev(*this, "dev")
...
// will late bind to "dev" relative to *this
// will work if "dev" hasn't been created yet or is replaced later
// won't work if *this is removed/replaced
// won't be callable until resolve() is called
cb1.set(m_dev, FUNC(some_device::w));
...
// will bind to current target of m_dev
// will not work if m_dev is not resolved
// will not work if "dev" is replaced later
// will be callable immediately
cb2.set(*m_dev, FUNC(some_device::w));
...
The order of the target and name has been reversed for functoids
(lambdas and other callable objects). This allows the NAME macro to
be used on lambdas and functoids. For example:
foo.set_something(NAME([this] (u8 data) { m_something = data; }));
I realise the diagnostic messages get ugly if you use NAME on a large
lambda. You can still give a literal name, you just have to place it
after the lambda rather than before. This is uglier, but it's
intentional. I'm trying to drive developers away from a certain style.
While it's nice that you can put half the driver code in the memory map,
it detracts from readability. It's hard to visualise the memory range
mappings if the memory map functions are punctuated by large lambdas.
There's also slightly higher overhead for calling a delegate bound to a
functoid.
If the code is prettier for trivial lambdas but uglier for non-trivial
lambdas in address maps, it will hopefully steer people away from
putting non-trivial lambdas in memory maps.
There were some devices that were converted from using plain delegates
without adding bind_relative_to calls. I fixed some of them (e.g.
LaserDisc) but I probably missed some. These will likely crash on
unresolved delegate calls.
There are some devices that reset delegates at configuration complete or
start time, preventing them from being set up during configuration (e.g.
src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This
goes against the design principles of how device delegates should be
used, but I didn't change them because I don't trust myself to find all
the places they're used.
I've definitely broken some stuff with this (I know about asterix), so
report issues and bear with me until I get it all fixed.
|
|
|
|
| |
emu\memarray.h cause I didn't want to cause a full recompile for this (nw)
|
|
|
|
| |
usages
|
|
|
|
|
|
|
|
|
|
| |
* Basically, initialisers go in the constructor arguments, and things for setting format go in set_format.
* Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag.
* Formats can be specified with an enum discriminator or a size and function pointer.
* You must always supply the number of entries when setting the format.
* When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together.
* The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation.
* Also killed an overload on delegates that wasn't being useful.
|
| |
|
|
|
|
| |
will be used in games (nw)
|
|
|
|
|
|
| |
pgm2 instead of improving anything, nw", Fix regressions, Reduce unnecessary arguments, values
It's tested, now almost same to old behavior.
|
|
|
|
| |
instead of improving anything, nw
|
|
|
|
|
|
|
|
|
|
|
|
| |
* pgm2.cpp, pgm2_memcard.cpp : Cleanups, Updates
pgm2.cpp : Do single-pass sprite drawing (uses screen.priority), Remove unused routine/values, Add notes, Shorter type values, Move most of things into private:, Make decrypt rom size related to ROM board integreated RAM size when RAM exists in ROM board, Add input name, Remove machine().save().register_postload, Reduce runtime tag lookups, Remove MCFGs, Remove unnecessary arguments, Simplified gfxdecode
pgm2_memcard.cpp : Shorter type values, Fix naming, Remove unnecessary arguments
* pgm2.cpp : Add Internal ROM version notes related to test mode
* pgm2.cpp : Minor type value correction
* pgm2.cpp : Add more notes, Fix RAM test fail (RAM4 at kov2nl, kov3, kof98umh, ddpdojt), Minor cleanup duplicate
|
| |
|
| |
|
|
|
|
| |
removal, nw
|
|
|
|
| |
behaviour becomes inconsistent between MSVC and GCC due to how pre-compiled headers are handled in MAME (nw)
|
|
|
|
|
|
|
| |
suddenly silenced
* streamline templates in addrmap.h
* get rid of overloads on read/write member names - this will become even more important in the near future
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Get rid of implicit prefix for GFX decode names and prefix them all
* Get rid of special macro for adding GFXDECODE in favour of constructor
* Make empty GFX decode a static member of interface
* Allow palette to be specified to GFXDECODE as a device finder
* Removed diserial.h from emu.h as it's used relatively infrequently
Also fix darkseal and vaportra propely. The palette device
automatically attaches itself to a share with matching tag. The correct
solution here is to rename one or the other out of the way, since it was
never attached to a share before.
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit. (#3565)
* -Removed DRIVER_INIT macros in favor of explicitly-named member functions, nw
* -Removed DRIVER_INIT_related macros. Made init_ prefix on driver initializers explicit. Renamed init_0 to empty_init. Fixed up GAME/COMP/CONS macro spacing. [Ryan Holtz]
* Missed some files, nw
* Fix compile, (nw)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* pgm.cpp : Correct metadata related to title screen
* pgm.cpp : Fix pgm3in1, svg* region string related to title screen
pgm2.cpp : Fix metadatas
* pgm2.cpp : Add notes
pgm2.cpp : Add ROM version info, Update title/distributor related to attract screens/title screen
* pgm.cpp : Add notes
add version/build time info related to operator setting in service mode/warning screens
* pgm2.cpp : fix unbreaked
* pgm2.cpp : Fix romanized japanese
* pgm.cpp : Fix metadata/Romanisations
pgm.cpp : Fix Romanisation/metadatas/version infos for bootlegs, etc (related to warning screen/operator setting/title screens)
* pgm.cpp : Fix duplicate
* pgm.cpp : Update informations
* pgm2.cpp : Update informations
|
|
|
|
| |
(nw) remove more MCFG macros and make speaker config more explicit
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix MT06964
Fix µPD7759 class hierarchy, and reset callback before resolving it
(fixed assert in Sega C2)
Remove some more low-value device add indirection macros, default some
more clocks
Make cards inherit clock from slot by default
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start replacing special device macros with additional constructors,
starting with ISA, INTELLEC 4 and RS-232 buses.
Allow an object finder to take on the target of another object finder.
(For a combination of the previous two things in action, see either the
INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out
looping over a device finder array to instantiate devices in some
places. Lots of things no longer need to pass tags around.)
Start supplying default clocks for things that have a standard clock or
have all clocks internal.
Eliminate the separate DEV versions of the DEVCB_ macros. Previously,
the plain versions were a shortcut for DEVICE_SELF as the target. You
can now supply a string tag (relative to current device being
configured), an object finder (takes on the base and relative tag), or
a reference to a device/interface (only do this if you know the device
won't be replaced out from under it, but that's a safe assumption for
your subdevices). In almost all cases, you can get the effect you want
by supplying *this as the target.
Eliminate sound and CPU versions of macros. They serve no useful
purpose, provide no extra checks, make error messages longer, add
indirection, and mislead newbies into thinking there's a difference.
Remove a lot of now-unnecessary ":" prefixes binding things relative to
machine root.
Clean up some miscellaneous rot.
Examples of new functionality in use in (some more subtle than others):
* src/mame/drivers/intellec4.cpp
* src/mame/drivers/tranz330.cpp
* src/mame/drivers/osboren1.cpp
* src/mame/drivers/zorba.cpp
* src/mame/devices/smioc.cpp
* src/devices/bus/a2bus/pc_xporter.cpp
* src/devices/bus/isa/isa.h
* src/devices/bus/isa/isa.h
* src/devices/bus/intellec4/intellec4.h
|
| |
|
|
|
|
|
|
| |
There's no voodoo involved in derived machine configurations and
fragments any more. The macros were just obfuscating things at this
point.
|
|
|
|
|
| |
Also, a lot more freedom happened, that's going to be more visible
soon.
|
|
|
|
|
|
|
| |
This allows for the much more natural "import another map and patch
it" structure, or "cover a whole region then punch holes in it". Our
previous first-entry-wins rule was always a surprise to newcomers, and
oldcomers too.
|
| |
|
| |
|
|
|
|
|
| |
-----------------
Knights of Valour 3 (V101, China, Hong Kong, Taiwan) [Peter Wilhelmsen, Morten Shearman Kirkegaard, David Haywood, MetalliC]
|
|
|
|
|
|
|
|
|
| |
------------------------
Oriental Legend 2 (V104, Japan) [Peter Wilhelmsen, Morten Shearman Kirkegaard, ShouTime,
Mouloud Bessaad, Dulleron, Christian Ricolleau, Marisol Nunez Serrano, Renato Mucciarelli,
Jeffrey Gray, John Wilke, Darksoft, Ryan Holtz, Smitdogg, The Dumping Union]
Oriental Legend 2 (V103, Japan)
Oriental Legend 2 (V101, Japan)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
prototype is simplified [O. Galibert]
Beware, the device context does not follow in MCFG_FRAGMENT_ADD
anymore due to the prototype change. So creating a device then
configuring through a fragment doesn't work as-is. The simplest
solution is just to add a MCFG_DEVICE_MODIFY at the start of the
fragment with the correct tag.
|
|
|
|
|
|
|
| |
Kirkegaard]
improved simulation using real data, make fake keys for kov3 100 and 104 [MetalliC]
note: mainly for documentation of rom module functioning, have no effect on emulation
|
|
|
|
| |
-state 0) tag driver as supporting states.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* remove no longer needed kov3 key from igs036crypt.cpp/.h
add kov2nl overseas set
rename ddpdojh -> ddpdojt because it's called 'Tamashii' also changed description to match format used by pgm1.cpp DDP titles.
updated some notes
* list Cave (nw)
* deleted 1 too many characters (nw)
|
| |
|
| |
|
| |
|
|
|
|
| |
probably should be devicified later.
|
|
|
|
|
|
| |
Knights of Valour 3 (V104, China, Hong Kong, Taiwan) [Peter Wilhelmsen, Morten Shearman Kirkegaard, David Haywood, MetalliC]
Knights of Valour 3 (V102, China, Hong Kong, Taiwan) [Peter Wilhelmsen, Morten Shearman Kirkegaard, David Haywood, MetalliC]
Knights of Valour 3 (V100, China, Hong Kong, Taiwan) [Peter Wilhelmsen, Morten Shearman Kirkegaard, David Haywood, MetalliC]
|
| |
|
|
|
|
|
|
| |
Shearman Kirkegaard]
not: FPGA comms emulation required, currently hacked out.
|
| |
|