path: root/src/mame/drivers/expro02.cpp
Commit message (Collapse)AuthorAgeFilesLines
* kaneko_spr.cpp : Fix drawing behaviorGravatarGravatar cam9002020-01-231-1/+2
| | | | | Fix priority in enabled 'keep sprite' function, Split 'Copy temporary bitmap into screen bitmap' function and Getting sprite function kaneko16.cpp : Fix sprite delay, Add notes, Correct explbrkr OKI bankswitching (tied into m_ym2149[0] port B), Remove outdated note
* Make devdelegate more like devcb for configuration. This is aGravatarGravatar Vas Crabb2019-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* expro02.cpp: identified one dip-switch for zipzap (nw)GravatarGravatar Ivan Vangelista2019-08-051-1/+1
* New working cloneGravatarGravatar braintro2019-07-201-10/+33
| | | | | | New working clone ------------------ Zip & Zap (Less Explicit) [system11, The Dumping Union]
* kaneko_spr.cpp : UpdatesGravatarGravatar cam9002019-05-111-52/+29
| | | | Internalize gfxdecodes(VU002 has 4bpp, KC002 has 8bpp), Reduce unnecessary lines, Fix spacings,Use shorter / correct type values
* kaneko_tmap.cpp : UpdatesGravatarGravatar cam9002019-05-101-19/+11
| | | | Internalize gfxdecode, Initialize values, Reduce unnecessary lines, Fix spacings
* all: ram auto-sharing is going away, so fix drivers relying on it [O. Galibert]GravatarGravatar Olivier Galibert2019-05-061-2/+0
* kaneko_spr.cpp : Updates (#4749)GravatarGravatar cam9002019-04-051-3/+3
| | | Simplify handlers, Fix namings, Use shorter type vales
* Merge pull request #4741 from cam900/kaneko_tmap_argsGravatarGravatar R. Belmont2019-03-301-32/+62
|\ | | | | kaneko_tmap.cpp : Updates / Cleanups
| * kaneko_tmap.cpp : Updates / CleanupsGravatarGravatar cam9002019-03-101-32/+62
| | | | | | | | | | | | | | Add address_map for VRAM handling, Move expro02.cpp exclusive tilemap bankswitching function into expro02.cpp (now callback'd), Fix namings, Reduce duplicates, Simplify handlers expro02.cpp : Minor simplify handlers, Reduce runtime tag lookup, Minor fix naming jchan.cpp : Fix notes kaneko16.cpp : Reduce unnecessary lines, Fix notes
* | (nw) Clean up the mess on masterGravatarGravatar Vas Crabb2019-03-261-67/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | This effectively reverts b380514764cf857469bae61c11143a19f79a74c5 and c24473ddff715ecec2e258a6eb38960cf8c8e98e, restoring the state at 598cd5227223c3b04ca31f0dbc1981256d9ea3ff. Before pushing, please check that what you're about to push is sane. Check your local commit log and ensure there isn't anything out-of-place before pushing to mainline. When things like this happen, it wastes everyone's time. I really don't need this in a week when real work™ is busting my balls and I'm behind where I want to be with preparing for MAME release.
* | Revert "conflict resolution (nw)"GravatarGravatar andreasnaive2019-03-251-76/+67
| | | | | | | | | | This reverts commit c24473ddff715ecec2e258a6eb38960cf8c8e98e, reversing changes made to 009cba4fb8102102168ef32870892438327f3705.
* | small update to readme (#4747)GravatarGravatar f205v2019-03-141-3/+4
|/ | | correct chip type + typo
* Fix clang error: must explicitly qualify name of member function when taking ↵GravatarGravatar AJR2019-03-081-1/+1
| | | | its address (nw)
* mame\drivers: removed most MCFG and MACHINE_CONFIG macros from drivers ↵GravatarGravatar Ivan Vangelista2019-03-081-59/+59
| | | | starting with e (nw)
* devices\machine\ticket, timer: removed MCFG macros (nw)GravatarGravatar Ivan Vangelista2019-01-211-1/+1
* get rid of the rest of the digfx MCFG as well (nw)GravatarGravatar Vas Crabb2019-01-071-3/+11
* Start cleaning up palette configuration:GravatarGravatar Vas Crabb2018-12-291-36/+22
| | | | | | | | | | * Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.
* src\mame: misc MCFG removal (nw)GravatarGravatar Ivan Vangelista2018-12-031-5/+2
* mame/video: more macro removal (nw)GravatarGravatar Ivan Vangelista2018-11-231-12/+11
* watchdog: removed MCFG macros (nw)GravatarGravatar Ivan Vangelista2018-09-071-4/+2
* more private member use in 'D, E, F, G' drivers (nw) (#3704)GravatarGravatar David Haywood2018-06-271-10/+13
| | | | | | | | | | | | * more private member use in 'D' drivers (nw) * same for 'E' drivers (nw) * and 'F' (nw) * 'G' (nw) (left galaxian/galaxold alone because I know somebody is looking at them)
* Remove emupal.h from emu.h (nw)GravatarGravatar AJR2018-06-131-0/+1
* as if millions of this pointers suddenly cried out in terror, and were ↵GravatarGravatar Vas Crabb2018-06-081-21/+21
| | | | | | | suddenly silenced * streamline templates in addrmap.h * get rid of overloads on read/write member names - this will become even more important in the near future
* More cleanup/streamlining of machine configuration and macros:GravatarGravatar Vas Crabb2018-05-151-4/+4
| | | | | | | | | | | | | * Get rid of implicit prefix for GFX decode names and prefix them all * Get rid of special macro for adding GFXDECODE in favour of constructor * Make empty GFX decode a static member of interface * Allow palette to be specified to GFXDECODE as a device finder * Removed diserial.h from emu.h as it's used relatively infrequently Also fix darkseal and vaportra propely. The palette device automatically attaches itself to a share with matching tag. The correct solution here is to rename one or the other out of the way, since it was never attached to a share before.
* Removed DRIVER_INIT-related macros, made driver init entry in GAME/COMP/CONS ↵GravatarGravatar MooglyGuy2018-05-131-32/+31
| | | | | | | | | | | | explicit. (#3565) * -Removed DRIVER_INIT macros in favor of explicitly-named member functions, nw * -Removed DRIVER_INIT_related macros. Made init_ prefix on driver initializers explicit. Renamed init_0 to empty_init. Fixed up GAME/COMP/CONS macro spacing. [Ryan Holtz] * Missed some files, nw * Fix compile, (nw)
* dsp16: fix condition mask in disassembler (nw)GravatarGravatar Vas Crabb2018-05-091-1/+1
| | | | (nw) remove more MCFG macros and make speaker config more explicit
* Add support for custom device constructors when replacing devices.GravatarGravatar Vas Crabb2018-05-081-3/+3
| | | | | | | | | | Current syntax: MCFG_DEVICE_REPLACE(tag_or_finder, TYPE, ...) Next-generation syntax: TYPE(config.replace(), tag_or_finder, ...) (nw) Kill off some more low-value macros that aren't needed any more, and get rid of the token-pasting voodoo and casts in the discrete sound macros.
* (nw) checkpoint since Midway SSIO sound is fixed - periodic interrupt ↵GravatarGravatar Vas Crabb2018-05-071-1/+1
| | | | doesn't support derived clock, kill off some more low-value macros, add a validity check, fix changes to Okim M6295 pin 7 in vgmplay
* Streamline machine configuration macros - everyone's a device edition.GravatarGravatar Vas Crabb2018-05-061-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start replacing special device macros with additional constructors, starting with ISA, INTELLEC 4 and RS-232 buses. Allow an object finder to take on the target of another object finder. (For a combination of the previous two things in action, see either the INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out looping over a device finder array to instantiate devices in some places. Lots of things no longer need to pass tags around.) Start supplying default clocks for things that have a standard clock or have all clocks internal. Eliminate the separate DEV versions of the DEVCB_ macros. Previously, the plain versions were a shortcut for DEVICE_SELF as the target. You can now supply a string tag (relative to current device being configured), an object finder (takes on the base and relative tag), or a reference to a device/interface (only do this if you know the device won't be replaced out from under it, but that's a safe assumption for your subdevices). In almost all cases, you can get the effect you want by supplying *this as the target. Eliminate sound and CPU versions of macros. They serve no useful purpose, provide no extra checks, make error messages longer, add indirection, and mislead newbies into thinking there's a difference. Remove a lot of now-unnecessary ":" prefixes binding things relative to machine root. Clean up some miscellaneous rot. Examples of new functionality in use in (some more subtle than others): * src/mame/drivers/intellec4.cpp * src/mame/drivers/tranz330.cpp * src/mame/drivers/osboren1.cpp * src/mame/drivers/zorba.cpp * src/mame/devices/smioc.cpp * src/devices/bus/a2bus/pc_xporter.cpp * src/devices/bus/isa/isa.h * src/devices/bus/isa/isa.h * src/devices/bus/intellec4/intellec4.h
* Restrict ROM labels to a filesystem- and shell-safe subset of printableGravatarGravatar Vas Crabb2018-03-181-42/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ASCII. This has not been done unilaterally - I have the support of @galibert, @Tafoid, and @rb6502 to do something about the current free-for-all. The trouble with the ROM label field in MAME is that it serves multiple competing purposes: it's supposed to identify the device in the original system, and also act as a filename when searching for media image files to load. It also has to appear in listings of needed/missing files (e.g. in cases where the image _isn't_ found). To identify the original device, the ROM label field in MAME often contains text derived from some combination of one or more of the text on a label if present, the silkscreen on an IC package, the location on the circuit board, and the device designation. There's no standard for the order in which these appear and how they're separated. Some people add arbitrary filename extensions and other annotations. There are practical limitations on what can appear in the string, given it's used as a filename: * Path/name length limits. * Restrictions on characters that can appear in a filename. * Practicality of using the filename in a command-line environment. * Ambiguity when describing a filename. Filesystems themselves typically restrict characters in filenames: * Windows defines MAX_PATH as 260 characters - longer paths are difficult to use with Win32 APIs and don't work properly in Windows Explorer * Most filesystems don't allow ^@ or the path separator in names. * Windows doesn't allow C0 control characters or <>:"/\|?* characters in filenames. * Filesystems may have collation, e.g. FAT16 is case-folding, NTFS and HFS+ are case-preserving but case-insensitive, while EXT and XFS are case-sensitive. * Filesystems may perform Unicode normalisation, e.g. NTFS forces NFC, HFS+ forces NFD, while ZFS stores filenames as supplied at creation, but may be configured to apply normalisation when testing equality. Shells use various ASCII characters for special purposes: * C0 control characters for line editing and control (e.g. ^C to cancel a line, ^V for control charecter escape, ^R for history search). * The "'\ chracaters for quoting/escaping. * The ><| characters for redirection. * The *?[] characters for pattern matching. * The ${}~ characters for variable substitution/sequence expansion. * The ! or ^ characters for history substitution. * The ()` characters for controlling subshells. * The %& characters for job control. * The ; character as a command separator. * The # character for comments. There's also the issue of whether users across a range of locales will be able to type/display characters. We still don't have good support for Unicode console output on Windows (std::wcout doesn't seem to work properly), many users don't install C/J/K fonts, and many users aren't comfortable entering text in unfamiliar languages. This means we're limited to printable ASCII for practical purposes. The practical limitations mean the subset of "safe" characters is limited to ASCII digits, either uppercase or lowercase English Latin (but not both due to collation behaving differently across systems), and the +,-.=_ punctuation chracters. We've decided on lowercase, digits, and safe punctuation. In addition to this, spaces are allowed, as they can be quoted/escaped easily enough if no other special characters are used. There have been some arguments that allowing uppercase is "more accurate", but in practical terms it doesn't add much value. A string in a C++ program can't represent layout, relative size of text, colour and shape of the label, text font, graphics, and many other details. It also does nothing to address labels with text outside the English Latin alphabet (e.g. labels with Chinese ideographs). Besides missing information, the lack of hard and fast rules means you need to intuit what a label string in MAME is trying to represent. There is simply no substitute for photographs. There wasn't even any consistency in case within individual machine sets. For example, several games in vigilant.cpp had inconsistent case for "ic" vs "IC" in designation suffixes, and ibm6850.cpp had inconsistent case for filename extensions withing a set. There were sets that used uppercase for text from the label but not from the part number/PCB location, and vice versa. It was a huge mess. There's some merit to the idea of allowing a wider variety of characters in the label strings in the source, and mapping to a more restricted set when searching for files. However it creates more issues than it solves. It would require a change to the XML output to provide both the label and filename, and a corresponding change to external ROM management tools. It would be impractical to do for software lists, because it would require ROM management tools to implement the exact same mapping algorithm as MAME. But that aside, actually doing useful mapping would be impractical. What would you do with C/J/K ideographs, like the chip labelled 東方不敗 (Dongfang Bubai)? There's no intuitive way to do the mapping wtihout incluing something like Unihan data, which would add a lot of bloat. Even the, without a language hint the Romanisation would be less than ideal in many cases (using Chinese reading for Japanese text and vice versa). There's still the messy issue of filesystem collation to deal with. We do allow full Unicode in comments in the source. If you want to provide a more detailed description of a ROM label, that's the place for it. You've got more characters available, and the possibility of using mulitple lines. There are too many other competing requirements on the label field in the ROM definitions.
* Let's fix them all (nw)GravatarGravatar Olivier Galibert2018-03-151-5/+5
* Small fix (nw)GravatarGravatar Olivier Galibert2018-03-151-3/+3
* Address maps macros removal, pass 1 [O. Galibert]GravatarGravatar Olivier Galibert2018-03-141-156/+167
* de-staticify initializations for mame/machine (#3251)GravatarGravatar wilbertpol2018-02-211-1/+1
* de-staticify initializations for src/mame/video (nw) (#3246)GravatarGravatar wilbertpol2018-02-201-6/+6
* (nw) screw you macros and the horse you rode in onGravatarGravatar Vas Crabb2018-02-141-8/+16
| | | | | | There's no voodoo involved in derived machine configurations and fragments any more. The macros were just obfuscating things at this point.
* API change: Memory maps are now methods of the owner class [O. Galibert]GravatarGravatar Olivier Galibert2018-02-121-11/+22
| | | | | Also, a lot more freedom happened, that's going to be more visible soon.
* API change: Memory maps are now "last entry wins" [O. Galibert]GravatarGravatar Olivier Galibert2018-01-311-5/+4
| | | | | | | This allows for the much more natural "import another map and patch it" structure, or "cover a whole region then punch holes in it". Our previous first-entry-wins rule was always a surprise to newcomers, and oldcomers too.
* memory: Deambiguate handlers, also a hint of things to come (nw)GravatarGravatar Olivier Galibert2018-01-191-2/+2
* API Change: Machine configs are now a method of the owner class, and the ↵GravatarGravatar Olivier Galibert2018-01-171-9/+18
| | | | | | | | | | prototype is simplified [O. Galibert] Beware, the device context does not follow in MCFG_FRAGMENT_ADD anymore due to the prototype change. So creating a device then configuring through a fragment doesn't work as-is. The simplest solution is just to add a MCFG_DEVICE_MODIFY at the start of the fragment with the correct tag.
* Revert "Revert "Merge branch 'master' of""GravatarGravatar Firehawke2017-12-131-2/+2
| | | | This reverts commit 54155441e9ba9941e85d80c4834a66376a11e791.
* Revert "Merge branch 'master' of"GravatarGravatar Firehawke2017-12-131-2/+2
| | | | | This reverts commit f537428e5a40ba6dde8ca9bf0fe9ae6b1f189ac4, reversing changes made to 0d70d798107d4e4e8fb9f230410aeb1e888d65c5.
* get rid of legacy BITSWAP* (nw)GravatarGravatar Vas Crabb2017-12-131-2/+2
* Remove timer_device from emu.h and move it out of src/emu (nw)GravatarGravatar AJR2017-10-011-0/+1
* dimemory: Lift the cap on the number of address spaces per device [O. Galibert]GravatarGravatar Olivier Galibert2017-07-031-5/+5
* Move static data out of devices into the device types. This is a ↵GravatarGravatar Vas Crabb2017-05-141-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | significant change, so please pay attention. The core changes are: * Short name, full name and source file are no longer members of device_t, they are part of the device type * MACHINE_COFIG_START no longer needs a driver class * MACHINE_CONFIG_DERIVED_CLASS is no longer necessary * Specify the state class you want in the GAME/COMP/CONS line * The compiler will work out the base class where the driver init member is declared * There is one static device type object per driver rather than one per machine configuration Use DECLARE_DEVICE_TYPE or DECLARE_DEVICE_TYPE_NS to declare device type. * DECLARE_DEVICE_TYPE forward-declares teh device type and class, and declares extern object finders. * DECLARE_DEVICE_TYPE_NS is for devices classes in namespaces - it doesn't forward-declare the device type. Use DEFINE_DEVICE_TYPE or DEFINE_DEVICE_TYPE_NS to define device types. * These macros declare storage for the static data, and instantiate the device type and device finder templates. The rest of the changes are mostly just moving stuff out of headers that shouldn't be there, renaming stuff for consistency, and scoping stuff down where appropriate. Things I've actually messed with substantially: * More descriptive names for a lot of devices * Untangled the fantasy sound from the driver state, which necessitates breaking up sound/flip writes * Changed DECO BSMT2000 ready callback into a device delegate * Untangled Microprose 3D noise from driver state * Used object finders for CoCo multipak, KC85 D002, and Irem sound subdevices * Started to get TI-99 stuff out of the TI-990 directory and arrange bus devices properly * Started to break out common parts of Samsung ARM SoC devices * Turned some of FM, SID, SCSP DSP, EPIC12 and Voodoo cores into something resmbling C++ * Tried to make Z180 table allocation/setup a bit safer * Converted generic keyboard/terminal to not use WRITE8 - space/offset aren't relevant * Dynamically allocate generic terminal buffer so derived devices (e.g. teleprinter) can specify size * Imporved encapsulation of Z80DART channels * Refactored the SPC7110 bit table generator loop to make it more readable * Added wrappers for SNES PPU operations so members can be made protected * Factored out some boilerplate for YM chips with PSG * toaplan2 gfx * stic/intv resolution * Video System video * Out Run/Y-board sprite alignment * GIC video hookup * Amstrad CPC ROM box members * IQ151 ROM cart region * MSX cart IRQ callback resolution time * SMS passthrough control devices starting subslots I've smoke-tested several drivers, but I've probably missed something. Things I've missed will likely blow up spectacularly with failure to bind errors and the like. Let me know if there's more subtle breakage (could have happened in FM or Voodoo). And can everyone please, please try to keep stuff clean. In particular, please stop polluting the global namespace. Keep things out of headers that don't need to be there, and use things that can be scoped down rather than macros. It feels like an uphill battle trying to get this stuff under control while more of it's added.
* Self-registering devices prep:GravatarGravatar Vas Crabb2017-02-271-1/+5
| | | | | | | | | | | | | | * Make device_creator a variable template and get rid of the ampersands * Remove screen.h and speaker.h from emu.h and add where necessary * Centralise instantiations of screen and speaker finder templates * Add/standardise #include guards in many hearers * Remove many redundant #includes * Order #includesr to help catch headers that can't be #included alone (nw) This changes #include order to be prefix, unit header if applicable then other stuff roughly in order from most dependent to least dependent library. This helps catch headers that don't #include things that they use.
* More ACCESSING_BITS cleanupsGravatarGravatar Dirk Best2017-01-051-24/+12
* expro02.cpp: fixed manufacturer name for newly added set (nw)GravatarGravatar Ivan Vangelista2016-12-061-1/+1