summaryrefslogtreecommitdiffstatshomepage
path: root/src/mame/drivers/abc80x.cpp (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Rearrange source to match project structure (done using the script in ↵ Vas Crabb2022-06-271-1540/+0
| | | | src/tools).
* Future-proofing by using correct #include for SOFTWARE_LIST device AJR2022-01-031-0/+1
|
* New working machines Curt Coder2021-01-141-12/+56
| | | | | | | -------------------- Facit DTC (DeskTop Computer) [Luxor ABC arkivet, Curt Coder] abc800: Added new revisions of ROMs, and skeletons for DataBoard 4106/4107. [Luxor ABC arkivet, Curt Coder]
* Simplify snapshot/quickload callback parameters; remove some uses of ↵ AJR2021-01-051-2/+2
| | | | auto_alloc_array
* Various buses and associated drivers: Simplify handler signatures (nw) AJR2020-05-211-16/+19
|
* srcclean and manual cleanup (nw) Vas Crabb2020-04-261-6/+6
|
* abc80x: Fixed the ABC 850/852/856 hard disk drives. [Curt Coder] Curt Coder2020-04-161-1/+0
|
* abc800c, abc800m: Fixed HR graphics. [Curt Coder] Curt Coder2020-04-151-4/+4
|
* Machines promoted to working Curt Coder2020-04-151-144/+113
| | | | | | | ---------------------------- Luxor ABC 802 [Curt Coder] abc800m, abc800c, abc802: Fixed memory banking. [Curt Coder]
* abc802: Fixed M1 opcode fetch. [Curt Coder] Curt Coder2020-04-131-0/+10
|
* removed more dummy_space() and other miscellaneous space passing (nw) smf-2020-04-021-1/+1
|
* c64.cpp, c128.cpp: fixed CBM IEC slot address not being set when replacing ↵ Vas Crabb2019-11-151-0/+2
| | | | | | | | | | | | | | | | | | | devices in machine config bus/c64/rex_ep256.cpp: fixed array of EPROM slots not being populated (subdevices don't exist at construction time) cleanup: (nw) * having a macro for a device's expected tag in a header is bad - devices should not make assumptions about their tag or their location in the system hierarchy * device types exist in the global namespace - you must not use overly generic names for them as this is likely to cause collisions * device short names and titles each have their own namespace, but they're also global, and it should be possible to work out vaguely what a device is from its names * POSIX reserves all names ending in "_t" at global scope - we want fewer of these causing potential future issues, not more * if your device is in the global namespace, you should name it in a way that's not asking for name collisions to happen * we have a simple convention for device class names - it doesn't hurt to follow it: - concrete device_t implementations end with "_device" - device_interface implementations end with "_interface" (and often start with "device_") - abstract classes that derive from device_t end with "_device_base" * if you want to give your slot card device classes short, generic names, put them in a namespace for the "bus" * if you really want to use names ending with "_t", put them in a namespace or nest them inside a class
* Make devdelegate more like devcb for configuration. This is a Vas Crabb2019-10-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* (nw) get rid of wave.h usage part 1 Robbbert2019-07-061-6/+5
|
* -snapquik: Modernized delegate and removed MCFG macros. [Ryan Holtz] MooglyGuy2019-06-301-4/+5
|
* (nw) removed unneccesary casting of cassette_state; Robbbert2019-06-291-1/+3
|
* (nw) Clean up the mess on master Vas Crabb2019-03-261-46/+43
| | | | | | | | | | | | | This effectively reverts b380514764cf857469bae61c11143a19f79a74c5 and c24473ddff715ecec2e258a6eb38960cf8c8e98e, restoring the state at 598cd5227223c3b04ca31f0dbc1981256d9ea3ff. Before pushing, please check that what you're about to push is sane. Check your local commit log and ensure there isn't anything out-of-place before pushing to mainline. When things like this happen, it wastes everyone's time. I really don't need this in a week when real work™ is busting my balls and I'm behind where I want to be with preparing for MAME release.
* Revert "conflict resolution (nw)" andreasnaive2019-03-251-43/+46
| | | | | This reverts commit c24473ddff715ecec2e258a6eb38960cf8c8e98e, reversing changes made to 009cba4fb8102102168ef32870892438327f3705.
* mame\drivers: removed most MACHINE_CONFIG and MCFG macros from drivers ↵ Ivan Vangelista2019-03-251-31/+29
| | | | starting with a (nw)
* Make the delay for snapshot/quickload an attotime, and allow implicit zero. ↵ Vas Crabb2019-02-061-1/+1
| | | | Removing the MCFG macros properly requires changing the pattern for the delegates. (nw)
* devices\bus: some more MCFG macros removal (nw) Ivan Vangelista2019-02-011-6/+5
|
* emu\softlist_dev: removed MCFG macros (nw) Ivan Vangelista2019-01-301-3/+3
| | | | also removed MCFG_DEVICE_REMOVE, MCFG_QUANTUM_TIME and MCFG_QUANTUM_PERFECT_CPU (nw)
* bus/abcbus: Remove MCFG_ macros; add bus clocks (presumed same as CPUs) (nw) AJR2019-01-261-1/+1
|
* magedev\cassette: removed MCFG macros (nw) Ivan Vangelista2019-01-221-2/+2
|
* devices\machine\ticket, timer: removed MCFG macros (nw) Ivan Vangelista2019-01-211-2/+2
|
* discrete: Eliminate unnecessary address space argument from handlers (nw) AJR2018-11-121-2/+2
| | | | audio/galaxian: Move configuration to driver files (nw)
* abc80x.cpp: fixed copy-paste error. Thanks Tafoid! (nw) Ivan Vangelista2018-10-231-6/+6
|
* rs232: another batch of MCFG removal (nw) Ivan Vangelista2018-10-221-9/+9
|
* z80daisy_generic, z80dart, z80dma: removed MCFG macros (nw) Ivan Vangelista2018-08-301-15/+11
| | | | z80_daisy: first part of MCFG macro removal (nw)
* z80dart.cpp, z80dma.cpp: started removing MCFG macros (nw) Ivan Vangelista2018-08-291-17/+15
|
* -epson_lx810l: Eliminated MACHINE_CONFIG_START, nw mooglyguy2018-08-251-1/+1
| | | | -e0156, e05a30: Eliminated MCFG, nw
* z8536.cpp, z80sti.cpp: deMCGF; z80sio.cpp: started deMCFG (nw) Ivan Vangelista2018-08-241-11/+11
|
* -ram_device: MCFG removal, nw mooglyguy2018-08-161-11/+4
|
* devcb3 Vas Crabb2018-07-071-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are multiple issues with the current device callbacks: * They always dispatch through a pointer-to-member * Chained callbacks are a linked list so the branch unit can't predict the early * There's a runtime decision made on the left/right shift direction * There are runtime NULL checks on various objects * Binding a lambda isn't practical * Arbitrary transformations are not supported * When chaining callbacks it isn't clear what the MCFG_DEVCB_ modifiers apply to * It isn't possible to just append to a callback in derived configuration * The macros need a magic, hidden local called devcb * Moving code that uses the magic locals around is error-prone * Writing the MCFG_ macros to make a device usable is a pain * You can't discover applicable MCFG_ macros with intellisense * Macros are not scoped * Using an inappropriate macro isn't detected at compile time * Lots of other things This changeset overcomes the biggest obstacle to remving MCFG_ macros altogether. Essentially, to allow a devcb to be configured, call .bind() and expose the result (a bind target for the callback). Bind target methods starting with "set" repace the current callbacks; methods starting with "append" append to them. You can't reconfigure a callback after resolving it. There's no need to use a macro matching the handler signatures - use FUNC for everything. Current device is implied if no tag/finder is supplied (no need for explicit this). Lambdas are supported, and the memory space and offset are optional. These kinds of things work: * .read_cb().set([this] () { return something; }); * .read_cb().set([this] (offs_t offset) { return ~offset; }); * .write_cb().set([this] (offs_t offset, u8 data) { m_array[offset] = data; }); * .write_cb().set([this] (int state) { some_var = state; }); Arbitrary transforms are allowed, and they can modify offset/mask for example: * .read_cb().set(FUNC(my_state::handler)).transform([] (u8 data) { return bitswap<4>(data, 1, 3, 0, 2); }); * .read_cb().set(m_dev, FUNC(some_device::member)).transform([] (offs_t &offset, u8 data) { offset ^= 3; return data; }); It's possible to stack arbitrary transforms, at the cost of compile time (the whole transform stack gets inlined at compile time). Shifts count as an arbitrary transform, but mask/exor does not. Order of mask/shift/exor now matters. Modifications are applied in the specified order. These are NOT EQUIVALENT: * .read_cb().set(FUNC(my_state::handler)).mask(0x06).lshift(2); * .read_cb().set(FUNC(my_state::handler)).lshift(2).mask(0x06); The bit helper no longer reverses its behaviour for read callbacks, and I/O ports are no longer aware of the field mask. Binding a read callback to no-op is not supported - specify a constant. The GND and VCC aliases have been removed intentionally - they're TTL-centric, and were already being abused. Other quirks have been preserved, including write logger only logging when the data is non-zero (quite unhelpful in many of the cases where it's used). Legacy syntax is still supported for simple cases, but will be phased out. New devices should not have MCFG_ macros. I don't think I've missed any fundamental issues, but if I've broken something, let me know.
* srcclean and other cleanup (nw) Vas Crabb2018-06-241-1/+1
|
* abc80x: Cleanup. (nw) Curt Coder2018-06-151-48/+38
|
* as if millions of this pointers suddenly cried out in terror, and were ↵ Vas Crabb2018-06-081-13/+13
| | | | | | | suddenly silenced * streamline templates in addrmap.h * get rid of overloads on read/write member names - this will become even more important in the near future
* Move the +1 to the proper place in the ROM BIOS macros - that's been Vas Crabb2018-05-291-14/+14
| | | | | | | | | confusing people for far too long. Yes, this is a change in behaviour. Add a valdiation check for ROMs with BIOS flag set that are unselectable, fix the things it uncovers. (nw) Fix other random stuff.
* srcclean (nw) Vas Crabb2018-05-271-9/+9
|
* abc806: Fixed memory banking allowing CP/M to boot. [Curt Coder] Curt Coder2018-05-161-164/+143
|
* abc800: Cleanup. (nw) Curt Coder2018-05-141-172/+130
|
* abc806: Marked software list items as not working. (nw) Curt Coder2018-05-141-1/+0
|
* abc800: Removed outdated todo item. (nw) Curt Coder2018-05-141-1/+0
|
* Removed DRIVER_INIT-related macros, made driver init entry in GAME/COMP/CONS ↵ MooglyGuy2018-05-131-10/+10
| | | | | | | | | | | | explicit. (#3565) * -Removed DRIVER_INIT macros in favor of explicitly-named member functions, nw * -Removed DRIVER_INIT_related macros. Made init_ prefix on driver initializers explicit. Renamed init_0 to empty_init. Fixed up GAME/COMP/CONS macro spacing. [Ryan Holtz] * Missed some files, nw * Fix compile, (nw)
* abc800: Cleanup. (nw) Curt Coder2018-05-111-198/+77
|
* dsp16: fix condition mask in disassembler (nw) Vas Crabb2018-05-091-3/+3
| | | | (nw) remove more MCFG macros and make speaker config more explicit
* Add support for custom device constructors when replacing devices. Vas Crabb2018-05-081-7/+4
| | | | | | | | | | Current syntax: MCFG_DEVICE_REPLACE(tag_or_finder, TYPE, ...) Next-generation syntax: TYPE(config.replace(), tag_or_finder, ...) (nw) Kill off some more low-value macros that aren't needed any more, and get rid of the token-pasting voodoo and casts in the discrete sound macros.
* Streamline machine configuration macros - everyone's a device edition. Vas Crabb2018-05-061-118/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start replacing special device macros with additional constructors, starting with ISA, INTELLEC 4 and RS-232 buses. Allow an object finder to take on the target of another object finder. (For a combination of the previous two things in action, see either the INTELLEC 4 driver, or the Apple 2 PC Exporter card. Also check out looping over a device finder array to instantiate devices in some places. Lots of things no longer need to pass tags around.) Start supplying default clocks for things that have a standard clock or have all clocks internal. Eliminate the separate DEV versions of the DEVCB_ macros. Previously, the plain versions were a shortcut for DEVICE_SELF as the target. You can now supply a string tag (relative to current device being configured), an object finder (takes on the base and relative tag), or a reference to a device/interface (only do this if you know the device won't be replaced out from under it, but that's a safe assumption for your subdevices). In almost all cases, you can get the effect you want by supplying *this as the target. Eliminate sound and CPU versions of macros. They serve no useful purpose, provide no extra checks, make error messages longer, add indirection, and mislead newbies into thinking there's a difference. Remove a lot of now-unnecessary ":" prefixes binding things relative to machine root. Clean up some miscellaneous rot. Examples of new functionality in use in (some more subtle than others): * src/mame/drivers/intellec4.cpp * src/mame/drivers/tranz330.cpp * src/mame/drivers/osboren1.cpp * src/mame/drivers/zorba.cpp * src/mame/devices/smioc.cpp * src/devices/bus/a2bus/pc_xporter.cpp * src/devices/bus/isa/isa.h * src/devices/bus/isa/isa.h * src/devices/bus/intellec4/intellec4.h
* abc800: WIP (nw) Curt Coder2018-05-021-0/+57
|
* maps: Finish mame/drivers (nw) Olivier Galibert2018-04-191-24/+27
|