summaryrefslogtreecommitdiffstatshomepage
path: root/src/lib/util (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Fix clang error: cannot initialize a parameter of type 'void *' with an ↵ AJR2019-11-241-1/+1
| | | | lvalue of type 'volatile unsigned char *' (nw)
* apparently 3AM is not the time to code (nw) Vas Crabb2019-11-251-3/+3
|
* helps to git add before git commit (nw) Vas Crabb2019-11-251-1/+1
|
* pre-fill things allocated with operator new with 0xcd in debug builds (value ↵ Vas Crabb2019-11-251-0/+34
| | | | can be changed by setting global g_mame_new_prefill_byte with a debugger) - this is gonna hurt performance, but it will help catch issues exposed when we remove pre-clearing before constructing devices
* util/options.cpp: fix locale issues and a const correctness issue Vas Crabb2019-11-232-89/+169
|
* misc cleanup: Vas Crabb2019-11-183-101/+99
| | | | | | | * Got rid of some more simple_list in core debugger code * Fixed a buffer overrun in wavwrite (buffer half requried size) * Slightly reduced dependencies and overhead in wavwrite * Made new disassembly windows in Qt debugger default to current CPU
* Fix invalid std::vector<> lookup in aviio.cpp npwoods2019-11-041-1/+2
| | | | | | | | | | | | | This fixes a case where: * m_soundbuf_samples == processedsamples * processedsamples > 0 * processedsamples * stream->channels() == m_soundbuf.size() In this scenario, the std::memmove() would do nothing (moving zero bytes), but the operator[] on the second parameter to std::memmove() overflows the array. This can be benign in optimized builds (because the third parameter to std::memmove() is 0), but on debugging builds this can cause an assert.
* Make devdelegate more like devcb for configuration. This is a Vas Crabb2019-10-261-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fundamental change to show device delegates are configured. Device delegates are now aware of the current device during configuration and will resolve string tags relative to it. This means that device delegates need a device to be supplied on construction so they can find the machine configuration object. There's a one-dimensional array helper to make it easier to construct arrays of device delegates with the same owner. (I didn't make an n-dimensional one because I didn't hit a use case, but it would be a simple addition.) There's no more bind_relative_to member - just call resolve() like you would for a devcb. There's also no need to cast nullptr when creating a late bind device delegate. The flip side is that for an overloaded or non-capturing lambda you'll need to cast to the desired type. There is one less conditional branch in the hot path for calls for delegates bound to a function pointer of member function pointer. This comes at the cost of one additional unconditional branch in the hot path for calls to delegates bound to functoids (lambdas, functions that don't take an object reference, other callable objects). This applies to all delegates, not just device delegates. Address spaces will now print an error message if a late bind error is encountered while installing a handler. This will give the range and address range, hopefully making it easier to guess which memory map is faulty. For the simple case of allowing a device_delegate member to be configured, use a member like this: template <typename... T> void set_foo(T &&...args) { m_foo_cb.set(std::forward<T>(args)...); } For a case where different delegates need to be used depending on the function signature, see src/emu/screen.h (the screen update function setters). Device delegates now take a target specification and function pointer. The target may be: * Target omitted, implying the current device being configured. This can only be used during configuration. It will work as long as the current device is not removed/replaced. * A tag string relative to the current device being configured. This can only be used during configuration. It will not be callable until .resolve() is called. It will work as long as the current device is not removed/replaced. * A device finder (required_device/optional_device). The delegate will late bind to the current target of the device finder. It will not be callable until .resolve() is called. It will work properly if the target device is replaced, as long as the device finder's base object isn't removed/replaced. * A reference to an object. It will be callable immediately. It will work as long as the target object is not removed/replaced. The target types and restrictions are pretty similar to what you already have on object finders and devcb, so it shouldn't cause any surprises. Note that dereferencing a device finder will changes the effect. To illustrate this: ... required_device<some_device> m_dev; ... m_dev(*this, "dev") ... // will late bind to "dev" relative to *this // will work if "dev" hasn't been created yet or is replaced later // won't work if *this is removed/replaced // won't be callable until resolve() is called cb1.set(m_dev, FUNC(some_device::w)); ... // will bind to current target of m_dev // will not work if m_dev is not resolved // will not work if "dev" is replaced later // will be callable immediately cb2.set(*m_dev, FUNC(some_device::w)); ... The order of the target and name has been reversed for functoids (lambdas and other callable objects). This allows the NAME macro to be used on lambdas and functoids. For example: foo.set_something(NAME([this] (u8 data) { m_something = data; })); I realise the diagnostic messages get ugly if you use NAME on a large lambda. You can still give a literal name, you just have to place it after the lambda rather than before. This is uglier, but it's intentional. I'm trying to drive developers away from a certain style. While it's nice that you can put half the driver code in the memory map, it detracts from readability. It's hard to visualise the memory range mappings if the memory map functions are punctuated by large lambdas. There's also slightly higher overhead for calling a delegate bound to a functoid. If the code is prettier for trivial lambdas but uglier for non-trivial lambdas in address maps, it will hopefully steer people away from putting non-trivial lambdas in memory maps. There were some devices that were converted from using plain delegates without adding bind_relative_to calls. I fixed some of them (e.g. LaserDisc) but I probably missed some. These will likely crash on unresolved delegate calls. There are some devices that reset delegates at configuration complete or start time, preventing them from being set up during configuration (e.g. src/devices/video/ppu2c0x.cpp and src/devices/machine/68307.cpp). This goes against the design principles of how device delegates should be used, but I didn't change them because I don't trust myself to find all the places they're used. I've definitely broken some stuff with this (I know about asterix), so report issues and bear with me until I get it all fixed.
* Fix spelling, tidy whitespace Zoë Blade2019-10-212-14/+14
|
* aviio: increase max size (nw) hap2019-10-051-1/+1
|
* aviio: dont crash on buffer overflow (nw) hap2019-10-041-0/+3
|
* Make osd_printf_* use util/strformat semantics. Vas Crabb2019-09-264-56/+44
| | | | | | | | | | | | | | | | | (nw) This has been a long time coming but it's here at last. It should be easier now that logerror, popmessage and osd_printf_* behave like string_format and stream_format. Remember the differences from printf: * Any object with a stream out operator works with %s * %d, %i, %o, %x, %X, etc. work out the size by magic * No sign extending promotion to int for short/char * No widening/narrowing conversions for characters/strings * Same rules on all platforms, insulated from C runtime library * No format warnings from compiler * Assert in debug builds if number of arguments doesn't match format (nw) Also removed a pile of redundant c_str and string_format, and some workarounds for not being able to portably format 64-bit integers or long long.
* -avivideo.cpp: Added an image device to provide looping uncompressed AVI ↵ mooglyguy2019-09-232-14/+14
| | | | | | frames as input. [Ryan Holtz] -vino.cpp: Adapted to support both avivideo_image_device and picture_image_device. [Ryan Holtz]
* Make bitmap8_t, bitmap16_t, bitmap32_t and bitmap64_t specializations of one ↵ AJR2019-09-162-91/+66
| | | | class template (nw)
* render.cpp: print a warning and continue on encountering malformed XML in a ↵ Vas Crabb2019-09-081-6/+10
| | | | layout file (nw)
* Fix build in newer Emscripten versions (nw) Justin Kerk2019-08-081-1/+1
|
* Use canonical spelling of "canonical" (nw) AJR2019-08-022-2/+2
|
* harddisk: Support non-CHD harddisk images in raw and 2MG format [R. Belmont] arbee2019-08-012-7/+73
|
* Merge pull request #5423 from npwoods/core_options_moves ajrhacker2019-08-011-2/+2
|\ | | | | Enabled default move ctor/assignments in core_options, and changed plugin_options code to use them
| * Enabled default move ctor/assignments in core_options, and changed npwoods2019-08-011-2/+2
| | | | | | | | plugin_options code to use them
* | coreutil: remove single-use (and savestate unsafe) rand_memory function (nw) hap2019-08-012-25/+0
|/
* srcclean (nw) Vas Crabb2019-07-282-5/+5
|
* -aviio: Added functionality to read RGB24 and YUV420p uncompressed video ↵ mooglyguy2019-07-212-15/+137
| | | | frames. [Ryan Holtz]
* imgtool: MT 6693 wip, solves mess_hd issue (nw) Sergey Svishchev2019-06-021-0/+1
|
* (nw) Clean up the mess on master Vas Crabb2019-03-266-97/+235
| | | | | | | | | | | | | This effectively reverts b380514764cf857469bae61c11143a19f79a74c5 and c24473ddff715ecec2e258a6eb38960cf8c8e98e, restoring the state at 598cd5227223c3b04ca31f0dbc1981256d9ea3ff. Before pushing, please check that what you're about to push is sane. Check your local commit log and ensure there isn't anything out-of-place before pushing to mainline. When things like this happen, it wastes everyone's time. I really don't need this in a week when real work™ is busting my balls and I'm behind where I want to be with preparing for MAME release.
* Revert "conflict resolution (nw)" andreasnaive2019-03-256-235/+97
| | | | | This reverts commit c24473ddff715ecec2e258a6eb38960cf8c8e98e, reversing changes made to 009cba4fb8102102168ef32870892438327f3705.
* More UI stuff: Vas Crabb2019-01-192-21/+22
| | | | | | | | | * Split up the different parts of ICO loading in the menus (locating files, scaling, drawing, etc.) * Added icon support to software selection menu * Added support for more ICO file variants, including PNG-in-ICO (new DIB parser is overkill for ICO but I can factor it out for BMP loading at some point) * Added favourites filter for software menus - includes software that's favourited on any system, so GBC includes DMG favourties and vice versa * Eliminated unnecessary member variables and O(n) walks in software selection menu * Made the menus' cached texture structures a bit more efficient
* Make search not suck as badly (use algorithm derived from Jaro-Winkler ↵ Vas Crabb2019-01-144-76/+213
| | | | similarity to match search strings, match on more useful stuff)
* Fixed a few missing #includes flagged by VS2019 beta, nw mooglyguy2018-12-301-0/+1
|
* (nw) So we're back to MSVC blowing up on non-trivial templates. Lovely. Vas Crabb2018-12-301-3/+10
| | | | | | | | Someone needs to get MS QA to put some non-trivial modern C++ compliation tests in the acceptance tests for their C++ compiler. Maybe MAME could even be a candidate. Well, that might be a plan if MS still had any QA. At least this makes some lines shorter (at the cost of needing more lines).
* Start cleaning up palette configuration: Vas Crabb2018-12-291-127/+113
| | | | | | | | | | * Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.
* Fix compilation errors with -Og Celelibi2018-12-111-1/+1
| | | | Signed-off-by: Celelibi <celelibi@gmail.com>
* Renamed flipendian -> swapendian, as I spent minutes trying to find the ↵ mooglyguy2018-11-052-12/+12
| | | | functions to tell to another person who spent minutes trying to find the functions, and we refer to such functions as swapping just about everywhere else in the codebase, nw
* util::fifo.queue_length() (nw) Patrick Mackinlay2018-10-181-0/+11
| | | | Not 100% confident about the variable type, and there may still be some debate over the function name (trying to avoid confusion with the length of the container, or with the number of empty slots), so appreciate review/comments.
* lib/util/options.cpp: Don't try to set the value of a header (nw) AJR2018-10-041-1/+2
|
* -options: Restored erroneously-removed game-specific INI option reversion ↵ mooglyguy2018-10-052-0/+29
| | | | between runs. Fixes MT#06171. [Ryan Holtz]
* (nw) Fix inadvertently non-const pointers - emu.h edition Vas Crabb2018-09-202-10/+10
| | | | | | | | | | | | | | | | This fixes all the non-const pointers with static lifetime I could find with a cheap grep (in combination with the last commit). There are likely more lurking that I didn't find, and things that aren't pointers that should be made const. There are still a few mutable static pointers that break the ability to host multiple drivers but these require refactoring to fix: src/devices/sound/sidvoice.cpp:static const uint8_t* waveform30; src/devices/sound/sidvoice.cpp:static const uint8_t* waveform50; src/devices/sound/sidvoice.cpp:static const uint8_t* waveform60; src/devices/sound/sidvoice.cpp:static const uint8_t* waveform70; src/mame/drivers/pockstat.cpp: static const char *gme_id = "123-456-STD"; src/mame/machine/namco51.cpp: static const game_driver *namcoio_51XX_driver = nullptr;
* chdcd: also accept .toast as a synonym for ISO images (nw) arbee2018-09-121-1/+1
|
* Fixed pmd85 regression, nw. Also replaced a fail-safe in ↵ mooglyguy2018-08-301-14/+28
| | | | src/lib/util/palette.cpp with an assert. Expect regressions, so better to get it out of the way now. nw
* imgtool: fix off by one error with leap years (nw) balr0g2018-08-131-1/+1
|
* make rectangle work better with constexpr, change many things to use ↵ Vas Crabb2018-07-282-55/+55
| | | | designated getters/setters (nw)
* Better support for screen orientation/geometry: Vas Crabb2018-07-2622-103/+118
| | | | | | | | | | | | | | | | | | | | | * Eliminates the need for the horizontal/vertical/LCD/SVG layout files * Screens can now have orientation and physical aspect ratio specified * RASTER/VECTOR defaults to 4:3, LCD/SVG defaults to square pixels at config time * System orientation is applied on top of screen orientation Automatically generated single-screen views and orientation flags in XML output now work correctly for systems with multiple screens in different geometries/orientations, e.g. housemnq, rocnms, stepstag, or netmerc. The "core rotation options" only interact with system orientation. Allowing multi-screen systems to work well with one monitor per emulated screen is a complex topic. System orientation also affects the GFX viewer while screen orientation doesn't. The orientation displayed in the system selection menu is from the system orientation. Let me know if I've broken any systems or use cases. Also, add save state support for std::array/C array nested to any depth.
* rendlay: allow user variables and repetition in layouts, also add a few more ↵ Vas Crabb2018-07-221-1/+1
| | | | predefined variables
* fix building with clang 6.0.1 (nw) smf-2018-07-073-3/+4
|
* emumem: Backend modernization [O. Galibert] Olivier Galibert2018-06-291-0/+8
|
* Fix error in debug build with SMS card options (nw) AJR2018-05-211-1/+1
|
* move some not-directly-emulation-related helpers to lib/util, further ↵ Vas Crabb2018-04-012-0/+55
| | | | extricate emu.h from tools (nw)
* Enable use of system-wide asio, glm and rapidjson (#3172) Julian Sikorski2018-02-086-6/+6
| | | | | | | | | | | | * Fixed building using system utf8proc * Fixed building using system portaudio * Allow using system-wide asio headers (1.11.0 or higher required). * Allow using system-wide glm headers * Allow using system-wide rapidjson headers
* Eliminate core_strdup (nw) AJR2018-01-242-25/+0
|
* Fixes for Coverity "Resource leak" warnings (#3089) Oliver Stöneberg2018-01-211-0/+4
| | | | | | | | | | * lib/util/chdcd.cpp: fixed Coverity "Resource Leak" warning (nw) * src/lib/util/chdcd.cpp: fixed more Coverity "Resource Leak" warnings (nw) * tools/imgtool/modules/mac.cpp: fixed Coverity "Resource Leak" warnings (nw) * devices/bus/ti99/gromport/cartridges.cpp: fixed Coverity "Resource Leak" warning (nw)