summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/bus/nes/act53.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/devices/bus/nes/act53.cpp')
-rw-r--r--src/devices/bus/nes/act53.cpp16
1 files changed, 7 insertions, 9 deletions
diff --git a/src/devices/bus/nes/act53.cpp b/src/devices/bus/nes/act53.cpp
index 51e2d75a7e1..59955eb74fc 100644
--- a/src/devices/bus/nes/act53.cpp
+++ b/src/devices/bus/nes/act53.cpp
@@ -17,12 +17,11 @@
#ifdef NES_PCB_DEBUG
-#define VERBOSE 1
+#define VERBOSE (LOG_GENERAL)
#else
-#define VERBOSE 0
+#define VERBOSE (0)
#endif
-
-#define LOG_MMC(x) do { if (VERBOSE) logerror x; } while (0)
+#include "logmacro.h"
//-------------------------------------------------
@@ -58,7 +57,6 @@ void nes_action53_device::pcb_start(running_machine &machine, u8 *ciram_ptr, boo
void nes_action53_device::pcb_reset()
{
- m_chr_source = m_vrom_chunks ? CHRROM : CHRRAM;
// register content is not touched by reset
}
@@ -112,7 +110,7 @@ void nes_action53_device::pcb_reset()
void nes_action53_device::update_prg()
{
u16 prg_lo, prg_hi;
- u8 size = (m_reg[2] & 0x30) >> 4; // Game size
+ u8 size = BIT(m_reg[2], 4, 2); // Game size
u16 mask = ~0 << (size + 1); // Bits to be taken from PRG regs
u8 b32k = !BIT(m_reg[2], 3); // 32K mode bit
u16 outer = m_reg[3] << 1; // Outer PRG reg bits
@@ -152,16 +150,16 @@ void nes_action53_device::update_mirr()
void nes_action53_device::write_l(offs_t offset, u8 data)
{
- LOG_MMC(("action 53 write_l, offset: %04x, data: %02x\n", offset, data));
+ LOG("action 53 write_l, offset: %04x, data: %02x\n", offset, data);
offset += 0x100;
if (offset >= 0x1000)
- m_sel = BIT(data, 0) | (BIT(data, 7) << 1);
+ m_sel = bitswap<2>(data, 7, 0);
}
void nes_action53_device::write_h(offs_t offset, u8 data)
{
- LOG_MMC(("action 53 write_h, offset: %04x, data: %02x\n", offset, data));
+ LOG("action 53 write_h, offset: %04x, data: %02x\n", offset, data);
if (m_reg[m_sel] != data)
{