diff options
Diffstat (limited to 'src/devices/bus/crvision/slot.cpp')
-rw-r--r-- | src/devices/bus/crvision/slot.cpp | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/src/devices/bus/crvision/slot.cpp b/src/devices/bus/crvision/slot.cpp index 1c86b7ed332..0b28124eb5b 100644 --- a/src/devices/bus/crvision/slot.cpp +++ b/src/devices/bus/crvision/slot.cpp @@ -44,11 +44,11 @@ device_crvision_cart_interface::~device_crvision_cart_interface() // rom_alloc - alloc the space for the cart //------------------------------------------------- -void device_crvision_cart_interface::rom_alloc(uint32_t size, const char *tag) +void device_crvision_cart_interface::rom_alloc(uint32_t size) { if (m_rom == nullptr) { - m_rom = device().machine().memory().region_alloc(std::string(tag).append(CRVSLOT_ROM_REGION_TAG).c_str(), size, 1, ENDIANNESS_LITTLE)->base(); + m_rom = device().machine().memory().region_alloc(device().subtag("^cart:rom"), size, 1, ENDIANNESS_LITTLE)->base(); m_rom_size = size; } } @@ -63,7 +63,7 @@ void device_crvision_cart_interface::rom_alloc(uint32_t size, const char *tag) //------------------------------------------------- crvision_cart_slot_device::crvision_cart_slot_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) : device_t(mconfig, CRVISION_CART_SLOT, tag, owner, clock), - device_image_interface(mconfig, *this), + device_cartrom_image_interface(mconfig, *this), device_single_card_slot_interface<device_crvision_cart_interface>(mconfig, *this), m_type(CRV_4K), m_cart(nullptr) { @@ -137,19 +137,16 @@ static const char *crvision_get_slot(int type) call load -------------------------------------------------*/ -image_init_result crvision_cart_slot_device::call_load() +std::pair<std::error_condition, std::string> crvision_cart_slot_device::call_load() { if (m_cart) { - uint32_t size = !loaded_through_softlist() ? length() : get_software_region_length("rom"); + uint32_t const size = !loaded_through_softlist() ? length() : get_software_region_length("rom"); if (size > 0x4800) - { - seterror(image_error::INVALIDIMAGE, "Image extends beyond the expected size for an APF cart"); - return image_init_result::FAIL; - } + return std::make_pair(image_error::INVALIDLENGTH, "Image exceeds the expected size for a CreatiVision cartridge (18K)"); - m_cart->rom_alloc(size, tag()); + m_cart->rom_alloc(size); if (!loaded_through_softlist()) fread(m_cart->get_rom_base(), size); @@ -192,12 +189,10 @@ image_init_result crvision_cart_slot_device::call_load() m_type = crvision_get_pcb_id(pcb_name); } - printf("Type: %s\n", crvision_get_slot(m_type)); - - return image_init_result::PASS; + logerror("Type: %s\n", crvision_get_slot(m_type)); } - return image_init_result::PASS; + return std::make_pair(std::error_condition(), std::string()); } |