summaryrefslogtreecommitdiffstatshomepage
path: root/src
diff options
context:
space:
mode:
author hap <happppp@users.noreply.github.com>2017-03-25 00:15:52 +0100
committer hap <happppp@users.noreply.github.com>2017-03-25 00:16:16 +0100
commitd717f8fe636bb7f2b664f669d1f570c18c6573a5 (patch)
treedfbb02ee862440c40d31e38ea34928ddd3a7897d /src
parent7d8c0a8d04f219e18d7e4bbd95230d69f6a2eff3 (diff)
hh_tms1k: fixed tbreakup flickering leds? (nw)
Diffstat (limited to 'src')
-rw-r--r--src/mame/drivers/hh_tms1k.cpp9
-rw-r--r--src/mame/layout/tbreakup.lay111
2 files changed, 56 insertions, 64 deletions
diff --git a/src/mame/drivers/hh_tms1k.cpp b/src/mame/drivers/hh_tms1k.cpp
index 3d273d32e69..3b84840bc38 100644
--- a/src/mame/drivers/hh_tms1k.cpp
+++ b/src/mame/drivers/hh_tms1k.cpp
@@ -123,7 +123,6 @@
- some of the games rely on the fact that faster/longer strobed leds appear brighter,
eg. tc4/h2hfootb(offense), bankshot(cue ball), ...
- stopthiep: unable to start a game (may be intentional?)
- - tbreakup: some of the leds flicker (rom and PLAs doublechecked)
- 7in1ss: in 2-player mode, game select and skill select can be configured
after selecting a game?
- bship discrete sound, netlist is documented
@@ -8041,10 +8040,6 @@ void tbreakup_state::prepare_display()
m_display_state[y] = (m_r >> y & 1) ? (m_o & 0x7f) : 0;
}
- // 22 round leds from O2-O7 and expander port 7
- for (int y = 2; y < 8; y++)
- m_display_state[y] = (m_o >> y & 1) ? m_exp_port[6] : 0;
-
// 24 rectangular leds from expander ports 1-6 (not strobed)
for (int y = 0; y < 6; y++)
m_display_state[y+8] = m_exp_port[y];
@@ -8082,6 +8077,10 @@ WRITE16_MEMBER(tbreakup_state::write_o)
// O0-O3: TMS1025 port H
m_expander->write_h(space, 0, data & 0xf);
+ // 22 round leds from O2-O7 and expander port 7 (update here)
+ for (int y = 2; y < 8; y++)
+ m_display_state[y] = (data >> y & 1) ? m_exp_port[6] : 0;
+
// O0-O7: led state
m_o = data;
prepare_display();
diff --git a/src/mame/layout/tbreakup.lay b/src/mame/layout/tbreakup.lay
index f203a23fee9..c5afd0c4336 100644
--- a/src/mame/layout/tbreakup.lay
+++ b/src/mame/layout/tbreakup.lay
@@ -39,9 +39,6 @@
<view name="Internal Layout">
<bounds left="6.5" right="37.1" top="35" bottom="82" />
- <bezel element="static_black">
- <bounds left="6.5" right="37.1" top="35" bottom="82" />
- </bezel>
<!-- score panel -->
@@ -52,7 +49,6 @@
<bezel name="digit0" element="digit"><bounds x="28.7" y="37.4" width="3" height="4.5" /></bezel>
<bezel name="digit1" element="digit"><bounds x="31.7" y="37.4" width="3" height="4.5" /></bezel>
-
<!-- main bezel -->
<bezel element="static_white"><bounds x="18.8" y="80.8" width="6" height="0.45" /></bezel>
@@ -66,66 +62,63 @@
<bezel element="static_white"><bounds x="8" y="47.5" width="27.6" height="8" /></bezel>
<bezel element="static_black2"><bounds x="8.2" y="47.7" width="27.2" height="7.6" /></bezel>
-
<!-- rect leds panel -->
- <bezel name="lamp90" element="brick"><bounds x="10" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp91" element="brick"><bounds x="13" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp92" element="brick"><bounds x="16" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp93" element="brick"><bounds x="19" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp110" element="brick"><bounds x="22" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp111" element="brick"><bounds x="25" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp112" element="brick"><bounds x="28" y="50" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp113" element="brick"><bounds x="31" y="50" width="2.6" height="1.2" /></bezel>
-
- <bezel name="lamp80" element="brick"><bounds x="10" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp81" element="brick"><bounds x="13" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp82" element="brick"><bounds x="16" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp83" element="brick"><bounds x="19" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp130" element="brick"><bounds x="22" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp131" element="brick"><bounds x="25" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp132" element="brick"><bounds x="28" y="51.5" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp133" element="brick"><bounds x="31" y="51.5" width="2.6" height="1.2" /></bezel>
-
- <bezel name="lamp100" element="brick"><bounds x="10" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp101" element="brick"><bounds x="13" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp102" element="brick"><bounds x="16" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp103" element="brick"><bounds x="19" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp120" element="brick"><bounds x="22" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp121" element="brick"><bounds x="25" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp122" element="brick"><bounds x="28" y="53" width="2.6" height="1.2" /></bezel>
- <bezel name="lamp123" element="brick"><bounds x="31" y="53" width="2.6" height="1.2" /></bezel>
-
+ <bezel name="9.0" element="brick"><bounds x="10" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="9.1" element="brick"><bounds x="13" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="9.2" element="brick"><bounds x="16" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="9.3" element="brick"><bounds x="19" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="11.0" element="brick"><bounds x="22" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="11.1" element="brick"><bounds x="25" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="11.2" element="brick"><bounds x="28" y="50" width="2.6" height="1.2" /></bezel>
+ <bezel name="11.3" element="brick"><bounds x="31" y="50" width="2.6" height="1.2" /></bezel>
+
+ <bezel name="8.0" element="brick"><bounds x="10" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="8.1" element="brick"><bounds x="13" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="8.2" element="brick"><bounds x="16" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="8.3" element="brick"><bounds x="19" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="13.0" element="brick"><bounds x="22" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="13.1" element="brick"><bounds x="25" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="13.2" element="brick"><bounds x="28" y="51.5" width="2.6" height="1.2" /></bezel>
+ <bezel name="13.3" element="brick"><bounds x="31" y="51.5" width="2.6" height="1.2" /></bezel>
+
+ <bezel name="10.0" element="brick"><bounds x="10" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="10.1" element="brick"><bounds x="13" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="10.2" element="brick"><bounds x="16" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="10.3" element="brick"><bounds x="19" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="12.0" element="brick"><bounds x="22" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="12.1" element="brick"><bounds x="25" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="12.2" element="brick"><bounds x="28" y="53" width="2.6" height="1.2" /></bezel>
+ <bezel name="12.3" element="brick"><bounds x="31" y="53" width="2.6" height="1.2" /></bezel>
<!-- round leds -->
- <bezel name="lamp70" element="led"><bounds x="12.3" y="48" width="1" height="1" /></bezel>
- <bezel name="lamp71" element="led"><bounds x="18.3" y="48" width="1" height="1" /></bezel>
- <bezel name="lamp72" element="led"><bounds x="24.3" y="48" width="1" height="1" /></bezel>
- <bezel name="lamp73" element="led"><bounds x="30.3" y="48" width="1" height="1" /></bezel>
-
- <bezel name="lamp40" element="led"><bounds x="10.6" y="61" width="1" height="1" /></bezel>
- <bezel name="lamp60" element="led"><bounds x="14.6" y="58" width="1" height="1" /></bezel>
- <bezel name="lamp61" element="led"><bounds x="18.3" y="56.5" width="1" height="1" /></bezel>
- <bezel name="lamp62" element="led"><bounds x="24.3" y="56.5" width="1" height="1" /></bezel>
- <bezel name="lamp63" element="led"><bounds x="28" y="58" width="1" height="1" /></bezel>
- <bezel name="lamp43" element="led"><bounds x="32" y="61" width="1" height="1" /></bezel>
-
- <bezel name="lamp30" element="led"><bounds x="10.6" y="68" width="1" height="1" /></bezel>
- <bezel name="lamp50" element="led"><bounds x="16.5" y="63.5" width="1" height="1" /></bezel>
- <bezel name="lamp51" element="led"><bounds x="18.7" y="61.8" width="1" height="1" /></bezel>
- <bezel name="lamp52" element="led"><bounds x="23.9" y="61.8" width="1" height="1" /></bezel>
- <bezel name="lamp53" element="led"><bounds x="26.1" y="63.5" width="1" height="1" /></bezel>
- <bezel name="lamp33" element="led"><bounds x="32" y="68" width="1" height="1" /></bezel>
-
- <bezel name="lamp41" element="led"><bounds x="15.1" y="70.7" width="1" height="1" /></bezel>
- <bezel name="lamp31" element="led"><bounds x="19.2" y="68.8" width="1" height="1" /></bezel>
- <bezel name="lamp32" element="led"><bounds x="23.4" y="68.8" width="1" height="1" /></bezel>
- <bezel name="lamp42" element="led"><bounds x="27.5" y="70.7" width="1" height="1" /></bezel>
-
- <bezel name="lamp21" element="led"><bounds x="21.3" y="75.5" width="1" height="1" /></bezel>
- <bezel name="lamp22" element="led"><bounds x="21.3" y="79.3" width="1" height="1" /></bezel>
-
+ <bezel name="7.0" element="led"><bounds x="12.3" y="48" width="1" height="1" /></bezel>
+ <bezel name="7.1" element="led"><bounds x="18.3" y="48" width="1" height="1" /></bezel>
+ <bezel name="7.2" element="led"><bounds x="24.3" y="48" width="1" height="1" /></bezel>
+ <bezel name="7.3" element="led"><bounds x="30.3" y="48" width="1" height="1" /></bezel>
+
+ <bezel name="4.0" element="led"><bounds x="10.6" y="60.5" width="1" height="1" /></bezel>
+ <bezel name="6.0" element="led"><bounds x="14.6" y="58" width="1" height="1" /></bezel>
+ <bezel name="6.1" element="led"><bounds x="18.3" y="56.5" width="1" height="1" /></bezel>
+ <bezel name="6.2" element="led"><bounds x="24.3" y="56.5" width="1" height="1" /></bezel>
+ <bezel name="6.3" element="led"><bounds x="28" y="58" width="1" height="1" /></bezel>
+ <bezel name="4.3" element="led"><bounds x="32" y="60.5" width="1" height="1" /></bezel>
+
+ <bezel name="3.0" element="led"><bounds x="10.6" y="68" width="1" height="1" /></bezel>
+ <bezel name="5.0" element="led"><bounds x="16.5" y="63.5" width="1" height="1" /></bezel>
+ <bezel name="5.1" element="led"><bounds x="18.7" y="61.8" width="1" height="1" /></bezel>
+ <bezel name="5.2" element="led"><bounds x="23.9" y="61.8" width="1" height="1" /></bezel>
+ <bezel name="5.3" element="led"><bounds x="26.1" y="63.5" width="1" height="1" /></bezel>
+ <bezel name="3.3" element="led"><bounds x="32" y="68" width="1" height="1" /></bezel>
+
+ <bezel name="4.1" element="led"><bounds x="15.1" y="70.7" width="1" height="1" /></bezel>
+ <bezel name="3.1" element="led"><bounds x="19.2" y="68.8" width="1" height="1" /></bezel>
+ <bezel name="3.2" element="led"><bounds x="23.4" y="68.8" width="1" height="1" /></bezel>
+ <bezel name="4.2" element="led"><bounds x="27.5" y="70.7" width="1" height="1" /></bezel>
+
+ <bezel name="2.1" element="led"><bounds x="21.3" y="75.5" width="1" height="1" /></bezel>
+ <bezel name="2.2" element="led"><bounds x="21.3" y="79.3" width="1" height="1" /></bezel>
</view>
</mamelayout>