summaryrefslogtreecommitdiffstatshomepage
path: root/src/tools
diff options
context:
space:
mode:
author AJR <ajrhacker@users.noreply.github.com>2016-01-10 16:36:18 -0500
committer AJR <ajrhacker@users.noreply.github.com>2016-01-10 16:36:18 -0500
commit115db95642ad6d861aad63775b92350e0491f2dd (patch)
tree8e7538ca804610335bff1927dc3b4d974b4c06da /src/tools
parent2a2a4a3c6e255c479d5072d02c2a40949f611ea6 (diff)
Return std::string objects by value rather than pass by reference
- strprintf is unaltered, but strformat now takes one fewer argument - state_string_export still fills a buffer, but has been made const - get_default_card_software now takes no arguments but returns a string
Diffstat (limited to 'src/tools')
-rw-r--r--src/tools/chdman.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/tools/chdman.cpp b/src/tools/chdman.cpp
index 75da3c76741..c17e7fa071f 100644
--- a/src/tools/chdman.cpp
+++ b/src/tools/chdman.cpp
@@ -2406,14 +2406,13 @@ static void do_extract_cd(parameters_t &params)
// output the metadata about the track to the TOC file
const cdrom_track_info &trackinfo = toc->tracks[tracknum];
- std::string temp;
if (mode == MODE_GDI)
{
- output_track_metadata(mode, output_toc_file, tracknum, trackinfo, core_filename_extract_base(temp, trackbin_name.c_str()).c_str(), discoffs, outputoffs);
+ output_track_metadata(mode, output_toc_file, tracknum, trackinfo, core_filename_extract_base(trackbin_name.c_str()).c_str(), discoffs, outputoffs);
}
else
{
- output_track_metadata(mode, output_toc_file, tracknum, trackinfo, core_filename_extract_base(temp, output_bin_file_str->c_str()).c_str(), discoffs, outputoffs);
+ output_track_metadata(mode, output_toc_file, tracknum, trackinfo, core_filename_extract_base(output_bin_file_str->c_str()).c_str(), discoffs, outputoffs);
}
// If this is bin/cue output and the CHD contains subdata, warn the user and don't include