summaryrefslogtreecommitdiffstatshomepage
path: root/src/osd/modules/debugger
diff options
context:
space:
mode:
author npwoods <npwoods@alumni.cmu.edu>2017-06-23 19:46:58 -0400
committer Vas Crabb <cuavas@users.noreply.github.com>2017-06-24 09:46:58 +1000
commit2af3233101b109a6ebcb1087d2c47ebce3c4c978 (patch)
tree3ec211a11853626cfd00a13f3148ff5cc8cf96f5 /src/osd/modules/debugger
parentf1c043d18c6882930b4c00877c5d1773c527f998 (diff)
Changed a few 'const char *' ==> 'const std::string &' in the MAME debugger (#2170)
Diffstat (limited to 'src/osd/modules/debugger')
-rw-r--r--src/osd/modules/debugger/win/consolewininfo.cpp4
-rw-r--r--src/osd/modules/debugger/win/consolewininfo.h2
-rw-r--r--src/osd/modules/debugger/win/disasmviewinfo.cpp2
-rw-r--r--src/osd/modules/debugger/win/disasmviewinfo.h2
-rw-r--r--src/osd/modules/debugger/win/disasmwininfo.cpp2
-rw-r--r--src/osd/modules/debugger/win/disasmwininfo.h2
-rw-r--r--src/osd/modules/debugger/win/editwininfo.h4
-rw-r--r--src/osd/modules/debugger/win/memoryviewinfo.cpp2
-rw-r--r--src/osd/modules/debugger/win/memoryviewinfo.h2
-rw-r--r--src/osd/modules/debugger/win/memorywininfo.cpp2
-rw-r--r--src/osd/modules/debugger/win/memorywininfo.h2
11 files changed, 13 insertions, 13 deletions
diff --git a/src/osd/modules/debugger/win/consolewininfo.cpp b/src/osd/modules/debugger/win/consolewininfo.cpp
index 079cf631049..6da9c67f040 100644
--- a/src/osd/modules/debugger/win/consolewininfo.cpp
+++ b/src/osd/modules/debugger/win/consolewininfo.cpp
@@ -453,9 +453,9 @@ bool consolewin_info::handle_command(WPARAM wparam, LPARAM lparam)
}
-void consolewin_info::process_string(char const *string)
+void consolewin_info::process_string(std::string const &string)
{
- if (string[0] == 0) // an empty string is a single step
+ if (string.empty()) // an empty string is a single step
machine().debugger().cpu().get_visible_cpu()->debug()->single_step();
else // otherwise, just process the command
machine().debugger().console().execute_command(string, true);
diff --git a/src/osd/modules/debugger/win/consolewininfo.h b/src/osd/modules/debugger/win/consolewininfo.h
index 6ab434a4e4c..3811a9029c2 100644
--- a/src/osd/modules/debugger/win/consolewininfo.h
+++ b/src/osd/modules/debugger/win/consolewininfo.h
@@ -42,7 +42,7 @@ private:
DEVOPTION_MAX
};
- virtual void process_string(char const *string) override;
+ virtual void process_string(std::string const &string) override;
static void build_generic_filter(device_image_interface *img, bool is_save, std::string &filter);
static void add_filter_entry(std::string &dest, char const *description, char const *extensions);
diff --git a/src/osd/modules/debugger/win/disasmviewinfo.cpp b/src/osd/modules/debugger/win/disasmviewinfo.cpp
index ade4267a68a..8884bee5195 100644
--- a/src/osd/modules/debugger/win/disasmviewinfo.cpp
+++ b/src/osd/modules/debugger/win/disasmviewinfo.cpp
@@ -33,7 +33,7 @@ offs_t disasmview_info::selected_address() const
}
-void disasmview_info::set_expression(char const *string)
+void disasmview_info::set_expression(const std::string &string)
{
view<debug_view_disasm>()->set_expression(string);
}
diff --git a/src/osd/modules/debugger/win/disasmviewinfo.h b/src/osd/modules/debugger/win/disasmviewinfo.h
index 011748517c0..d1e7090ef2f 100644
--- a/src/osd/modules/debugger/win/disasmviewinfo.h
+++ b/src/osd/modules/debugger/win/disasmviewinfo.h
@@ -25,7 +25,7 @@ public:
disasm_right_column right_column() const;
offs_t selected_address() const;
- void set_expression(const char *expression);
+ void set_expression(const std::string &expression);
void set_right_column(disasm_right_column contents);
};
diff --git a/src/osd/modules/debugger/win/disasmwininfo.cpp b/src/osd/modules/debugger/win/disasmwininfo.cpp
index 6a86a6da397..b94eadbba03 100644
--- a/src/osd/modules/debugger/win/disasmwininfo.cpp
+++ b/src/osd/modules/debugger/win/disasmwininfo.cpp
@@ -126,7 +126,7 @@ void disasmwin_info::draw_contents(HDC dc)
}
-void disasmwin_info::process_string(char const *string)
+void disasmwin_info::process_string(const std::string &string)
{
// set the string to the disasm view
downcast<disasmview_info *>(m_views[0].get())->set_expression(string);
diff --git a/src/osd/modules/debugger/win/disasmwininfo.h b/src/osd/modules/debugger/win/disasmwininfo.h
index 6297b628168..34e8275f2f9 100644
--- a/src/osd/modules/debugger/win/disasmwininfo.h
+++ b/src/osd/modules/debugger/win/disasmwininfo.h
@@ -26,7 +26,7 @@ protected:
virtual void draw_contents(HDC dc) override;
private:
- virtual void process_string(char const *string) override;
+ virtual void process_string(const std::string &string) override;
void update_caption();
diff --git a/src/osd/modules/debugger/win/editwininfo.h b/src/osd/modules/debugger/win/editwininfo.h
index 4a1e42371e1..1aaee55f1e9 100644
--- a/src/osd/modules/debugger/win/editwininfo.h
+++ b/src/osd/modules/debugger/win/editwininfo.h
@@ -34,14 +34,14 @@ protected:
void set_editwnd_bounds(RECT const &bounds);
void set_editwnd_text(char const *text);
void editwnd_select_all();
- void set_edit_defstr(char const *string) { m_edit_defstr = string; }
+ void set_edit_defstr(const std::string &string) { m_edit_defstr = string; }
virtual void draw_contents(HDC dc) override;
private:
typedef std::deque<std::basic_string<TCHAR> > history_deque;
- virtual void process_string(char const *string) = 0;
+ virtual void process_string(const std::string &string) = 0;
LRESULT edit_proc(UINT message, WPARAM wparam, LPARAM lparam);
diff --git a/src/osd/modules/debugger/win/memoryviewinfo.cpp b/src/osd/modules/debugger/win/memoryviewinfo.cpp
index 3bfe3e3ed8c..423679f26a9 100644
--- a/src/osd/modules/debugger/win/memoryviewinfo.cpp
+++ b/src/osd/modules/debugger/win/memoryviewinfo.cpp
@@ -47,7 +47,7 @@ bool memoryview_info::physical() const
}
-void memoryview_info::set_expression(char const *string)
+void memoryview_info::set_expression(const std::string &string)
{
view<debug_view_memory>()->set_expression(string);
}
diff --git a/src/osd/modules/debugger/win/memoryviewinfo.h b/src/osd/modules/debugger/win/memoryviewinfo.h
index dd4cd557222..2ab810654f3 100644
--- a/src/osd/modules/debugger/win/memoryviewinfo.h
+++ b/src/osd/modules/debugger/win/memoryviewinfo.h
@@ -25,7 +25,7 @@ public:
bool reverse() const;
bool physical() const;
- void set_expression(char const *string);
+ void set_expression(const std::string &string);
void set_data_format(uint8_t dataformat);
void set_chunks_per_row(uint32_t rowchunks);
void set_reverse(bool reverse);
diff --git a/src/osd/modules/debugger/win/memorywininfo.cpp b/src/osd/modules/debugger/win/memorywininfo.cpp
index fbd7e853203..6f461295ec2 100644
--- a/src/osd/modules/debugger/win/memorywininfo.cpp
+++ b/src/osd/modules/debugger/win/memorywininfo.cpp
@@ -283,7 +283,7 @@ void memorywin_info::draw_contents(HDC dc)
}
-void memorywin_info::process_string(char const *string)
+void memorywin_info::process_string(const std::string &string)
{
// set the string to the memory view
downcast<memoryview_info *>(m_views[0].get())->set_expression(string);
diff --git a/src/osd/modules/debugger/win/memorywininfo.h b/src/osd/modules/debugger/win/memorywininfo.h
index f0fe535cf16..501d7acc76f 100644
--- a/src/osd/modules/debugger/win/memorywininfo.h
+++ b/src/osd/modules/debugger/win/memorywininfo.h
@@ -29,7 +29,7 @@ protected:
virtual void draw_contents(HDC dc) override;
private:
- virtual void process_string(char const *string) override;
+ virtual void process_string(const std::string &string) override;
void update_caption();