diff options
author | Vas Crabb <vas@vastheman.com> | 2021-09-26 14:15:42 +1000 |
---|---|---|
committer | Vas Crabb <vas@vastheman.com> | 2021-09-26 14:15:42 +1000 |
commit | b225f4db4a42978ec6d3384716d340cc204c3a56 (patch) | |
tree | 925c3a934e542eef41cff9ec3d9a2cd6634a176b /src/mame | |
parent | 3066057077c9a1e500f885cc0b1c6bd5dd523b6d (diff) |
srcclean in preparation for MAME 0.235, and two small adjustments.
* Reduce repeated directory walking in cleansrc target (substantially
improves speed of building the target on Windows).
* Disable a validity check using an MSVC language extension when using
clang in MSVC ABI mode.
Diffstat (limited to 'src/mame')
-rw-r--r-- | src/mame/drivers/4enraya.cpp | 4 | ||||
-rw-r--r-- | src/mame/drivers/acesp.cpp | 4 | ||||
-rw-r--r-- | src/mame/drivers/agat.cpp | 8 | ||||
-rw-r--r-- | src/mame/drivers/ampoker2.cpp | 6 | ||||
-rw-r--r-- | src/mame/drivers/apple2.cpp | 8 | ||||
-rw-r--r-- | src/mame/drivers/apple2gs.cpp | 2 | ||||
-rw-r--r-- | src/mame/drivers/atarig42.cpp | 6 | ||||
-rw-r--r-- | src/mame/drivers/barni.cpp | 16 | ||||
-rw-r--r-- | src/mame/drivers/cybstorm.cpp | 4 | ||||
-rw-r--r-- | src/mame/drivers/mpu4.cpp | 4 | ||||
-rw-r--r-- | src/mame/drivers/naomi.cpp | 2 | ||||
-rw-r--r-- | src/mame/drivers/pc8001.cpp | 56 | ||||
-rw-r--r-- | src/mame/drivers/pc8801.cpp | 8 | ||||
-rw-r--r-- | src/mame/drivers/rollext.cpp | 32 | ||||
-rw-r--r-- | src/mame/drivers/saturn.cpp | 4 | ||||
-rw-r--r-- | src/mame/drivers/spg2xx_jakks.cpp | 2 | ||||
-rw-r--r-- | src/mame/includes/pc8001.h | 12 | ||||
-rw-r--r-- | src/mame/layout/ace_sp_dmd.lay | 2 | ||||
-rw-r--r-- | src/mame/machine/ace_sp_reelctrl.cpp | 4 | ||||
-rw-r--r-- | src/mame/machine/pc80s31k.cpp | 134 | ||||
-rw-r--r-- | src/mame/machine/pc80s31k.h | 2 | ||||
-rw-r--r-- | src/mame/mame.lst | 2 | ||||
-rw-r--r-- | src/mame/video/sknsspr.cpp | 2 |
23 files changed, 162 insertions, 162 deletions
diff --git a/src/mame/drivers/4enraya.cpp b/src/mame/drivers/4enraya.cpp index ffd8224a931..1cfeb83af07 100644 --- a/src/mame/drivers/4enraya.cpp +++ b/src/mame/drivers/4enraya.cpp @@ -677,10 +677,10 @@ ROM_END TourVision was a Spanish developer, PCB had TourVision stickers, but this kind of machine was illegal in Spain, so made for the French market instead - Ariège Amusements was the exclusive distributor of TourVision products until 1991, Paradise Automatique was a spin-off of this distributor + Ariège Amusements was the exclusive distributor of TourVision products until 1991, Paradise Automatique was a spin-off of this distributor and was legally created in 1992 to import/export food vending machines, video games and audiovisual appliances and continued to work with TourVision. - + A version of this exists (on newer hardware?) with the title 'Lucky Gum' or 'Luck Gum' however the supported game shows no title screen so the title is unknown. */ diff --git a/src/mame/drivers/acesp.cpp b/src/mame/drivers/acesp.cpp index 1f39b35d536..9ad8f15365b 100644 --- a/src/mame/drivers/acesp.cpp +++ b/src/mame/drivers/acesp.cpp @@ -116,8 +116,8 @@ void ace_sp_state::ace_sp_map(address_map &map) // 0x33 - lamp stb // 0x34 - shift stb // 0x35 - shift clk - map(0x36, 0x36).ram().rw(FUNC(ace_sp_state::serial_r), FUNC(ace_sp_state::serial_w)); // 0x36 - sio - + map(0x36, 0x36).ram().rw(FUNC(ace_sp_state::serial_r), FUNC(ace_sp_state::serial_w)); // 0x36 - sio + // 0x37 - watchdog? map(0x0038, 0x003b).rw("pia0", FUNC(pia6821_device::read), FUNC(pia6821_device::write)); /* 0x3c */ diff --git a/src/mame/drivers/agat.cpp b/src/mame/drivers/agat.cpp index 4f7b20828b4..56d5f7b95f7 100644 --- a/src/mame/drivers/agat.cpp +++ b/src/mame/drivers/agat.cpp @@ -586,19 +586,19 @@ uint8_t agat_base_state::controller_strobe_r() void agat_base_state::controller_strobe_w(uint8_t data) { // 555 monostable one-shot timers; a running timer cannot be restarted - if (machine().time().as_double() >= m_joystick_x1_time) + if (machine().time().as_double() >= m_joystick_x1_time) { m_joystick_x1_time = machine().time().as_double() + m_x_calibration * m_joy1x->read(); } - if (machine().time().as_double() >= m_joystick_y1_time) + if (machine().time().as_double() >= m_joystick_y1_time) { m_joystick_y1_time = machine().time().as_double() + m_y_calibration * m_joy1y->read(); } - if (machine().time().as_double() >= m_joystick_x2_time) + if (machine().time().as_double() >= m_joystick_x2_time) { m_joystick_x2_time = machine().time().as_double() + m_x_calibration * m_joy2x->read(); } - if (machine().time().as_double() >= m_joystick_y2_time) + if (machine().time().as_double() >= m_joystick_y2_time) { m_joystick_y2_time = machine().time().as_double() + m_y_calibration * m_joy2y->read(); } diff --git a/src/mame/drivers/ampoker2.cpp b/src/mame/drivers/ampoker2.cpp index 17aa59aee8c..349f6f95ad7 100644 --- a/src/mame/drivers/ampoker2.cpp +++ b/src/mame/drivers/ampoker2.cpp @@ -1323,7 +1323,7 @@ ROM_END */ ROM_START( ampkr2jsp ) - ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "3A". + ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "3A". ROM_LOAD( "u6", 0x0000, 0x10000, CRC(183b67a6) SHA1(8d5b1ce401e8783641c666a5b190a1f052f2dfca) ) ROM_REGION( 0x4000, "gfx1", 0 ) @@ -1335,7 +1335,7 @@ ROM_START( ampkr2jsp ) ROM_END ROM_START( ampkr2jspa ) - ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "zarate". + ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "zarate". ROM_LOAD( "u6", 0x0000, 0x10000, CRC(35aa7c52) SHA1(8aa422b1b86d0366fe4736d97470fc330335ae78) ) ROM_REGION( 0x4000, "gfx1", 0 ) @@ -1346,7 +1346,7 @@ ROM_START( ampkr2jspa ) ROM_END ROM_START( ampkr2jspb ) - ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "novomatic". + ROM_REGION( 0x10000, "maincpu", 0 ) // The set is marked as "novomatic". ROM_LOAD( "u6", 0x0000, 0x10000, CRC(e2f5ff56) SHA1(ab793a4f15673d6d4447024172f6fa6c61719fe7) ) ROM_REGION( 0x4000, "gfx1", 0 ) diff --git a/src/mame/drivers/apple2.cpp b/src/mame/drivers/apple2.cpp index d43eb3fa842..6020af74499 100644 --- a/src/mame/drivers/apple2.cpp +++ b/src/mame/drivers/apple2.cpp @@ -678,19 +678,19 @@ u8 apple2_state::controller_strobe_r() void apple2_state::controller_strobe_w(u8 data) { // 558 monostable one-shot timers; a running timer cannot be restarted - if (machine().time().as_double() >= m_joystick_x1_time) + if (machine().time().as_double() >= m_joystick_x1_time) { m_joystick_x1_time = machine().time().as_double() + m_x_calibration * m_gameio->pdl0_r(); } - if (machine().time().as_double() >= m_joystick_y1_time) + if (machine().time().as_double() >= m_joystick_y1_time) { m_joystick_y1_time = machine().time().as_double() + m_y_calibration * m_gameio->pdl1_r(); } - if (machine().time().as_double() >= m_joystick_x2_time) + if (machine().time().as_double() >= m_joystick_x2_time) { m_joystick_x2_time = machine().time().as_double() + m_x_calibration * m_gameio->pdl2_r(); } - if (machine().time().as_double() >= m_joystick_y2_time) + if (machine().time().as_double() >= m_joystick_y2_time) { m_joystick_y2_time = machine().time().as_double() + m_y_calibration * m_gameio->pdl3_r(); } diff --git a/src/mame/drivers/apple2gs.cpp b/src/mame/drivers/apple2gs.cpp index e01bc172779..7df85e9c9cb 100644 --- a/src/mame/drivers/apple2gs.cpp +++ b/src/mame/drivers/apple2gs.cpp @@ -1543,7 +1543,7 @@ void apple2gs_state::machine_reset() m_ramrd = false; m_ramwrt = false; m_ioudis = true; - m_newvideo = 0x01; // verified on ROM03 hardware + m_newvideo = 0x01; // verified on ROM03 hardware m_clock_frame = 0; m_mouse_x = 0x00; m_mouse_y = 0x00; diff --git a/src/mame/drivers/atarig42.cpp b/src/mame/drivers/atarig42.cpp index 0fd418de9c8..2a17942f426 100644 --- a/src/mame/drivers/atarig42.cpp +++ b/src/mame/drivers/atarig42.cpp @@ -375,7 +375,7 @@ INPUT_PORTS_END INPUT_PORTS_START( dangerex ) - PORT_START("IN0") /* e00000 */ + PORT_START("IN0") /* e00000 */ PORT_BIT( 0x000f, IP_ACTIVE_LOW, IPT_UNUSED ) PORT_BIT( 0x0010, IP_ACTIVE_LOW, IPT_CUSTOM ) // Toggle 0 - D4 PORT_BIT( 0x0020, IP_ACTIVE_LOW, IPT_CUSTOM ) // Toggle 1 - D5 @@ -798,7 +798,7 @@ ROM_END ROM_START( dangerex ) - ROM_REGION( 0x80004, "maincpu", 0 ) /* 68000 code */ + ROM_REGION( 0x80004, "maincpu", 0 ) /* 68000 code */ ROM_LOAD16_BYTE( "dx8d-0h.8d", 0x00000, 0x20000, CRC(4957b65d) SHA1(de9f187b6496cf96d29c4b1b29887abc2bdf9bf0) ) ROM_LOAD16_BYTE( "dx8c-0l.8c", 0x00001, 0x20000, CRC(aedcb497) SHA1(7e201b7db5c0ff661f782566a6b17299d514c77a) ) ROM_LOAD16_BYTE( "dx9d-1h.9d", 0x40000, 0x20000, CRC(2eb943e2) SHA1(87dbf11720e2938bf5755b13231fc668ab3e0e05) ) @@ -849,7 +849,7 @@ ROM_START( dangerex ) ROM_REGION( 0x800, "eeprom", 0 ) ROM_LOAD( "dx-eeprom.5c", 0x0000, 0x800, CRC(d14e813d) SHA1(b206ce85f7a87986d401d34eafa188b5bffae08c) ) - ROM_REGION( 0x0600, "proms", 0 ) /* microcode for growth renderer */ + ROM_REGION( 0x0600, "proms", 0 ) /* microcode for growth renderer */ ROM_LOAD( "092-1001.20p", 0x0000, 0x0200, NO_DUMP ) ROM_LOAD( "092-1002.22p", 0x0200, 0x0200, NO_DUMP ) ROM_LOAD( "092-1003.21p", 0x0400, 0x0200, NO_DUMP ) diff --git a/src/mame/drivers/barni.cpp b/src/mame/drivers/barni.cpp index d47eec28897..766c226382b 100644 --- a/src/mame/drivers/barni.cpp +++ b/src/mame/drivers/barni.cpp @@ -218,21 +218,21 @@ void barni_state::barni(machine_config &config) config.set_default_layout(layout_barni); PIA6821(config, m_pia1, 0); -// m_pia1->writepa_handler().set(FUNC(barni_state::pia1_pa_w)); -// m_pia1->writepb_handler().set(FUNC(barni_state::pia1_pb_w)); -// m_pia1->readpa_handler().set(FUNC(barni_state::pia1_pa_r)); +// m_pia1->writepa_handler().set(FUNC(barni_state::pia1_pa_w)); +// m_pia1->writepb_handler().set(FUNC(barni_state::pia1_pb_w)); +// m_pia1->readpa_handler().set(FUNC(barni_state::pia1_pa_r)); PIA6821(config, m_pia2, 0); -// m_pia2->writepa_handler().set(FUNC(barni_state::pia2_pa_w)); -// m_pia2->writepb_handler().set(FUNC(barni_state::pia2_pb_w)); -// m_pia2->readpa_handler().set(FUNC(barni_state::pia2_pa_r)); +// m_pia2->writepa_handler().set(FUNC(barni_state::pia2_pa_w)); +// m_pia2->writepb_handler().set(FUNC(barni_state::pia2_pb_w)); +// m_pia2->readpa_handler().set(FUNC(barni_state::pia2_pa_r)); MOS6522(config, m_via, 4'000'000 / 4); // to check m_via->irq_handler().set_inputline(m_maincpu, M6809_IRQ_LINE); m_via->writepa_handler().set(FUNC(barni_state::via_pa_w)); m_via->writepb_handler().set(FUNC(barni_state::via_pb_w)); -// m_via->ca2_handler().set(FUNC(barni_state::via_ca2_w)); -// m_via->cb2_handler().set(FUNC(barni_state::via_cb2_w)); +// m_via->ca2_handler().set(FUNC(barni_state::via_ca2_w)); +// m_via->cb2_handler().set(FUNC(barni_state::via_cb2_w)); // SOUND BOARD M6802(config, m_audiocpu, 4000000); // guess - crystal value not shown diff --git a/src/mame/drivers/cybstorm.cpp b/src/mame/drivers/cybstorm.cpp index 216fbad30b6..dbd7318286c 100644 --- a/src/mame/drivers/cybstorm.cpp +++ b/src/mame/drivers/cybstorm.cpp @@ -12,8 +12,8 @@ Known bugs: * STAIN effect not 100% correct - Possible bugs: - * Tilemap offsets shifted by 1 pixel? + Possible bugs: + * Tilemap offsets shifted by 1 pixel? ***************************************************************************/ diff --git a/src/mame/drivers/mpu4.cpp b/src/mame/drivers/mpu4.cpp index acb4be7a6ff..bae54af37e7 100644 --- a/src/mame/drivers/mpu4.cpp +++ b/src/mame/drivers/mpu4.cpp @@ -1517,7 +1517,7 @@ ROM_END BARCREST SAMPLED SOUND _________________________ - | · | + | · | | · | | · | | · |_____________ @@ -1543,7 +1543,7 @@ Just one different byte between the three "Escalera y Tobogan" sets, at address 1268: 0xF4 1269: 0xF5 1270: 0xF6 -May be the game serial number hard-encoded on the EPROM? +May be the game serial number hard-encoded on the EPROM? */ ROM_START( m4esctbg ) ROM_REGION( 0x20000, "maincpu", 0 ) diff --git a/src/mame/drivers/naomi.cpp b/src/mame/drivers/naomi.cpp index e7b4d49ddb4..bf6d54e3fd0 100644 --- a/src/mame/drivers/naomi.cpp +++ b/src/mame/drivers/naomi.cpp @@ -5115,7 +5115,7 @@ ROM_START( mushikk ) NAOMI_DEFAULT_EEPROM ROM_REGION( 0x4000000, "rom_board", ROMREGION_ERASEFF ) - ROM_LOAD( "epr-24265.ic11", 0x0000000, 0x0400000, CRC(dccb210b) SHA1(35891f97bec251083b2c927e926d73685d750a4d) ) + ROM_LOAD( "epr-24265.ic11", 0x0000000, 0x0400000, CRC(dccb210b) SHA1(35891f97bec251083b2c927e926d73685d750a4d) ) ROM_LOAD32_WORD( "opr-24266.ic17s", 0x1000000, 0x0800000, CRC(293e5350) SHA1(7107d3378fe3a73e868bc03e0572b19e91152a3b) ) ROM_LOAD32_WORD( "opr-24267.ic18", 0x1000002, 0x0800000, CRC(80798f9a) SHA1(a843a052dce254f9a5a7b7024f21e4e6f8621666) ) ROM_LOAD32_WORD( "opr-24268.ic19s", 0x2000000, 0x0800000, CRC(b512c772) SHA1(f45084f2e242e07e47c25eeeed44624274a95a7e) ) diff --git a/src/mame/drivers/pc8001.cpp b/src/mame/drivers/pc8001.cpp index 1e48dde03ac..9e790f900b4 100644 --- a/src/mame/drivers/pc8001.cpp +++ b/src/mame/drivers/pc8001.cpp @@ -16,24 +16,24 @@ - PCG-1000; - Intel 8251; - cassette; - - dip-switches; + - dip-switches; - PC-8011 (expansion unit) - PC-8021; - PC-8031 (mini disk unit, in progress) - - pc8001mk2sr: verify how much needs to be ported from pc8801.cpp code - (Has 3 bitplane GVRAM like PC-8801 V1 mode); - - waitstates & DMA penalty (some games are suspciously fast); - - buzzer has pretty ugly aliasing in places; + - pc8001mk2sr: verify how much needs to be ported from pc8801.cpp code + (Has 3 bitplane GVRAM like PC-8801 V1 mode); + - waitstates & DMA penalty (some games are suspciously fast); + - buzzer has pretty ugly aliasing in places; Notes: - pc8001 v1.01 / v1.02 sports a buggy readout of the expansion ROM at PC=17a1: It expects an header read of 0x41-0x42 at offset $6000-6001, but second read at PC=0x17aa is just a comparison to $6000 == 0x42, which is impossible at that point unless external aid is given. This has been fixed in v1.10; - - Color Magical (pc8001gp:flop5 option 7) transfers two 8 color screens at - even/odd frame intervals, effectively boosting the number of available colors to 27. - This trick is kinda flickery even on real HW, no wonder it looks ugly in MAME, - can it be improved? + - Color Magical (pc8001gp:flop5 option 7) transfers two 8 color screens at + even/odd frame intervals, effectively boosting the number of available colors to 27. + This trick is kinda flickery even on real HW, no wonder it looks ugly in MAME, + can it be improved? */ @@ -152,7 +152,7 @@ UPD3301_DRAW_CHARACTER_MEMBER( pc8001_base_state::draw_text ) if (reverse ^ m_screen_reverse) tile ^= 0xff; -// if (m_width80) +// if (m_width80) { u8 pen; @@ -170,7 +170,7 @@ UPD3301_DRAW_CHARACTER_MEMBER( pc8001_base_state::draw_text ) pen = tile; pen = (pen >> (7 - (xi >> (dot_width - 1)))) & 1; } - + for (int di = 0; di < dot_width; di++) bitmap.pix(y, res_x + di) = m_crtc_palette->pen(pen ? color : 0); } @@ -237,7 +237,7 @@ void pc8001_base_state::port30_w(uint8_t data) /* color mode */ m_color = BIT(data, 1); - + m_cassette->change_state(BIT(data, 3) ? CASSETTE_MOTOR_ENABLED : CASSETTE_MOTOR_DISABLED, CASSETTE_MASK_MOTOR); } @@ -257,7 +257,7 @@ void pc8001mk2_state::port31_w(uint8_t data) 7 background color */ - membank("bank2")->set_entry(data & 1); + membank("bank2")->set_entry(data & 1); } WRITE_LINE_MEMBER( pc8001_state::write_centronics_busy ) @@ -438,8 +438,8 @@ void pc8001mk2sr_state::port71_w(u8 data) void pc8001mk2sr_state::pc8001mk2sr_io(address_map &map) { - pc8001mk2_io(map); - map(0x33, 0x33).w(FUNC(pc8001mk2sr_state::port33_w)); + pc8001mk2_io(map); + map(0x33, 0x33).w(FUNC(pc8001mk2sr_state::port33_w)); map(0x71, 0x71).rw(FUNC(pc8001mk2sr_state::port71_r), FUNC(pc8001mk2sr_state::port71_w)); } @@ -546,13 +546,13 @@ static INPUT_PORTS_START( pc8001 ) PORT_BIT( 0x40, IP_ACTIVE_LOW, IPT_KEYBOARD ) PORT_CODE(KEYCODE_SPACE) PORT_CHAR(' ') PORT_BIT( 0x80, IP_ACTIVE_LOW, IPT_KEYBOARD ) PORT_CODE(KEYCODE_ESC) PORT_CHAR(27) -// PORT_START("DSW1") +// PORT_START("DSW1") INPUT_PORTS_END static INPUT_PORTS_START( pc8001mk2 ) - PORT_INCLUDE( pc8001 ) + PORT_INCLUDE( pc8001 ) - PORT_START("DSW1") + PORT_START("DSW1") PORT_DIPNAME( 0x01, 0x00, "Boot Mode" ) PORT_DIPSETTING( 0x00, "N-BASIC" ) PORT_DIPSETTING( 0x01, "N80-BASIC" ) @@ -606,7 +606,7 @@ static INPUT_PORTS_START( pc8001mk2 ) INPUT_PORTS_END static INPUT_PORTS_START( pc8001mk2sr ) - PORT_INCLUDE( pc8001mk2 ) + PORT_INCLUDE( pc8001mk2 ) PORT_MODIFY("DSW1") // This is really a tri-state dip on front panel @@ -690,10 +690,10 @@ void pc8001_state::machine_start() program.install_readwrite_bank(0x0000, 0x5fff, membank("bank1")); program.install_readwrite_bank(0x6000, 0xbfff, membank("bank2")); program.install_readwrite_bank(0x8000, 0xffff, membank("bank3")); -// membank("bank2")->set_entry(0); +// membank("bank2")->set_entry(0); break; } - + // PC8001 is 15KHz only set_screen_frequency(false); } @@ -707,18 +707,18 @@ void pc8001_state::machine_reset() void pc8001mk2sr_state::machine_start() { - pc8001_state::machine_start(); + pc8001_state::machine_start(); membank("bank1")->configure_entry(2, m_n80sr_rom->base()); membank("bank2")->configure_entry(2, m_n80sr_rom->base() + 0x6000); membank("bank2")->configure_entry(3, m_n80sr_rom->base() + 0x8000); - + save_item(NAME(m_n80sr_bank)); } void pc8001mk2sr_state::machine_reset() { - pc8001_state::machine_reset(); + pc8001_state::machine_reset(); //membank("bank1")->set_entry(2); //membank("bank2")->set_entry(2); @@ -728,8 +728,8 @@ void pc8001mk2sr_state::machine_reset() void pc8001_state::pc8001(machine_config &config) { - constexpr XTAL MASTER_CLOCK = XTAL(4'000'000); - constexpr XTAL VIDEO_CLOCK = XTAL(14'318'181); + constexpr XTAL MASTER_CLOCK = XTAL(4'000'000); + constexpr XTAL VIDEO_CLOCK = XTAL(14'318'181); /* basic machine hardware */ Z80(config, m_maincpu, MASTER_CLOCK); @@ -744,7 +744,7 @@ void pc8001_state::pc8001(machine_config &config) SCREEN(config, m_screen, SCREEN_TYPE_RASTER); m_screen->set_raw(VIDEO_CLOCK, 896, 0, 640, 260, 0, 200); m_screen->set_screen_update(FUNC(pc8001_state::screen_update)); -// m_screen->set_palette(m_crtc_palette); +// m_screen->set_palette(m_crtc_palette); PALETTE(config, m_crtc_palette, palette_device::BRG_3BIT); @@ -783,7 +783,7 @@ void pc8001_state::pc8001(machine_config &config) /* sound hardware */ SPEAKER(config, "mono").front_center(); - // TODO: unknown clock, is it really a beeper? + // TODO: unknown clock, is it really a beeper? BEEP(config, m_beep, 2400).add_route(ALL_OUTPUTS, "mono", 0.25); } diff --git a/src/mame/drivers/pc8801.cpp b/src/mame/drivers/pc8801.cpp index 8746a52fb41..2e975032af3 100644 --- a/src/mame/drivers/pc8801.cpp +++ b/src/mame/drivers/pc8801.cpp @@ -655,7 +655,7 @@ void pc8801_state::pc8801_alu_w(offs_t offset, uint8_t data) for(i=0;i<3;i++) { logic_op = (m_alu_ctrl1 & (0x11 << i)) >> i; - + switch(logic_op) { case 0x00: { m_gvram[i*0x4000 + offset] &= ~data; } break; @@ -843,7 +843,7 @@ void pc8801_state::pc8801_mem_w(offs_t offset, uint8_t data) window_offset = (offset & 0x3ff) + (m_window_offset_bank << 8); // castlex and imenes accesses this - // TODO: high TVRAM even + // TODO: high TVRAM even // (uPD3301 reads from this instead of the regular work RAM) if(((window_offset & 0xf000) == 0xf000) && (m_misc_ctrl & 0x10)) pc8801_high_wram_w(window_offset & 0xfff,data); @@ -2165,7 +2165,7 @@ MACHINE_RESET_MEMBER(pc8801_state,pc8801_clock_speed) m_maincpu->set_unscaled_clock(m_clock_setting ? XTAL(4'000'000) : XTAL(8'000'000)); // TODO: FDC board shouldn't be connected to the clock setting, verify -// m_fdccpu->set_unscaled_clock(m_clock_setting ? XTAL(4'000'000) : XTAL(8'000'000)); +// m_fdccpu->set_unscaled_clock(m_clock_setting ? XTAL(4'000'000) : XTAL(8'000'000)); m_baudrate_val = 0; } @@ -2240,7 +2240,7 @@ void pc8801_state::pc8801(machine_config &config) config.set_perfect_quantum(m_maincpu); config.set_perfect_quantum("pc80s31:fdc_cpu"); -// config.set_maximum_quantum(attotime::from_hz(MASTER_CLOCK/1024)); +// config.set_maximum_quantum(attotime::from_hz(MASTER_CLOCK/1024)); #if USE_PROPER_I8214 I8214(config, I8214_TAG, MASTER_CLOCK); diff --git a/src/mame/drivers/rollext.cpp b/src/mame/drivers/rollext.cpp index 64b44c8b712..e730e1536f9 100644 --- a/src/mame/drivers/rollext.cpp +++ b/src/mame/drivers/rollext.cpp @@ -71,16 +71,16 @@ - TODO: + TODO: - - TMS320C82 parallel processors are not emulated - * PP0 transfers polygon data from a software FIFO to the graphics processor. This is currently HLE'd. - * PP1 most likely does sound mixing. This is currently not emulated. - - 93C66 EEPROM - - Alpha blending (probably based on palette index like on gaelco3d) - - Minor Z-buffer issues - - Wrong textures in a few places (could be a CPU core bug) - - Networking + - TMS320C82 parallel processors are not emulated + * PP0 transfers polygon data from a software FIFO to the graphics processor. This is currently HLE'd. + * PP1 most likely does sound mixing. This is currently not emulated. + - 93C66 EEPROM + - Alpha blending (probably based on palette index like on gaelco3d) + - Minor Z-buffer issues + - Wrong textures in a few places (could be a CPU core bug) + - Networking */ @@ -193,7 +193,7 @@ void rollext_renderer::render_texture_scan(int32_t scanline, const extent_t &ext int ty = tex_origin_y + (int)(v); -#if BILINEAR +#if BILINEAR float intu, intv; int fracu = modff(u, &intu) * 255.0f; @@ -470,7 +470,7 @@ uint32_t rollext_state::a0000000_r(offs_t offset, uint32_t mem_mask) data |= m_in[0]->read() << 16; data |= m_in[1]->read(); - data |= 0x200; // 0 causes inf loop + data |= 0x200; // 0 causes inf loop // -------- ---x---- -------- -------- ADC channel 0 // -------- --x----- -------- -------- ADC channel 1? @@ -485,7 +485,7 @@ uint32_t rollext_state::a0000000_r(offs_t offset, uint32_t mem_mask) case 1: uint32_t data = 0; data |= m_in[2]->read(); - return data; + return data; } return 0xffffffff; @@ -538,7 +538,7 @@ void rollext_state::cmd_callback(address_space &space, uint32_t data) if (command & 0x00004000) { // simulate PP behavior for now... - space.write_dword(0x00000084, 3); + space.write_dword(0x00000084, 3); m_renderer->m_fb_current ^= 1; m_renderer->clear_fb(); @@ -559,7 +559,7 @@ void rollext_state::cmd_callback(address_space &space, uint32_t data) } void rollext_state::palette_w(offs_t offset, uint32_t data, uint32_t mem_mask) -{ +{ if (ACCESSING_BITS_16_31) { m_renderer->palette_write((offset * 2) + 1, data >> 16); @@ -609,7 +609,7 @@ void rollext_state::memmap(address_map &map) static INPUT_PORTS_START(rollext) PORT_START("INPUTS1") - PORT_SERVICE_NO_TOGGLE(0x8, IP_ACTIVE_LOW) // test button + PORT_SERVICE_NO_TOGGLE(0x8, IP_ACTIVE_LOW) // test button PORT_BIT(0x4, IP_ACTIVE_LOW, IPT_VOLUME_DOWN) PORT_BIT(0x2, IP_ACTIVE_LOW, IPT_SERVICE1) PORT_BIT(0x1, IP_ACTIVE_LOW, IPT_VOLUME_UP) @@ -668,7 +668,7 @@ void rollext_state::fifo_ptr_w(offs_t offset, uint32_t data, uint32_t mem_mask) } m_maincpu->space().write_dword(0x600ffffc, oldnum + consume_num); m_maincpu->space().write_dword(0x00000090, 0); - } + } } diff --git a/src/mame/drivers/saturn.cpp b/src/mame/drivers/saturn.cpp index 3605cc72880..3e1b93d9c51 100644 --- a/src/mame/drivers/saturn.cpp +++ b/src/mame/drivers/saturn.cpp @@ -483,12 +483,12 @@ private: enum { REGION_NTSC_0 = 0, REGION_NTSC_JAPAN, -// REGION_NTSC_TAIWAN, +// REGION_NTSC_TAIWAN, REGION_NTSC_KOREA, REGION_NTSC_3, REGION_NTSC_USA, // & Canada, Mexico REGION_NTSC_BRAZIL, -// REGION_NTSC_KOREA, +// REGION_NTSC_KOREA, REGION_NTSC_TAIWAN, // & Philippines REGION_NTSC_7, REGION_PAL_8, diff --git a/src/mame/drivers/spg2xx_jakks.cpp b/src/mame/drivers/spg2xx_jakks.cpp index da3125d5e32..7deed4f8473 100644 --- a/src/mame/drivers/spg2xx_jakks.cpp +++ b/src/mame/drivers/spg2xx_jakks.cpp @@ -216,7 +216,7 @@ CONS( 2004, jak_mpacw,0, 0, jakks_mpac, jak_mpac, jakks_state, empty_init, "JA // This was available in 2 different case styles, initially an underwater / jellyfish themed one, then later // reissued in a 'SpongeBob head' style case reminiscent of the undumpable 2003 SpongeBob plug and play but // with 2 buttons in the top left corner instead of 1 -// +// // The software on both versions of Jellyfish Dodge is believed to be the same, the build date can be seen in // the 'hidden' test mode. // diff --git a/src/mame/includes/pc8001.h b/src/mame/includes/pc8001.h index 6a68ab80321..d2c4ed50e8f 100644 --- a/src/mame/includes/pc8001.h +++ b/src/mame/includes/pc8001.h @@ -92,7 +92,7 @@ protected: void pc8001_map(address_map &map); virtual void machine_start() override; - virtual void machine_reset() override; + virtual void machine_reset() override; uint32_t screen_update(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect); @@ -123,7 +123,7 @@ public: pc8001mk2_state(const machine_config &mconfig, device_type type, const char *tag) : pc8001_state(mconfig, type, tag) , m_kanji_rom(*this, "kanji") - , m_dsw(*this, "DSW%d", 1U) + , m_dsw(*this, "DSW%d", 1U) { } void pc8001mk2(machine_config &config); @@ -133,7 +133,7 @@ protected: void pc8001mk2_map(address_map &map); required_memory_region m_kanji_rom; - required_ioport_array<2> m_dsw; + required_ioport_array<2> m_dsw; private: void port31_w(uint8_t data); }; @@ -150,10 +150,10 @@ public: private: virtual void machine_start() override; - virtual void machine_reset() override; - void pc8001mk2sr_io(address_map &map); + virtual void machine_reset() override; + void pc8001mk2sr_io(address_map &map); - required_memory_region m_n80sr_rom; + required_memory_region m_n80sr_rom; void port33_w(u8 data); u8 port71_r(); diff --git a/src/mame/layout/ace_sp_dmd.lay b/src/mame/layout/ace_sp_dmd.lay index e00e8abeabd..d3876c787e2 100644 --- a/src/mame/layout/ace_sp_dmd.lay +++ b/src/mame/layout/ace_sp_dmd.lay @@ -14,7 +14,7 @@ license:CC0 <color state="0" red="0.125" green="0.125" blue="0.125" /> </disk> </element> - + <group name="dmd"> <repeat count="24"> <param name="s" start="0" increment="64" /> diff --git a/src/mame/machine/ace_sp_reelctrl.cpp b/src/mame/machine/ace_sp_reelctrl.cpp index b4fd316b235..dbec9211045 100644 --- a/src/mame/machine/ace_sp_reelctrl.cpp +++ b/src/mame/machine/ace_sp_reelctrl.cpp @@ -42,7 +42,7 @@ void ace_sp_reelctrl_base_device::device_add_mconfig(machine_config &config) } ROM_START( ace_sp_reelctrl ) - ROM_REGION16_BE( 0x0800, "mcu", 0 ) + ROM_REGION16_BE( 0x0800, "mcu", 0 ) ROM_LOAD( "ace reel mcu v9 _space_.bin", 0, 0x0800, CRC(d7b91fe0) SHA1(44f78da8138caf4f79f1e8e9a2abe53d79c0fe79) ) // MC68705P3 internal ROM ROM_END @@ -52,7 +52,7 @@ const tiny_rom_entry *ace_sp_reelctrl_device::device_rom_region() const } ROM_START( ace_sp_reelctrl_pcp ) - ROM_REGION16_BE( 0x0800, "mcu", 0 ) + ROM_REGION16_BE( 0x0800, "mcu", 0 ) ROM_LOAD( "pcp reel mcu fcr 1 _space_.bin", 0, 0x0800, CRC(1c8019bf) SHA1(d1d6ea68d9aace4a4ea0de212f17426bccfe5856) ) // MC68705P3 internal ROM ROM_END diff --git a/src/mame/machine/pc80s31k.cpp b/src/mame/machine/pc80s31k.cpp index 317a9edd988..eb05acb8cfd 100644 --- a/src/mame/machine/pc80s31k.cpp +++ b/src/mame/machine/pc80s31k.cpp @@ -2,34 +2,34 @@ // copyright-holders:Angelo Salese, Olivier Galibert /************************************************************************************************** - NEC PC-80S31(K) Mini Disk Unit - - Z80 + μPD765 + PPI that connects in cross with an host PPI - - "Mini" as compared to the PC-8881 8-inch floppy I/F - - Design is decidedly derived from Epson TF-20 and friends, - cfr. devices/bus/epson_sio/tf20.cpp - - TODO: - - What's PC-80S32? Is it the 88VA version or a different beast? - - PC=0x7dd reads from FDC bit 3 in ST3 (twosid_r fn), - expecting a bit 3 high for all the PC8001 games otherwise keeps looping and eventually dies. - Are those incorrectly identified as 2DD? Hacked to work for now; - - set_input_line_vector fn doesn't work properly when issued from a device_reset, - we currently just implement the irq_callback instead; - - Bus option; - - Cascade mode, i.e. the CN2 connector used to accept a second disk unit for drive 2 & 3; - - pc80s31k: verify that irq vector write (I/O port $f0) belongs here or just - whatever PC88VA uses. - - printer interface (used for debugging? 4-bit serial?) - - Pinpoint what host I/O ports $f6, $f7 truly are + NEC PC-80S31(K) Mini Disk Unit + + Z80 + μPD765 + PPI that connects in cross with an host PPI + + "Mini" as compared to the PC-8881 8-inch floppy I/F + + Design is decidedly derived from Epson TF-20 and friends, + cfr. devices/bus/epson_sio/tf20.cpp + + TODO: + - What's PC-80S32? Is it the 88VA version or a different beast? + - PC=0x7dd reads from FDC bit 3 in ST3 (twosid_r fn), + expecting a bit 3 high for all the PC8001 games otherwise keeps looping and eventually dies. + Are those incorrectly identified as 2DD? Hacked to work for now; + - set_input_line_vector fn doesn't work properly when issued from a device_reset, + we currently just implement the irq_callback instead; + - Bus option; + - Cascade mode, i.e. the CN2 connector used to accept a second disk unit for drive 2 & 3; + - pc80s31k: verify that irq vector write (I/O port $f0) belongs here or just + whatever PC88VA uses. + - printer interface (used for debugging? 4-bit serial?) + - Pinpoint what host I/O ports $f6, $f7 truly are (direct FDC access from this device or a different beast? cfr. play6lim with pc8001mk2) - filemst tries to access undocumented I/O port $09 at PC=5000: - \- If that's 0 then it tries to read a vector at [0x8000]; - \- It then tries to read at memory [0xc0ff], set the value read in [0xf012]; - \- Expects that ROM [0x0000] is not equal to 0xc3; - Bottom line: Is it trying to access some custom HW? + \- If that's 0 then it tries to read a vector at [0x8000]; + \- It then tries to read at memory [0xc0ff], set the value read in [0xf012]; + \- Expects that ROM [0x0000] is not equal to 0xc3; + Bottom line: Is it trying to access some custom HW? =================================================================================================== @@ -37,29 +37,29 @@ PCB (PC-80S31K) =================================================================================================== - |--------------------------------------| - | P1 P2 P3 X1 | - | | - | CN2 | + |--------------------------------------| + | P1 P2 P3 X1 | + | | + | CN2 | | B6102C022 | | FD1 FD2 (**) | | | | | | CN1 ------- D765AC D2364EC (*)| - | (*)| - | D8255AC-2 B6101C017 D780C-1 | - | | - |--------------------------------------| - - PCB is marked PC-80S31KFDC NEC-14T - P1, P2, P3 are power supplies (+5V, +12V, -5V for P1, lacks -5V for the other two) - μPD2364EC is at position IC13, it's a 8192 size ROM. (***) - (*) are μPD41416C - (**) marked as JP, unpopulated x 3; - μPB6101/2 are bipolar TTL gate arrays, presumably - Cannot read marking of X1 (8 MHz?) - - (***) Given this, we guess that PC80S31 is the 2D version while the 'K - variant is the 2D/2DD/2HD version. + | (*)| + | D8255AC-2 B6101C017 D780C-1 | + | | + |--------------------------------------| + + PCB is marked PC-80S31KFDC NEC-14T + P1, P2, P3 are power supplies (+5V, +12V, -5V for P1, lacks -5V for the other two) + μPD2364EC is at position IC13, it's a 8192 size ROM. (***) + (*) are μPD41416C + (**) marked as JP, unpopulated x 3; + μPB6101/2 are bipolar TTL gate arrays, presumably + Cannot read marking of X1 (8 MHz?) + + (***) Given this, we guess that PC80S31 is the 2D version while the 'K + variant is the 2D/2DD/2HD version. =================================================================================================== @@ -67,7 +67,7 @@ Command Protocol =================================================================================================== -Command & parameters are normally communicated from Host via port B +Command & parameters are normally communicated from Host via port B (read on port A on FDC side) An RPi implementation can be seen at https://github.com/MinatsuT/RPi_PC-80S31 @@ -93,10 +93,10 @@ An RPi implementation can be seen at https://github.com/MinatsuT/RPi_PC-80S31 %7 destination sector number +1 [0x05] Format %1 drive number -[0x06] Send result status to Host +[0x06] Send result status to Host x--- ---- I/O complete - -x-- ---- has unread buffer - ---- ---x error occurred + -x-- ---- has unread buffer + ---- ---x error occurred [0x07] Drive status [0x0b] Send memory data %1-%2 address start @@ -110,12 +110,12 @@ An RPi implementation can be seen at https://github.com/MinatsuT/RPi_PC-80S31 (picks up number of sector etc. from previous issued commands?) [0x14] Device status x--- ---- ESIG: error - -x-- ---- WPDR: write protected - --x- ---- RDY: ready - ---x ---- TRK0: track 0 - ---- x--- DSDR: double sided drive - ---- -x-- HDDR: head - ---- --xx DS1, DS2: drive select + -x-- ---- WPDR: write protected + --x- ---- RDY: ready + ---x ---- TRK0: track 0 + ---- x--- DSDR: double sided drive + ---- -x-- HDDR: head + ---- --xx DS1, DS2: drive select (same as 765 ST3?) [0x17] Mode change %1 ---- xxxx mode select @@ -133,7 +133,7 @@ Used as a communication protocol flags (swap 4-bit nibbles and r/w direction for FDC side, all bits are active high): x--- ---- (w) ATN AtenTioN: host sends a command to FDC, interrupts current one - (looks unconnected the other way around?) + (looks unconnected the other way around?) -x-- ---- (w) DAC DAta aCcepted: host just picked up data from FDC --x- ---- (w) RFD Ready For Data: @@ -231,11 +231,11 @@ void pc80s31_device::fdc_io(address_map &map) { map.unmap_value_high(); map.global_mask(0xff); -// map(0x09, 0x09).r accessed by filemst (pc8801), cfr. notes +// map(0x09, 0x09).r accessed by filemst (pc8801), cfr. notes -// map(0xf0, 0xf0).w(FUNC(pc8801_state::fdc_irq_vector_w)); // Interrupt Opcode Port -// map(0xf4, 0xf4).w(FUNC(pc8801_state::fdc_drive_mode_w)); // Drive mode, 2d, 2dd, 2hd -// map(0xf6, 0xf6).nopw(); // printer related +// map(0xf0, 0xf0).w(FUNC(pc8801_state::fdc_irq_vector_w)); // Interrupt Opcode Port +// map(0xf4, 0xf4).w(FUNC(pc8801_state::fdc_drive_mode_w)); // Drive mode, 2d, 2dd, 2hd +// map(0xf6, 0xf6).nopw(); // printer related map(0xf7, 0xf7).nopw(); // printer port output map(0xf8, 0xf8).rw(FUNC(pc80s31_device::terminal_count_r), FUNC(pc80s31_device::motor_control_w)); map(0xfa, 0xfb).m(m_fdc, FUNC(upd765a_device::map)); @@ -301,7 +301,7 @@ void pc80s31_device::device_timer(emu_timer &timer, device_timer_id id, int para m_fdc->tc_w(false); - // several games tries to scan invalid IDs from their structures, if this hits then + // several games tries to scan invalid IDs from their structures, if this hits then // it's possibly an attempt to scan a missing sector from the floppy structure. // cfr. acrojet: the third read data command issued tries to access a CHRN of (0, 0, 16, 256) // and checks at PC=500B if any of these status flags are satisfied: @@ -313,7 +313,7 @@ void pc80s31_device::device_timer(emu_timer &timer, device_timer_id id, int para if ((u8)m_fdc_cpu->state_int(Z80_HALT) == 1) { logerror("%s: attempt to trigger TC while in HALT state (read ID copy protection warning)\n", machine().describe_context()); -// throw emu_fatalerror("copy protection hit"); +// throw emu_fatalerror("copy protection hit"); } } @@ -324,7 +324,7 @@ void pc80s31_device::device_timer(emu_timer &timer, device_timer_id id, int para void pc80s31_device::device_start() { m_tc_zero_timer = timer_alloc(0); - + save_item(NAME(m_irq_vector)); } @@ -357,14 +357,14 @@ void pc80s31_device::device_reset() template <unsigned N> u8 pc80s31_device::latch_r() { const int port_mask = N & 4 ? 0x0f : 0xff; -// machine().scheduler().synchronize(); +// machine().scheduler().synchronize(); return m_latch[N]->read() & port_mask; } template <unsigned N> void pc80s31_device::latch_w(u8 data) { const int lower_nibble = N & 4; -// machine().scheduler().synchronize(); +// machine().scheduler().synchronize(); if (lower_nibble) { LOG("%s: %s port C write %02x (ATN=%d DAC=%d RFD=%d DAV=%d)\n" @@ -398,14 +398,14 @@ void pc80s31_device::motor_control_w(uint8_t data) { // FIXME: on pc80s31k device (particularly on later releases) this stays always on // babylon: just spins indefinitely at PC=6d8 (using the internal routines), - // waiting for DAV or ATN being on. Never hits the port until a flag is issued. + // waiting for DAV or ATN being on. Never hits the port until a flag is issued. // prajator: on idle times it spins at PC=7060, waiting for ATN and keep issuing a 0xff here. // valis2: calls PC=7009 subroutine for idle, waits for ATN on. // It eventually writes a 0 here, not before an extremely long time // (~10000 frames!) m_floppy[0]->get_device()->mon_w(!(data & 1)); m_floppy[1]->get_device()->mon_w(!(data & 2)); - + // TODO: according to docs a value of 0x07 enables precompensation to tracks 0-19, 0xf enables it on 20-39 } diff --git a/src/mame/machine/pc80s31k.h b/src/mame/machine/pc80s31k.h index a1f9209e75e..b21d2845daf 100644 --- a/src/mame/machine/pc80s31k.h +++ b/src/mame/machine/pc80s31k.h @@ -60,7 +60,7 @@ private: u8 terminal_count_r(address_space &space); void motor_control_w(u8 data); - + emu_timer *m_tc_zero_timer; IRQ_CALLBACK_MEMBER(irq_cb); diff --git a/src/mame/mame.lst b/src/mame/mame.lst index 13b19ca5586..9cfd3faacb6 100644 --- a/src/mame/mame.lst +++ b/src/mame/mame.lst @@ -33857,7 +33857,7 @@ pc6601 // @source:pc8001.cpp pc8001 // 1979 pc8001mk2 // 1983 -pc8001mk2sr // 1985 +pc8001mk2sr // 1985 @source:pc8401a.cpp pc8401a // roms needed diff --git a/src/mame/video/sknsspr.cpp b/src/mame/video/sknsspr.cpp index 518e2a4bfb5..d474ff0d8da 100644 --- a/src/mame/video/sknsspr.cpp +++ b/src/mame/video/sknsspr.cpp @@ -156,7 +156,7 @@ void sknsspr_device::skns_sprite_kludge(int x, int y) while(ys < sy && yd >= clip.min_y) #define z_draw_pixel() \ - u8 val = src[(xs >> 16) & 0x3f]; \ + u8 val = src[(xs >> 16) & 0x3f]; \ if(val) \ bitmap.pix(yd>>16, xd>>16) = val + colour; |