diff options
author | Vas Crabb <vas@vastheman.com> | 2018-07-07 02:40:29 +1000 |
---|---|---|
committer | Vas Crabb <vas@vastheman.com> | 2018-07-07 02:40:29 +1000 |
commit | c3fb11c2c98a5c28ece6a27093a0f9def350ac64 (patch) | |
tree | c68b38f05ed1d32358add721fda7f45e8803479f /src/mame/drivers/zac2650.cpp | |
parent | 5d9e33b786d7ef452317439359f3cbd8cc920513 (diff) |
devcb3
There are multiple issues with the current device callbacks:
* They always dispatch through a pointer-to-member
* Chained callbacks are a linked list so the branch unit can't predict the early
* There's a runtime decision made on the left/right shift direction
* There are runtime NULL checks on various objects
* Binding a lambda isn't practical
* Arbitrary transformations are not supported
* When chaining callbacks it isn't clear what the MCFG_DEVCB_ modifiers apply to
* It isn't possible to just append to a callback in derived configuration
* The macros need a magic, hidden local called devcb
* Moving code that uses the magic locals around is error-prone
* Writing the MCFG_ macros to make a device usable is a pain
* You can't discover applicable MCFG_ macros with intellisense
* Macros are not scoped
* Using an inappropriate macro isn't detected at compile time
* Lots of other things
This changeset overcomes the biggest obstacle to remving MCFG_ macros
altogether. Essentially, to allow a devcb to be configured, call
.bind() and expose the result (a bind target for the callback). Bind
target methods starting with "set" repace the current callbacks; methods
starting with "append" append to them. You can't reconfigure a callback
after resolving it. There's no need to use a macro matching the
handler signatures - use FUNC for everything. Current device is implied
if no tag/finder is supplied (no need for explicit this).
Lambdas are supported, and the memory space and offset are optional.
These kinds of things work:
* .read_cb().set([this] () { return something; });
* .read_cb().set([this] (offs_t offset) { return ~offset; });
* .write_cb().set([this] (offs_t offset, u8 data) { m_array[offset] = data; });
* .write_cb().set([this] (int state) { some_var = state; });
Arbitrary transforms are allowed, and they can modify offset/mask for example:
* .read_cb().set(FUNC(my_state::handler)).transform([] (u8 data) { return bitswap<4>(data, 1, 3, 0, 2); });
* .read_cb().set(m_dev, FUNC(some_device::member)).transform([] (offs_t &offset, u8 data) { offset ^= 3; return data; });
It's possible to stack arbitrary transforms, at the cost of compile
time (the whole transform stack gets inlined at compile time). Shifts
count as an arbitrary transform, but mask/exor does not.
Order of mask/shift/exor now matters. Modifications are applied in the
specified order. These are NOT EQUIVALENT:
* .read_cb().set(FUNC(my_state::handler)).mask(0x06).lshift(2);
* .read_cb().set(FUNC(my_state::handler)).lshift(2).mask(0x06);
The bit helper no longer reverses its behaviour for read callbacks, and
I/O ports are no longer aware of the field mask. Binding a read
callback to no-op is not supported - specify a constant. The GND and
VCC aliases have been removed intentionally - they're TTL-centric, and
were already being abused.
Other quirks have been preserved, including write logger only logging
when the data is non-zero (quite unhelpful in many of the cases where
it's used). Legacy syntax is still supported for simple cases, but will
be phased out. New devices should not have MCFG_ macros.
I don't think I've missed any fundamental issues, but if I've broken
something, let me know.
Diffstat (limited to 'src/mame/drivers/zac2650.cpp')
-rw-r--r-- | src/mame/drivers/zac2650.cpp | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/mame/drivers/zac2650.cpp b/src/mame/drivers/zac2650.cpp index 8b524777454..dcba11ad8aa 100644 --- a/src/mame/drivers/zac2650.cpp +++ b/src/mame/drivers/zac2650.cpp @@ -233,18 +233,18 @@ GFXDECODE_END MACHINE_CONFIG_START(zac2650_state::tinvader) /* basic machine hardware */ - MCFG_DEVICE_ADD("maincpu", S2650, 3800000/4) - MCFG_DEVICE_PROGRAM_MAP(main_map) - MCFG_S2650_SENSE_INPUT(READLINE("screen", screen_device, vblank)) MCFG_DEVCB_INVERT + s2650_device &maincpu(S2650(config, m_maincpu, 3800000/4)); + maincpu.set_addrmap(AS_PROGRAM, &zac2650_state::main_map); + maincpu.sense_handler().set(m_screen, FUNC(screen_device::vblank)).invert(); /* video hardware */ - MCFG_SCREEN_ADD("screen", RASTER) - MCFG_SCREEN_REFRESH_RATE(55) - MCFG_SCREEN_VBLANK_TIME(ATTOSECONDS_IN_USEC(1041)) - MCFG_SCREEN_SIZE(30*24, 32*24) - MCFG_SCREEN_VISIBLE_AREA(0, 719, 0, 767) - MCFG_SCREEN_UPDATE_DRIVER(zac2650_state, screen_update_tinvader) - MCFG_SCREEN_PALETTE("palette") + SCREEN(config, m_screen, SCREEN_TYPE_RASTER); + m_screen->set_refresh_hz(55); + m_screen->set_vblank_time(ATTOSECONDS_IN_USEC(1041)); + m_screen->set_size(30*24, 32*24); + m_screen->set_visarea(0, 719, 0, 767); + m_screen->set_screen_update(FUNC(zac2650_state::screen_update_tinvader)); + m_screen->set_palette(m_palette); MCFG_DEVICE_ADD("gfxdecode", GFXDECODE, "palette", gfx_tinvader) MCFG_PALETTE_ADD("palette", 4) @@ -253,8 +253,8 @@ MACHINE_CONFIG_START(zac2650_state::tinvader) /* sound hardware */ SPEAKER(config, "mono").front_center(); - MCFG_DEVICE_ADD("s2636", S2636, 0) - MCFG_SOUND_ROUTE(ALL_OUTPUTS, "mono", 0.25) + S2636(config, m_s2636, 0); + m_s2636->add_route(ALL_OUTPUTS, "mono", 0.25); MACHINE_CONFIG_END WRITE8_MEMBER(zac2650_state::tinvader_sound_w) |