summaryrefslogtreecommitdiffstatshomepage
path: root/src/mame/drivers/majorpkr.cpp
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2018-12-29 05:53:50 +1100
committer Vas Crabb <vas@vastheman.com>2018-12-29 05:53:50 +1100
commitf1f0591f43f381123e8d9ec20c52eb7c0c332c79 (patch)
tree97c8dd30a6ea292c3189f372b8103a2e303c0b2d /src/mame/drivers/majorpkr.cpp
parent65bfb2654f0c73235f114e9145c766245bed9790 (diff)
Start cleaning up palette configuration:
* Basically, initialisers go in the constructor arguments, and things for setting format go in set_format. * Initialisation patterns can be specified with an enum discriminator or with a FUNC and optionally a tag. * Formats can be specified with an enum discriminator or a size and function pointer. * You must always supply the number of entries when setting the format. * When initislising with a paletter initialisation member, you can specify the entries and indirecte entries together. * The palette_device now has a standard constructor, so use .set_entries if you are specifying entry count with no format/initialisation. * Also killed an overload on delegates that wasn't being useful.
Diffstat (limited to 'src/mame/drivers/majorpkr.cpp')
-rw-r--r--src/mame/drivers/majorpkr.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/mame/drivers/majorpkr.cpp b/src/mame/drivers/majorpkr.cpp
index 9a38bfcc7de..a632af8ca67 100644
--- a/src/mame/drivers/majorpkr.cpp
+++ b/src/mame/drivers/majorpkr.cpp
@@ -488,6 +488,10 @@ public:
void init_majorpkr();
+protected:
+ virtual void machine_start() override { m_lamps.resolve(); }
+ virtual void video_start() override;
+
private:
DECLARE_WRITE8_MEMBER(rom_bank_w);
DECLARE_WRITE8_MEMBER(palette_bank_w);
@@ -509,9 +513,6 @@ private:
void portmap(address_map &map);
void vrambanks(address_map &map);
- virtual void machine_start() override { m_lamps.resolve(); }
- virtual void video_start() override;
-
required_device<gfxdecode_device> m_gfxdecode;
required_device<address_map_bank_device> m_palette_bank;
required_device<address_map_bank_device> m_vram_bank;
@@ -1021,10 +1022,9 @@ MACHINE_CONFIG_START(majorpkr_state::majorpkr)
MCFG_SCREEN_UPDATE_DRIVER(majorpkr_state, screen_update_majorpkr)
MCFG_SCREEN_PALETTE("palette")
- MCFG_DEVICE_ADD("gfxdecode", GFXDECODE, "palette", gfx_majorpkr)
+ GFXDECODE(config, m_gfxdecode, "palette", gfx_majorpkr);
- MCFG_PALETTE_ADD("palette", 0x100 * 16)
- MCFG_PALETTE_FORMAT(xGGGGGRRRRRBBBBB)
+ PALETTE(config, "palette").set_format(palette_device::xGRB_555, 0x100 * 16);
mc6845_device &crtc(MC6845(config, "crtc", CRTC_CLOCK)); // verified.
crtc.set_screen("screen");