diff options
author | Aaron Giles <aaron@aarongiles.com> | 2008-08-14 05:17:39 +0000 |
---|---|---|
committer | Aaron Giles <aaron@aarongiles.com> | 2008-08-14 05:17:39 +0000 |
commit | 3b76b8e25ec2ad0947c8e9e26a6ffd092a4f99ac (patch) | |
tree | 27fb3f405e03b4a5aa2c50ca4bb8282dd8c93737 /src/mame/drivers/ginganin.c | |
parent | 15893eeed0ae869cd2f31a38946ff1318349751d (diff) |
From: Fabio Priuli [mailto:doge.fabio@gmail.com]
Subject: some more input clean-ups
Hi,
attached please find a few patches against u4. These diffs improve
input ports for drivers starting with F->L. In particular: they add
AM_READ_PORT whenever suitable, they make inputs fully 32bit where
needed, they remove indexed input read handlers from INITs, they
replace many read handlers with appropriate CUSTOM_INPUTs.
Additional improvements:
* added dip switches and locations to go2000 (even if they were
partially documented in the source)
* fixed artmagic protection (it used a wrong tag, which probably
I added somewhere in 0.125uX); even if I haven't experienced any
problems due to the bug since the regression now it's fixed
More details on the patches:
* u4_clean01 -> u4_clean07: these are standard changes like the
one I submitted previously (no custom inputs involved)
* u4_custom01 -> u4_custom04: here there are also changes involving
custom inputs (they mainly deal with eeprom reads, but a few were a
bit more interesting); I separated these from the other ones in
case you want to check them more in detail
* itech8.diff: this patch improves ports & their handling in itech8.c.
In particular, it replaces the 'special' handlers with a single
custom input and I would like a confirmation that it was the right
choice in this case.
Patches are independent one from the other and should apply with
no problems. Let me know if this is not the case.
Regards,
Fabio
Diffstat (limited to 'src/mame/drivers/ginganin.c')
-rw-r--r-- | src/mame/drivers/ginganin.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/src/mame/drivers/ginganin.c b/src/mame/drivers/ginganin.c index 237565d90a4..77a868f4ab9 100644 --- a/src/mame/drivers/ginganin.c +++ b/src/mame/drivers/ginganin.c @@ -81,8 +81,8 @@ static ADDRESS_MAP_START( readmem, ADDRESS_SPACE_PROGRAM, 16 ) AM_RANGE(0x050000, 0x0507ff) AM_READ(SMH_RAM) AM_RANGE(0x060000, 0x06000f) AM_READ(SMH_RAM) AM_RANGE(0x068000, 0x06bfff) AM_READ(SMH_RAM) /* bg lives in ROM */ - AM_RANGE(0x070000, 0x070001) AM_READ(input_port_0_word_r) /* controls */ - AM_RANGE(0x070002, 0x070003) AM_READ(input_port_1_word_r) /* DSWs */ + AM_RANGE(0x070000, 0x070001) AM_READ_PORT("P1_P2") + AM_RANGE(0x070002, 0x070003) AM_READ_PORT("DSW") ADDRESS_MAP_END static ADDRESS_MAP_START( writemem, ADDRESS_SPACE_PROGRAM, 16 ) @@ -186,13 +186,10 @@ static ADDRESS_MAP_START( sound_writemem, ADDRESS_SPACE_PROGRAM, 8 ) ADDRESS_MAP_END - - -/* Input Ports: [0] Controls [1] DSWs */ +/* Input Ports */ static INPUT_PORTS_START( ginganin ) - - PORT_START("IN0") /* - Controls - Read from 70000.w */ + PORT_START("P1_P2") /* 70000.w */ PORT_BIT( 0x0001, IP_ACTIVE_LOW, IPT_JOYSTICK_UP ) PORT_8WAY PORT_BIT( 0x0002, IP_ACTIVE_LOW, IPT_JOYSTICK_DOWN ) PORT_8WAY PORT_BIT( 0x0004, IP_ACTIVE_LOW, IPT_JOYSTICK_LEFT ) PORT_8WAY @@ -210,7 +207,7 @@ static INPUT_PORTS_START( ginganin ) PORT_BIT( 0x4000, IP_ACTIVE_LOW, IPT_START1 ) PORT_BIT( 0x8000, IP_ACTIVE_LOW, IPT_START2 ) - PORT_START("IN1") /* DSWs - Read from 70002.w */ + PORT_START("DSW") /* 70002.w */ PORT_DIPNAME( 0x0007, 0x0007, DEF_STR( Coin_A ) ) PORT_DIPSETTING( 0x0000, DEF_STR( 5C_1C ) ) PORT_DIPSETTING( 0x0004, DEF_STR( 4C_1C ) ) @@ -259,7 +256,6 @@ static INPUT_PORTS_START( ginganin ) PORT_DIPNAME( 0x8000, 0x8000, "Freeze (Cheat)") PORT_DIPSETTING( 0x8000, DEF_STR( Off ) ) PORT_DIPSETTING( 0x0000, DEF_STR( On ) ) - INPUT_PORTS_END |