summaryrefslogtreecommitdiffstatshomepage
path: root/src/mame/drivers/c64.cpp
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2019-11-15 05:11:51 +1100
committer Vas Crabb <vas@vastheman.com>2019-11-15 05:11:51 +1100
commitce3c38914d4b710e2e40c212af0d61aa4b328de0 (patch)
tree9f68c3964399f72379e3f7c349c57e56756879ca /src/mame/drivers/c64.cpp
parentf7e679876fef04ee8d1f1ca5af6466423a265ae7 (diff)
c64.cpp, c128.cpp: fixed CBM IEC slot address not being set when replacing devices in machine config
bus/c64/rex_ep256.cpp: fixed array of EPROM slots not being populated (subdevices don't exist at construction time) cleanup: (nw) * having a macro for a device's expected tag in a header is bad - devices should not make assumptions about their tag or their location in the system hierarchy * device types exist in the global namespace - you must not use overly generic names for them as this is likely to cause collisions * device short names and titles each have their own namespace, but they're also global, and it should be possible to work out vaguely what a device is from its names * POSIX reserves all names ending in "_t" at global scope - we want fewer of these causing potential future issues, not more * if your device is in the global namespace, you should name it in a way that's not asking for name collisions to happen * we have a simple convention for device class names - it doesn't hurt to follow it: - concrete device_t implementations end with "_device" - device_interface implementations end with "_interface" (and often start with "device_") - abstract classes that derive from device_t end with "_device_base" * if you want to give your slot card device classes short, generic names, put them in a namespace for the "bus" * if you really want to use names ending with "_t", put them in a namespace or nest them inside a class
Diffstat (limited to 'src/mame/drivers/c64.cpp')
-rw-r--r--src/mame/drivers/c64.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mame/drivers/c64.cpp b/src/mame/drivers/c64.cpp
index 95ebaafbbbc..60a969ea667 100644
--- a/src/mame/drivers/c64.cpp
+++ b/src/mame/drivers/c64.cpp
@@ -1572,7 +1572,7 @@ void sx64_state::ntsc_sx(machine_config &config)
m_maincpu->set_pulls(0x07, 0xc0);
// devices
- CBM_IEC_SLOT(config.replace(), "iec8", sx1541_iec_devices, "sx1541");
+ CBM_IEC_SLOT(config.replace(), "iec8", 8, sx1541_iec_devices, "sx1541");
}
@@ -1585,7 +1585,7 @@ void sx64_state::ntsc_dx(machine_config &config)
ntsc_sx(config);
// devices
- CBM_IEC_SLOT(config.replace(), "iec9", sx1541_iec_devices, "sx1541");
+ CBM_IEC_SLOT(config.replace(), "iec9", 9, sx1541_iec_devices, "sx1541");
}
@@ -1732,7 +1732,7 @@ void sx64_state::pal_sx(machine_config &config)
m_maincpu->set_pulls(0x07, 0xc0);
// devices
- CBM_IEC_SLOT(config.replace(), "iec8", sx1541_iec_devices, "sx1541");
+ CBM_IEC_SLOT(config.replace(), "iec8", 8, sx1541_iec_devices, "sx1541");
}