path: root/src/frontend/mame/cheat.cpp
diff options
author AJR <>2020-05-25 11:15:39 -0400
committer AJR <>2020-05-25 11:15:39 -0400
commit0fa6e7eb86d3b247c46f840ef230c9331f3cc948 (patch)
treee01509e44adcff62a7d8e087c58572fce6b90e13 /src/frontend/mame/cheat.cpp
parentad7a31ad57b09e1e0e9bb1adb03767f9dd386605 (diff)
Debugger expression and memory access overhaul
- Memory references in expressions no longer default to the console's visible CPU if no device name was specified, except when entered through the console itself. Expressions in view windows now use the context of the currently selected device instead. - The pcatmem debug command and similar qt mouseover function now produce an error message if the initial address translation fails. Related internal changes (nw) - The debugger_cpu class no longer interprets memory accesses. The existing routines have been moved into symbol_table (which used to invoke them as callbacks), and reimplemented in most other places. Thecode duplication is a bit messy, but could be potentially improved in the future with new utility classes. - The cheat engine no longer needs to hook into the debugger_cpu class or instantiate a dummy instance of it. - The inclusion of debug/express.h within emu.h has been undone. Some debugging structures now need unique_ptr to wrap the resulting incomplete classes; hopefully the performance impact of this is negligible. Another direct consequence is that the breakpoint, watchpoint and registerpoint classes are no longer inside device_debug and have their own source file. - The breakpoint list is now a std::multimap, using the addresses as keys to hopefully expedite lookup. - The visible CPU pointer has been removed from the debugger_cpu class, being now considered a property of the console instead. - Many minor bits of code have been simplified.
Diffstat (limited to 'src/frontend/mame/cheat.cpp')
1 files changed, 2 insertions, 17 deletions
diff --git a/src/frontend/mame/cheat.cpp b/src/frontend/mame/cheat.cpp
index 00f8c9d67fd..daf6461b0f4 100644
--- a/src/frontend/mame/cheat.cpp
+++ b/src/frontend/mame/cheat.cpp
@@ -79,9 +79,7 @@
#include "ui/ui.h"
#include "ui/menu.h"
-#include "debugger.h"
#include "emuopts.h"
-#include "debug/debugcpu.h"
#include <cstring>
#include <iterator>
@@ -679,7 +677,7 @@ void cheat_script::script_entry::output_argument::save(emu_file &cheatfile) cons
cheat_entry::cheat_entry(cheat_manager &manager, symbol_table &globaltable, std::string const &filename, util::xml::data_node const &cheatnode)
: m_manager(manager)
- , m_symbols(&globaltable)
+ , m_symbols(manager.machine(), &globaltable)
, m_argindex(0)
@@ -1058,7 +1056,7 @@ constexpr int cheat_manager::CHEAT_VERSION;
cheat_manager::cheat_manager(running_machine &machine)
: m_machine(machine)
, m_disabled(true)
- , m_symtable()
+ , m_symtable(machine)
// if the cheat engine is disabled, we're done
if (!machine.options().cheat())
@@ -1081,19 +1079,6 @@ cheat_manager::cheat_manager(running_machine &machine)
m_symtable.add("frombcd", 1, 1, execute_frombcd);
m_symtable.add("tobcd", 1, 1, execute_tobcd);
- // we rely on the debugger expression callbacks; if the debugger isn't
- // enabled, we must jumpstart them manually
- if ((machine.debug_flags & DEBUG_FLAG_ENABLED) == 0)
- {
- m_cpu = std::make_unique<debugger_cpu>(machine);
- m_cpu->configure_memory(m_symtable);
- }
- else
- {
- // configure for memory access (shared with debugger)
- machine.debugger().cpu().configure_memory(m_symtable);
- }
// load the cheats